27759 2009-07-28 01:38:15 -0700 [V8] DOMData needs AtomicallyInitializedStatic 2014-12-16 00:48:17 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 1 abarth webkit-unassigned antonm arv levin oldest_to_newest 135138 0 abarth 2009-07-28 01:38:15 -0700 > + > +DOMData* DOMData::getCurrent() > +{ > + if (WTF::isMainThread()) > + return getCurrentMainThread(); > + > + DEFINE_STATIC_LOCAL(WTF::ThreadSpecific<ChildThreadDOMData>, childThreadDOMData, ()); This looks like it has race conditions. Please add a comment about why it isn't or consider switching to using AtomicallyInitializedStatic (from wtf/Threading.h). 135139 1 abarth 2009-07-28 01:38:54 -0700 I should say that those words in the issue report are Dave Levin's. I don't understand the issue yet. 135140 2 levin 2009-07-28 01:53:00 -0700 This one too: > Index: WebCore/bindings/v8/DOMData.h > +WTF::Mutex& DOMDataStore::allStoresMutex() > +{ > + DEFINE_STATIC_LOCAL(WTF::Mutex, staticDOMDataListMutex, ()); This looks like it has race conditions. Please add a comment about why it isn't or consider switching to using AtomicallyInitializedStatic (from wtf/Threading.h). 135606 3 antonm 2009-07-29 09:31:57 -0700 (In reply to comment #2) > This one too: > > > Index: WebCore/bindings/v8/DOMData.h > > +WTF::Mutex& DOMDataStore::allStoresMutex() > > +{ > > + DEFINE_STATIC_LOCAL(WTF::Mutex, staticDOMDataListMutex, ()); > > This looks like it has race conditions. Please add a comment about why it > isn't or consider switching to using AtomicallyInitializedStatic (from > wtf/Threading.h). Just a minor comment. If I did measurements right, AtomicallyInitializedStatic is rather expensive on Windows, so, please, be careful to measure performance implications. Maybe sometimes it's easier to have plain static at least for main thread. just my 2 cents. 135610 4 levin 2009-07-29 09:40:01 -0700 > If I did measurements right, AtomicallyInitializedStatic is rather expensive on Windows Likely true. I simply want something that is safe though (for anyone using the bindings in a multithreaded fashion). Of course, there could be a (compile time or runtime) flag that indicates whether this level of safetly is needed. 135627 5 abarth 2009-07-29 10:37:58 -0700 I bet the main thread static is actually safe. After all, you need to get a Worker wrapper before you can even create another thread. :) 1055939 6 burg 2014-12-16 00:48:17 -0800 Closing some V8-related work items.