27758 2009-07-28 01:21:53 -0700 Web Inspector: Add inspected node using public console API. 2009-07-29 04:29:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman webkit-unassigned keishi timothy oldest_to_newest 135135 0 pfeldman 2009-07-28 01:21:53 -0700 Do not use methods that start with _ from outside the JS class. 135160 1 33614 keishi 2009-07-28 04:30:28 -0700 Created attachment 33614 Patch 135486 2 timothy 2009-07-28 21:57:14 -0700 For some reason half of this was landed. I landed the rest. http://trac.webkit.org/changeset/46516 135504 3 pfeldman 2009-07-29 00:17:56 -0700 I think it was landed property and was functioning well. There is nothing wrong in calling private methods within the class/file (WebInspector.Console). It was bad to make calls to Console's internals from ElementsPanel. FYI: As we move towards serialized inspector interaction, JavaScript code will split into 'agent' and 'front-end' components. InspectorCommandLineAPI will belong to the 'agent' part and hence having _addInspectedNode within the InspectorCommandLine API along with the container for these last inspected nodes was actually making sense. 135548 4 timothy 2009-07-29 03:06:53 -0700 I guess what landed wasnt what was attached here. And this bug was still open and waiting to land (so it seemed). So I was confused when it looked like half landed and the bug was still open. 135549 5 timothy 2009-07-29 03:08:15 -0700 I agree, what you landed was fine now that I think about it. 135562 6 pfeldman 2009-07-29 04:29:32 -0700 (In reply to comment #5) > I agree, what you landed was fine now that I think about it. It looks like some kind of a glitch. I was attaching the original patch under this very bug, landing exactly what I was attaching after you reviewed it. I can't see my attachment anymore. Every time I land I update the bug with the commit record and close it. I can't find it here now. I wonder what could go wrong here. 33614 2009-07-28 04:30:28 -0700 2009-07-28 05:06:28 -0700 Patch patch0.diff text/plain 3249 keishi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mzc1YjYxNi4uYmI1NjJmZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNy0yOCAgS2Vpc2hpIEhhdHRv cmkgIDxjYXNleS5oYXR0b3JpQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgaW5zcGVjdGVkIG5vZGUg dXNpbmcgcHVibGljIGNvbnNvbGUgQVBJLgorCQlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mjc3NTgKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ29uc29s ZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlLnByb3RvdHlwZS5fZW5zdXJlQ29t bWFuZExpbmVBUElJbnN0YWxsZWQpOiBSZW1vdmVkIF9pbnNwZWN0b3JDb21tYW5kTGluZUFQSS5f YWRkSW5zcGVjdGVkTm9kZS4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlLnByb3RvdHlw ZS5hZGRJbnNwZWN0ZWROb2RlKTogQWRkZWQuCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9FbGVtZW50c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwu dGhpcy50cmVlT3V0bGluZS5mb2N1c2VkTm9kZUNoYW5nZWQpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkVsZW1lbnRzUGFuZWwpOgorCiAyMDA5LTA3LTI4ICBKYW4gTWljaGFlbCBBbG9uem8gIDxq bWFsb256b0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlLmpzIGIvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGUuanMKaW5kZXggNTFiNDQ1OS4uZDhlOTI5OSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGUuanMKKysrIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGUuanMKQEAgLTQxNCwxMiArNDE0LDYg QEAgV2ViSW5zcGVjdG9yLkNvbnNvbGUucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIHBy b2ZpbGU6IGZ1bmN0aW9uKCkgeyByZXR1cm4gY29uc29sZS5wcm9maWxlLmFwcGx5KGNvbnNvbGUs IGFyZ3VtZW50cykgfSwgXAogICAgICAgICAgICAgICAgIHByb2ZpbGVFbmQ6IGZ1bmN0aW9uKCkg eyByZXR1cm4gY29uc29sZS5wcm9maWxlRW5kLmFwcGx5KGNvbnNvbGUsIGFyZ3VtZW50cykgfSwg XAogICAgICAgICAgICAgICAgIF9pbnNwZWN0ZWROb2RlczogW10sIFwKLSAgICAgICAgICAgICAg ICBfYWRkSW5zcGVjdGVkTm9kZTogZnVuY3Rpb24obm9kZSkgeyBcCi0gICAgICAgICAgICAgICAg ICAgIHZhciBpbnNwZWN0ZWROb2RlcyA9IF9pbnNwZWN0b3JDb21tYW5kTGluZUFQSS5faW5zcGVj dGVkTm9kZXM7IFwKLSAgICAgICAgICAgICAgICAgICAgaW5zcGVjdGVkTm9kZXMudW5zaGlmdChu b2RlKTsgXAotICAgICAgICAgICAgICAgICAgICBpZiAoaW5zcGVjdGVkTm9kZXMubGVuZ3RoID49 IDUpIFwKLSAgICAgICAgICAgICAgICAgICAgICAgIGluc3BlY3RlZE5vZGVzLnBvcCgpOyBcCi0g ICAgICAgICAgICAgICAgfSwgXAogICAgICAgICAgICAgICAgIGdldCAkMCgpIHsgcmV0dXJuIF9p bnNwZWN0b3JDb21tYW5kTGluZUFQSS5faW5zcGVjdGVkTm9kZXNbMF0gfSwgXAogICAgICAgICAg ICAgICAgIGdldCAkMSgpIHsgcmV0dXJuIF9pbnNwZWN0b3JDb21tYW5kTGluZUFQSS5faW5zcGVj dGVkTm9kZXNbMV0gfSwgXAogICAgICAgICAgICAgICAgIGdldCAkMigpIHsgcmV0dXJuIF9pbnNw ZWN0b3JDb21tYW5kTGluZUFQSS5faW5zcGVjdGVkTm9kZXNbMl0gfSwgXApAQCAtNDMxLDYgKzQy NSwxNiBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIH0KICAg ICB9LAogICAgIAorICAgIGFkZEluc3BlY3RlZE5vZGU6IGZ1bmN0aW9uKG5vZGUpCisgICAgewor ICAgICAgICB2YXIgaW5zcGVjdGVkV2luZG93ID0gSW5zcGVjdG9yQ29udHJvbGxlci5pbnNwZWN0 ZWRXaW5kb3coKTsKKyAgICAgICAgdGhpcy5fZW5zdXJlQ29tbWFuZExpbmVBUElJbnN0YWxsZWQo aW5zcGVjdGVkV2luZG93KTsKKyAgICAgICAgdmFyIGluc3BlY3RlZE5vZGVzID0gaW5zcGVjdGVk V2luZG93Ll9pbnNwZWN0b3JDb21tYW5kTGluZUFQSS5faW5zcGVjdGVkTm9kZXM7CisgICAgICAg IGluc3BlY3RlZE5vZGVzLnVuc2hpZnQobm9kZSk7CisgICAgICAgIGlmIChpbnNwZWN0ZWROb2Rl cy5sZW5ndGggPj0gNSkKKyAgICAgICAgICAgIGluc3BlY3RlZE5vZGVzLnBvcCgpOworICAgIH0s CisKICAgICBkb0V2YWxJbldpbmRvdzogZnVuY3Rpb24oZXhwcmVzc2lvbiwgY2FsbGJhY2spCiAg ICAgewogICAgICAgICBpZiAoIWV4cHJlc3Npb24pIHsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKaW5kZXggNzM1NTA1Zi4uNzZkOTc0NiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKKysrIGIvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKQEAgLTYxLDkgKzYxLDcg QEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwgPSBmdW5jdGlvbigpCiAgICAgICAgICAgICB0 aGlzLnBhbmVsLm5vZGVTZWFyY2hCdXR0b24ucmVtb3ZlU3R5bGVDbGFzcygidG9nZ2xlZC1vbiIp OwogICAgICAgICB9CiAKLSAgICAgICAgdmFyIGluc3BlY3RlZFdpbmRvdyA9IEluc3BlY3RvckNv bnRyb2xsZXIuaW5zcGVjdGVkV2luZG93KCk7Ci0gICAgICAgIFdlYkluc3BlY3Rvci5jb25zb2xl Ll9lbnN1cmVDb21tYW5kTGluZUFQSUluc3RhbGxlZChpbnNwZWN0ZWRXaW5kb3cpOwotICAgICAg ICBpbnNwZWN0ZWRXaW5kb3cuX2luc3BlY3RvckNvbW1hbmRMaW5lQVBJLl9hZGRJbnNwZWN0ZWRO b2RlKHRoaXMuX2ZvY3VzZWRET01Ob2RlKTsKKyAgICAgICAgV2ViSW5zcGVjdG9yLmNvbnNvbGUu YWRkSW5zcGVjdGVkTm9kZSh0aGlzLl9mb2N1c2VkRE9NTm9kZSk7CiAgICAgfTsKIAogICAgIHRo aXMuY29udGVudEVsZW1lbnQuYXBwZW5kQ2hpbGQodGhpcy50cmVlT3V0bGluZS5lbGVtZW50KTsK