27757 2009-07-27 23:28:47 -0700 [commit+] update-webkit-auxiliary-libs, update-webkit-support-libs cause Perl warnings about functions tmpnam and tmpfile 2009-07-31 23:56:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates webkit-unassigned abarth eric oldest_to_newest 135128 0 dbates 2009-07-27 23:28:47 -0700 Perl complains about the functions tmpfile and tmpnam since they are defined in both File::Temp and POSIX. Script that run Perl with warnings enabled (-w flag) show these warnings, such as update-webkit-auxiliary-libs and update-webkit-support-libs. 135129 1 33603 dbates 2009-07-27 23:31:40 -0700 Created attachment 33603 Patch 135131 2 33605 dbates 2009-07-27 23:45:21 -0700 Created attachment 33605 Reduction A simple example. When you run this script, say: perl reduction.pl You should see the following warnings: Subroutine main::tmpfile redefined at /System/Library/Perl/5.8.8/Exporter.pm line 65. at /System/Library/Perl/5.8.8/darwin-thread-multi-2level/POSIX.pm line 19 Subroutine main::tmpnam redefined at /System/Library/Perl/5.8.8/Exporter.pm line 65. at /System/Library/Perl/5.8.8/darwin-thread-multi-2level/POSIX.pm line 19 135263 3 33603 eric 2009-07-28 10:37:25 -0700 Comment on attachment 33603 Patch perldoc -f use says: If you do not want to call the package's "import" method (for instance, to stop your namespace from being altered), explic- itly supply the empty list: use Module (); That is exactly equivalent to BEGIN { require Module } Looks fine. You might want to add more information to the ChangeLog about why this stops the warning. 135274 4 33653 dbates 2009-07-28 10:56:01 -0700 Created attachment 33653 Patch with updated ChangeLog Added additional information as per Eric's suggestion. 135499 5 dbates 2009-07-28 23:31:54 -0700 Eric, I made the change. Can you land this? 135513 6 33603 levin 2009-07-29 00:39:02 -0700 Comment on attachment 33603 Patch Cleared r+ on obsolete patch to move this out of the commit queue. 136423 7 33653 abarth 2009-07-31 23:56:50 -0700 Comment on attachment 33653 Patch with updated ChangeLog Clearing review flag on attachment: 33653 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/update-webkit-auxiliary-libs M WebKitTools/Scripts/update-webkit-support-libs Committed r46664 M WebKitTools/ChangeLog M WebKitTools/Scripts/update-webkit-auxiliary-libs M WebKitTools/Scripts/update-webkit-support-libs r46664 = 13ac7fcfe92ad91ecbaedb4adecfd2aa9c133cee (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46664 136424 8 abarth 2009-07-31 23:56:54 -0700 All reviewed patches have been landed. Closing bug. 33603 2009-07-27 23:31:40 -0700 2009-07-29 00:39:02 -0700 Patch Bug27757_1.patch text/plain 1575 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ2NDU5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMjcgIERhbmllbCBCYXRlcyAgPGRi YXRlc0BpbnR1ZGF0YS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mjc3NTcKKworICAgICAgICBSZXNvbHZlcyBQZXJsIHJlZGVmaW5pdGlvbiB3YXJuaW5ncyBh Ym91dCBmdW5jdGlvbnMgdG1wZmlsZSBhbmQgdG1wbmFtIHdoaWNoIGFyZSAKKyAgICAgICAgZGVm aW5lZCBpbiBib3RoIEZpbGU6OlRlbXAgYW5kIFBPU0lYLgorCisgICAgICAgICogU2NyaXB0cy91 cGRhdGUtd2Via2l0LWF1eGlsaWFyeS1saWJzOiBDaGFuZ2VkICJ1c2UgRmlsZTo6VGVtcCIgdG8g InVzZSBGaWxlOjpUZW1wICgpIi4KKyAgICAgICAgKiBTY3JpcHRzL3VwZGF0ZS13ZWJraXQtc3Vw cG9ydC1saWJzOiBkaXR0bworCiAyMDA5LTA3LTI3ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogV2ViS2l0 VG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWF1eGlsaWFyeS1saWJzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1hdXhpbGlhcnktbGlicwkocmV2aXNp b24gNDYyNTApCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtYXV4aWxpYXJ5 LWxpYnMJKHdvcmtpbmcgY29weSkKQEAgLTMzLDcgKzMzLDcgQEAgdXNlIHdhcm5pbmdzOwogCiB1 c2UgSFRUUDo6RGF0ZSBxdyhzdHIydGltZSk7CiB1c2UgRmlsZTo6RmluZDsKLXVzZSBGaWxlOjpU ZW1wOwordXNlIEZpbGU6OlRlbXAgKCk7CiB1c2UgRmlsZTo6U3BlYzsKIHVzZSBGaW5kQmluOwog dXNlIGxpYiAkRmluZEJpbjo6QmluOwpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy91cGRhdGUt d2Via2l0LXN1cHBvcnQtbGlicwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3Vw ZGF0ZS13ZWJraXQtc3VwcG9ydC1saWJzCShyZXZpc2lvbiA0NjI1MCkKKysrIFdlYktpdFRvb2xz L1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1zdXBwb3J0LWxpYnMJKHdvcmtpbmcgY29weSkKQEAgLTMy LDcgKzMyLDcgQEAgdXNlIHN0cmljdDsKIHVzZSB3YXJuaW5nczsKIAogdXNlIEZpbGU6OkZpbmQ7 Ci11c2UgRmlsZTo6VGVtcDsKK3VzZSBGaWxlOjpUZW1wICgpOwogdXNlIEZpbGU6OlNwZWM7CiB1 c2UgRmluZEJpbjsKIHVzZSBsaWIgJEZpbmRCaW46OkJpbjsK 33605 2009-07-27 23:45:21 -0700 2009-07-27 23:45:21 -0700 Reduction reduction.pl text/plain 478 dbates IyEvdXNyL2Jpbi9wZXJsIC13CnVzZSBGaWxlOjpUZW1wOwp1c2UgUE9TSVg7CgojIFlvdSBzaG91 bGQgc2VlIHRoZSBmb2xsb3dpbmcgdHdvIHdhcm5pbmdzIChvciBzb21ldGhpbmcgc2ltaWxpYXIp IHdoZW4geW91IHJ1biB0aGlzIHNjcmlwdDoKIwojU3Vicm91dGluZSBtYWluOjp0bXBmaWxlIHJl ZGVmaW5lZCBhdCAvU3lzdGVtL0xpYnJhcnkvUGVybC81LjguOC9FeHBvcnRlci5wbSBsaW5lIDY1 LgojIGF0IC9TeXN0ZW0vTGlicmFyeS9QZXJsLzUuOC44L2Rhcndpbi10aHJlYWQtbXVsdGktMmxl dmVsL1BPU0lYLnBtIGxpbmUgMTkKI1N1YnJvdXRpbmUgbWFpbjo6dG1wbmFtIHJlZGVmaW5lZCBh dCAvU3lzdGVtL0xpYnJhcnkvUGVybC81LjguOC9FeHBvcnRlci5wbSBsaW5lIDY1LgojIGF0IC9T eXN0ZW0vTGlicmFyeS9QZXJsLzUuOC44L2Rhcndpbi10aHJlYWQtbXVsdGktMmxldmVsL1BPU0lY LnBtIGxpbmUgMTkKCmV4aXQoMCk7Cg== 33653 2009-07-28 10:56:01 -0700 2009-07-31 23:56:50 -0700 Patch with updated ChangeLog Bug27757_2.patch text/plain 2023 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ2NDU5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDktMDctMjcgIERhbmllbCBCYXRlcyAgPGRi YXRlc0BpbnR1ZGF0YS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mjc3NTcKKworICAgICAgICBSZXNvbHZlcyBQZXJsIHJlZGVmaW5pdGlvbiB3YXJuaW5ncyBh Ym91dCBmdW5jdGlvbnMgdG1wZmlsZSBhbmQgdG1wbmFtIHdoaWNoIGFyZSAKKyAgICAgICAgZGVm aW5lZCBpbiBib3RoIEZpbGU6OlRlbXAgYW5kIFBPU0lYLgorICAgICAgICAKKyAgICAgICAgVGhp cyBzdG9wcyB0aGUgd2FybmluZ3MgYnkgcHJldmVudGluZyB0aGUgImltcG9ydCIgbWV0aG9kIG9m IEZpbGU6OlRlbXAgZnJvbSBiZWluZyBjYWxsZWQsCisgICAgICAgIHdoaWNoIHdvdWxkIG90aGVy d2lzZSBhZGQgdGhlc2UgZnVuY3Rpb25zIGludG8gdGhlIHByaW1hcnkgbmFtZXNwYWNlLiBOb3Rl LCAidXNlIFBPU0lYIiAKKyAgICAgICAgd2lsbCBpbXBvcnQgdGhlc2UgZnVuY3Rpb25zIGludG8g dGhlIHByaW1hcnkgbmFtZXNwYWNlIGFueXdheS4gV2Ugb25seSBuZWVkIG9uZSBpbnN0YW5jZQor ICAgICAgICBvZiB0aGVzZSBmdW5jdGlvbnMgaW4gb3VyIG5hbWVzcGFjZSAob3Igd2UgZ2V0IHJl ZGVmaW5pdGlvbiB3YXJuaW5ncyksIHNvIGxldHMgdXNlIHRoZSAKKyAgICAgICAgb25lJ3MgaW4g dGhlIFBPU0lYIHBhY2thZ2UuCisgICAgICAgIAorICAgICAgICAqIFNjcmlwdHMvdXBkYXRlLXdl YmtpdC1hdXhpbGlhcnktbGliczogQ2hhbmdlZCAidXNlIEZpbGU6OlRlbXAiIHRvICJ1c2UgRmls ZTo6VGVtcCAoKSIuCisgICAgICAgICogU2NyaXB0cy91cGRhdGUtd2Via2l0LXN1cHBvcnQtbGli czogZGl0dG8KKwogMjAwOS0wNy0yNyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFdlYktpdFRvb2xzL1Nj cmlwdHMvdXBkYXRlLXdlYmtpdC1hdXhpbGlhcnktbGlicwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRU b29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtYXV4aWxpYXJ5LWxpYnMJKHJldmlzaW9uIDQ2MjUw KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWF1eGlsaWFyeS1saWJzCSh3 b3JraW5nIGNvcHkpCkBAIC0zMyw3ICszMyw3IEBAIHVzZSB3YXJuaW5nczsKIAogdXNlIEhUVFA6 OkRhdGUgcXcoc3RyMnRpbWUpOwogdXNlIEZpbGU6OkZpbmQ7Ci11c2UgRmlsZTo6VGVtcDsKK3Vz ZSBGaWxlOjpUZW1wICgpOwogdXNlIEZpbGU6OlNwZWM7CiB1c2UgRmluZEJpbjsKIHVzZSBsaWIg JEZpbmRCaW46OkJpbjsKSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1z dXBwb3J0LWxpYnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy91cGRhdGUtd2Vi a2l0LXN1cHBvcnQtbGlicwkocmV2aXNpb24gNDYyNTApCisrKyBXZWJLaXRUb29scy9TY3JpcHRz L3VwZGF0ZS13ZWJraXQtc3VwcG9ydC1saWJzCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw3ICszMiw3 IEBAIHVzZSBzdHJpY3Q7CiB1c2Ugd2FybmluZ3M7CiAKIHVzZSBGaWxlOjpGaW5kOwotdXNlIEZp bGU6OlRlbXA7Cit1c2UgRmlsZTo6VGVtcCAoKTsKIHVzZSBGaWxlOjpTcGVjOwogdXNlIEZpbmRC aW47CiB1c2UgbGliICRGaW5kQmluOjpCaW47Cg==