27753 2009-07-27 19:44:09 -0700 clean up CSSRuleData in CSSStyleSelector.h 2010-12-24 12:44:23 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 49775 1 dpranke webkit-unassigned abarth cjerdonek commit-queue dglazkov eric jhanssen rniwa webkit.review.bot oldest_to_newest 135108 0 dpranke 2009-07-27 19:44:09 -0700 CSSRuleData and CSSRuleDataSet don't really need to be in CSSStyleSelector.h (they are only used in the .cpp file). Moving them to the .cpp file will reduce the number of accidental recompiles. In addition, it's possible that CSSRuleDataSet can just be replaced with a std::list container. (Filed as an offshoot of bug 27748). 209324 1 dpranke 2010-04-06 16:37:29 -0700 I'm not working on this now nor do I expect to be in the near future, so I am disclaiming ownership in case someone else wants to pick this up. 325819 2 77286 jhanssen 2010-12-22 17:39:43 -0800 Created attachment 77286 Patch Move CSSRuleData and CSSRuleDataList from the .h to the .cpp file. Not sure if changing the custom linked list implementation to one of the generic WTF containers is still preferred. 326663 3 77286 eric 2010-12-24 10:22:47 -0800 Comment on attachment 77286 Patch Seems sane. There shouldn't be any perf impact if this is the only class using these. 326672 4 commit-queue 2010-12-24 10:54:30 -0800 The commit-queue encountered the following flaky tests while processing attachment 77286: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch. 326674 5 77286 commit-queue 2010-12-24 10:55:48 -0800 Comment on attachment 77286 Patch Clearing flags on attachment: 77286 Committed r74642: <http://trac.webkit.org/changeset/74642> 326675 6 commit-queue 2010-12-24 10:55:54 -0800 All reviewed patches have been landed. Closing bug. 326723 7 webkit.review.bot 2010-12-24 12:40:10 -0800 http://trac.webkit.org/changeset/74642 might have broken GTK Linux 32-bit Release 326727 8 jhanssen 2010-12-24 12:42:47 -0800 (In reply to comment #7) > http://trac.webkit.org/changeset/74642 might have broken GTK Linux 32-bit Release Seems unlikely to be caused by this. 326728 9 eric 2010-12-24 12:44:23 -0800 They're all media/ test failures from a media change at the same time as this one. The Gtk bot is kinda slow, so many changes get built at once. 77286 2010-12-22 17:39:43 -0800 2010-12-24 10:55:48 -0800 Patch bug-27753-20101222173942.patch text/plain 4971 jhanssen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTQ3NWQ4NTBiZTNmYTM5OThiYjg5MjczOWRlMTY1N2MyMzQzOGQ5Yi4uOTZjYTVlMGUzYTExZjI5 YjNlMGE0ZTgyOTA4NzMxNzY0ZmMwN2E0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMC0xMi0yMiAgSmFu IEVyaWsgSGFuc3NlbiAgPGpoYW5zc2VuQHNlbmNoYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xlYW4gdXAgQ1NTUnVsZURhdGEgaW4gQ1NT U3R5bGVTZWxlY3Rvci5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNzc1MworCisgICAgICAgIE1vdmUgQ1NTUnVsZURhdGEgYW5kIENTU1J1bGVEYXRh TGlzdCBmcm9tIENTU1N0eWxlU2VsZWN0b3IuaCB0byB0aGUgLmNwcCBmaWxlLgorCisgICAgICAg ICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUnVsZURh dGE6OkNTU1J1bGVEYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1J1bGVEYXRhOjp+Q1NTUnVs ZURhdGEpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUnVsZURhdGE6OnBvc2l0aW9uKToKKyAgICAg ICAgKFdlYkNvcmU6OkNTU1J1bGVEYXRhOjpydWxlKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1J1 bGVEYXRhOjpzZWxlY3Rvcik6CisgICAgICAgIChXZWJDb3JlOjpDU1NSdWxlRGF0YTo6bmV4dCk6 CisgICAgICAgIChXZWJDb3JlOjpDU1NSdWxlRGF0YUxpc3Q6OkNTU1J1bGVEYXRhTGlzdCk6Cisg ICAgICAgIChXZWJDb3JlOjpDU1NSdWxlRGF0YUxpc3Q6On5DU1NSdWxlRGF0YUxpc3QpOgorICAg ICAgICAoV2ViQ29yZTo6Q1NTUnVsZURhdGFMaXN0OjpmaXJzdCk6CisgICAgICAgIChXZWJDb3Jl OjpDU1NSdWxlRGF0YUxpc3Q6Omxhc3QpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUnVsZURhdGFM aXN0OjphcHBlbmQpOgorICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmg6CisKIDIwMTAt MTItMjIgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBLZW5uZXRoIFJ1c3NlbGwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nzcy9DU1NTdHls ZVNlbGVjdG9yLmNwcCBiL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCmluZGV4IGU5 MGY5ZjA3ODMxNzJkN2UzY2FkYThhOWY1YjQ5MDliZmZmM2ZhMDAuLjFkYzRkMGQzMTM4ZGRiZmUz YmUzYjkwNjA0NjM3YmZjYTNhNTU5MmIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvY3NzL0NTU1N0eWxl U2VsZWN0b3IuY3BwCisrKyBiL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCkBAIC0z NDgsNiArMzQ4LDY0IEBAIGlmIChpZCA9PSBwcm9wSUQpIHsgXAogICAgIHJldHVybjsgXAogfQog CitjbGFzcyBDU1NSdWxlRGF0YSA6IHB1YmxpYyBOb25jb3B5YWJsZSB7CitwdWJsaWM6CisgICAg Q1NTUnVsZURhdGEodW5zaWduZWQgcG9zLCBDU1NTdHlsZVJ1bGUqIHIsIENTU1NlbGVjdG9yKiBz ZWwsIENTU1J1bGVEYXRhKiBwcmV2ID0gMCkKKyAgICAgICAgOiBtX3Bvc2l0aW9uKHBvcykKKyAg ICAgICAgLCBtX3J1bGUocikKKyAgICAgICAgLCBtX3NlbGVjdG9yKHNlbCkKKyAgICAgICAgLCBt X25leHQoMCkKKyAgICB7CisgICAgICAgIGlmIChwcmV2KQorICAgICAgICAgICAgcHJldi0+bV9u ZXh0ID0gdGhpczsKKyAgICB9CisKKyAgICB+Q1NTUnVsZURhdGEoKQorICAgIHsKKyAgICB9CisK KyAgICB1bnNpZ25lZCBwb3NpdGlvbigpIHsgcmV0dXJuIG1fcG9zaXRpb247IH0KKyAgICBDU1NT dHlsZVJ1bGUqIHJ1bGUoKSB7IHJldHVybiBtX3J1bGU7IH0KKyAgICBDU1NTZWxlY3Rvciogc2Vs ZWN0b3IoKSB7IHJldHVybiBtX3NlbGVjdG9yOyB9CisgICAgQ1NTUnVsZURhdGEqIG5leHQoKSB7 IHJldHVybiBtX25leHQ7IH0KKworcHJpdmF0ZToKKyAgICB1bnNpZ25lZCBtX3Bvc2l0aW9uOwor ICAgIENTU1N0eWxlUnVsZSogbV9ydWxlOworICAgIENTU1NlbGVjdG9yKiBtX3NlbGVjdG9yOwor ICAgIENTU1J1bGVEYXRhKiBtX25leHQ7Cit9OworCitjbGFzcyBDU1NSdWxlRGF0YUxpc3QgOiBw dWJsaWMgTm9uY29weWFibGUgeworcHVibGljOgorICAgIENTU1J1bGVEYXRhTGlzdCh1bnNpZ25l ZCBwb3MsIENTU1N0eWxlUnVsZSogcnVsZSwgQ1NTU2VsZWN0b3IqIHNlbCkKKyAgICAgICAgOiBt X2ZpcnN0KG5ldyBDU1NSdWxlRGF0YShwb3MsIHJ1bGUsIHNlbCkpCisgICAgICAgICwgbV9sYXN0 KG1fZmlyc3QpCisgICAgeworICAgIH0KKworICAgIH5DU1NSdWxlRGF0YUxpc3QoKQorICAgIHsK KyAgICAgICAgQ1NTUnVsZURhdGEqIHB0cjsKKyAgICAgICAgQ1NTUnVsZURhdGEqIG5leHQ7Cisg ICAgICAgIHB0ciA9IG1fZmlyc3Q7CisgICAgICAgIHdoaWxlIChwdHIpIHsKKyAgICAgICAgICAg IG5leHQgPSBwdHItPm5leHQoKTsKKyAgICAgICAgICAgIGRlbGV0ZSBwdHI7CisgICAgICAgICAg ICBwdHIgPSBuZXh0OworICAgICAgICB9CisgICAgfQorCisgICAgQ1NTUnVsZURhdGEqIGZpcnN0 KCkgeyByZXR1cm4gbV9maXJzdDsgfQorICAgIENTU1J1bGVEYXRhKiBsYXN0KCkgeyByZXR1cm4g bV9sYXN0OyB9CisKKyAgICB2b2lkIGFwcGVuZCh1bnNpZ25lZCBwb3MsIENTU1N0eWxlUnVsZSog cnVsZSwgQ1NTU2VsZWN0b3IqIHNlbCkgeyBtX2xhc3QgPSBuZXcgQ1NTUnVsZURhdGEocG9zLCBy dWxlLCBzZWwsIG1fbGFzdCk7IH0KKworcHJpdmF0ZToKKyAgICBDU1NSdWxlRGF0YSogbV9maXJz dDsKKyAgICBDU1NSdWxlRGF0YSogbV9sYXN0OworfTsKKwogY2xhc3MgQ1NTUnVsZVNldCA6IHB1 YmxpYyBOb25jb3B5YWJsZSB7CiBwdWJsaWM6CiAgICAgQ1NTUnVsZVNldCgpOwpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5oIGIvV2ViQ29yZS9jc3MvQ1NTU3R5bGVT ZWxlY3Rvci5oCmluZGV4IGI3MTg3NTFhY2EwZjljYjY5YzMxNWViNTgxM2NhMjdhODM0M2Q5N2Qu Ljg3ZjZhOTU4MDBiNjQ1NzExYWRjN2M0NmFkNDMyNjMxMjRiYjZmODggMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuaAorKysgYi9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNl bGVjdG9yLmgKQEAgLTMxNSw2NCArMzE1LDYgQEAgcHVibGljOgogICAgICAgICBWZWN0b3I8TWVk aWFRdWVyeVJlc3VsdCo+IG1fdmlld3BvcnREZXBlbmRlbnRNZWRpYVF1ZXJ5UmVzdWx0czsKICAg ICB9OwogCi0gICAgY2xhc3MgQ1NTUnVsZURhdGEgOiBwdWJsaWMgTm9uY29weWFibGUgewotICAg IHB1YmxpYzoKLSAgICAgICAgQ1NTUnVsZURhdGEodW5zaWduZWQgcG9zLCBDU1NTdHlsZVJ1bGUq IHIsIENTU1NlbGVjdG9yKiBzZWwsIENTU1J1bGVEYXRhKiBwcmV2ID0gMCkKLSAgICAgICAgICAg IDogbV9wb3NpdGlvbihwb3MpCi0gICAgICAgICAgICAsIG1fcnVsZShyKQotICAgICAgICAgICAg LCBtX3NlbGVjdG9yKHNlbCkKLSAgICAgICAgICAgICwgbV9uZXh0KDApCi0gICAgICAgIHsKLSAg ICAgICAgICAgIGlmIChwcmV2KQotICAgICAgICAgICAgICAgIHByZXYtPm1fbmV4dCA9IHRoaXM7 Ci0gICAgICAgIH0KLQotICAgICAgICB+Q1NTUnVsZURhdGEoKSAKLSAgICAgICAgeyAKLSAgICAg ICAgfQotCi0gICAgICAgIHVuc2lnbmVkIHBvc2l0aW9uKCkgeyByZXR1cm4gbV9wb3NpdGlvbjsg fQotICAgICAgICBDU1NTdHlsZVJ1bGUqIHJ1bGUoKSB7IHJldHVybiBtX3J1bGU7IH0KLSAgICAg ICAgQ1NTU2VsZWN0b3IqIHNlbGVjdG9yKCkgeyByZXR1cm4gbV9zZWxlY3RvcjsgfQotICAgICAg ICBDU1NSdWxlRGF0YSogbmV4dCgpIHsgcmV0dXJuIG1fbmV4dDsgfQotCi0gICAgcHJpdmF0ZToK LSAgICAgICAgdW5zaWduZWQgbV9wb3NpdGlvbjsKLSAgICAgICAgQ1NTU3R5bGVSdWxlKiBtX3J1 bGU7Ci0gICAgICAgIENTU1NlbGVjdG9yKiBtX3NlbGVjdG9yOwotICAgICAgICBDU1NSdWxlRGF0 YSogbV9uZXh0OwotICAgIH07Ci0KLSAgICBjbGFzcyBDU1NSdWxlRGF0YUxpc3QgOiBwdWJsaWMg Tm9uY29weWFibGUgewotICAgIHB1YmxpYzoKLSAgICAgICAgQ1NTUnVsZURhdGFMaXN0KHVuc2ln bmVkIHBvcywgQ1NTU3R5bGVSdWxlKiBydWxlLCBDU1NTZWxlY3Rvciogc2VsKQotICAgICAgICAg ICAgOiBtX2ZpcnN0KG5ldyBDU1NSdWxlRGF0YShwb3MsIHJ1bGUsIHNlbCkpCi0gICAgICAgICAg ICAsIG1fbGFzdChtX2ZpcnN0KQotICAgICAgICB7Ci0gICAgICAgIH0KLQotICAgICAgICB+Q1NT UnVsZURhdGFMaXN0KCkgCi0gICAgICAgIHsgCi0gICAgICAgICAgICBDU1NSdWxlRGF0YSogcHRy OwotICAgICAgICAgICAgQ1NTUnVsZURhdGEqIG5leHQ7Ci0gICAgICAgICAgICBwdHIgPSBtX2Zp cnN0OwotICAgICAgICAgICAgd2hpbGUgKHB0cikgewotICAgICAgICAgICAgICAgIG5leHQgPSBw dHItPm5leHQoKTsKLSAgICAgICAgICAgICAgICBkZWxldGUgcHRyOwotICAgICAgICAgICAgICAg IHB0ciA9IG5leHQ7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLQotICAgICAgICBDU1NSdWxl RGF0YSogZmlyc3QoKSB7IHJldHVybiBtX2ZpcnN0OyB9Ci0gICAgICAgIENTU1J1bGVEYXRhKiBs YXN0KCkgeyByZXR1cm4gbV9sYXN0OyB9Ci0KLSAgICAgICAgdm9pZCBhcHBlbmQodW5zaWduZWQg cG9zLCBDU1NTdHlsZVJ1bGUqIHJ1bGUsIENTU1NlbGVjdG9yKiBzZWwpIHsgbV9sYXN0ID0gbmV3 IENTU1J1bGVEYXRhKHBvcywgcnVsZSwgc2VsLCBtX2xhc3QpOyB9Ci0KLSAgICBwcml2YXRlOgot ICAgICAgICBDU1NSdWxlRGF0YSogbV9maXJzdDsKLSAgICAgICAgQ1NTUnVsZURhdGEqIG1fbGFz dDsKLSAgICB9OwotCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBDU1NTdHls ZVNlbGVjdG9yX2gK