27747 2009-07-27 18:05:37 -0700 "bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load. 2011-05-24 19:13:41 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pdherbemont webkit-unassigned eric oldest_to_newest 135083 0 pdherbemont 2009-07-27 18:05:37 -0700 "bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load. $ WebKitTools/Scripts/bugzilla-tool post-commits head Traceback (most recent call last): File "WebKitTools/Scripts/bugzilla-tool", line 600, in <module> main() File "WebKitTools/Scripts/bugzilla-tool", line 597, in main return tool.main() File "WebKitTools/Scripts/bugzilla-tool", line 592, in main return command_object.execute(command_options, command_args, self) File "WebKitTools/Scripts/bugzilla-tool", line 436, in execute bug_id = options.bug_id or commit_message.parse_bug_id() File "/Volumes/Data/Sources/WebKit/WebKitTools/Scripts/modules/scm.py", line 84, in parse_bug_id match = re.search(Bugzilla.bug_server_regex + "show_bug\.cgi\?id=(?P<bug_id>\d+)", line) NameError: global name 'Bugzilla' is not defined 135084 1 33586 pdherbemont 2009-07-27 18:07:44 -0700 Created attachment 33586 2009-07-27 Pierre d'Herbemont <pdherbemont@apple.com> Reviewed by NOBODY (OOPS!). "bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load. https://bugs.webkit.org/show_bug.cgi?id=27747 modules.bugzilla is not found because not included. * Scripts/modules/scm.py: Properly import modules.bugzilla. --- 2 files changed, 12 insertions(+), 0 deletions(-) 135121 2 pdherbemont 2009-07-27 21:26:42 -0700 https://trac.webkit.org/changeset/46454 135408 3 ddkilzer 2009-07-28 16:12:38 -0700 *** Bug 27389 has been marked as a duplicate of this bug. *** 135411 4 eric 2009-07-28 16:28:27 -0700 I think this is the wrong fix. I don't think scm.py should depend on bugzilla.py. That said, I think it's OK for now to unbreak things as-is. There should be some other ChangeLogs.py which knows how to deal with these details. 135412 5 eric 2009-07-28 16:30:27 -0700 (Thank you for fixing this though!) 33586 2009-07-27 18:07:44 -0700 2009-07-27 18:11:38 -0700 2009-07-27 Pierre d'Herbemont <pdherbemont@apple.com> bug-27747-20090727180743.patch text/plain 1077 pdherbemont ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzZWQ2ODc0Li44ODFkMmMwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDct MjcgIFBpZXJyZSBkJ0hlcmJlbW9udCAgPHBkaGVyYmVtb250QGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAiYnVnemlsbGEtdG9vbCBw b3N0LWNvbW1pdCBoZWFkIiBkb2Vzbid0IHdvcmsgYmVjYXVzZSBpdCBjYW4ndCBmaW5kIHRoZSBi dWcgaWQgZnJvbSB0aGUgY29tbWl0IGxvYWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yNzc0NworCisgICAgICAgIG1vZHVsZXMuYnVnemlsbGEgaXMg bm90IGZvdW5kIGJlY2F1c2Ugbm90IGluY2x1ZGVkLgorCisgICAgICAgICogU2NyaXB0cy9tb2R1 bGVzL3NjbS5weTogUHJvcGVybHkgaW1wb3J0IG1vZHVsZXMuYnVnemlsbGEuCisKIDIwMDktMDct MjQgIFBpZXJyZSBkJ0hlcmJlbW9udCAgPHBkaGVyYmVtb250QGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvbW9kdWxlcy9zY20ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvc2NtLnB5 CmluZGV4IDVmMTQ1ZDcuLmJiODBjODMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMv bW9kdWxlcy9zY20ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbS5weQpA QCAtMzUsNiArMzUsNyBAQCBpbXBvcnQgc3VicHJvY2VzcwogCiAjIEltcG9ydCBXZWJLaXQtc3Bl Y2lmaWMgbW9kdWxlcy4KIGZyb20gbW9kdWxlcy5sb2dnaW5nIGltcG9ydCBlcnJvciwgbG9nCitm cm9tIG1vZHVsZXMuYnVnemlsbGEgaW1wb3J0IEJ1Z3ppbGxhCiAKIGRlZiBkZXRlY3Rfc2NtX3N5 c3RlbShwYXRoKToKICAgICBpZiBTVk4uaW5fd29ya2luZ19kaXJlY3RvcnkocGF0aCk6