27746 2009-07-27 16:58:33 -0700 Inspector: Tab Through the DOM Storage DataGrid when Editing 2009-07-28 21:54:54 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned aroben kmccullough timothy oldest_to_newest 135064 0 joepeck 2009-07-27 16:58:33 -0700 Here is a video of what I'm thinking about (be wary of your volume, the tab key is close to the mac's microphone!) http://screencast.com/t/sFS4NGyiAw This only handles the Tab Key when editing a property, and thus is a part of DOMStorageDataGrid and not the generic DataGrid key handler. 135070 1 33583 joepeck 2009-07-27 17:16:54 -0700 Created attachment 33583 Tab Through DOM Storage DataGrid When Editing NOTES: - Relies on the (previously r+) patch in bug 27322 135482 2 timothy 2009-07-28 21:54:54 -0700 http://trac.webkit.org/changeset/46520 33583 2009-07-27 17:16:54 -0700 2009-07-28 21:03:19 -0700 Tab Through DOM Storage DataGrid When Editing TabThroughDOMStorageDataGrid.patch text/plain 5449 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWZhNmY2Zi4uZjMwZTE4MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAwOS0wNy0yNyAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVjazAyQGdtYWlsLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbnNwZWN0b3I6IFRhYiBUaHJvdWdoIHRoZSBET00gU3RvcmFn ZSBEYXRhR3JpZCB3aGVuIEVkaXRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI3NzQ2CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RP TVN0b3JhZ2VEYXRhR3JpZC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01TdG9yYWdlRGF0 YUdyaWQucHJvdG90eXBlLl9zdGFydEVkaXRpbmdDb2x1bW5PZkRhdGFHcmlkTm9kZSk6IHJlZmFj dG9yZWQgdG8gZGlyZWN0bHkgZWRpdCBhbmQgc2VsZWN0IGEgY29sdW1uCisgICAgICAgIChXZWJJ bnNwZWN0b3IuRE9NU3RvcmFnZURhdGFHcmlkLnByb3RvdHlwZS5fc3RhcnRFZGl0aW5nKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5ET01TdG9yYWdlRGF0YUdyaWQucHJvdG90eXBlLl9lZGl0aW5n Q29tbWl0dGVkLm1vdmVUb05leHRJZk5lZWRlZCk6IGhhbmRsZXMgbW92ZURpcmVjdGlvbiBvbiBh IGNvbW1pdAorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VEYXRhR3JpZC5wcm90b3R5 cGUuX2VkaXRpbmdDb21taXR0ZWQpOiB1c2VzIG1vdmVUb05leHQgdG8gdHJhdmVyc2UgYXBwcm9w cmlhdGVseQorCisyMDA5LTA3LTI3ICBKb3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrMDJAZ21haWwu Y29tPgorCiAgICAgICAgIEluc3BlY3RvcjogVGFiIFRocm91Z2ggRWxlbWVudCBBdHRyaWJ1dGVz IGFuZCBDU1MgUHJvcGVydGllcyBXaGVuIEVkaXRpbmcKIAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc2NzMKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9ET01TdG9yYWdlRGF0YUdyaWQuanMgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvRE9NU3RvcmFnZURhdGFHcmlkLmpzCmluZGV4IDUwNGNjMmQuLmQxNjY4NTcg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01TdG9yYWdlRGF0YUdy aWQuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RPTVN0b3JhZ2VEYXRhR3Jp ZC5qcwpAQCAtMzksNiArMzksMTcgQEAgV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VEYXRhR3JpZC5w cm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX3N0YXJ0RWRpdGluZyhldmVudCk7CiAgICAgfSwK IAorICAgIF9zdGFydEVkaXRpbmdDb2x1bW5PZkRhdGFHcmlkTm9kZTogZnVuY3Rpb24obm9kZSwg Y29sdW1uKQorICAgIHsKKyAgICAgICAgdGhpcy5fZWRpdGluZyA9IHRydWU7CisgICAgICAgIHRo aXMuX2VkaXRpbmdOb2RlID0gbm9kZTsKKyAgICAgICAgdGhpcy5fZWRpdGluZ05vZGUuc2VsZWN0 KCk7CisKKyAgICAgICAgdmFyIGVsZW1lbnQgPSB0aGlzLl9lZGl0aW5nTm9kZS5fZWxlbWVudC5j aGlsZHJlbltjb2x1bW5dOworICAgICAgICBXZWJJbnNwZWN0b3Iuc3RhcnRFZGl0aW5nKGVsZW1l bnQsIHRoaXMuX2VkaXRpbmdDb21taXR0ZWQuYmluZCh0aGlzKSwgdGhpcy5fZWRpdGluZ0NhbmNl bGxlZC5iaW5kKHRoaXMpLCBlbGVtZW50LnRleHRDb250ZW50KTsKKyAgICAgICAgd2luZG93Lmdl dFNlbGVjdGlvbigpLnNldEJhc2VBbmRFeHRlbnQoZWxlbWVudCwgMCwgZWxlbWVudCwgMSk7Cisg ICAgfSwKKwogICAgIF9zdGFydEVkaXRpbmc6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKICAgICAg ICAgdmFyIGVsZW1lbnQgPSBldmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhOb2Rl TmFtZSgidGQiKTsKQEAgLTUxLDIzICs2Miw1NyBAQCBXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZURh dGFHcmlkLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAg ICB0aGlzLl9lZGl0aW5nTm9kZSA9IHRoaXMuY3JlYXRpb25Ob2RlOwogICAgICAgICB9Ci0gICAg ICAgIHRoaXMuX2VkaXRpbmcgPSB0cnVlOwogCi0gICAgICAgIGlmICh0aGlzLl9lZGl0aW5nTm9k ZS5pc0NyZWF0aW9uTm9kZSkgewotICAgICAgICAgICAgdGhpcy5fZWRpdGluZ05vZGUuc2VsZWN0 KCk7Ci0gICAgICAgICAgICBlbGVtZW50ID0gdGhpcy5fZWRpdGluZ05vZGUuX2VsZW1lbnQuY2hp bGRyZW5bMF07IC8vIENyZWF0ZSBhIG5ldyBub2RlIGJ5IHByb3ZpZGluZyBhIEtleSBGaXJzdAot ICAgICAgICB9CisgICAgICAgIC8vIEZvcmNlIGVkaXRpbmcgdGhlICJLZXkiIGNvbHVtbiB3aGVu IGVkaXRpbmcgdGhlIGNyZWF0aW9uIG5vZGUKKyAgICAgICAgaWYgKHRoaXMuX2VkaXRpbmdOb2Rl LmlzQ3JlYXRpb25Ob2RlKQorICAgICAgICAgICAgcmV0dXJuIHRoaXMuX3N0YXJ0RWRpdGluZ0Nv bHVtbk9mRGF0YUdyaWROb2RlKHRoaXMuX2VkaXRpbmdOb2RlLCAwKTsKIAorICAgICAgICB0aGlz Ll9lZGl0aW5nID0gdHJ1ZTsKICAgICAgICAgV2ViSW5zcGVjdG9yLnN0YXJ0RWRpdGluZyhlbGVt ZW50LCB0aGlzLl9lZGl0aW5nQ29tbWl0dGVkLmJpbmQodGhpcyksIHRoaXMuX2VkaXRpbmdDYW5j ZWxsZWQuYmluZCh0aGlzKSwgZWxlbWVudC50ZXh0Q29udGVudCk7CiAgICAgICAgIHdpbmRvdy5n ZXRTZWxlY3Rpb24oKS5zZXRCYXNlQW5kRXh0ZW50KGVsZW1lbnQsIDAsIGVsZW1lbnQsIDEpOwog ICAgIH0sCiAKLSAgICBfZWRpdGluZ0NvbW1pdHRlZDogZnVuY3Rpb24oZWxlbWVudCwgbmV3VGV4 dCkKKyAgICBfZWRpdGluZ0NvbW1pdHRlZDogZnVuY3Rpb24oZWxlbWVudCwgbmV3VGV4dCwgb2xk VGV4dCwgY29udGV4dCwgbW92ZURpcmVjdGlvbikKICAgICB7CiAgICAgICAgIHZhciBjb2x1bW5J ZGVudGlmaWVyID0gKGVsZW1lbnQuaGFzU3R5bGVDbGFzcygiMC1jb2x1bW4iKSA/IDAgOiAxKTsK ICAgICAgICAgdmFyIHRleHRCZWZvcmVFZGl0aW5nID0gdGhpcy5fZWRpdGluZ05vZGUuZGF0YVtj b2x1bW5JZGVudGlmaWVyXTsKKyAgICAgICAgdmFyIGN1cnJlbnRFZGl0aW5nTm9kZSA9IHRoaXMu X2VkaXRpbmdOb2RlOworCisgICAgICAgIGZ1bmN0aW9uIG1vdmVUb05leHRJZk5lZWRlZCh3YXND aGFuZ2UpIHsKKyAgICAgICAgICAgIGlmICghbW92ZURpcmVjdGlvbikKKyAgICAgICAgICAgICAg ICByZXR1cm47CisKKyAgICAgICAgICAgIGlmIChtb3ZlRGlyZWN0aW9uID09PSAiZm9yd2FyZCIp IHsKKyAgICAgICAgICAgICAgICBpZiAoY3VycmVudEVkaXRpbmdOb2RlLmlzQ3JlYXRpb25Ob2Rl ICYmIGNvbHVtbklkZW50aWZpZXIgPT09IDAgJiYgIXdhc0NoYW5nZSkKKyAgICAgICAgICAgICAg ICAgICAgcmV0dXJuOworCisgICAgICAgICAgICAgICAgaWYgKGNvbHVtbklkZW50aWZpZXIgPT09 IDApCisgICAgICAgICAgICAgICAgICAgIHJldHVybiB0aGlzLl9zdGFydEVkaXRpbmdDb2x1bW5P ZkRhdGFHcmlkTm9kZShjdXJyZW50RWRpdGluZ05vZGUsIDEpOworCisgICAgICAgICAgICAgICAg dmFyIG5leHREYXRhR3JpZE5vZGUgPSBjdXJyZW50RWRpdGluZ05vZGUudHJhdmVyc2VOZXh0Tm9k ZSh0cnVlLCBudWxsLCB0cnVlKTsKKyAgICAgICAgICAgICAgICBpZiAobmV4dERhdGFHcmlkTm9k ZSkKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRoaXMuX3N0YXJ0RWRpdGluZ0NvbHVtbk9m RGF0YUdyaWROb2RlKG5leHREYXRhR3JpZE5vZGUsIDApOworICAgICAgICAgICAgICAgIGlmIChj dXJyZW50RWRpdGluZ05vZGUuaXNDcmVhdGlvbk5vZGUgJiYgd2FzQ2hhbmdlKSB7CisgICAgICAg ICAgICAgICAgICAgIGFkZENyZWF0aW9uTm9kZShmYWxzZSk7CisgICAgICAgICAgICAgICAgICAg IHJldHVybiB0aGlzLl9zdGFydEVkaXRpbmdDb2x1bW5PZkRhdGFHcmlkTm9kZSh0aGlzLmNyZWF0 aW9uTm9kZSwgMCk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgaWYgKG1vdmVEaXJlY3Rpb24gPT09ICJiYWNr d2FyZCIpIHsKKyAgICAgICAgICAgICAgICBpZiAoY29sdW1uSWRlbnRpZmllciA9PT0gMSkKKyAg ICAgICAgICAgICAgICAgICAgcmV0dXJuIHRoaXMuX3N0YXJ0RWRpdGluZ0NvbHVtbk9mRGF0YUdy aWROb2RlKGN1cnJlbnRFZGl0aW5nTm9kZSwgMCk7CisgICAgICAgICAgICAgICAgICAgIHZhciBu ZXh0RGF0YUdyaWROb2RlID0gY3VycmVudEVkaXRpbmdOb2RlLnRyYXZlcnNlUHJldmlvdXNOb2Rl KHRydWUsIG51bGwsIHRydWUpOworCisgICAgICAgICAgICAgICAgaWYgKG5leHREYXRhR3JpZE5v ZGUpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiB0aGlzLl9zdGFydEVkaXRpbmdDb2x1bW5P ZkRhdGFHcmlkTm9kZShuZXh0RGF0YUdyaWROb2RlLCAxKTsKKyAgICAgICAgICAgICAgICByZXR1 cm47CisgICAgICAgICAgICB9CisgICAgICAgIH0KKwogICAgICAgICBpZiAodGV4dEJlZm9yZUVk aXRpbmcgPT0gbmV3VGV4dCkgewogICAgICAgICAgICAgdGhpcy5fZWRpdGluZ0NhbmNlbGxlZChl bGVtZW50KTsKKyAgICAgICAgICAgIG1vdmVUb05leHRJZk5lZWRlZC5jYWxsKHRoaXMsIGZhbHNl KTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCkBAIC03Nyw2ICsxMjIsNyBAQCBX ZWJJbnNwZWN0b3IuRE9NU3RvcmFnZURhdGFHcmlkLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAg ICAgICBpZiAoZG9tU3RvcmFnZS5nZXRJdGVtKG5ld1RleHQpICE9IG51bGwpIHsKICAgICAgICAg ICAgICAgICAgICAgZWxlbWVudC50ZXh0Q29udGVudCA9IHRoaXMuX2VkaXRpbmdOb2RlLmRhdGFb MF07CiAgICAgICAgICAgICAgICAgICAgIHRoaXMuX2VkaXRpbmdDYW5jZWxsZWQoZWxlbWVudCk7 CisgICAgICAgICAgICAgICAgICAgIG1vdmVUb05leHRJZk5lZWRlZC5jYWxsKHRoaXMsIGZhbHNl KTsKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgICAgICBkb21TdG9yYWdlLnJlbW92ZUl0ZW0odGhpcy5fZWRpdGluZ05vZGUuZGF0YVsw XSk7CkBAIC05Miw2ICsxMzgsNyBAQCBXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZURhdGFHcmlkLnBy b3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMuYWRkQ3JlYXRpb25Ob2RlKGZhbHNlKTsKIAog ICAgICAgICB0aGlzLl9lZGl0aW5nQ2FuY2VsbGVkKGVsZW1lbnQpOworICAgICAgICBtb3ZlVG9O ZXh0SWZOZWVkZWQuY2FsbCh0aGlzLCB0cnVlKTsKICAgICB9LAogCiAgICAgX2VkaXRpbmdDYW5j ZWxsZWQ6IGZ1bmN0aW9uKGVsZW1lbnQsIGNvbnRleHQpCg==