27731 2009-07-27 13:30:13 -0700 [V8] Implement EventListener::reportError for V8 event listeners in worker context. 2009-07-27 18:12:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED h P2 Normal --- 1 jianli jianli levin oldest_to_newest 135002 0 jianli 2009-07-27 13:30:13 -0700 Implement EventListener::reportError for V8 event listeners in worker context. 135003 1 33567 jianli 2009-07-27 13:35:19 -0700 Created attachment 33567 Proposed Patch 135082 2 33567 levin 2009-07-27 18:04:19 -0700 Comment on attachment 33567 Proposed Patch > diff --git a/WebCore/bindings/v8/V8WorkerContextEventListener.cpp b/WebCore/bindings/v8/V8WorkerContextEventListener.cpp > + // The callback function on XMLHttpRequest can clear the event listener and destroys 'this' object. Keep a local reference to it. I'd get rid of "on XMLHttpRequest" and change "destroys" to "destroy". > + // See issue 889829. I'd remove this issue number here. 135087 3 jianli 2009-07-27 18:12:18 -0700 Committed as http://trac.webkit.org/changeset/46448 33567 2009-07-27 13:35:19 -0700 2009-07-27 18:04:18 -0700 Proposed Patch 27731 text/plain 4047 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTdmMDMyOS4uNjhmMmYxNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAwOS0wNy0yNyAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1Y4XSBJbXBsZW1lbnQgRXZlbnRMaXN0ZW5lcjo6cmVwb3J0RXJyb3IgZm9y IFY4IGV2ZW50IGxpc3RlbmVycyBpbiB3b3JrZXIgY29udGV4dC4gCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzczMQorCisgICAgICAgICogYmluZGlu Z3MvdjgvVjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0ZW5lci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpWOFdvcmtlckNvbnRleHRFdmVudExpc3RlbmVyOjpyZXBvcnRFcnJvcik6CisgICAgICAgICog YmluZGluZ3MvdjgvVjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0ZW5lci5oOgorCisyMDA5LTA3LTI3 ICBKaWFuIExpICA8amlhbmxpQGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBE YXZpZCBMZXZpbi4KIAogICAgICAgICBGaXggZXJyb3IgaGFuZGxpbmcgaW4gZGVkaWNhdGVkIHdv cmtlciBhbmQgd29ya2VyIGNvbnRleHQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4V29ya2VyQ29udGV4dEV2ZW50TGlzdGVuZXIuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9W OFdvcmtlckNvbnRleHRFdmVudExpc3RlbmVyLmNwcAppbmRleCA5YmI0OGZiLi4wNzMwYjU2IDEw MDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4V29ya2VyQ29udGV4dEV2ZW50TGlzdGVu ZXIuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0 ZW5lci5jcHAKQEAgLTM1LDYgKzM1LDcgQEAKICNpbmNsdWRlICJWOFdvcmtlckNvbnRleHRFdmVu dExpc3RlbmVyLmgiCiAKICNpbmNsdWRlICJFdmVudC5oIgorI2luY2x1ZGUgIlY4QmluZGluZy5o IgogI2luY2x1ZGUgIldvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eS5oIgogCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CkBAIC03Nyw2ICs3OCw1MyBAQCB2b2lkIFY4V29ya2VyQ29udGV4dEV2ZW50TGlz dGVuZXI6OmhhbmRsZUV2ZW50KEV2ZW50KiBldmVudCwgYm9vbCBpc1dpbmRvd0V2ZW50KQogICAg IGludm9rZUV2ZW50SGFuZGxlcihjb250ZXh0LCBldmVudCwganNFdmVudCwgaXNXaW5kb3dFdmVu dCk7CiB9CiAKK2Jvb2wgVjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0ZW5lcjo6cmVwb3J0RXJyb3Io Y29uc3QgU3RyaW5nJiBtZXNzYWdlLCBjb25zdCBTdHJpbmcmIHVybCwgaW50IGxpbmVOdW1iZXIp Cit7CisgICAgLy8gSXMgdGhlIEV2ZW50TGlzdGVuZXIgZGlzY29ubmVjdGVkPworICAgIGlmIChk aXNjb25uZWN0ZWQoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgLy8gVGhlIGNhbGxi YWNrIGZ1bmN0aW9uIG9uIFhNTEh0dHBSZXF1ZXN0IGNhbiBjbGVhciB0aGUgZXZlbnQgbGlzdGVu ZXIgYW5kIGRlc3Ryb3lzICd0aGlzJyBvYmplY3QuIEtlZXAgYSBsb2NhbCByZWZlcmVuY2UgdG8g aXQuCisgICAgLy8gU2VlIGlzc3VlIDg4OTgyOS4KKyAgICBSZWZQdHI8VjhBYnN0cmFjdEV2ZW50 TGlzdGVuZXI+IHByb3RlY3QodGhpcyk7CisKKyAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxlU2Nv cGU7CisKKyAgICB2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiBjb250ZXh0ID0gbV9wcm94eS0+R2V0 Q29udGV4dCgpOworICAgIGlmIChjb250ZXh0LklzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIGZh bHNlOworCisgICAgLy8gRW50ZXIgdGhlIFY4IGNvbnRleHQgaW4gd2hpY2ggdG8gcGVyZm9ybSB0 aGUgZXZlbnQgaGFuZGxpbmcuCisgICAgdjg6OkNvbnRleHQ6OlNjb3BlIHNjb3BlKGNvbnRleHQp OworCisgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gcmV0dXJuVmFsdWU7CisgICAgeworICAgICAg ICAvLyBDYXRjaCBleGNlcHRpb25zIHRocm93biBpbiBjYWxsaW5nIHRoZSBmdW5jdGlvbiBzbyB0 aGV5IGRvIG5vdCBwcm9wYWdhdGUgdG8gamF2YXNjcmlwdCBjb2RlIHRoYXQgY2F1c2VkIHRoZSBl dmVudCB0byBmaXJlLgorICAgICAgICB2ODo6VHJ5Q2F0Y2ggdHJ5Q2F0Y2g7CisgICAgICAgIHRy eUNhdGNoLlNldFZlcmJvc2UodHJ1ZSk7CisKKyAgICAgICAgLy8gQ2FsbCB0aGUgZnVuY3Rpb24u CisgICAgICAgIGlmICghbV9saXN0ZW5lci5Jc0VtcHR5KCkgJiYgbV9saXN0ZW5lci0+SXNGdW5j dGlvbigpKSB7CisgICAgICAgICAgICB2ODo6TG9jYWw8djg6OkZ1bmN0aW9uPiBjYWxsRnVuY3Rp b24gPSB2ODo6TG9jYWw8djg6OkZ1bmN0aW9uPjo6TmV3KHY4OjpQZXJzaXN0ZW50PHY4OjpGdW5j dGlvbj46OkNhc3QobV9saXN0ZW5lcikpOworICAgICAgICAgICAgdjg6OkxvY2FsPHY4OjpPYmpl Y3Q+IHRoaXNWYWx1ZSA9IHY4OjpDb250ZXh0OjpHZXRDdXJyZW50KCktPkdsb2JhbCgpOworCisg ICAgICAgICAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gcGFyYW1ldGVyc1szXSA9IHsgdjhTdHJp bmcobWVzc2FnZSksIHY4U3RyaW5nKHVybCksIHY4OjpJbnRlZ2VyOjpOZXcobGluZU51bWJlcikg fTsKKyAgICAgICAgICAgIHJldHVyblZhbHVlID0gY2FsbEZ1bmN0aW9uLT5DYWxsKHRoaXNWYWx1 ZSwgMywgcGFyYW1ldGVycyk7CisgICAgICAgIH0KKworICAgICAgICAvLyBJZiBhbiBlcnJvciBv Y2N1cnMgd2hpbGUgaGFuZGxpbmcgdGhlIHNjcmlwdCBlcnJvciwgaXQgc2hvdWxkIGJlIGJ1YmJs ZWQgdXAuCisgICAgICAgIGlmICh0cnlDYXRjaC5IYXNDYXVnaHQoKSkgeworICAgICAgICAgICAg dHJ5Q2F0Y2guUmVzZXQoKTsKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgfQor ICAgIH0KKworICAgIC8vIElmIHRoZSBmdW5jdGlvbiByZXR1cm5zIGZhbHNlLCB0aGVuIHRoZSBl cnJvciBpcyBoYW5kbGVkLiBPdGhlcndpc2UsIHRoZSBlcnJvciBpcyBub3QgaGFuZGxlZC4KKyAg ICBib29sIGVycm9ySGFuZGxlZCA9IHJldHVyblZhbHVlLT5Jc0Jvb2xlYW4oKSAmJiAhcmV0dXJu VmFsdWUtPkJvb2xlYW5WYWx1ZSgpOworCisgICAgcmV0dXJuIGVycm9ySGFuZGxlZDsKK30KKwog djg6OkxvY2FsPHY4OjpWYWx1ZT4gVjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0ZW5lcjo6Y2FsbExp c3RlbmVyRnVuY3Rpb24odjg6OkhhbmRsZTx2ODo6VmFsdWU+IGpzRXZlbnQsIEV2ZW50KiBldmVu dCwgYm9vbCBpc1dpbmRvd0V2ZW50KQogewogICAgIHY4OjpMb2NhbDx2ODo6RnVuY3Rpb24+IGhh bmRsZXJGdW5jdGlvbiA9IGdldExpc3RlbmVyRnVuY3Rpb24oKTsKZGlmZiAtLWdpdCBhL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0ZW5lci5oIGIvV2ViQ29yZS9i aW5kaW5ncy92OC9WOFdvcmtlckNvbnRleHRFdmVudExpc3RlbmVyLmgKaW5kZXggOGU1NmE3My4u YzkwMWM1MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFdvcmtlckNvbnRleHRF dmVudExpc3RlbmVyLmgKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFdvcmtlckNvbnRleHRF dmVudExpc3RlbmVyLmgKQEAgLTUyLDYgKzUyLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAg ICAgICAgIHZpcnR1YWwgflY4V29ya2VyQ29udGV4dEV2ZW50TGlzdGVuZXIoKTsKICAgICAgICAg dmlydHVhbCB2b2lkIGhhbmRsZUV2ZW50KEV2ZW50KiwgYm9vbCBpc1dpbmRvd0V2ZW50KTsKKyAg ICAgICAgdmlydHVhbCBib29sIHJlcG9ydEVycm9yKGNvbnN0IFN0cmluZyYgbWVzc2FnZSwgY29u c3QgU3RyaW5nJiB1cmwsIGludCBsaW5lTnVtYmVyKTsKICAgICAgICAgdmlydHVhbCBib29sIGRp c2Nvbm5lY3RlZCgpIGNvbnN0IHsgcmV0dXJuICFtX3Byb3h5OyB9CiAKICAgICAgICAgV29ya2Vy Q29udGV4dEV4ZWN1dGlvblByb3h5KiBwcm94eSgpIGNvbnN0IHsgcmV0dXJuIG1fcHJveHk7IH0K