277309 2024-07-29 18:29:10 -0700 REGRESSION(276883@main): common/checkout/scm/scm_unittest.py::GitTestWithMock::test_push_local_commits_to_server_* 2026-03-14 20:42:13 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=271965 InRadar P2 Normal --- 1 gsnedders gsnedders bfan2 webkit-bug-importer oldest_to_newest 2049321 0 gsnedders 2024-07-29 18:29:10 -0700 Once again, the fact we don't run the SCM tests once again bites us. Running via tox and pytest, which doesn't skip these by default: FAILED common/checkout/scm/scm_unittest.py::GitTestWithMock::test_push_local_commits_to_server_with_username_and_without_password - AttributeError: 'Git' object has no attribute 'has_authorization_for_realm' FAILED common/checkout/scm/scm_unittest.py::GitTestWithMock::test_push_local_commits_to_server_without_username_and_password - AttributeError: 'Git' object has no attribute 'has_authorization_for_realm' FAILED common/checkout/scm/scm_unittest.py::GitTestWithMock::test_push_local_commits_to_server_without_username_and_with_password - AttributeError: 'Git' object has no attribute 'has_authorization_for_realm' This gets thrown from: def push_local_commits_to_server(self, username=None, password=None): dcommit_command = ['svn', 'dcommit', '--rmdir'] > if (not username or not password) and not self.has_authorization_for_realm(self.svn_server_realm): E AttributeError: 'Git' object has no attribute 'has_authorization_for_realm' common/checkout/scm/git.py:492: AttributeError The correct answer here is probably to just remove `Git.push_local_commits_to_server`, given `git-svn dcommit` and our SVN server being gone, but it does have several callers. I presume just everything using it is just dead code that I failed to catch when I tried to remove dead code before. I think webkit-patch's land-unsafe, land-attachment, land-from-bug, and revert at least all use that code path, and I don't know if we expect any of these to still be functional at all? 2049322 1 webkit-bug-importer 2024-07-29 18:29:18 -0700 <rdar://problem/132770101> 2190163 2 gsnedders 2026-03-13 16:58:01 -0700 Pull request: https://github.com/WebKit/WebKit/pull/60598 2190352 3 ews-feeder 2026-03-14 20:42:13 -0700 Test gardening commit 309282@main (3a620254c233): <https://commits.webkit.org/309282@main> Reviewed commits have been landed. Closing PR #60598 and removing active labels.