27726 2009-07-27 11:34:58 -0700 [WML] Variable substitution recursion seems to have bugs 2009-07-28 08:34:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 20393 1 zimmermann zimmermann staikos oldest_to_newest 134967 0 zimmermann 2009-07-27 11:34:58 -0700 <setvar name="a" value="b"/> <setvar name="b" value="$a"/> After substitution, "b" is empty, where it should be equal to "a". LayoutTests/wml/resources/variable-reference-valid.js contains a FIXME related to that. manual-tests/wml/variable-substitution.wml also highlights the problem. 135216 1 33642 zimmermann 2009-07-28 08:27:21 -0700 Created attachment 33642 Initial patch 135221 2 zimmermann 2009-07-28 08:34:28 -0700 Landed in r46487. 33642 2009-07-28 08:27:21 -0700 2009-07-28 08:31:35 -0700 Initial patch bug-27726-20090728172718.patch text/plain 6653 zimmermann SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjQ4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDctMjggIE5pa29sYXMgWmltbWVybWFubiAgPG5pa29sYXMu emltbWVybWFubkB0b3JjaG1vYmlsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW1dNTF0gVmFyaWFibGUgc3Vic3RpdHV0aW9uIHJlY3Vyc2lv biBzZWVtcyB0byBoYXZlIGJ1Z3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI3NzI2CisKKyAgICAgICAgQWxsb3cgPHNldHZhcj4gZWxlbWVudHMgdG8g ZGVwZW5kIG9uIHRoZSB2YWx1ZSBzcGVjaWZpZWQgYnkgcHJlY2VlZGluZyA8c2V0dmFyPiBlbGVt ZW50cy4KKyAgICAgICAgUmVxdWlyZWQgYnkgdGhlIHNwZWNpZmljYXRpb24gLSBhc3N1cmUgaXQg b25seSB3b3JrcyBpbiBsaW5lYXIgb3JkZXIuIEEgc2V0dmFyIGVsZW1lbnQgbWF5CisgICAgICAg IG5vdCBkZXBlbmQgb24gdGhlIHZhcmlhYmxlIHN0YXRlIG9mIGEgZm9sbG93aW5nIHNldHZhciBl bGVtZW50LCBvbmx5IHRoZSBwcmV2aW91cyBvbmVzLgorCisgICAgICAgIEV4dGVuZCB3bWwvdmFy aWFibGUtcmVmZXJlbmNlLXZhbGlkLmh0bWwgbGF5b3V0IHRlc3QgdG8gY292ZXIgdGhlc2UgY2Fz ZXMuCisKKyAgICAgICAgKiB3bWwvV01MVGFza0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6V01MVGFza0VsZW1lbnQ6OnN0b3JlVmFyaWFibGVTdGF0ZSk6CisKIDIwMDktMDctMjggIE5p a29sYXMgWmltbWVybWFubiAgPG5pa29sYXMuemltbWVybWFubkB0b3JjaG1vYmlsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvcmdlIFN0YWlrb3MuCkluZGV4OiBXZWJDb3JlL3dtbC9X TUxUYXNrRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS93bWwvV01MVGFza0VsZW1l bnQuY3BwCShyZXZpc2lvbiA0NjQ4NikKKysrIFdlYkNvcmUvd21sL1dNTFRhc2tFbGVtZW50LmNw cAkod29ya2luZyBjb3B5KQpAQCAtNzgsMTQgKzc4LDE4IEBAIHZvaWQgV01MVGFza0VsZW1lbnQ6 OnN0b3JlVmFyaWFibGVTdGF0ZSgKIAogICAgIGZvciAoOyBpdCAhPSBlbmQ7ICsraXQpIHsKICAg ICAgICAgV01MU2V0dmFyRWxlbWVudCogc2V0dGVyRWxlbWVudCA9ICgqaXQpOwotICAgICAgICBp ZiAoc2V0dGVyRWxlbWVudC0+bmFtZSgpLmlzRW1wdHkoKSkKKworICAgICAgICBTdHJpbmcgbmFt ZSA9IHNldHRlckVsZW1lbnQtPm5hbWUoKTsKKyAgICAgICAgaWYgKG5hbWUuaXNFbXB0eSgpKQog ICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgdmFyaWFibGVzLnNldChzZXR0ZXJFbGVt ZW50LT5uYW1lKCksIHNldHRlckVsZW1lbnQtPnZhbHVlKCkpOwotICAgIH0KKyAgICAgICAgU3Ry aW5nIHZhbHVlID0gc2V0dGVyRWxlbWVudC0+dmFsdWUoKTsKKyAgICAgICAgdmFyaWFibGVzLnNl dChuYW1lLCB2YWx1ZSk7CiAKLSAgICBpZiAodmFyaWFibGVzLmlzRW1wdHkoKSkKLSAgICAgICAg cmV0dXJuOworICAgICAgICAvLyBUaGUgbmV4dCBzZXR2YXIgZWxlbWVudCBtYXkgZGVwZW5kIG9u IHRoaXMgdmFyaWFibGUgdmFsdWUuIEl0J3Mgc2FmZSB0byBzdG9yZSB0aGUgY3VycmVudAorICAg ICAgICAvLyBuYW1lIHZhbHVlIHBhaXIgaW4gdGhlIHBhZ2Ugc3RhdGUsIGFzIHRoZSB3aG9sZSBw YWdlIHN0YXRlIGlzIHJlcGxhY2VkIHNvb24gYnkgdGhpcyBuZXcgbWFwCisgICAgICAgIHBhZ2VT dGF0ZS0+c3RvcmVWYXJpYWJsZShuYW1lLCB2YWx1ZSk7CisgICAgfQogCiAgICAgcGFnZVN0YXRl LT5zdG9yZVZhcmlhYmxlcyh2YXJpYWJsZXMpOwogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDY0ODYp CisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBA QAorMjAwOS0wNy0yOCAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bmlrb2xhcy56aW1tZXJtYW5uQHRv cmNobW9iaWxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbV01MXSBWYXJpYWJsZSBzdWJzdGl0dXRpb24gcmVjdXJzaW9uIHNlZW1zIHRvIGhh dmUgYnVncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mjc3MjYKKworICAgICAgICBFeHRlbmQgdmFyaWFibGUtcmVmZXJlbmNlLXZhbGlkLmh0bWwgdG8g dGVzdCA8c2V0dmFyPiBhdHRyaWJ1dGUgdmFsdWVzIGRlcGVuZGluZyBvbiBlYWNoIG90aGVyLgor CisgICAgICAgICogd21sL3Jlc291cmNlcy92YXJpYWJsZS1yZWZlcmVuY2UtdmFsaWQuanM6Cisg ICAgICAgIChzZXR1cFRlc3REb2N1bWVudCk6CisgICAgICAgIChwcmVwYXJlVGVzdCk6CisgICAg ICAgIChleGVjdXRlVGVzdCk6CisgICAgICAgICogd21sL3ZhcmlhYmxlLXJlZmVyZW5jZS12YWxp ZC1leHBlY3RlZC50eHQ6CisKIDIwMDktMDctMjggIE5pa29sYXMgWmltbWVybWFubiAgPG5pa29s YXMuemltbWVybWFubkB0b3JjaG1vYmlsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2Vv cmdlIFN0YWlrb3MuCkluZGV4OiBMYXlvdXRUZXN0cy93bWwvdmFyaWFibGUtcmVmZXJlbmNlLXZh bGlkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy93bWwvdmFyaWFibGUt cmVmZXJlbmNlLXZhbGlkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNDY0ODYpCisrKyBMYXlvdXRU ZXN0cy93bWwvdmFyaWFibGUtcmVmZXJlbmNlLXZhbGlkLWV4cGVjdGVkLnR4dAkod29ya2luZyBj b3B5KQpAQCAtMTIsMTIgKzEyLDE0IEBAIFBBU1MgcEVsZW1lbnQzLnRleHRDb250ZW50IGlzICJS ZXN1bHQ6ICQKIFBBU1MgcEVsZW1lbnQ0LnRleHRDb250ZW50IGlzICJSZXN1bHQ6ICQodmFyMjp1 bmVzYykiCiBQQVNTIHBFbGVtZW50NS50ZXh0Q29udGVudCBpcyAiUmVzdWx0OiAkdiIKIFBBU1Mg cEVsZW1lbnQ2LnRleHRDb250ZW50IGlzICJSZXN1bHQ6ICQodjplKSIKK1BBU1MgcEVsZW1lbnQ3 LnRleHRDb250ZW50IGlzICJSZXN1bHQ6ICR3b250d29yayIKIFBBU1MgcEVsZW1lbnQxLnRleHRD b250ZW50IGlzICJSZXN1bHQ6IFRFU1QgUEFTU0VEIgogUEFTUyBwRWxlbWVudDIudGV4dENvbnRl bnQgaXMgIlJlc3VsdDogVEVTVCUyMFBBU1NFRCIKIFBBU1MgcEVsZW1lbnQzLnRleHRDb250ZW50 IGlzICJSZXN1bHQ6IFRFU1QlMjBQQVNTRUQiCiBQQVNTIHBFbGVtZW50NC50ZXh0Q29udGVudCBp cyAiUmVzdWx0OiBURVNUIFBBU1NFRCIKIFBBU1MgcEVsZW1lbnQ1LnRleHRDb250ZW50IGlzICJS ZXN1bHQ6IFRFU1QgUEFTU0VEIgogUEFTUyBwRWxlbWVudDYudGV4dENvbnRlbnQgaXMgIlJlc3Vs dDogVEVTVCUyMFBBU1NFRCIKK1BBU1MgcEVsZW1lbnQ3LnRleHRDb250ZW50IGlzICJSZXN1bHQ6 ICIKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpAQCAt MzMsMyArMzUsNCBAQCBSZXN1bHQ6IFRFU1QlMjBQQVNTRUQKIFJlc3VsdDogVEVTVCBQQVNTRUQK IFJlc3VsdDogVEVTVCBQQVNTRUQKIFJlc3VsdDogVEVTVCUyMFBBU1NFRAorUmVzdWx0OgpJbmRl eDogTGF5b3V0VGVzdHMvd21sL3Jlc291cmNlcy92YXJpYWJsZS1yZWZlcmVuY2UtdmFsaWQuanMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvd21sL3Jlc291cmNlcy92YXJpYWJsZS1yZWZlcmVu Y2UtdmFsaWQuanMJKHJldmlzaW9uIDQ2NDg2KQorKysgTGF5b3V0VGVzdHMvd21sL3Jlc291cmNl cy92YXJpYWJsZS1yZWZlcmVuY2UtdmFsaWQuanMJKHdvcmtpbmcgY29weSkKQEAgLTE3LDE5ICsx NywyMyBAQCBmdW5jdGlvbiBzZXR1cFRlc3REb2N1bWVudCgpIHsKICAgICBzZXR2YXJFbGVtZW50 MS5zZXRBdHRyaWJ1dGUoInZhbHVlIiwgIlRFU1QgUEFTU0VEIik7CiAgICAgcmVmcmVzaEVsZW1l bnQuYXBwZW5kQ2hpbGQoc2V0dmFyRWxlbWVudDEpOwogCisgICAgLy8gJ3ZhcjInIGRvZXNuJ3Qg ZXhpc3QgeWV0LCBzbyB0aGUgdmFsdWUgd2lsbCBiZSBlbXB0eQogICAgIHZhciBzZXR2YXJFbGVt ZW50MiA9IGNyZWF0ZVdNTEVsZW1lbnQoInNldHZhciIpOwotICAgIHNldHZhckVsZW1lbnQyLnNl dEF0dHJpYnV0ZSgibmFtZSIsICJ2YXIyIik7Ci0KLSAgICAvLyBGSVhNRTogVXNlICQodmFyOmVz Y2FwZSkgaW5zdGVhZCBvZiBURVNUJTIwUEFTU0VELgotICAgIC8vIFRoaXMgZG9lc24ndCB3b3Jr IGF0IHRoZSBtb21lbnQuIEludmVzdGlnYXRlLgotICAgIHNldHZhckVsZW1lbnQyLnNldEF0dHJp YnV0ZSgidmFsdWUiLCAiVEVTVCUyMFBBU1NFRCIpOworICAgIHNldHZhckVsZW1lbnQyLnNldEF0 dHJpYnV0ZSgibmFtZSIsICJ3b250d29yayIpOworICAgIHNldHZhckVsZW1lbnQyLnNldEF0dHJp YnV0ZSgidmFsdWUiLCAiJHZhcjIiKTsKICAgICByZWZyZXNoRWxlbWVudC5hcHBlbmRDaGlsZChz ZXR2YXJFbGVtZW50Mik7CiAKKyAgICAvLyAndmFyJyBhbHJlYWR5IGV4aXN0cywgc28gdGhlIHZh bHVlIHdpbGwgYmUgIlRFU1QlMjBQQVNTRUQiCiAgICAgdmFyIHNldHZhckVsZW1lbnQzID0gY3Jl YXRlV01MRWxlbWVudCgic2V0dmFyIik7Ci0gICAgc2V0dmFyRWxlbWVudDMuc2V0QXR0cmlidXRl KCJuYW1lIiwgInYiKTsKLSAgICBzZXR2YXJFbGVtZW50My5zZXRBdHRyaWJ1dGUoInZhbHVlIiwg IlRFU1QgUEFTU0VEIik7CisgICAgc2V0dmFyRWxlbWVudDMuc2V0QXR0cmlidXRlKCJuYW1lIiwg InZhcjIiKTsKKyAgICBzZXR2YXJFbGVtZW50My5zZXRBdHRyaWJ1dGUoInZhbHVlIiwgIiQodmFy OmVzY2FwZSkiKTsKICAgICByZWZyZXNoRWxlbWVudC5hcHBlbmRDaGlsZChzZXR2YXJFbGVtZW50 Myk7CiAKKyAgICB2YXIgc2V0dmFyRWxlbWVudDQgPSBjcmVhdGVXTUxFbGVtZW50KCJzZXR2YXIi KTsKKyAgICBzZXR2YXJFbGVtZW50NC5zZXRBdHRyaWJ1dGUoIm5hbWUiLCAidiIpOworICAgIHNl dHZhckVsZW1lbnQ0LnNldEF0dHJpYnV0ZSgidmFsdWUiLCAiVEVTVCBQQVNTRUQiKTsKKyAgICBy ZWZyZXNoRWxlbWVudC5hcHBlbmRDaGlsZChzZXR2YXJFbGVtZW50NCk7CisKICAgICBwRWxlbWVu dDEgPSBjcmVhdGVXTUxFbGVtZW50KCJwIik7CiAgICAgcEVsZW1lbnQxLnRleHRDb250ZW50ID0g IlJlc3VsdDogJHZhciI7CiAgICAgY2FyZEVsZW1lbnQuYXBwZW5kQ2hpbGQocEVsZW1lbnQxKTsK QEAgLTUzLDYgKzU3LDEwIEBAIGZ1bmN0aW9uIHNldHVwVGVzdERvY3VtZW50KCkgewogICAgIHBF bGVtZW50NiA9IGNyZWF0ZVdNTEVsZW1lbnQoInAiKTsKICAgICBwRWxlbWVudDYudGV4dENvbnRl bnQgPSAiUmVzdWx0OiAkKHY6ZSkiOwogICAgIGNhcmRFbGVtZW50LmFwcGVuZENoaWxkKHBFbGVt ZW50Nik7CisKKyAgICBwRWxlbWVudDcgPSBjcmVhdGVXTUxFbGVtZW50KCJwIik7CisgICAgcEVs ZW1lbnQ3LnRleHRDb250ZW50ID0gIlJlc3VsdDogJHdvbnR3b3JrIjsKKyAgICBjYXJkRWxlbWVu dC5hcHBlbmRDaGlsZChwRWxlbWVudDcpOwogfQogCiBmdW5jdGlvbiBwcmVwYXJlVGVzdCgpIHsK QEAgLTYyLDYgKzcwLDcgQEAgZnVuY3Rpb24gcHJlcGFyZVRlc3QoKSB7CiAgICAgc2hvdWxkQmVF cXVhbFRvU3RyaW5nKCJwRWxlbWVudDQudGV4dENvbnRlbnQiLCAiUmVzdWx0OiAkKHZhcjI6dW5l c2MpIik7CiAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJwRWxlbWVudDUudGV4dENvbnRlbnQi LCAiUmVzdWx0OiAkdiIpOwogICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygicEVsZW1lbnQ2LnRl eHRDb250ZW50IiwgIlJlc3VsdDogJCh2OmUpIik7CisgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5n KCJwRWxlbWVudDcudGV4dENvbnRlbnQiLCAiUmVzdWx0OiAkd29udHdvcmsiKTsKIAogICAgIHN0 YXJ0VGVzdCgyNSwgMTUpOwogfQpAQCAtNzMsNiArODIsNyBAQCBmdW5jdGlvbiBleGVjdXRlVGVz dCgpIHsKICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoInBFbGVtZW50NC50ZXh0Q29udGVudCIs ICJSZXN1bHQ6IFRFU1QgUEFTU0VEIik7CiAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJwRWxl bWVudDUudGV4dENvbnRlbnQiLCAiUmVzdWx0OiBURVNUIFBBU1NFRCIpOwogICAgIHNob3VsZEJl RXF1YWxUb1N0cmluZygicEVsZW1lbnQ2LnRleHRDb250ZW50IiwgIlJlc3VsdDogVEVTVCUyMFBB U1NFRCIpOworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygicEVsZW1lbnQ3LnRleHRDb250ZW50 IiwgIlJlc3VsdDogIik7CiAKICAgICBjb21wbGV0ZVRlc3QoKTsKIH0=