<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>277243</bug_id>
          
          <creation_ts>2024-07-28 21:15:00 -0700</creation_ts>
          <short_desc>prepare-ChangeLog fails to extract function names from changed files with Windows Perl</short_desc>
          <delta_ts>2024-07-30 12:53:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2049023</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2024-07-28 21:15:00 -0700</bug_when>
    <thetext>prepare-ChangeLog is used for prepare-commit-msg.

PS C:\webkit\wb&gt; perl .\Tools\Scripts\prepare-ChangeLog --no-write --only-files --git-commit c78d507eeee2
  Running status to find changed, added, or removed files.
  Reviewing diff to determine which lines changed.
  Extracting affected function names from source files.
fatal: path &apos;&apos;Source\WebCore\style\StyleBuilderConverter.h&apos;&apos; does not exist in &apos;c78d507eeee2&apos;
fatal: path &apos;&apos;Source\WebCore\style\StyleBuilderConverter.h&apos;&apos; does not exist in &apos;c78d507eeee2^&apos;
fatal: path &apos;&apos;LayoutTests\svg\zoom\page\transform-origin-and-zoom-expected.html&apos;&apos; does not exist in &apos;c78d507eeee2&apos;
Use of uninitialized value $first_line in pattern match (m//) at .\Tools\Scripts\prepare-ChangeLog line 734.
fatal: path &apos;&apos;LayoutTests\svg\zoom\page\transform-origin-and-zoom.html&apos;&apos; does not exist in &apos;c78d507eeee2&apos;
Use of uninitialized value $first_line in pattern match (m//) at .\Tools\Scripts\prepare-ChangeLog line 734.
fatal: path &apos;&apos;Source\WebCore\svg\SVGGraphicsElement.cpp&apos;&apos; does not exist in &apos;c78d507eeee2&apos;
fatal: path &apos;&apos;Source\WebCore\svg\SVGGraphicsElement.cpp&apos;&apos; does not exist in &apos;c78d507eeee2^&apos;
  Change author: Fujii Hironori &lt;Hironori.Fujii@sony.com&gt;.
        * LayoutTests/svg/zoom/page/transform-origin-and-zoom-expected.html: Added.
        * LayoutTests/svg/zoom/page/transform-origin-and-zoom.html: Added.
        * Source/WebCore/style/StyleBuilderConverter.h:
        * Source/WebCore/svg/SVGGraphicsElement.cpp:</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2049026</commentid>
    <comment_count>1</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2024-07-28 21:29:38 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/31373</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2049028</commentid>
    <comment_count>2</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2024-07-28 21:30:43 -0700</bug_when>
    <thetext>With above PR, it works as expected.

PS C:\webkit\wb&gt; perl .\Tools\Scripts\prepare-ChangeLog --no-write --only-files --git-commit c78d507eeee2
  Running status to find changed, added, or removed files.
  Reviewing diff to determine which lines changed.
  Extracting affected function names from source files.
  Change author: Fujii Hironori &lt;Hironori.Fujii@sony.com&gt;.
        * LayoutTests/svg/zoom/page/transform-origin-and-zoom-expected.html: Added.
        * LayoutTests/svg/zoom/page/transform-origin-and-zoom.html: Added.
        * Source/WebCore/style/StyleBuilderConverter.h:
        (WebCore::Style::BuilderConverter::convertTransform):
        (WebCore::Style::BuilderConverter::convertTranslate):
        * Source/WebCore/svg/SVGGraphicsElement.cpp:
        (WebCore::SVGGraphicsElement::animatedLocalTransform const):</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2049580</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-07-30 12:52:44 -0700</bug_when>
    <thetext>Committed 281589@main (feb8501f9c7b): &lt;https://commits.webkit.org/281589@main&gt;

Reviewed commits have been landed. Closing PR #31373 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2049582</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-07-30 12:53:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/132836566&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>