27709 2009-07-27 06:30:59 -0700 [Qt] Disable some compiler warnings for the win build 2009-07-28 05:27:15 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Windows 2000 RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned hausmann oldest_to_newest 134901 0 laszlo.gombos 2009-07-27 06:30:59 -0700 I propose to disable the following windows warnings for the QtWebKit windows build. All of these warnings are disabled for the Safari Windows build as well. warning C4503: decorated name length exceeded, name was truncated warning C4800: 'BOOL' : forcing value to bool 'true' or 'false' (performance warning) warning C4819: The file contains a character that cannot be represented in the current code page (XXX). Save the file in Unicode format to prevent data loss" -- see r46398 warning C4996: This function or variable may be unsafe. Consider using YYY instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. I would like to also propose to apply these options in WebKit.pri so that they are applicable for the entire QtWebKit project and not just for QtWebKit.dll. 134902 1 33541 laszlo.gombos 2009-07-27 06:35:09 -0700 Created attachment 33541 proposed patch. 135165 2 33541 hausmann 2009-07-28 05:25:54 -0700 Comment on attachment 33541 proposed patch. r=me. Thanks :) 135166 3 hausmann 2009-07-28 05:27:15 -0700 Landed in r46471 33541 2009-07-27 06:35:09 -0700 2009-07-28 05:25:53 -0700 proposed patch. patch_27709.txt text/plain 2280 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ2NDE1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDct MjcgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRGlzYWJsZSBzb21l IGNvbXBpbGVyIHdhcm5pbmdzIGZvciB0aGUgd2luIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzcwOQorCisgICAgICAgICogV2ViS2l0LnBy aToKKwogMjAwOS0wNy0yNCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgpJbmRleDogV2ViS2l0LnByaQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQucHJpCShyZXZpc2lvbiA0NjQwMSkKKysrIFdlYktpdC5wcmkJKHdvcmtp bmcgY29weSkKQEAgLTUyLDYgKzUyLDEwIEBAIHN5bWJpYW4gewogCiBjb250YWlucyhERUZJTkVT LCBRVF9OT19VSVRPT0xTKTogQ09ORklHIC09IHVpdG9vbHMKIAorIyBEaXNhYmxlIGEgZmV3IHdh cm5pbmdzIG9uIFdpbmRvd3MuIFRoZSB3YXJuaW5ncyBhcmUgYWxzbworIyBkaXNhYmxlZCBpbiBX ZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvY29tbW9uLnZzcHJvcHMKK3dpbjMyLW1z dmMqOiBRTUFLRV9DWFhGTEFHUyArPSAtd2Q0MjkxIC13ZDQzNDQgLXdkNDUwMyAtd2Q0ODAwIC13 ZDQ4MTkgLXdkNDk5NgorCiAjCiAjIEZvciBidWlsZHMgaW5zaWRlIFF0IHdlIGludGVycHJldCB0 aGUgb3V0cHV0IHJ1bGUgYW5kIHRoZSBpbnB1dCBvZiBlYWNoIGV4dHJhIGNvbXBpbGVyIG1hbnVh bGx5CiAjIGFuZCBhZGQgdGhlIHJlc3VsdGluZyBzb3VyY2VzIHRvIHRoZSBTT1VSQ0VTIHZhcmlh YmxlLCBiZWNhdXNlIHRoZSBidWlsZCBpbnNpZGUgUXQgY29udGFpbnMgYWxyZWFkeQpJbmRleDog V2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlz aW9uIDQ2NDE1KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxMiBAQAorMjAwOS0wNy0yNyAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tp YS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W1F0XSBEaXNhYmxlIHNvbWUgY29tcGlsZXIgd2FybmluZ3MgZm9yIHRoZSB3aW4gYnVpbGQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NzA5CisKKyAg ICAgICAgKiBXZWJDb3JlLnBybzogTW92ZSB0aGUgbXN2YyBvcHRpb25zIHRvIFdlYktpdC5wcmkK KwogMjAwOS0wNy0yNyAgVG9yIEFybmUgVmVzdGLDuCAgPHRvci5hcm5lLnZlc3Rib0Bub2tpYS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJDb3Jl L1dlYkNvcmUucHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvV2ViQ29yZS5wcm8JKHJldmlzaW9u IDQ2NDAxKQorKysgV2ViQ29yZS9XZWJDb3JlLnBybwkod29ya2luZyBjb3B5KQpAQCAtMzcsMTAg KzM3LDYgQEAgdW5peCB7CiBDT05GSUcgLT0gd2Fybl9vbgogKi1nKysqOlFNQUtFX0NYWEZMQUdT ICs9IC1XcmV0dXJuLXR5cGUgLWZuby1zdHJpY3QtYWxpYXNpbmcKIAotIyBEaXNhYmxlIGEgZmV3 IHdhcm5pbmdzIG9uIFdpbmRvd3MuIFRoZSB3YXJuaW5ncyBhcmUgYWxzbwotIyBkaXNhYmxlZCBp biBXZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvY29tbW9uLnZzcHJvcHMKLXdpbjMy LW1zdmMqOiBRTUFLRV9DWFhGTEFHUyArPSAtd2Q0MjkxIC13ZDQzNDQKLQogdW5peDohbWFjOiot ZysrKjpRTUFLRV9DWFhGTEFHUyArPSAtZmZ1bmN0aW9uLXNlY3Rpb25zIC1mZGF0YS1zZWN0aW9u cyAKIHVuaXg6IW1hYzoqLWcrKyo6UU1BS0VfTEZMQUdTICs9IC1XbCwtLWdjLXNlY3Rpb25zCiAK