277089 2024-07-25 12:25:02 -0700 [WASM] Prefixed opcodes should be printed in full in code origins and disassembly 2024-07-26 14:36:24 -0700 1 1 1 Unclassified WebKit WebAssembly WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 d_degazio d_degazio webkit-bug-importer oldest_to_newest 2048374 0 d_degazio 2024-07-25 12:25:02 -0700 Our WASM disassembly and code origins assume that each WASM instruction is identifiable by a single OpType. This hasn't been true for a while, and what this means is whenever we dump the origin for a SIMD or GC or Ext1 opcode, we just dump something like "ExtGC" instead of something more specific. We should pass this information along when it's easily possible to aid in debugging. 2048375 1 webkit-bug-importer 2024-07-25 12:25:16 -0700 <rdar://problem/132508220> 2048382 2 d_degazio 2024-07-25 12:56:15 -0700 Pull request: https://github.com/WebKit/WebKit/pull/31239 2048409 3 d_degazio 2024-07-25 14:14:39 -0700 Example --dumpBBQDisassembly=1 output before: [ 0x1] ExtSIMD [ 0x13] ExtSIMD [ 0x25] ExtSIMD [ 0x28] ExtSIMD [ 0x2b] End ...and after: [ 0x1] V128Const [ 0x13] V128Const [ 0x25] F32x4Pmin [ 0x28] F32x4ExtractLane [ 0x2b] End 2048715 4 ews-feeder 2024-07-26 14:36:23 -0700 Committed 281418@main (d898a3cffd9c): <https://commits.webkit.org/281418@main> Reviewed commits have been landed. Closing PR #31239 and removing active labels.