27702 2009-07-27 02:11:09 -0700 [Qt] Buildfix on Windows 2009-07-27 03:39:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 ossy webkit-unassigned hausmann oldest_to_newest 134870 0 ossy 2009-07-27 02:11:09 -0700 If building QtWebKit with MinGW-4.4, assembler stop the building, because the inline assembly code below compiled to "call %*dl". The "g" constraint should be "m", because *endPaint is nothing but memory operand, such as *beginPaint in hookedBeginPaint function. WebCore/plugins/win/PluginViewWin.cpp - hookedEndPaint function: asm ("push %2\n" "push %3\n" "call *%4\n" : "=a" (result) : "a" (endPaintSysCall), "g" (lpPaint), "g" (hWnd), "g" (*endPaint) ); 134872 1 33526 ossy 2009-07-27 02:14:39 -0700 Created attachment 33526 proposed patch 134881 2 33530 ossy 2009-07-27 03:36:38 -0700 Created attachment 33530 proposed patch 134882 3 33530 hausmann 2009-07-27 03:38:45 -0700 Comment on attachment 33530 proposed patch r=me. Thanks! 134883 4 hausmann 2009-07-27 03:39:49 -0700 Landed in r46411 33526 2009-07-27 02:14:39 -0700 2009-07-27 03:36:38 -0700 proposed patch winbuildfix.patch text/plain 1090 ossy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDFlNmJhYS4uYzUwODMzOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNy0yNyAgQ3NhYmEgT3N6dHJv Z29uYWMgIDxvc3ppQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEJ1aWxkZml4IG9uIFdpbmRvd3MuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzcwMgorCisgICAgICAg ICogcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVn aW5WaWV3Ojpob29rZWRFbmRQYWludCk6CisKIDIwMDktMDctMjcgIEJyZW50IEZ1bGdoYW0gIDxi ZnVsZ2hhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkIGNvcnJlY3QsIG5vIHJldmlldy4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAgYi9XZWJD b3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwCmluZGV4IGYwYTJhMTQuLjQ2NDBiNGQg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKKysrIGIv V2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcApAQCAtMTU0LDcgKzE1NCw3IEBA IEJPT0wgV0lOQVBJIFBsdWdpblZpZXc6Omhvb2tlZEVuZFBhaW50KEhXTkQgaFduZCwgY29uc3Qg UEFJTlRTVFJVQ1QqIGxwUGFpbnQpCiAgICAgICAgICAicHVzaCAgICUzXG4iCiAgICAgICAgICAi Y2FsbCAgIColNFxuIgogICAgICAgICAgOiAiPWEiIChyZXN1bHQpCi0gICAgICAgICA6ICJhIiAo ZW5kUGFpbnRTeXNDYWxsKSwgImciIChscFBhaW50KSwgImciIChoV25kKSwgImciICgqZW5kUGFp bnQpCisgICAgICAgICA6ICJhIiAoZW5kUGFpbnRTeXNDYWxsKSwgImciIChscFBhaW50KSwgImci IChoV25kKSwgIm0iICgqZW5kUGFpbnQpCiAgICAgICAgICk7CiAgICAgcmV0dXJuIHJlc3VsdDsK ICNlbHNlCg== 33530 2009-07-27 03:36:38 -0700 2009-07-27 03:38:45 -0700 proposed patch winbuildfix2.patch text/plain 1265 ossy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDFlNmJhYS4uYmE5YmU3NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNy0yNyAgQ3NhYmEgT3N6dHJv Z29uYWMgIDxvc3ppQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEJ1aWxkZml4IG9uIFdpbmRvd3MuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzcwMgorCisgICAgICAg ICogcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVn aW5WaWV3Ojpob29rZWRFbmRQYWludCk6CisgICAgICAgICAgICBDb25zdHJhaW50IG9mICgqZW5k UGFpbnQpIG9wZXJhbmQgbW9kaWZpZWQgZnJvbSAiZyIgdG8gIm0iIChtZW1vcnkpIGluIGlubGlu ZSAKKyAgICAgICAgICAgIGFzc2VtYmx5LCBiZWNhdXNlIHdpdGggImciIGNvbnN0cmFpbnQsIHdy b25nIGFzc2VtYmx5IGNvZGUgZ2VuZXJhdGVkLgorCiAyMDA5LTA3LTI3ICBCcmVudCBGdWxnaGFt ICA8YmZ1bGdoYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBjb3JyZWN0LCBubyByZXZp ZXcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwIGIv V2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAppbmRleCBmMGEyYTE0Li40NjQw YjRkIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwCisr KyBiL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKQEAgLTE1NCw3ICsxNTQs NyBAQCBCT09MIFdJTkFQSSBQbHVnaW5WaWV3Ojpob29rZWRFbmRQYWludChIV05EIGhXbmQsIGNv bnN0IFBBSU5UU1RSVUNUKiBscFBhaW50KQogICAgICAgICAgInB1c2ggICAlM1xuIgogICAgICAg ICAgImNhbGwgICAqJTRcbiIKICAgICAgICAgIDogIj1hIiAocmVzdWx0KQotICAgICAgICAgOiAi YSIgKGVuZFBhaW50U3lzQ2FsbCksICJnIiAobHBQYWludCksICJnIiAoaFduZCksICJnIiAoKmVu ZFBhaW50KQorICAgICAgICAgOiAiYSIgKGVuZFBhaW50U3lzQ2FsbCksICJnIiAobHBQYWludCks ICJnIiAoaFduZCksICJtIiAoKmVuZFBhaW50KQogICAgICAgICApOwogICAgIHJldHVybiByZXN1 bHQ7CiAjZWxzZQo=