27696 2009-07-26 22:56:30 -0700 Inspector: Console should show completions for the command line APIs 2009-07-29 01:09:33 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P3 Enhancement --- 1 keishi levin joepeck levin mike oldest_to_newest 134845 0 keishi 2009-07-26 22:56:30 -0700 Currently the completion candidates do not include command line APIs. 134846 1 33520 keishi 2009-07-26 22:58:04 -0700 Created attachment 33520 Patch 134868 2 33525 keishi 2009-07-27 02:06:27 -0700 Created attachment 33525 oops tabs 134919 3 joepeck 2009-07-27 08:13:22 -0700 Sort function for Object.sortedProperties is used in ObjectPropertiesSections. You should that parameter (sortFunc) back. If sortFunc is not provided then the normal sort() is applied so it works out fine. Also what about global functions/classes? For example: String, Date, toString, Number, ... 134925 4 33549 keishi 2009-07-27 08:47:02 -0700 Created attachment 33549 Fixed sortedProperties (In reply to comment #3) > Sort function for Object.sortedProperties is used in ObjectPropertiesSections. > You should that parameter (sortFunc) back. If sortFunc is not provided then > the normal sort() is applied so it works out fine. Sorry my mistake. > Also what about global functions/classes? For example: > String, Date, toString, Number, ... Great idea. My understanding is that those are specified are {DontEnum} so you need to keep a list of them. I think I'll file separate bug. 135470 5 33549 timothy 2009-07-28 20:50:04 -0700 Comment on attachment 33549 Fixed sortedProperties > + commandLineAPI = commandLineAPI.reduce(function(a, prop) { > + if (prop.charAt(0) !== "_") > + a.push(prop); > + return a; > + }, []); This is pretty fancy. I never really used/liked reduce or map. I think this would be easier to read as a simple for loop that only appends things to properties not starting with "_". I bet it will be less code too! 135479 6 33690 keishi 2009-07-28 21:41:44 -0700 Created attachment 33690 Eliminated reduce 135495 7 33693 keishi 2009-07-28 22:31:10 -0700 Created attachment 33693 Eliminated reduce 135508 8 levin 2009-07-29 00:30:20 -0700 Assign to levin for landing. 135522 9 levin 2009-07-29 01:09:33 -0700 Committed as http://trac.webkit.org/changeset/46526 33520 2009-07-26 22:58:04 -0700 2009-07-27 02:06:27 -0700 Patch patch.diff text/plain 2554 keishi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTkzYmRkNi4uYmFiYjFiYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNy0yNiAgS2Vpc2hpIEhhdHRv cmkgIDxjYXNleS5oYXR0b3JpQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworCQlJbnNwZWN0b3I6IENvbnNvbGUgc2hvdWxkIHNob3cgY29tcGxldGlv bnMgZm9yIHRoZSBjb21tYW5kIGxpbmUgQVBJcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc2OTYKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvQ29uc29sZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlLnByb3RvdHlwZS5f cmVwb3J0Q29tcGxldGlvbnMpOiBBZGRzIHByb3BlcnRpZXMgZnJvbSBfaW5zcGVjdG9yQ29tbWFu ZExpbmVBUEkgdG8gCisgICAgICAgIGNvbXBsZXRpb25zIHdoZW4gYXZhaWxhYmxlLgorICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzOgorICAgICAgICAoT2JqZWN0LnBy b3BlcnRpZXMpOiBBZGRlZC4KKyAgICAgICAgKE9iamVjdC5zb3J0ZWRQcm9wZXJ0aWVzKToKKwog MjAwOS0wNy0yNSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBGaXggV2luZG93cyBidWlsZCBicmVha2FnZSBpbnRyb2R1Y2VkIGluIDQ2MzkwLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGUuanMgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcwppbmRleCA1MWI0NDU5Li4yYjQ4NDdhIDEw MDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcworKysgYi9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcwpAQCAtMjczLDYgKzI3MywxNyBA QCBXZWJJbnNwZWN0b3IuQ29uc29sZS5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgdmFyIHJlc3Vs dHMgPSBbXTsKICAgICAgICAgdmFyIHByb3BlcnRpZXMgPSBPYmplY3Quc29ydGVkUHJvcGVydGll cyhyZXN1bHQpOworCisJCWlmICghZG90Tm90YXRpb24gJiYgIWJyYWNrZXROb3RhdGlvbiAmJiBy ZXN1bHQuX2luc3BlY3RvckNvbW1hbmRMaW5lQVBJKSB7CisJCQl2YXIgY29tbWFuZExpbmVBUEkg PSBPYmplY3QucHJvcGVydGllcyhyZXN1bHQuX2luc3BlY3RvckNvbW1hbmRMaW5lQVBJKTsKKwkJ CWNvbW1hbmRMaW5lQVBJID0gY29tbWFuZExpbmVBUEkucmVkdWNlKGZ1bmN0aW9uKGEsIHByb3Ap IHsKKwkJCQlpZiAocHJvcC5jaGFyQXQoMCkgIT09ICJfIikKKwkJCQkJYS5wdXNoKHByb3ApOwor CQkJCXJldHVybiBhOworCQkJfSwgW10pOworICAgICAgICAgICAgcHJvcGVydGllcyA9IHByb3Bl cnRpZXMuY29uY2F0KGNvbW1hbmRMaW5lQVBJKS5zb3J0KCk7CisgICAgICAgIH0KKwogICAgICAg ICBmb3IgKHZhciBpID0gMDsgaSA8IHByb3BlcnRpZXMubGVuZ3RoOyArK2kpIHsKICAgICAgICAg ICAgIHZhciBwcm9wZXJ0eSA9IHByb3BlcnRpZXNbaV07CiAKQEAgLTI5NCw2ICszMDUsNyBAQCBX ZWJJbnNwZWN0b3IuQ29uc29sZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBpZiAoYmVzdE1h dGNoT25seSkKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQorICAgICAgICAKICAg ICAgICAgc2V0VGltZW91dChjb21wbGV0aW9uc1JlYWR5Q2FsbGJhY2ssIDAsIHJlc3VsdHMpOwog ICAgIH0sCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRp ZXMuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzCmluZGV4IDQy ODU3ODUuLjY2YzllNmYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91 dGlsaXRpZXMuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5q cwpAQCAtOTQsMTUgKzk0LDE5IEBAIE9iamVjdC5kZXNjcmliZSA9IGZ1bmN0aW9uKG9iaiwgYWJi cmV2aWF0ZWQpCiAgICAgfQogfQogCi1PYmplY3Quc29ydGVkUHJvcGVydGllcyA9IGZ1bmN0aW9u KG9iaiwgc29ydEZ1bmMpCitPYmplY3QucHJvcGVydGllcyA9IGZ1bmN0aW9uKG9iaikKIHsKLSAg ICB2YXIgcHJvcGVydGllcyA9IFtdOworCXZhciBwcm9wZXJ0aWVzID0gW107CiAgICAgZm9yICh2 YXIgcHJvcCBpbiBvYmopCiAgICAgICAgIHByb3BlcnRpZXMucHVzaChwcm9wKTsKLSAgICBwcm9w ZXJ0aWVzLnNvcnQoc29ydEZ1bmMpOwogICAgIHJldHVybiBwcm9wZXJ0aWVzOwogfQogCitPYmpl Y3Quc29ydGVkUHJvcGVydGllcyA9IGZ1bmN0aW9uKG9iaikKK3sKKyAgICByZXR1cm4gT2JqZWN0 LnByb3BlcnRpZXMob2JqKS5zb3J0KCk7Cit9CisKIEZ1bmN0aW9uLnByb3RvdHlwZS5iaW5kID0g ZnVuY3Rpb24odGhpc09iamVjdCkKIHsKICAgICB2YXIgZnVuYyA9IHRoaXM7Cg== 33525 2009-07-27 02:06:27 -0700 2009-07-27 08:47:02 -0700 oops tabs patch.diff text/plain 2402 keishi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTkzYmRkNi4uYmFiYjFiYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNy0yNiAgS2Vpc2hpIEhhdHRv cmkgIDxjYXNleS5oYXR0b3JpQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworCQlJbnNwZWN0b3I6IENvbnNvbGUgc2hvdWxkIHNob3cgY29tcGxldGlv bnMgZm9yIHRoZSBjb21tYW5kIGxpbmUgQVBJcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc2OTYKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvQ29uc29sZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlLnByb3RvdHlwZS5f cmVwb3J0Q29tcGxldGlvbnMpOiBBZGRzIHByb3BlcnRpZXMgZnJvbSBfaW5zcGVjdG9yQ29tbWFu ZExpbmVBUEkgdG8gCisgICAgICAgIGNvbXBsZXRpb25zIHdoZW4gYXZhaWxhYmxlLgorICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzOgorICAgICAgICAoT2JqZWN0LnBy b3BlcnRpZXMpOiBBZGRlZC4KKyAgICAgICAgKE9iamVjdC5zb3J0ZWRQcm9wZXJ0aWVzKToKKwog MjAwOS0wNy0yNSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBGaXggV2luZG93cyBidWlsZCBicmVha2FnZSBpbnRyb2R1Y2VkIGluIDQ2MzkwLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGUuanMgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcwppbmRleCA1MWI0NDU5Li41MWQ2YjVhIDEw MDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcworKysgYi9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcwpAQCAtMjczLDYgKzI3MywxNyBA QCBXZWJJbnNwZWN0b3IuQ29uc29sZS5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgdmFyIHJlc3Vs dHMgPSBbXTsKICAgICAgICAgdmFyIHByb3BlcnRpZXMgPSBPYmplY3Quc29ydGVkUHJvcGVydGll cyhyZXN1bHQpOworCisgICAgICAgIGlmICghZG90Tm90YXRpb24gJiYgIWJyYWNrZXROb3RhdGlv biAmJiByZXN1bHQuX2luc3BlY3RvckNvbW1hbmRMaW5lQVBJKSB7CisgICAgICAgICAgICB2YXIg Y29tbWFuZExpbmVBUEkgPSBPYmplY3QucHJvcGVydGllcyhyZXN1bHQuX2luc3BlY3RvckNvbW1h bmRMaW5lQVBJKTsKKyAgICAgICAgICAgIGNvbW1hbmRMaW5lQVBJID0gY29tbWFuZExpbmVBUEku cmVkdWNlKGZ1bmN0aW9uKGEsIHByb3ApIHsKKyAgICAgICAgICAgICAgICBpZiAocHJvcC5jaGFy QXQoMCkgIT09ICJfIikKKyAgICAgICAgICAgICAgICAgICAgYS5wdXNoKHByb3ApOworICAgICAg ICAgICAgICAgIHJldHVybiBhOworICAgICAgICAgICAgfSwgW10pOworICAgICAgICAgICAgcHJv cGVydGllcyA9IHByb3BlcnRpZXMuY29uY2F0KGNvbW1hbmRMaW5lQVBJKS5zb3J0KCk7CisgICAg ICAgIH0KKwogICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHByb3BlcnRpZXMubGVuZ3RoOyAr K2kpIHsKICAgICAgICAgICAgIHZhciBwcm9wZXJ0eSA9IHByb3BlcnRpZXNbaV07CiAKZGlmZiAt LWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzCmluZGV4IDQyODU3ODUuLjU1YjJjZDUg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMKKysr IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcwpAQCAtOTQsMTUgKzk0 LDE5IEBAIE9iamVjdC5kZXNjcmliZSA9IGZ1bmN0aW9uKG9iaiwgYWJicmV2aWF0ZWQpCiAgICAg fQogfQogCi1PYmplY3Quc29ydGVkUHJvcGVydGllcyA9IGZ1bmN0aW9uKG9iaiwgc29ydEZ1bmMp CitPYmplY3QucHJvcGVydGllcyA9IGZ1bmN0aW9uKG9iaikKIHsKICAgICB2YXIgcHJvcGVydGll cyA9IFtdOwogICAgIGZvciAodmFyIHByb3AgaW4gb2JqKQogICAgICAgICBwcm9wZXJ0aWVzLnB1 c2gocHJvcCk7Ci0gICAgcHJvcGVydGllcy5zb3J0KHNvcnRGdW5jKTsKICAgICByZXR1cm4gcHJv cGVydGllczsKIH0KIAorT2JqZWN0LnNvcnRlZFByb3BlcnRpZXMgPSBmdW5jdGlvbihvYmopCit7 CisgICAgcmV0dXJuIE9iamVjdC5wcm9wZXJ0aWVzKG9iaikuc29ydCgpOworfQorCiBGdW5jdGlv bi5wcm90b3R5cGUuYmluZCA9IGZ1bmN0aW9uKHRoaXNPYmplY3QpCiB7CiAgICAgdmFyIGZ1bmMg PSB0aGlzOwo= 33549 2009-07-27 08:47:02 -0700 2009-07-28 21:41:44 -0700 Fixed sortedProperties patch.diff text/plain 2420 keishi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTkzYmRkNi4uYmFiYjFiYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNy0yNiAgS2Vpc2hpIEhhdHRv cmkgIDxjYXNleS5oYXR0b3JpQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworCQlJbnNwZWN0b3I6IENvbnNvbGUgc2hvdWxkIHNob3cgY29tcGxldGlv bnMgZm9yIHRoZSBjb21tYW5kIGxpbmUgQVBJcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc2OTYKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvQ29uc29sZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlLnByb3RvdHlwZS5f cmVwb3J0Q29tcGxldGlvbnMpOiBBZGRzIHByb3BlcnRpZXMgZnJvbSBfaW5zcGVjdG9yQ29tbWFu ZExpbmVBUEkgdG8gCisgICAgICAgIGNvbXBsZXRpb25zIHdoZW4gYXZhaWxhYmxlLgorICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzOgorICAgICAgICAoT2JqZWN0LnBy b3BlcnRpZXMpOiBBZGRlZC4KKyAgICAgICAgKE9iamVjdC5zb3J0ZWRQcm9wZXJ0aWVzKToKKwog MjAwOS0wNy0yNSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBGaXggV2luZG93cyBidWlsZCBicmVha2FnZSBpbnRyb2R1Y2VkIGluIDQ2MzkwLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGUuanMgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcwppbmRleCA1MWI0NDU5Li41MWQ2YjVhIDEw MDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcworKysgYi9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcwpAQCAtMjczLDYgKzI3MywxNyBA QCBXZWJJbnNwZWN0b3IuQ29uc29sZS5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgdmFyIHJlc3Vs dHMgPSBbXTsKICAgICAgICAgdmFyIHByb3BlcnRpZXMgPSBPYmplY3Quc29ydGVkUHJvcGVydGll cyhyZXN1bHQpOworCisgICAgICAgIGlmICghZG90Tm90YXRpb24gJiYgIWJyYWNrZXROb3RhdGlv biAmJiByZXN1bHQuX2luc3BlY3RvckNvbW1hbmRMaW5lQVBJKSB7CisgICAgICAgICAgICB2YXIg Y29tbWFuZExpbmVBUEkgPSBPYmplY3QucHJvcGVydGllcyhyZXN1bHQuX2luc3BlY3RvckNvbW1h bmRMaW5lQVBJKTsKKyAgICAgICAgICAgIGNvbW1hbmRMaW5lQVBJID0gY29tbWFuZExpbmVBUEku cmVkdWNlKGZ1bmN0aW9uKGEsIHByb3ApIHsKKyAgICAgICAgICAgICAgICBpZiAocHJvcC5jaGFy QXQoMCkgIT09ICJfIikKKyAgICAgICAgICAgICAgICAgICAgYS5wdXNoKHByb3ApOworICAgICAg ICAgICAgICAgIHJldHVybiBhOworICAgICAgICAgICAgfSwgW10pOworICAgICAgICAgICAgcHJv cGVydGllcyA9IHByb3BlcnRpZXMuY29uY2F0KGNvbW1hbmRMaW5lQVBJKS5zb3J0KCk7CisgICAg ICAgIH0KKwogICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHByb3BlcnRpZXMubGVuZ3RoOyAr K2kpIHsKICAgICAgICAgICAgIHZhciBwcm9wZXJ0eSA9IHByb3BlcnRpZXNbaV07CiAKZGlmZiAt LWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzCmluZGV4IDQyODU3ODUuLjQwMGFhMDgg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMKKysr IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcwpAQCAtOTQsMTUgKzk0 LDE5IEBAIE9iamVjdC5kZXNjcmliZSA9IGZ1bmN0aW9uKG9iaiwgYWJicmV2aWF0ZWQpCiAgICAg fQogfQogCi1PYmplY3Quc29ydGVkUHJvcGVydGllcyA9IGZ1bmN0aW9uKG9iaiwgc29ydEZ1bmMp CitPYmplY3QucHJvcGVydGllcyA9IGZ1bmN0aW9uKG9iaikKIHsKICAgICB2YXIgcHJvcGVydGll cyA9IFtdOwogICAgIGZvciAodmFyIHByb3AgaW4gb2JqKQogICAgICAgICBwcm9wZXJ0aWVzLnB1 c2gocHJvcCk7Ci0gICAgcHJvcGVydGllcy5zb3J0KHNvcnRGdW5jKTsKICAgICByZXR1cm4gcHJv cGVydGllczsKIH0KIAorT2JqZWN0LnNvcnRlZFByb3BlcnRpZXMgPSBmdW5jdGlvbihvYmosIHNv cnRGdW5jKQoreworICAgIHJldHVybiBPYmplY3QucHJvcGVydGllcyhvYmopLnNvcnQoc29ydEZ1 bmMpOworfQorCiBGdW5jdGlvbi5wcm90b3R5cGUuYmluZCA9IGZ1bmN0aW9uKHRoaXNPYmplY3Qp CiB7CiAgICAgdmFyIGZ1bmMgPSB0aGlzOwo= 33690 2009-07-28 21:41:44 -0700 2009-07-28 21:42:32 -0700 Eliminated reduce patch.diff text/plain 2444 keishi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjA4ZTA1Zi4uYmE5ODc1NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNy0yOCAgS2Vpc2hpIEhhdHRv cmkgIDxjYXNleS5oYXR0b3JpQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbnNwZWN0b3I6IENvbnNvbGUgc2hvdWxkIHNob3cgY29t cGxldGlvbnMgZm9yIHRoZSBjb21tYW5kIGxpbmUgQVBJcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc2OTYKKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvQ29uc29sZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlLnByb3Rv dHlwZS5fcmVwb3J0Q29tcGxldGlvbnMpOiBBZGRzIHByb3BlcnRpZXMgZnJvbSBfaW5zcGVjdG9y Q29tbWFuZExpbmVBUEkgdG8gCisgICAgICAgIGNvbXBsZXRpb25zIHdoZW4gYXZhaWxhYmxlLgor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzOgorICAgICAgICAoT2Jq ZWN0LnByb3BlcnRpZXMpOiBBZGRlZC4KKyAgICAgICAgKE9iamVjdC5zb3J0ZWRQcm9wZXJ0aWVz KToKKwogMjAwOS0wNy0yOCAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9Db25zb2xlLmpzCmluZGV4IDUyMGUyMTMuLmE0ZjcyOWUgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9Db25zb2xlLmpzCkBAIC0yNzIsNyArMjcyLDE3IEBAIFdlYkluc3BlY3Rv ci5Db25zb2xlLnByb3RvdHlwZSA9IHsKICAgICAgICAgfQogCiAgICAgICAgIHZhciByZXN1bHRz ID0gW107Ci0gICAgICAgIHZhciBwcm9wZXJ0aWVzID0gT2JqZWN0LnNvcnRlZFByb3BlcnRpZXMo cmVzdWx0KTsKKyAgICAgICAgdmFyIHByb3BlcnRpZXMgPSBPYmplY3QucHJvcGVydGllcyhyZXN1 bHQpOworICAgICAgICBpZiAoIWRvdE5vdGF0aW9uICYmICFicmFja2V0Tm90YXRpb24gJiYgcmVz dWx0Ll9pbnNwZWN0b3JDb21tYW5kTGluZUFQSSkgeworICAgICAgICAgICAgdmFyIGNvbW1hbmRM aW5lQVBJID0gT2JqZWN0LnByb3BlcnRpZXMocmVzdWx0Ll9pbnNwZWN0b3JDb21tYW5kTGluZUFQ SSk7CisgICAgICAgICAgICBmb3IgKHZhciBpPTA7IGkgPCBjb21tYW5kTGluZUFQSS5sZW5ndGg7 IGkrKykgeworICAgICAgICAgICAgICAgIHZhciBwcm9wZXJ0eSA9IGNvbW1hbmRMaW5lQVBJW2ld OworICAgICAgICAgICAgICAgIGlmIChwcm9wZXJ0eS5jaGFyQXQoMCkgIT09ICJfIikKKyAgICAg ICAgICAgICAgICAgICAgYS5wdXNoKHByb3BlcnR5KTsKKyAgICAgICAgICAgIH0KKyAgICAgICAg fQorICAgICAgICBwcm9wZXJ0aWVzLnNvcnQoKTsKKwogICAgICAgICBmb3IgKHZhciBpID0gMDsg aSA8IHByb3BlcnRpZXMubGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAgIHZhciBwcm9wZXJ0eSA9 IHByb3BlcnRpZXNbaV07CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC91dGlsaXRpZXMuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpz CmluZGV4IDQyODU3ODUuLjQwMGFhMDggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC91dGlsaXRpZXMuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0 aWxpdGllcy5qcwpAQCAtOTQsMTUgKzk0LDE5IEBAIE9iamVjdC5kZXNjcmliZSA9IGZ1bmN0aW9u KG9iaiwgYWJicmV2aWF0ZWQpCiAgICAgfQogfQogCi1PYmplY3Quc29ydGVkUHJvcGVydGllcyA9 IGZ1bmN0aW9uKG9iaiwgc29ydEZ1bmMpCitPYmplY3QucHJvcGVydGllcyA9IGZ1bmN0aW9uKG9i aikKIHsKICAgICB2YXIgcHJvcGVydGllcyA9IFtdOwogICAgIGZvciAodmFyIHByb3AgaW4gb2Jq KQogICAgICAgICBwcm9wZXJ0aWVzLnB1c2gocHJvcCk7Ci0gICAgcHJvcGVydGllcy5zb3J0KHNv cnRGdW5jKTsKICAgICByZXR1cm4gcHJvcGVydGllczsKIH0KIAorT2JqZWN0LnNvcnRlZFByb3Bl cnRpZXMgPSBmdW5jdGlvbihvYmosIHNvcnRGdW5jKQoreworICAgIHJldHVybiBPYmplY3QucHJv cGVydGllcyhvYmopLnNvcnQoc29ydEZ1bmMpOworfQorCiBGdW5jdGlvbi5wcm90b3R5cGUuYmlu ZCA9IGZ1bmN0aW9uKHRoaXNPYmplY3QpCiB7CiAgICAgdmFyIGZ1bmMgPSB0aGlzOwo= 33693 2009-07-28 22:31:10 -0700 2009-07-28 23:13:18 -0700 Eliminated reduce patch.diff text/plain 2455 keishi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjA4ZTA1Zi4uYmE5ODc1NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNy0yOCAgS2Vpc2hpIEhhdHRv cmkgIDxjYXNleS5oYXR0b3JpQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbnNwZWN0b3I6IENvbnNvbGUgc2hvdWxkIHNob3cgY29t cGxldGlvbnMgZm9yIHRoZSBjb21tYW5kIGxpbmUgQVBJcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc2OTYKKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvQ29uc29sZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlLnByb3Rv dHlwZS5fcmVwb3J0Q29tcGxldGlvbnMpOiBBZGRzIHByb3BlcnRpZXMgZnJvbSBfaW5zcGVjdG9y Q29tbWFuZExpbmVBUEkgdG8gCisgICAgICAgIGNvbXBsZXRpb25zIHdoZW4gYXZhaWxhYmxlLgor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzOgorICAgICAgICAoT2Jq ZWN0LnByb3BlcnRpZXMpOiBBZGRlZC4KKyAgICAgICAgKE9iamVjdC5zb3J0ZWRQcm9wZXJ0aWVz KToKKwogMjAwOS0wNy0yOCAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9Db25zb2xlLmpzCmluZGV4IDUyMGUyMTMuLjVmYzg2ZWYgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9Db25zb2xlLmpzCkBAIC0yNzIsNyArMjcyLDE3IEBAIFdlYkluc3BlY3Rv ci5Db25zb2xlLnByb3RvdHlwZSA9IHsKICAgICAgICAgfQogCiAgICAgICAgIHZhciByZXN1bHRz ID0gW107Ci0gICAgICAgIHZhciBwcm9wZXJ0aWVzID0gT2JqZWN0LnNvcnRlZFByb3BlcnRpZXMo cmVzdWx0KTsKKyAgICAgICAgdmFyIHByb3BlcnRpZXMgPSBPYmplY3QucHJvcGVydGllcyhyZXN1 bHQpOworICAgICAgICBpZiAoIWRvdE5vdGF0aW9uICYmICFicmFja2V0Tm90YXRpb24gJiYgcmVz dWx0Ll9pbnNwZWN0b3JDb21tYW5kTGluZUFQSSkgeworICAgICAgICAgICAgdmFyIGNvbW1hbmRM aW5lQVBJID0gT2JqZWN0LnByb3BlcnRpZXMocmVzdWx0Ll9pbnNwZWN0b3JDb21tYW5kTGluZUFQ SSk7CisgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGNvbW1hbmRMaW5lQVBJLmxlbmd0 aDsgKytpKSB7CisgICAgICAgICAgICAgICAgdmFyIHByb3BlcnR5ID0gY29tbWFuZExpbmVBUElb aV07CisgICAgICAgICAgICAgICAgaWYgKHByb3BlcnR5LmNoYXJBdCgwKSAhPT0gIl8iKQorICAg ICAgICAgICAgICAgICAgICBwcm9wZXJ0aWVzLnB1c2gocHJvcGVydHkpOworICAgICAgICAgICAg fQorICAgICAgICB9CisgICAgICAgIHByb3BlcnRpZXMuc29ydCgpOworCiAgICAgICAgIGZvciAo dmFyIGkgPSAwOyBpIDwgcHJvcGVydGllcy5sZW5ndGg7ICsraSkgewogICAgICAgICAgICAgdmFy IHByb3BlcnR5ID0gcHJvcGVydGllc1tpXTsKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91 dGlsaXRpZXMuanMKaW5kZXggNDI4NTc4NS4uNDAwYWEwOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvdXRpbGl0aWVzLmpzCkBAIC05NCwxNSArOTQsMTkgQEAgT2JqZWN0LmRlc2NyaWJl ID0gZnVuY3Rpb24ob2JqLCBhYmJyZXZpYXRlZCkKICAgICB9CiB9CiAKLU9iamVjdC5zb3J0ZWRQ cm9wZXJ0aWVzID0gZnVuY3Rpb24ob2JqLCBzb3J0RnVuYykKK09iamVjdC5wcm9wZXJ0aWVzID0g ZnVuY3Rpb24ob2JqKQogewogICAgIHZhciBwcm9wZXJ0aWVzID0gW107CiAgICAgZm9yICh2YXIg cHJvcCBpbiBvYmopCiAgICAgICAgIHByb3BlcnRpZXMucHVzaChwcm9wKTsKLSAgICBwcm9wZXJ0 aWVzLnNvcnQoc29ydEZ1bmMpOwogICAgIHJldHVybiBwcm9wZXJ0aWVzOwogfQogCitPYmplY3Qu c29ydGVkUHJvcGVydGllcyA9IGZ1bmN0aW9uKG9iaiwgc29ydEZ1bmMpCit7CisgICAgcmV0dXJu IE9iamVjdC5wcm9wZXJ0aWVzKG9iaikuc29ydChzb3J0RnVuYyk7Cit9CisKIEZ1bmN0aW9uLnBy b3RvdHlwZS5iaW5kID0gZnVuY3Rpb24odGhpc09iamVjdCkKIHsKICAgICB2YXIgZnVuYyA9IHRo aXM7Cg==