276741 2024-07-17 15:03:57 -0700 Enable JSC_validateOptions on GTK 2024-07-19 05:11:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 justin dpino dpino webkit-bug-importer oldest_to_newest 2046820 0 justin 2024-07-17 15:03:57 -0700 Enable JSC_validateOptions on GTK 2046823 1 justin 2024-07-17 15:06:59 -0700 Pull request: https://github.com/WebKit/WebKit/pull/30925 2047097 2 ews-feeder 2024-07-18 15:26:37 -0700 Committed 281106@main (e812e22f41af): <https://commits.webkit.org/281106@main> Reviewed commits have been landed. Closing PR #30925 and removing active labels. 2047098 3 webkit-bug-importer 2024-07-18 15:27:15 -0700 <rdar://problem/132043022> 2047163 4 dpino 2024-07-19 01:49:29 -0700 GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 is broken after this patch. https://build.webkit.org/#/builders/30/builds/9027 The build error is the following: ``` In file included from /home/buildbot/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build/WebKitBuild/GTK/Release/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f2e18ffc-32.cpp:1: /home/buildbot/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build/Source/JavaScriptCore/runtime/Options.cpp:987:27: error: use of undeclared identifier 'environ' char** envp = environ; ^ ``` In Linux, `environ` is an extern variable defined in `unistd.h`. 2047164 5 dpino 2024-07-19 01:54:02 -0700 Re-opening for pull request https://github.com/webkit/webkit/pull/30994 2047173 6 ews-feeder 2024-07-19 05:11:35 -0700 Committed 281133@main (8e4157809750): <https://commits.webkit.org/281133@main> Reviewed commits have been landed. Closing PR #30994 and removing active labels.