276734 2024-07-17 13:47:27 -0700 [JSC] Debug build fails to compile when JIT_OPERATION_VALIDATION is disabled 2024-07-17 17:49:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Trivial --- 1 marcus_plutowski webkit-unassigned webkit-bug-importer oldest_to_newest 2046802 0 marcus_plutowski 2024-07-17 13:47:27 -0700 rdar://131950848 If you try to compile JSC in debug with JIT_OPERATION_VALIDATION forced to 0, some portions of the feature still compile (and therefore throw errors) because JIT_OPERATION_VALIDATION_ASSERT_ENABLED currently only checks ASSERT_ENABLED. At one point it was gated by ENABLE(JIT_OPERATION_VALIDATION), so this was not the case, but since then that gate was weakened and changed to `#if ENABLE(JIT_OPERATION_VALIDATION) || ENABLE(JIT_OPERATION_DISASSEMBLY)`. As such, JIT_OPERATION_VALIDATION_ASSERT_ENABLED should explicitly check for JIT_OPERATION_VALIDATION to ensure it’s not turned on when not requested. This is helpful for debugging. 2046804 1 marcus_plutowski 2024-07-17 13:50:04 -0700 Pull request: https://github.com/WebKit/WebKit/pull/30919 2046870 2 ews-feeder 2024-07-17 17:47:35 -0700 Committed 281070@main (292ee2d452da): <https://commits.webkit.org/281070@main> Reviewed commits have been landed. Closing PR #30919 and removing active labels. 2046871 3 webkit-bug-importer 2024-07-17 17:49:19 -0700 <rdar://problem/131967366>