27665 2009-07-24 13:58:35 -0700 Failed assertion in WorkerContext::~WorkerContext() 2009-07-24 14:32:32 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson dimich levin oldest_to_newest 134651 0 atwilson 2009-07-24 13:58:35 -0700 There's a race condition when WorkerContext shuts down, because the WorkerThread object can get freed before the WorkerContext constructor finishes executing. We need to update the code to make sure we don't access the m_thread after calling workerContextDestroyed() because the pointer may not be valid. 134664 1 33472 atwilson 2009-07-24 14:21:47 -0700 Created attachment 33472 Fix for flaky tests Worker tests are slightly flaky after my earlier patch - this addresses that problem. 134665 2 dimich 2009-07-24 14:32:32 -0700 Landed: http://trac.webkit.org/changeset/46376 33472 2009-07-24 14:21:47 -0700 2009-07-24 14:25:37 -0700 Fix for flaky tests patch.txt text/plain 2081 atwilson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzZjZDc5MS4uMjE5OWMwYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAwOS0wNy0yNCAgRHJldyBXaWxzb24g IDxhdHdpbHNvbkBnb29nbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENoYW5nZWQgV29ya2VyQ29udGV4dCBkZXN0cnVjdG9yIHRvIG5vdCBh Y2Nlc3MgcG9zc2libHktZnJlZWQgV29ya2VyVGhyZWFkLgorCisgICAgICAgIEZhaWxlZCBhc3Nl cnRpb24gaW4gV29ya2VyQ29udGV4dDo6fldvcmtlckNvbnRleHQoKS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NjY1CisKKyAgICAgICAqIHdvcmtl cnMvRGVkaWNhdGVkV29ya2VyQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEZWRpY2F0 ZWRXb3JrZXJDb250ZXh0Ojp+RGVkaWNhdGVkV29ya2VyQ29udGV4dCk6CisgICAgICAgICogd29y a2Vycy9Xb3JrZXJDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldvcmtlckNvbnRleHQ6 On5Xb3JrZXJDb250ZXh0KToKKyAgICAgICAgUmVtb3ZlZCBhc3NlcnRpb24gdGhhdCByZWxpZXMg b24gV29ya2VyVGhyZWFkIHN0aWxsIGJlaW5nIGFsaXZlIChtb3ZlZCB0byBEZWRpY2F0ZWRXb3Jr ZXJDb250ZXh0IGRlc3RydWN0b3IpLgorCisyMDA5LTA3LTI0ICBEcmV3IFdpbHNvbiAgPGF0d2ls c29uQGdvb2dsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KIAogICAg ICAgICBVcGRhdGVkIGNvZGUgZ2VuZXJhdG9yIHRvIHByb3Blcmx5IGdlbmVyYXRlIGJpbmRpbmdz IGZvciBXb3JrZXJDb250ZXh0IGV4cG9zZWQgZnVuY3Rpb25zLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS93b3JrZXJzL0RlZGljYXRlZFdvcmtlckNvbnRleHQuY3BwIGIvV2ViQ29yZS93b3JrZXJzL0Rl ZGljYXRlZFdvcmtlckNvbnRleHQuY3BwCmluZGV4IGRhYjg1ODcuLjRkNDdhYWYgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvd29ya2Vycy9EZWRpY2F0ZWRXb3JrZXJDb250ZXh0LmNwcAorKysgYi9XZWJD b3JlL3dvcmtlcnMvRGVkaWNhdGVkV29ya2VyQ29udGV4dC5jcHAKQEAgLTQ4LDcgKzQ4LDggQEAg RGVkaWNhdGVkV29ya2VyQ29udGV4dDo6RGVkaWNhdGVkV29ya2VyQ29udGV4dChjb25zdCBLVVJM JiB1cmwsIGNvbnN0IFN0cmluZyYgdXMKIAogRGVkaWNhdGVkV29ya2VyQ29udGV4dDo6fkRlZGlj YXRlZFdvcmtlckNvbnRleHQoKQogewotICAgIC8vIE5vdGlmeSBwYXJlbnQgd29ya2VyIHdlIGFy ZSBnb2luZyBhd2F5LgorICAgIEFTU0VSVChjdXJyZW50VGhyZWFkKCkgPT0gdGhyZWFkKCktPnRo cmVhZElEKCkpOworICAgIC8vIE5vdGlmeSBwYXJlbnQgd29ya2VyIHdlIGFyZSBnb2luZyBhd2F5 LiBUaGlzIGNhbiBmcmVlIHRoZSBXb3JrZXJUaHJlYWQgb2JqZWN0LCBzbyBkbyBub3QgYWNjZXNz IGl0IGFmdGVyIHRoaXMuCiAgICAgdGhyZWFkKCktPndvcmtlck9iamVjdFByb3h5KCkud29ya2Vy Q29udGV4dERlc3Ryb3llZCgpOwogfQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3dvcmtlcnMvV29y a2VyQ29udGV4dC5jcHAgYi9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5jcHAKaW5kZXgg OTY1YzBhNS4uM2NlYjJhOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRl eHQuY3BwCisrKyBiL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250ZXh0LmNwcApAQCAtNjQsNyAr NjQsNiBAQCBXb3JrZXJDb250ZXh0OjpXb3JrZXJDb250ZXh0KGNvbnN0IEtVUkwmIHVybCwgY29u c3QgU3RyaW5nJiB1c2VyQWdlbnQsIFdvcmtlclRocgogCiBXb3JrZXJDb250ZXh0Ojp+V29ya2Vy Q29udGV4dCgpCiB7Ci0gICAgQVNTRVJUKGN1cnJlbnRUaHJlYWQoKSA9PSBtX3RocmVhZC0+dGhy ZWFkSUQoKSk7CiB9CiAKIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIFdvcmtlckNvbnRleHQ6OnNj cmlwdEV4ZWN1dGlvbkNvbnRleHQoKSBjb25zdAo=