276639 2024-07-15 18:46:17 -0700 REGRESSION(280837@main): Broke <http://nfl.com|nfl.com> and <http://yelp.com|yelp.com> reviews 2024-07-17 23:06:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 276438 1 commit-queue commit-queue dan.hecht keith_miller mark.lam webkit-bug-importer oldest_to_newest 2046388 0 commit-queue 2024-07-15 18:46:17 -0700 https://commits.webkit.org/280837@main introduced a regression: Broke <http://nfl.com|nfl.com> and <http://yelp.com|yelp.com> reviews This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 2046390 1 471889 commit-queue 2024-07-15 18:46:23 -0700 Created attachment 471889 REVERT of 280837@main Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 2046391 2 ews-feeder 2024-07-15 18:49:32 -0700 Committed 280996@main (81f9536d8285): <https://commits.webkit.org/280996@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471889. 2046392 3 keith_miller 2024-07-15 18:50:14 -0700 rdar://131792885 2046393 4 webkit-bug-importer 2024-07-15 18:50:25 -0700 <rdar://problem/131800097> 2046395 5 mark.lam 2024-07-15 18:52:27 -0700 rdar://131792885 2046931 6 ews-feeder 2024-07-17 23:06:15 -0700 Committed 280938.37@integration/ci/131792885_81f9536d82_safari-7619-branch (ff0375c3d089): <https://commits.webkit.org/280938.37@integration/ci/131792885_81f9536d82_safari-7619-branch> Reviewed commits have been landed. Closing PR #1391 and removing active labels. 471889 2024-07-15 18:46:23 -0700 2024-07-15 18:49:33 -0700 REVERT of 280837@main bug-276639-20240716014622.patch text/plain 6545 commit-queue RnJvbSBiNmQ4MjIwNjY0ZmNiZDk3MmE2ZWZhNDlkMWUyMTQwZjE0NDYwZTIyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDb21taXQgUXVldWUgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3Jn PgpEYXRlOiBUdWUsIDE2IEp1bCAyMDI0IDAxOjQ2OjIwICswMDAwClN1YmplY3Q6IFtQQVRDSF0g VW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIDI4MDgzN0BtYWluLgogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI3NjYzOQoKQnJva2UgPGh0dHA6Ly9uZmwuY29tfG5mbC5jb20+ IGFuZCA8aHR0cDovL3llbHAuY29tfHllbHAuY29tPiByZXZpZXdzCgpSZXZlcnRlZCBjaGFuZ2Vz ZXQ6CgoiW0pTQ10gRGlzYWxsb3cgeWllbGQvYXdhaXQgZXhwcmVzc2lvbnMgaW4gY2xhc3MgZmll bGQgaW5pdGlhbGl6ZXJzIgpodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mjc2NDM4Cmh0dHBzOi8vY29tbWl0cy53ZWJraXQub3JnLzI4MDgzN0BtYWluCi0tLQogU291cmNl L0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwICAgICAgIHwgIDggKy0KIC4uLmllbGQt YXdhaXQtY2xhc3MtZmllbGQtaW5pdGlhbGl6ZXItZXhwci5qcyB8IDg5IC0tLS0tLS0tLS0tLS0t LS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCA5NSBkZWxldGlvbnMoLSkK IGRlbGV0ZSBtb2RlIDEwMDY0NCBKU1Rlc3RzL3N0cmVzcy95aWVsZC1hd2FpdC1jbGFzcy1maWVs ZC1pbml0aWFsaXplci1leHByLmpzCgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3BhcnNlci9QYXJzZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIu Y3BwCmluZGV4IGQ0OTlhODcyMzY0Yi4uM2I1YmMyMmE1MWE3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3BhcnNlci9QYXJzZXIuY3BwCkBAIC00MzI2LDkgKzQzMjYsNiBAQCB0ZW1wbGF0ZSA8Y2xh c3MgVHJlZUJ1aWxkZXI+IFRyZWVFeHByZXNzaW9uIFBhcnNlcjxMZXhlclR5cGU+OjpwYXJzZVlp ZWxkRXhwcmVzcwogICAgIC8vIGh0dHA6Ly9lY21hLWludGVybmF0aW9uYWwub3JnL2VjbWEtMjYy LzYuMC8jc2VjLWdlbmVyYXRvci1mdW5jdGlvbi1kZWZpbml0aW9ucy1zdGF0aWMtc2VtYW50aWNz LWVhcmx5LWVycm9ycwogICAgIGZhaWxJZlRydWUobV9wYXJzZXJTdGF0ZS5mdW5jdGlvblBhcnNl UGhhc2UgPT0gRnVuY3Rpb25QYXJzZVBoYXNlOjpQYXJhbWV0ZXJzLCAiQ2Fubm90IHVzZSB5aWVs ZCBleHByZXNzaW9uIHdpdGhpbiBwYXJhbWV0ZXJzIik7CiAKLSAgICAvLyBodHRwczovL2dpdGh1 Yi5jb20vdGMzOS9lY21hMjYyL2lzc3Vlcy8zMzMzCi0gICAgZmFpbElmVHJ1ZShtX3BhcnNlclN0 YXRlLmlzUGFyc2luZ0NsYXNzRmllbGRJbml0aWFsaXplciwgIkNhbm5vdCB1c2UgeWllbGQgZXhw cmVzc2lvbiBpbnNpZGUgY2xhc3MgZmllbGQgaW5pdGlhbGl6ZXIgZXhwcmVzc2lvbiIpOwotCiAg ICAgSlNUb2tlbkxvY2F0aW9uIGxvY2F0aW9uKHRva2VuTG9jYXRpb24oKSk7CiAgICAgSlNUZXh0 UG9zaXRpb24gZGl2b3RTdGFydCA9IHRva2VuU3RhcnRQb3NpdGlvbigpOwogICAgIEFTU0VSVCht YXRjaChZSUVMRCkpOwpAQCAtNDM1NSw3ICs0MzUyLDYgQEAgdGVtcGxhdGUgPGNsYXNzIFRyZWVC dWlsZGVyPiBUcmVlRXhwcmVzc2lvbiBQYXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VBd2FpdEV4cHJl c3MKICAgICBBU1NFUlQoY3VycmVudFNjb3BlKCktPmlzQXN5bmNGdW5jdGlvbigpIHx8IGlzTW9k dWxlUGFyc2VNb2RlKHNvdXJjZVBhcnNlTW9kZSgpKSk7CiAgICAgQVNTRVJUKGlzQXN5bmNGdW5j dGlvblBhcnNlTW9kZShzb3VyY2VQYXJzZU1vZGUoKSkgfHwgaXNNb2R1bGVQYXJzZU1vZGUoc291 cmNlUGFyc2VNb2RlKCkpKTsKICAgICBBU1NFUlQobV9wYXJzZXJTdGF0ZS5mdW5jdGlvblBhcnNl UGhhc2UgIT0gRnVuY3Rpb25QYXJzZVBoYXNlOjpQYXJhbWV0ZXJzKTsKLSAgICBBU1NFUlQoIW1f cGFyc2VyU3RhdGUuaXNQYXJzaW5nQ2xhc3NGaWVsZEluaXRpYWxpemVyKTsKICAgICBKU1Rva2Vu TG9jYXRpb24gbG9jYXRpb24odG9rZW5Mb2NhdGlvbigpKTsKICAgICBKU1RleHRQb3NpdGlvbiBk aXZvdFN0YXJ0ID0gdG9rZW5TdGFydFBvc2l0aW9uKCk7CiAgICAgbmV4dCgpOwpAQCAtNTA5MCw3 ICs1MDg2LDcgQEAgdGVtcGxhdGUgPGNsYXNzIFRyZWVCdWlsZGVyPiBUcmVlRXhwcmVzc2lvbiBQ YXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VQcmltYXJ5RXhwcmUKICAgICAgICAgc2VtYW50aWNGYWls SWZUcnVlKGN1cnJlbnRTY29wZSgpLT5pc1N0YXRpY0Jsb2NrKCksICJUaGUgJ2F3YWl0JyBrZXl3 b3JkIGlzIGRpc2FsbG93ZWQgaW4gdGhlIElkZW50aWZpZXJSZWZlcmVuY2UgcG9zaXRpb24gd2l0 aGluIHN0YXRpYyBibG9jayIpOwogICAgICAgICBpZiAobV9wYXJzZXJTdGF0ZS5mdW5jdGlvblBh cnNlUGhhc2UgPT0gRnVuY3Rpb25QYXJzZVBoYXNlOjpQYXJhbWV0ZXJzKQogICAgICAgICAgICAg c2VtYW50aWNGYWlsSWZGYWxzZShtX3BhcnNlclN0YXRlLmFsbG93QXdhaXQsICJDYW5ub3QgdXNl ICdhd2FpdCcgd2l0aGluIGEgcGFyYW1ldGVyIGRlZmF1bHQgZXhwcmVzc2lvbiIpOwotICAgICAg ICBlbHNlIGlmICghbV9wYXJzZXJTdGF0ZS5pc1BhcnNpbmdDbGFzc0ZpZWxkSW5pdGlhbGl6ZXIg JiYgKGN1cnJlbnRGdW5jdGlvblNjb3BlKCktPmlzQXN5bmNGdW5jdGlvbkJvdW5kYXJ5KCkgfHwg aXNNb2R1bGVQYXJzZU1vZGUoc291cmNlUGFyc2VNb2RlKCkpKSkKKyAgICAgICAgZWxzZSBpZiAo Y3VycmVudEZ1bmN0aW9uU2NvcGUoKS0+aXNBc3luY0Z1bmN0aW9uQm91bmRhcnkoKSB8fCBpc01v ZHVsZVBhcnNlTW9kZShzb3VyY2VQYXJzZU1vZGUoKSkpCiAgICAgICAgICAgICByZXR1cm4gcGFy c2VBd2FpdEV4cHJlc3Npb24oY29udGV4dCk7CiAKICAgICAgICAgZ290byBpZGVudGlmaWVyRXhw cmVzc2lvbjsKQEAgLTU1ODcsNyArNTU4Myw3IEBAIHRlbXBsYXRlIDxjbGFzcyBUcmVlQnVpbGRl cj4gVHJlZUV4cHJlc3Npb24gUGFyc2VyPExleGVyVHlwZT46OnBhcnNlVW5hcnlFeHByZXNzCiAg ICAgYm9vbCBoYXNQcmVmaXhVcGRhdGVPcCA9IGZhbHNlOwogICAgIHVuc2lnbmVkIGxhc3RPcGVy YXRvciA9IDA7CiAKLSAgICBpZiAoVU5MSUtFTFkobWF0Y2goQVdBSVQpICYmICFtX3BhcnNlclN0 YXRlLmlzUGFyc2luZ0NsYXNzRmllbGRJbml0aWFsaXplciAmJiAoY3VycmVudEZ1bmN0aW9uU2Nv cGUoKS0+aXNBc3luY0Z1bmN0aW9uQm91bmRhcnkoKSB8fCBpc01vZHVsZVBhcnNlTW9kZShzb3Vy Y2VQYXJzZU1vZGUoKSkpKSkgeworICAgIGlmIChVTkxJS0VMWShtYXRjaChBV0FJVCkgJiYgKGN1 cnJlbnRGdW5jdGlvblNjb3BlKCktPmlzQXN5bmNGdW5jdGlvbkJvdW5kYXJ5KCkgfHwgaXNNb2R1 bGVQYXJzZU1vZGUoc291cmNlUGFyc2VNb2RlKCkpKSkpIHsKICAgICAgICAgc2VtYW50aWNGYWls SWZUcnVlKGN1cnJlbnRTY29wZSgpLT5pc1N0YXRpY0Jsb2NrKCksICJDYW5ub3QgdXNlICdhd2Fp dCcgd2l0aGluIHN0YXRpYyBibG9jayIpOwogICAgICAgICByZXR1cm4gcGFyc2VBd2FpdEV4cHJl c3Npb24oY29udGV4dCk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MveWllbGQt YXdhaXQtY2xhc3MtZmllbGQtaW5pdGlhbGl6ZXItZXhwci5qcyBiL0pTVGVzdHMvc3RyZXNzL3lp ZWxkLWF3YWl0LWNsYXNzLWZpZWxkLWluaXRpYWxpemVyLWV4cHIuanMKZGVsZXRlZCBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IGE5YmVlZjc2ZmYxNC4uMDAwMDAwMDAwMDAwCi0tLSBhL0pTVGVzdHMv c3RyZXNzL3lpZWxkLWF3YWl0LWNsYXNzLWZpZWxkLWluaXRpYWxpemVyLWV4cHIuanMKKysrIC9k ZXYvbnVsbApAQCAtMSw4OSArMCwwIEBACi0vLyBUZXN0cyBmb3IgJ3lpZWxkJyBhbmQgJ2F3YWl0 JyBpbnNpZGUgY2xhc3MgZmllbGQgaW5pdGlhbGl6ZXJzLCB3aGVyZSB0aGUgY2xhc3MgaXMgZGVj bGFyZWQgaW5zaWRlCi0vLyBhc3luYyBhbmQgZ2VuZXJhdG9yIGZ1bmN0aW9ucy4KLWNvbnN0IHZl cmJvc2UgPSBmYWxzZTsKLQotY29uc3Qgd3JhcHBlcnMgPSBbJ25vbmUnLCAnZ2VuZXJhdG9yJywg J2FzeW5jJ107Ci1jb25zdCBmaWVsZE1vZGlmaWVycyA9IFsnJywgJ3N0YXRpYyddOwotY29uc3Qg ZmllbGRJbml0RXhwcnMgPSBbJ3lpZWxkJywgJ3lpZWxkIDQyJywgJ2F3YWl0JywgJ2F3YWl0IDMn XTsKLQotZnVuY3Rpb24gZ2VuVGVzdENhc2VzKCkgewotICAgIGxldCBjYXNlcyA9IFtdOwotICAg IGZvciAoY29uc3Qgd3JhcHBlciBvZiB3cmFwcGVycykgewotICAgICAgICBmb3IgKGNvbnN0IGZp ZWxkTW9kaWZpZXIgb2YgZmllbGRNb2RpZmllcnMpIHsKLSAgICAgICAgICAgIGZvciAoY29uc3Qg ZmllbGRJbml0RXhwciBvZiBmaWVsZEluaXRFeHBycykgewotICAgICAgICAgICAgICAgIGNhc2Vz LnB1c2goeyB3cmFwcGVyLCBmaWVsZE1vZGlmaWVyLCBmaWVsZEluaXRFeHByIH0pOwotICAgICAg ICAgICAgfQotICAgICAgICB9Ci0gICAgfQotICAgIHJldHVybiBjYXNlczsKLX0KLQotZnVuY3Rp b24gZ2VuVGVzdFNjcmlwdChjKSB7Ci0gICAgbGV0IHRhYnMgPSAwOwotICAgIGxldCBzY3JpcHQg PSAiIjsKLQotICAgIGZ1bmN0aW9uIGFwcGVuZChsaW5lKSB7Ci0gICAgICAgIGZvciAodCA9IDA7 IHQgPCB0YWJzOyB0KyspCi0gICAgICAgICAgICBzY3JpcHQgKz0gJyAgJzsKLSAgICAgICAgc2Ny aXB0ICs9IGxpbmUgKyAnXG4nOwotICAgIH0KLQotICAgIHN3aXRjaCAoYy53cmFwcGVyKSB7Ci0g ICAgICAgIGNhc2UgJ2dlbmVyYXRvcic6Ci0gICAgICAgICAgICBhcHBlbmQoJ2Z1bmN0aW9uICog ZygpIHsnKTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlICdhc3luYyc6Ci0gICAg ICAgICAgICBhcHBlbmQoJ2FzeW5jIGZ1bmN0aW9uIGYoKSB7Jyk7Ci0gICAgICAgICAgICBicmVh azsKLSAgICAgICAgY2FzZSAnbm9uZSc6Ci0gICAgICAgICAgICBicmVhazsKLSAgICB9Ci0gICAg dGFicysrOwotICAgIGFwcGVuZCgnY2xhc3MgQyB7Jyk7Ci0gICAgdGFicysrOwotICAgIGFwcGVu ZChgJHtjLmZpZWxkTW9kaWZpZXJ9IGYgPSAke2MuZmllbGRJbml0RXhwcn07YCk7Ci0gICAgdGFi cy0tOwotICAgIGFwcGVuZCgnfScpOwotICAgIHRhYnMtLTsKLSAgICBpZiAoYy53cmFwcGVyICE9 PSAnbm9uZScpIGFwcGVuZCgnfScpOwotICAgIHJldHVybiBzY3JpcHQ7Ci19Ci0KLWZ1bmN0aW9u IGV4cGVjdGVkKGMsIHJlc3VsdCwgZXJyb3IpIHsKLSAgICBpZiAoYy5maWVsZEluaXRFeHByID09 PSAnYXdhaXQnKSB7Ci0gICAgICAgIC8vICdhd2FpdCcgd2lsbCBwYXJzZSBhcyBhbiBpZGVudGlm aWVyLgotICAgICAgICBpZiAoYy53cmFwcGVyID09PSAnbm9uZScgJiYgYy5maWVsZE1vZGlmaWVy ID09PSAnc3RhdGljJykgewotICAgICAgICAgICAgLy8gSW4gdGhpcyBjYXNlLCAnYXdhaXQnIGFz IGlkZW50aWZpZXIgcHJvZHVjZXMgYSBSZWZlcmVuY2VFcnJvci4KLSAgICAgICAgICAgIHJldHVy biByZXN1bHQgPT09IG51bGwgJiYgZXJyb3IgaW5zdGFuY2VvZiBSZWZlcmVuY2VFcnJvcjsKLSAg ICAgICAgfQotICAgICAgICAvLyBJbiB0aGVzZSBjYXNlcywgJ2F3YWl0JyBhcyBpZGVudGlmaWVy IGhhcyB2YWx1ZSAndW5kZWZpbmVkJykuCi0gICAgICAgIHJldHVybiByZXN1bHQgPT09IHVuZGVm aW5lZCAmJiBlcnJvciA9PT0gbnVsbDsKLSAgICB9Ci0gICAgLy8gQWxsIG90aGVyIGNhc2VzIHNo b3VsZCByZXN1bHQgaW4gYSBTeW50YXhFcnJvci4KLSAgICByZXR1cm4gcmVzdWx0ID09PSBudWxs ICYmIGVycm9yIGluc3RhbmNlb2YgU3ludGF4RXJyb3I7Ci19Ci0KLWNhc2VzID0gZ2VuVGVzdENh c2VzKCk7Ci0KLWZvciAoY29uc3QgYyBvZiBjYXNlcykgewotICAgIGxldCBzY3JpcHQgPSBnZW5U ZXN0U2NyaXB0KGMpOwotICAgIGxldCByZXN1bHQgPSBudWxsOwotICAgIGxldCBlcnJvciA9IG51 bGw7Ci0gICAgdHJ5IHsKLSAgICAgICAgcmVzdWx0ID0gZXZhbChzY3JpcHQpOwotICAgIH0gY2F0 Y2ggKGUpIHsKLSAgICAgICAgZXJyb3IgPSBlOwotICAgIH0KLQotICAgIGlmICh2ZXJib3NlIHx8 ICFleHBlY3RlZChjLCByZXN1bHQsIGVycm9yKSkgewotICAgICAgICBwcmludChgQ2FzZTogJHtj LndyYXBwZXJ9OiR7Yy5maWVsZE1vZGlmaWVyfToke2MuZmllbGRJbml0RXhwcn1gKTsKLSAgICAg ICAgcHJpbnQoYFNjcmlwdDpcbiR7c2NyaXB0fWApOwotICAgICAgICBpZiAocmVzdWx0ICE9IG51 bGwpIHsKLSAgICAgICAgICAgIHByaW50KCJSZXN1bHQ6ICIgKyByZXN1bHQpOwotICAgICAgICB9 IGVsc2UgaWYgKGVycm9yICE9IG51bGwpIHsKLSAgICAgICAgICAgIHByaW50KCJFcnJvcjogIiAr IGVycm9yKTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIHByaW50KCJFeHBlY3Rpbmcg ZWl0aGVyIHJlc3VsdCBvciBlcnJvciEiKQotICAgICAgICB9Ci0gICAgfQotfQo=