27641 2009-07-24 00:03:48 -0700 Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::mark() instead 2009-07-24 00:14:40 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 27634 1 eric webkit-unassigned oldest_to_newest 134408 0 eric 2009-07-24 00:03:48 -0700 Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::mark() instead Actually I'm going to change these to Base::mark() instead for future-proofing. All the auto-gen bindings define a Base typedef which is the superclass. So sad that c++ doesn't just have a super:: call built-in. :( 134409 1 33410 eric 2009-07-24 00:08:27 -0700 Created attachment 33410 patch 134410 2 33410 abarth 2009-07-24 00:10:06 -0700 Comment on attachment 33410 patch Yep. C++ is the suck. 134411 3 eric 2009-07-24 00:14:40 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/js/JSAbstractWorkerCustom.cpp M WebCore/bindings/js/JSDOMApplicationCacheCustom.cpp M WebCore/bindings/js/JSMessageChannelCustom.cpp M WebCore/bindings/js/JSMessagePortCustom.cpp M WebCore/bindings/js/JSNamedNodesCollection.cpp M WebCore/bindings/js/JSNodeCustom.cpp M WebCore/bindings/js/JSNodeFilterCustom.cpp M WebCore/bindings/js/JSNodeIteratorCustom.cpp M WebCore/bindings/js/JSSVGElementInstanceCustom.cpp M WebCore/bindings/js/JSTreeWalkerCustom.cpp Committed r46322 M WebCore/ChangeLog M WebCore/bindings/js/JSDOMApplicationCacheCustom.cpp M WebCore/bindings/js/JSNodeFilterCustom.cpp M WebCore/bindings/js/JSAbstractWorkerCustom.cpp M WebCore/bindings/js/JSNamedNodesCollection.cpp M WebCore/bindings/js/JSSVGElementInstanceCustom.cpp M WebCore/bindings/js/JSMessageChannelCustom.cpp M WebCore/bindings/js/JSMessagePortCustom.cpp M WebCore/bindings/js/JSNodeCustom.cpp M WebCore/bindings/js/JSNodeIteratorCustom.cpp M WebCore/bindings/js/JSTreeWalkerCustom.cpp r46322 = 9074277481c1c10c1941550c44bda829678c5499 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46322 33410 2009-07-24 00:08:27 -0700 2009-07-24 00:10:06 -0700 patch bug-27641-20090724000826.patch text/plain 6946 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjZiZjQyZS4uYzI3YzQwNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzNSBAQAorMjAwOS0wNy0yNCAgRXJpYyBTZWlkZWwg IDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2xhc3NlcyBjYWxsIERPTU9iamVjdDo6bWFyaygpIGV4cGxpY2l0bHksIHNo b3VsZCBjYWxsIERPTU9iamVjdFdpdGhHbG9iYWw6Om1hcmsoKSBpbnN0ZWFkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzY0MQorCisgICAgICAgIE5v dGhpbmcgdXNlcyBnbG9iYWxPYmplY3QoKSB5ZXQsIGJ1dCB0aGlzIHdhcyBjYXVzaW5nIGNyYXNo ZXMKKyAgICAgICAgaW4gdGhlIHBhdGNoIGZvciBidWcgMjc2MzQuICBUaGlzIGlzIGNvdmVyZWQg YnkgZmFzdC9kb20vZ2MtNi5odG1sLgorCisgICAgICAgICogV2ViQ29yZS54Y29kZXByb2ovcHJv amVjdC5wYnhwcm9qOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQWJzdHJhY3RXb3JrZXJDdXN0 b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNBYnN0cmFjdFdvcmtlcjo6bWFyayk6CisgICAg ICAgICogYmluZGluZ3MvanMvSlNET01BcHBsaWNhdGlvbkNhY2hlQ3VzdG9tLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkpTRE9NQXBwbGljYXRpb25DYWNoZTo6bWFyayk6CisgICAgICAgICogYmlu ZGluZ3MvanMvSlNNZXNzYWdlQ2hhbm5lbEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpK U01lc3NhZ2VDaGFubmVsOjptYXJrKToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU01lc3NhZ2VQ b3J0Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTTWVzc2FnZVBvcnQ6Om1hcmspOgor ICAgICAgICAqIGJpbmRpbmdzL2pzL0pTTmFtZWROb2Rlc0NvbGxlY3Rpb24uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6SlNOYW1lZE5vZGVzQ29sbGVjdGlvbjo6Z2V0T3duUHJvcGVydHlTbG90KToK KyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU05vZGVDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SlNOb2RlOjptYXJrKToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU05vZGVGaWx0ZXJDdXN0 b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNOb2RlRmlsdGVyOjptYXJrKToKKyAgICAgICAg KiBiaW5kaW5ncy9qcy9KU05vZGVJdGVyYXRvckN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpKU05vZGVJdGVyYXRvcjo6bWFyayk6CisgICAgICAgICogYmluZGluZ3MvanMvSlNTVkdFbGVt ZW50SW5zdGFuY2VDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNTVkdFbGVtZW50SW5z dGFuY2U6Om1hcmspOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTVHJlZVdhbGtlckN1c3RvbS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpKU1RyZWVXYWxrZXI6Om1hcmspOgorCiAyMDA5LTA3LTIy ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBB ZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0Fic3RyYWN0V29y a2VyQ3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvanMvSlNBYnN0cmFjdFdvcmtlckN1c3Rv bS5jcHAKaW5kZXggYTQzMzk3My4uNTEwMmVmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0Fic3RyYWN0V29ya2VyQ3VzdG9tLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTQWJzdHJhY3RXb3JrZXJDdXN0b20uY3BwCkBAIC00NSw3ICs0NSw3IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogdm9pZCBKU0Fic3RyYWN0V29ya2VyOjptYXJrKCkKIHsKLSAgICBET01PYmpl Y3Q6Om1hcmsoKTsKKyAgICBCYXNlOjptYXJrKCk7CiAKICAgICBtYXJrSWZOb3ROdWxsKG1faW1w bC0+b25lcnJvcigpKTsKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUFw cGxpY2F0aW9uQ2FjaGVDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUFwcGxp Y2F0aW9uQ2FjaGVDdXN0b20uY3BwCmluZGV4IDdlOGQ5Y2UuLmE3ZmFlNzggMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01BcHBsaWNhdGlvbkNhY2hlQ3VzdG9tLmNwcAorKysg Yi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQXBwbGljYXRpb25DYWNoZUN1c3RvbS5jcHAKQEAg LTQ0LDcgKzQ0LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiB2b2lkIEpTRE9NQXBwbGljYXRp b25DYWNoZTo6bWFyaygpCiB7Ci0gICAgRE9NT2JqZWN0OjptYXJrKCk7CisgICAgQmFzZTo6bWFy aygpOwogCiAgICAgbWFya0lmTm90TnVsbChtX2ltcGwtPm9uY2hlY2tpbmcoKSk7CiAgICAgbWFy a0lmTm90TnVsbChtX2ltcGwtPm9uZXJyb3IoKSk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRp bmdzL2pzL0pTTWVzc2FnZUNoYW5uZWxDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U01lc3NhZ2VDaGFubmVsQ3VzdG9tLmNwcAppbmRleCA3MDMyOWUyLi5kM2I1ODc4IDEwMDY0NAot LS0gYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTWVzc2FnZUNoYW5uZWxDdXN0b20uY3BwCisrKyBi L1dlYkNvcmUvYmluZGluZ3MvanMvSlNNZXNzYWdlQ2hhbm5lbEN1c3RvbS5jcHAKQEAgLTM0LDcg KzM0LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIAogdm9pZCBKU01lc3NhZ2VDaGFubmVs OjptYXJrKCkKIHsKLSAgICBET01PYmplY3Q6Om1hcmsoKTsKKyAgICBCYXNlOjptYXJrKCk7CiAK ICAgICBpZiAoTWVzc2FnZVBvcnQqIHBvcnQgPSBtX2ltcGwtPnBvcnQxKCkpIHsKICAgICAgICAg RE9NT2JqZWN0KiB3cmFwcGVyID0gZ2V0Q2FjaGVkRE9NT2JqZWN0V3JhcHBlcigqSGVhcDo6aGVh cCh0aGlzKS0+Z2xvYmFsRGF0YSgpLCBwb3J0KTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNNZXNzYWdlUG9ydEN1c3RvbS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTWVz c2FnZVBvcnRDdXN0b20uY3BwCmluZGV4IGJmYWMzNzUuLjcxNDcyZDUgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvYmluZGluZ3MvanMvSlNNZXNzYWdlUG9ydEN1c3RvbS5jcHAKKysrIGIvV2ViQ29yZS9i aW5kaW5ncy9qcy9KU01lc3NhZ2VQb3J0Q3VzdG9tLmNwcApAQCAtNDAsNyArNDAsNyBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKIHZvaWQgSlNNZXNzYWdlUG9ydDo6bWFyaygpCiB7Ci0gICAgRE9N T2JqZWN0OjptYXJrKCk7CisgICAgQmFzZTo6bWFyaygpOwogCiAgICAgbWFya0lmTm90TnVsbCht X2ltcGwtPm9ubWVzc2FnZSgpKTsKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U05hbWVkTm9kZXNDb2xsZWN0aW9uLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvanMvSlNOYW1lZE5v ZGVzQ29sbGVjdGlvbi5jcHAKaW5kZXggMzMyM2VlMi4uZjM2YTdkNiAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU05hbWVkTm9kZXNDb2xsZWN0aW9uLmNwcAorKysgYi9XZWJDb3Jl L2JpbmRpbmdzL2pzL0pTTmFtZWROb2Rlc0NvbGxlY3Rpb24uY3BwCkBAIC04Niw3ICs4Niw3IEBA IGJvb2wgSlNOYW1lZE5vZGVzQ29sbGVjdGlvbjo6Z2V0T3duUHJvcGVydHlTbG90KEV4ZWNTdGF0 ZSogZXhlYywgY29uc3QgSWRlbnRpZmllCiAgICAgICAgIH0KICAgICB9CiAKLSAgICByZXR1cm4g RE9NT2JqZWN0OjpnZXRPd25Qcm9wZXJ0eVNsb3QoZXhlYywgcHJvcGVydHlOYW1lLCBzbG90KTsK KyAgICByZXR1cm4gRE9NT2JqZWN0V2l0aEdsb2JhbFBvaW50ZXI6OmdldE93blByb3BlcnR5U2xv dChleGVjLCBwcm9wZXJ0eU5hbWUsIHNsb3QpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTm9kZUN1c3RvbS5jcHAgYi9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTTm9kZUN1c3RvbS5jcHAKaW5kZXggNzlhYzZiNy4uNjc2OGIyZSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU05vZGVDdXN0b20uY3BwCisrKyBiL1dl YkNvcmUvYmluZGluZ3MvanMvSlNOb2RlQ3VzdG9tLmNwcApAQCAtMTQ2LDcgKzE0Niw3IEBAIHZv aWQgSlNOb2RlOjptYXJrKCkKICAgICAvLyB0aGUgZG9jdW1lbnQsIHdlIG5lZWQgdG8gbWFyayB0 aGUgZG9jdW1lbnQsIGJ1dCB3ZSBkb24ndCBuZWVkIHRvIGV4cGxpY2l0bHkKICAgICAvLyBtYXJr IGFueSBvdGhlciBub2Rlcy4KICAgICBpZiAobm9kZS0+aW5Eb2N1bWVudCgpKSB7Ci0gICAgICAg IERPTU9iamVjdDo6bWFyaygpOworICAgICAgICBCYXNlOjptYXJrKCk7CiAgICAgICAgIG1hcmtF dmVudExpc3RlbmVycyhub2RlLT5ldmVudExpc3RlbmVycygpKTsKICAgICAgICAgaWYgKERvY3Vt ZW50KiBkb2MgPSBub2RlLT5vd25lckRvY3VtZW50KCkpCiAgICAgICAgICAgICBpZiAoRE9NT2Jq ZWN0KiBkb2NXcmFwcGVyID0gZ2V0Q2FjaGVkRE9NT2JqZWN0V3JhcHBlcigqSGVhcDo6aGVhcCh0 aGlzKS0+Z2xvYmFsRGF0YSgpLCBkb2MpKQpAQCAtMTY0LDcgKzE2NCw3IEBAIHZvaWQgSlNOb2Rl OjptYXJrKCkKICAgICAvLyBOb2RlcyBpbiBhIHN1YnRyZWUgYXJlIG1hcmtlZCBieSB0aGUgdHJl ZSdzIHJvb3QsIHNvLCBpZiB0aGUgcm9vdCBpcyBhbHJlYWR5CiAgICAgLy8gbWFya2luZyB0aGUg dHJlZSwgd2UgZG9uJ3QgbmVlZCB0byBleHBsaWNpdGx5IG1hcmsgYW55IG90aGVyIG5vZGVzLgog ICAgIGlmIChyb290LT5pblN1YnRyZWVNYXJrKCkpIHsKLSAgICAgICAgRE9NT2JqZWN0OjptYXJr KCk7CisgICAgICAgIEJhc2U6Om1hcmsoKTsKICAgICAgICAgbWFya0V2ZW50TGlzdGVuZXJzKG5v ZGUtPmV2ZW50TGlzdGVuZXJzKCkpOwogICAgICAgICByZXR1cm47CiAgICAgfQpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU05vZGVGaWx0ZXJDdXN0b20uY3BwIGIvV2ViQ29yZS9i aW5kaW5ncy9qcy9KU05vZGVGaWx0ZXJDdXN0b20uY3BwCmluZGV4IGVjYzEyZDUuLmE0OGE1OWQg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvanMvSlNOb2RlRmlsdGVyQ3VzdG9tLmNwcAor KysgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTm9kZUZpbHRlckN1c3RvbS5jcHAKQEAgLTM4LDcg KzM4LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogdm9pZCBKU05vZGVGaWx0ZXI6Om1hcmsoKQog ewogICAgIGltcGwoKS0+bWFyaygpOwotICAgIERPTU9iamVjdDo6bWFyaygpOworICAgIEJhc2U6 Om1hcmsoKTsKIH0KIAogSlNWYWx1ZSBKU05vZGVGaWx0ZXI6OmFjY2VwdE5vZGUoRXhlY1N0YXRl KiBleGVjLCBjb25zdCBBcmdMaXN0JiBhcmdzKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU05vZGVJdGVyYXRvckN1c3RvbS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTm9k ZUl0ZXJhdG9yQ3VzdG9tLmNwcAppbmRleCA4ZmZmODJlLi5hMmI5NjU4IDEwMDY0NAotLS0gYS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTTm9kZUl0ZXJhdG9yQ3VzdG9tLmNwcAorKysgYi9XZWJDb3Jl L2JpbmRpbmdzL2pzL0pTTm9kZUl0ZXJhdG9yQ3VzdG9tLmNwcApAQCAtMzQsNyArMzQsNyBAQCB2 b2lkIEpTTm9kZUl0ZXJhdG9yOjptYXJrKCkKICAgICBpZiAoTm9kZUZpbHRlciogZmlsdGVyID0g bV9pbXBsLT5maWx0ZXIoKSkKICAgICAgICAgZmlsdGVyLT5tYXJrKCk7CiAgICAgCi0gICAgRE9N T2JqZWN0OjptYXJrKCk7CisgICAgQmFzZTo6bWFyaygpOwogfQogCiBKU1ZhbHVlIEpTTm9kZUl0 ZXJhdG9yOjpuZXh0Tm9kZShFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEFyZ0xpc3QmKQpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1NWR0VsZW1lbnRJbnN0YW5jZUN1c3RvbS5jcHAg Yi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTU1ZHRWxlbWVudEluc3RhbmNlQ3VzdG9tLmNwcAppbmRl eCAyOTIyNzQwLi45M2FjNmExIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTU1ZH RWxlbWVudEluc3RhbmNlQ3VzdG9tLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTU1ZH RWxlbWVudEluc3RhbmNlQ3VzdG9tLmNwcApAQCAtMzksNyArMzksNyBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKIHZvaWQgSlNTVkdFbGVtZW50SW5zdGFuY2U6Om1hcmsoKQogewotICAgIERPTU9i amVjdDo6bWFyaygpOworICAgIEJhc2U6Om1hcmsoKTsKIAogICAgIC8vIE1hcmsgdGhlIHdyYXBw ZXIgZm9yIG91ciBjb3JyZXNwb25kaW5nIGVsZW1lbnQsIHNvIGl0IGNhbiBtYXJrIGl0cyBldmVu dCBoYW5kbGVycy4KICAgICBKU05vZGUqIGNvcnJlc3BvbmRpbmdXcmFwcGVyID0gZ2V0Q2FjaGVk RE9NTm9kZVdyYXBwZXIoaW1wbCgpLT5jb3JyZXNwb25kaW5nRWxlbWVudCgpLT5kb2N1bWVudCgp LCBpbXBsKCktPmNvcnJlc3BvbmRpbmdFbGVtZW50KCkpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9i aW5kaW5ncy9qcy9KU1RyZWVXYWxrZXJDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U1RyZWVXYWxrZXJDdXN0b20uY3BwCmluZGV4IDYzNjkwMTcuLjU4ZWVhNzIgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvYmluZGluZ3MvanMvSlNUcmVlV2Fsa2VyQ3VzdG9tLmNwcAorKysgYi9XZWJDb3Jl L2JpbmRpbmdzL2pzL0pTVHJlZVdhbGtlckN1c3RvbS5jcHAKQEAgLTM0LDcgKzM0LDcgQEAgdm9p ZCBKU1RyZWVXYWxrZXI6Om1hcmsoKQogICAgIGlmIChOb2RlRmlsdGVyKiBmaWx0ZXIgPSBtX2lt cGwtPmZpbHRlcigpKQogICAgICAgICBmaWx0ZXItPm1hcmsoKTsKICAgICAKLSAgICBET01PYmpl Y3Q6Om1hcmsoKTsKKyAgICBCYXNlOjptYXJrKCk7CiB9CiAgICAgCiBKU1ZhbHVlIEpTVHJlZVdh bGtlcjo6cGFyZW50Tm9kZShFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEFyZ0xpc3QmKQ==