27633 2009-07-23 17:30:37 -0700 AXLoadComplete can be fired off to frequently 2009-07-23 17:35:53 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach webkit-unassigned staikos oldest_to_newest 134324 0 cfleizach 2009-07-23 17:30:37 -0700 looks like an integration left out some curly brackets around an if statement Document.cpp no brackets for if (f && renderer() && this == topDocument() && AXObjectCache::accessibilityEnabled()) 134325 1 33396 cfleizach 2009-07-23 17:32:05 -0700 Created attachment 33396 patch 134326 2 33396 staikos 2009-07-23 17:34:06 -0700 Comment on attachment 33396 patch A perfect example of why I strongly disagree with the braces "policy" that is being so strictly enforced. 134327 3 staikos 2009-07-23 17:34:44 -0700 heh beat me to the r+ :) 134328 4 cfleizach 2009-07-23 17:35:53 -0700 http://trac.webkit.org/changeset/46301 33396 2009-07-23 17:32:05 -0700 2009-07-23 17:34:06 -0700 patch patch.txt text/plain 1667 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjMwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMjMgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWcgMjc2MzMgLSBBWExvYWRDb21wbGV0ZSBjYW4gYmUgZmlyZWQgb2ZmIHRvIGZyZXF1ZW50 bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NjMz CisKKyAgICAgICAgQW4gaW50ZWdyYXRpb24gaXNzdWUgbGVmdCBvdXQgc29tZSBjdXJseSBicmFj ZXMuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9j dW1lbnQ6OmltcGxpY2l0Q2xvc2UpOgorCiAyMDA5LTA3LTIzICBEYXJpbiBBZGxlciAgPGRhcmlu QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBCcmFkeSBFaWRzb24uCkluZGV4OiBX ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vRG9jdW1l bnQuY3BwCShyZXZpc2lvbiA0NjI4OSkKKysrIFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTY4MSwxMyArMTY4MSwxNCBAQCB2b2lkIERvY3VtZW50OjppbXBsaWNp dENsb3NlKCkKICAgICB9CiAKICNpZiBQTEFURk9STShNQUMpCi0gICAgaWYgKGYgJiYgcmVuZGVy T2JqZWN0ICYmIHRoaXMgPT0gdG9wRG9jdW1lbnQoKSAmJiBBWE9iamVjdENhY2hlOjphY2Nlc3Np YmlsaXR5RW5hYmxlZCgpKQorICAgIGlmIChmICYmIHJlbmRlck9iamVjdCAmJiB0aGlzID09IHRv cERvY3VtZW50KCkgJiYgQVhPYmplY3RDYWNoZTo6YWNjZXNzaWJpbGl0eUVuYWJsZWQoKSkgewog ICAgICAgICAvLyBUaGUgQVggY2FjaGUgbWF5IGhhdmUgYmVlbiBjbGVhcmVkIGF0IHRoaXMgcG9p bnQsIGJ1dCB3ZSBuZWVkIHRvIG1ha2Ugc3VyZSBpdCBjb250YWlucyBhbgogICAgICAgICAvLyBB WCBvYmplY3QgdG8gc2VuZCB0aGUgbm90aWZpY2F0aW9uIHRvLiBnZXRPckNyZWF0ZSB3aWxsIG1h a2Ugc3VyZSB0aGF0IGFuIHZhbGlkIEFYIG9iamVjdAogICAgICAgICAvLyBleGlzdHMgaW4gdGhl IGNhY2hlICh3ZSBpZ25vcmUgdGhlIHJldHVybiB2YWx1ZSBiZWNhdXNlIHdlIGRvbid0IG5lZWQg aXQgaGVyZSkuIFRoaXMgaXMgCiAgICAgICAgIC8vIG9ubHkgc2FmZSB0byBjYWxsIHdoZW4gYSBs YXlvdXQgaXMgbm90IGluIHByb2dyZXNzLCBzbyBpdCBjYW4gbm90IGJlIHVzZWQgaW4gcG9zdE5v dGlmaWNhdGlvbi4gICAgCiAgICAgICAgIGF4T2JqZWN0Q2FjaGUoKS0+Z2V0T3JDcmVhdGUocmVu ZGVyT2JqZWN0KTsKICAgICAgICAgYXhPYmplY3RDYWNoZSgpLT5wb3N0Tm90aWZpY2F0aW9uKHJl bmRlck9iamVjdCwgIkFYTG9hZENvbXBsZXRlIiwgdHJ1ZSk7CisgICAgfQogI2VuZGlmCiAKICNp ZiBFTkFCTEUoU1ZHKQo=