27618 2009-07-23 12:39:34 -0700 WebCore/page/DOMTimer.cpp/h does not conform to style standards 2009-07-24 00:28:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 mifenton abarth abarth manyoso oldest_to_newest 134204 0 mifenton 2009-07-23 12:39:34 -0700 cpplint reports a number of valid style fixes that should be made to WebCore/page/DOMTimer.cpp/h. 134209 1 33356 mifenton 2009-07-23 13:00:09 -0700 Created attachment 33356 Style patch for DOMTimer.cpp/h 134215 2 33356 darin 2009-07-23 13:13:22 -0700 Comment on attachment 33356 Style patch for DOMTimer.cpp/h It seems that most of this patch is about stripping trailing whitespace. I didn't know we had a convention that said this was important. 134219 3 manyoso 2009-07-23 13:18:12 -0700 In the absence of (In reply to comment #2) > (From update of attachment 33356 [details]) > It seems that most of this patch is about stripping trailing whitespace. I > didn't know we had a convention that said this was important. In the abscense of other styling errors, maybe not. But in addition to... Why not? They serve no useful purpose and can be distracting in some editors that highlight them. 134241 4 mifenton 2009-07-23 13:55:12 -0700 This patch does include non-whitespace changes as well as whitespace changes. 134380 5 33356 eric 2009-07-23 23:12:32 -0700 Comment on attachment 33356 Style patch for DOMTimer.cpp/h I wish XCode would strip whitespace for me. ;) The changes look fine. 134403 6 abarth 2009-07-23 23:56:07 -0700 Will land. 134416 7 abarth 2009-07-24 00:28:55 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/DOMTimer.cpp M WebCore/page/DOMTimer.h Committed r46324 M WebCore/ChangeLog M WebCore/page/DOMTimer.h M WebCore/page/DOMTimer.cpp r46324 = 33c74813d8d1eb35a78b02d4d954b5890c1b7285 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46324 33356 2009-07-23 13:00:09 -0700 2009-07-23 23:12:32 -0700 Style patch for DOMTimer.cpp/h DOMTimerPatch.diff text/plain 5904 mifenton ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjMxMzA2Ni4uYzlkZTBhYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0wNy0yMyAgTWlrZSBGZW50b24g IDxtaWtlLmZlbnRvbkB0b3JjaG1vYmlsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIFdlYkNvcmUvcGFnZS9ET01UaW1lci5jcHAv aCB0byBjb25mb3JtIHRvIFdlYktpdAorICAgICAgICBTdHlsZSBHdWlkZWxpbmVzIGFzIGlkZW50 aWZpZWQgYnkgY3BwbGludC5weS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI3NjE4CisKKyAgICAgICAgKiBwYWdlL0RPTVRpbWVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkRPTVRpbWVyOjpET01UaW1lcik6CisgICAgICAgIChXZWJDb3JlOjpET01U aW1lcjo6fkRPTVRpbWVyKToKKyAgICAgICAgKFdlYkNvcmU6OkRPTVRpbWVyOjpmaXJlZCk6Cisg ICAgICAgIChXZWJDb3JlOjpET01UaW1lcjo6c3VzcGVuZCk6CisgICAgICAgIChXZWJDb3JlOjpE T01UaW1lcjo6cmVzdW1lKToKKyAgICAgICAgKFdlYkNvcmU6OkRPTVRpbWVyOjpjYW5TdXNwZW5k KToKKyAgICAgICAgKiBwYWdlL0RPTVRpbWVyLmg6CisgICAgICAgIChXZWJDb3JlOjpET01UaW1l cjo6bWluVGltZXJJbnRlcnZhbCk6CisgICAgICAgIChXZWJDb3JlOjpET01UaW1lcjo6c2V0TWlu VGltZXJJbnRlcnZhbCk6CisKIDIwMDktMDctMjMgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGFnZS9ET01UaW1lci5jcHAgYi9XZWJDb3JlL3BhZ2UvRE9NVGltZXIuY3BwCmluZGV4IDFj Yzc3MzAuLmM0MmEwZGMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9ET01UaW1lci5jcHAKKysr IGIvV2ViQ29yZS9wYWdlL0RPTVRpbWVyLmNwcApAQCAtNTQsNyArNTQsNyBAQCBET01UaW1lcjo6 RE9NVGltZXIoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgU2NoZWR1bGVkQWN0aW9u KiBhY3Rpb24sIGludAogICAgIGlmIChsYXN0VXNlZFRpbWVvdXRJZCA8PSAwKQogICAgICAgICBs YXN0VXNlZFRpbWVvdXRJZCA9IDE7CiAgICAgbV90aW1lb3V0SWQgPSBsYXN0VXNlZFRpbWVvdXRJ ZDsKLSAgICAKKwogICAgIG1fbmVzdGluZ0xldmVsID0gdGltZXJOZXN0aW5nTGV2ZWwgKyAxOwog CiAgICAgc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLT5hZGRUaW1lb3V0KG1fdGltZW91dElkLCB0 aGlzKTsKQEAgLTc0LDExICs3NCwxMCBAQCBET01UaW1lcjo6RE9NVGltZXIoU2NyaXB0RXhlY3V0 aW9uQ29udGV4dCogY29udGV4dCwgU2NoZWR1bGVkQWN0aW9uKiBhY3Rpb24sIGludAogCiBET01U aW1lcjo6fkRPTVRpbWVyKCkKIHsKLSAgICBpZiAoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKSB7 CisgICAgaWYgKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkKICAgICAgICAgc2NyaXB0RXhlY3V0 aW9uQ29udGV4dCgpLT5yZW1vdmVUaW1lb3V0KG1fdGltZW91dElkKTsKLSAgICB9CiB9Ci0gICAg CisKIGludCBET01UaW1lcjo6aW5zdGFsbChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0 LCBTY2hlZHVsZWRBY3Rpb24qIGFjdGlvbiwgaW50IHRpbWVvdXQsIGJvb2wgc2luZ2xlU2hvdCkK IHsKICAgICAvLyBET01UaW1lciBjb25zdHJ1Y3RvciBsaW5rcyB0aGUgbmV3IHRpbWVyIGludG8g YSBsaXN0IG9mIEFjdGl2ZURPTU9iamVjdHMgaGVsZCBieSB0aGUgJ2NvbnRleHQnLgpAQCAtMTEw LDcgKzEwOSw3IEBAIHZvaWQgRE9NVGltZXI6OmZpcmVkKCkKICAgICAgICAgICAgIGlmIChtX25l c3RpbmdMZXZlbCA+PSBtYXhUaW1lck5lc3RpbmdMZXZlbCkKICAgICAgICAgICAgICAgICBhdWdt ZW50UmVwZWF0SW50ZXJ2YWwoc19taW5UaW1lckludGVydmFsIC0gcmVwZWF0SW50ZXJ2YWwoKSk7 CiAgICAgICAgIH0KLSAgICAgICAgCisKICAgICAgICAgLy8gTm8gYWNjZXNzIHRvIG1lbWJlciB2 YXJpYWJsZXMgYWZ0ZXIgdGhpcyBwb2ludCwgaXQgY2FuIGRlbGV0ZSB0aGUgdGltZXIuCiAgICAg ICAgIG1fYWN0aW9uLT5leGVjdXRlKGNvbnRleHQpOwogICAgICAgICByZXR1cm47CkBAIC0xMjEs NyArMTIwLDcgQEAgdm9pZCBET01UaW1lcjo6ZmlyZWQoKQogCiAgICAgLy8gTm8gYWNjZXNzIHRv IG1lbWJlciB2YXJpYWJsZXMgYWZ0ZXIgdGhpcyBwb2ludC4KICAgICBkZWxldGUgdGhpczsKLSAg ICAKKwogICAgIGFjdGlvbi0+ZXhlY3V0ZShjb250ZXh0KTsKICAgICBkZWxldGUgYWN0aW9uOwog ICAgIHRpbWVyTmVzdGluZ0xldmVsID0gMDsKQEAgLTE0NywyNCArMTQ2LDI0IEBAIHZvaWQgRE9N VGltZXI6OnN0b3AoKQogICAgIG1fYWN0aW9uLmNsZWFyKCk7CiB9CiAKLXZvaWQgRE9NVGltZXI6 OnN1c3BlbmQoKSAKLXsgCi0gICAgQVNTRVJUKG1fbmV4dEZpcmVJbnRlcnZhbCA9PSAwICYmIG1f cmVwZWF0SW50ZXJ2YWwgPT0gMCk7IAordm9pZCBET01UaW1lcjo6c3VzcGVuZCgpCit7CisgICAg QVNTRVJUKCFtX25leHRGaXJlSW50ZXJ2YWwgJiYgIW1fcmVwZWF0SW50ZXJ2YWwpOwogICAgIG1f bmV4dEZpcmVJbnRlcnZhbCA9IG5leHRGaXJlSW50ZXJ2YWwoKTsKICAgICBtX3JlcGVhdEludGVy dmFsID0gcmVwZWF0SW50ZXJ2YWwoKTsKICAgICBUaW1lckJhc2U6OnN0b3AoKTsKLX0gCi0gCi12 b2lkIERPTVRpbWVyOjpyZXN1bWUoKSAKLXsgCit9CisKK3ZvaWQgRE9NVGltZXI6OnJlc3VtZSgp Cit7CiAgICAgc3RhcnQobV9uZXh0RmlyZUludGVydmFsLCBtX3JlcGVhdEludGVydmFsKTsKICAg ICBtX25leHRGaXJlSW50ZXJ2YWwgPSAwOwogICAgIG1fcmVwZWF0SW50ZXJ2YWwgPSAwOwotfSAK LSAKLSAKLWJvb2wgRE9NVGltZXI6OmNhblN1c3BlbmQoKSBjb25zdCAKLXsgCit9CisKKworYm9v bCBET01UaW1lcjo6Y2FuU3VzcGVuZCgpIGNvbnN0Cit7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9ET01UaW1lci5oIGIvV2ViQ29yZS9wYWdlL0RPTVRp bWVyLmgKaW5kZXggZjYzNDNmYy4uNmQ2MjcxZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0RP TVRpbWVyLmgKKysrIGIvV2ViQ29yZS9wYWdlL0RPTVRpbWVyLmgKQEAgLTMzLDQxICszMyw0MSBA QAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNsYXNzIFNjaGVkdWxlZEFjdGlvbjsKKyAgICBj bGFzcyBTY2hlZHVsZWRBY3Rpb247CiAKLWNsYXNzIERPTVRpbWVyIDogcHVibGljIFRpbWVyQmFz ZSwgcHVibGljIEFjdGl2ZURPTU9iamVjdCB7Ci1wdWJsaWM6Ci0gICAgdmlydHVhbCB+RE9NVGlt ZXIoKTsKLSAgICAvLyBDcmVhdGVzIGEgbmV3IHRpbWVyIG93bmVkIGJ5IHNwZWNpZmllZCBTY3Jp cHRFeGVjdXRpb25Db250ZXh0LCBzdGFydHMgaXQKLSAgICAvLyBhbmQgcmV0dXJucyBpdHMgSWQu Ci0gICAgc3RhdGljIGludCBpbnN0YWxsKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCBTY2hlZHVs ZWRBY3Rpb24qLCBpbnQgdGltZW91dCwgYm9vbCBzaW5nbGVTaG90KTsKLSAgICBzdGF0aWMgdm9p ZCByZW1vdmVCeUlkKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCBpbnQgdGltZW91dElkKTsKKyAg ICBjbGFzcyBET01UaW1lciA6IHB1YmxpYyBUaW1lckJhc2UsIHB1YmxpYyBBY3RpdmVET01PYmpl Y3QgeworICAgIHB1YmxpYzoKKyAgICAgICAgdmlydHVhbCB+RE9NVGltZXIoKTsKKyAgICAgICAg Ly8gQ3JlYXRlcyBhIG5ldyB0aW1lciBvd25lZCBieSBzcGVjaWZpZWQgU2NyaXB0RXhlY3V0aW9u Q29udGV4dCwgc3RhcnRzIGl0CisgICAgICAgIC8vIGFuZCByZXR1cm5zIGl0cyBJZC4KKyAgICAg ICAgc3RhdGljIGludCBpbnN0YWxsKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCBTY2hlZHVsZWRB Y3Rpb24qLCBpbnQgdGltZW91dCwgYm9vbCBzaW5nbGVTaG90KTsKKyAgICAgICAgc3RhdGljIHZv aWQgcmVtb3ZlQnlJZChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgaW50IHRpbWVvdXRJZCk7CiAK LSAgICAvLyBBY3RpdmVET01PYmplY3QKLSAgICB2aXJ0dWFsIGJvb2wgaGFzUGVuZGluZ0FjdGl2 aXR5KCkgY29uc3Q7Ci0gICAgdmlydHVhbCB2b2lkIGNvbnRleHREZXN0cm95ZWQoKTsKLSAgICB2 aXJ0dWFsIHZvaWQgc3RvcCgpOwotICAgIHZpcnR1YWwgYm9vbCBjYW5TdXNwZW5kKCkgY29uc3Q7 Ci0gICAgdmlydHVhbCB2b2lkIHN1c3BlbmQoKTsKLSAgICB2aXJ0dWFsIHZvaWQgcmVzdW1lKCk7 CisgICAgICAgIC8vIEFjdGl2ZURPTU9iamVjdAorICAgICAgICB2aXJ0dWFsIGJvb2wgaGFzUGVu ZGluZ0FjdGl2aXR5KCkgY29uc3Q7CisgICAgICAgIHZpcnR1YWwgdm9pZCBjb250ZXh0RGVzdHJv eWVkKCk7CisgICAgICAgIHZpcnR1YWwgdm9pZCBzdG9wKCk7CisgICAgICAgIHZpcnR1YWwgYm9v bCBjYW5TdXNwZW5kKCkgY29uc3Q7CisgICAgICAgIHZpcnR1YWwgdm9pZCBzdXNwZW5kKCk7Cisg ICAgICAgIHZpcnR1YWwgdm9pZCByZXN1bWUoKTsKIAotICAgIC8vIFRoZSBsb3dlc3QgYWxsb3dh YmxlIHRpbWVyIHNldHRpbmcgKGluIHNlY29uZHMsIDAuMDAxID09IDEgbXMpLgotICAgIC8vIERl ZmF1bHQgaXMgMTBtcy4KLSAgICAvLyBDaHJvbWl1bSB1c2VzIGEgbm9uLWRlZmF1bHQgdGltZW91 dC4KLSAgICBzdGF0aWMgZG91YmxlIG1pblRpbWVySW50ZXJ2YWwoKSB7IHJldHVybiBzX21pblRp bWVySW50ZXJ2YWw7IH0KLSAgICBzdGF0aWMgdm9pZCBzZXRNaW5UaW1lckludGVydmFsKGRvdWJs ZSB2YWx1ZSkgeyBzX21pblRpbWVySW50ZXJ2YWwgPSB2YWx1ZTsgfQorICAgICAgICAvLyBUaGUg bG93ZXN0IGFsbG93YWJsZSB0aW1lciBzZXR0aW5nIChpbiBzZWNvbmRzLCAwLjAwMSA9PSAxIG1z KS4KKyAgICAgICAgLy8gRGVmYXVsdCBpcyAxMG1zLgorICAgICAgICAvLyBDaHJvbWl1bSB1c2Vz IGEgbm9uLWRlZmF1bHQgdGltZW91dC4KKyAgICAgICAgc3RhdGljIGRvdWJsZSBtaW5UaW1lcklu dGVydmFsKCkgeyByZXR1cm4gc19taW5UaW1lckludGVydmFsOyB9CisgICAgICAgIHN0YXRpYyB2 b2lkIHNldE1pblRpbWVySW50ZXJ2YWwoZG91YmxlIHZhbHVlKSB7IHNfbWluVGltZXJJbnRlcnZh bCA9IHZhbHVlOyB9CiAKLXByaXZhdGU6Ci0gICAgRE9NVGltZXIoU2NyaXB0RXhlY3V0aW9uQ29u dGV4dCosIFNjaGVkdWxlZEFjdGlvbiosIGludCB0aW1lb3V0LCBib29sIHNpbmdsZVNob3QpOwot ICAgIHZpcnR1YWwgdm9pZCBmaXJlZCgpOworICAgIHByaXZhdGU6CisgICAgICAgIERPTVRpbWVy KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCBTY2hlZHVsZWRBY3Rpb24qLCBpbnQgdGltZW91dCwg Ym9vbCBzaW5nbGVTaG90KTsKKyAgICAgICAgdmlydHVhbCB2b2lkIGZpcmVkKCk7CiAKLSAgICBp bnQgbV90aW1lb3V0SWQ7Ci0gICAgaW50IG1fbmVzdGluZ0xldmVsOwotICAgIE93blB0cjxTY2hl ZHVsZWRBY3Rpb24+IG1fYWN0aW9uOwotICAgIGRvdWJsZSBtX25leHRGaXJlSW50ZXJ2YWw7Ci0g ICAgZG91YmxlIG1fcmVwZWF0SW50ZXJ2YWw7Ci0gICAgc3RhdGljIGRvdWJsZSBzX21pblRpbWVy SW50ZXJ2YWw7Ci19OworICAgICAgICBpbnQgbV90aW1lb3V0SWQ7CisgICAgICAgIGludCBtX25l c3RpbmdMZXZlbDsKKyAgICAgICAgT3duUHRyPFNjaGVkdWxlZEFjdGlvbj4gbV9hY3Rpb247Cisg ICAgICAgIGRvdWJsZSBtX25leHRGaXJlSW50ZXJ2YWw7CisgICAgICAgIGRvdWJsZSBtX3JlcGVh dEludGVydmFsOworICAgICAgICBzdGF0aWMgZG91YmxlIHNfbWluVGltZXJJbnRlcnZhbDsKKyAg ICB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAK