276141 2024-07-02 13:21:38 -0700 Remove `plugins()` and use `ImplementAs=embeds` in 'Document+HTML.idl' 2024-07-12 10:57:21 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned annevk webkit-bug-importer oldest_to_newest 2044278 0 ahmad.saleem792 2024-07-02 13:21:38 -0700 Hi Team, We have following potential clean-up: > https://searchfox.org/wubkat/rev/8104e1d037fe1ef5d6824f8d893b5df6c2691452/Source/WebCore/dom/Document.cpp#7243 Ref<HTMLCollection> Document::plugins() { // This is an alias for embeds() required for the JS DOM bindings. return ensureCachedCollection<CollectionType::DocEmbeds>(); } > https://searchfox.org/wubkat/rev/8104e1d037fe1ef5d6824f8d893b5df6c2691452/Source/WebCore/dom/Document.h#585 WEBCORE_EXPORT Ref<HTMLCollection> plugins(); // an alias for embeds() required for the JS DOM bindings. ___ By removing them and then just doing this in Document+HTML.idl: https://searchfox.org/wubkat/rev/8104e1d037fe1ef5d6824f8d893b5df6c2691452/Source/WebCore/dom/Document+HTML.idl#48 [ImplementedAs=embeds, SameObject] readonly attribute HTMLCollection plugins; ____ Is this good clean-up? Or doable - haven't tried locally. Thanks! 2044799 1 annevk 2024-07-05 08:05:24 -0700 Yeah, go for it. 2045393 2 webkit-bug-importer 2024-07-09 13:22:35 -0700 <rdar://problem/131407054> 2045988 3 ews-feeder 2024-07-12 10:57:20 -0700 Committed 280913@main (d4fa9f182229): <https://commits.webkit.org/280913@main> Reviewed commits have been landed. Closing PR #30748 and removing active labels.