27608 2009-07-23 09:42:06 -0700 WebCore/page/Chrome.cpp does not conform to style standards 2009-07-24 00:44:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 mifenton abarth abarth eric manyoso oldest_to_newest 134130 0 mifenton 2009-07-23 09:42:06 -0700 cpplint reports a number of valid style fixes that should be made to WebCore/page/Chrome.cpp. 134131 1 33340 mifenton 2009-07-23 09:44:49 -0700 Created attachment 33340 Style patch for Chrome.cpp 134385 2 33340 eric 2009-07-23 23:15:36 -0700 Comment on attachment 33340 Style patch for Chrome.cpp LGTM. 134386 3 eric 2009-07-23 23:16:19 -0700 I wish we were keeping track of which files passed etc. Instead of fixing all of these manually, it seems it would be more useful to add style checking to something like svn-create-patch or bugzilla-tool post-diff. Then these files would just fix themselves over time. :) 134406 4 abarth 2009-07-23 23:57:03 -0700 Will land. 134429 5 abarth 2009-07-24 00:44:19 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/Chrome.cpp Committed r46329 M WebCore/ChangeLog M WebCore/page/Chrome.cpp r46329 = 97cc408e67e652b3d485b722dd0bc8c6a4f4a4ea (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46329 33340 2009-07-23 09:44:49 -0700 2009-07-23 23:15:36 -0700 Style patch for Chrome.cpp ChromePatch.diff text/plain 6107 mifenton ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjMxMzA2Ni4uODFkMmQ5ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0wNy0yMyAgTWlrZSBGZW50b24g IDxtaWtlLmZlbnRvbkB0b3JjaG1vYmlsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIFdlYkNvcmUvcGFnZS9DaHJvbWUuY3BwIHRv IGNvbmZvcm0gdG8gV2ViS2l0CisgICAgICAgIFN0eWxlIEd1aWRlbGluZXMgYXMgaWRlbnRpZmll ZCBieSBjcHBsaW50LnB5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mjc2MDgKKworICAgICAgICAqIHBhZ2UvQ2hyb21lLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkNocm9tZTo6cnVuQmVmb3JlVW5sb2FkQ29uZmlybVBhbmVsKToKKyAgICAgICAgKFdl YkNvcmU6OkNocm9tZTo6cnVuSmF2YVNjcmlwdEFsZXJ0KToKKyAgICAgICAgKFdlYkNvcmU6OkNo cm9tZTo6cnVuSmF2YVNjcmlwdENvbmZpcm0pOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lOjpy dW5KYXZhU2NyaXB0UHJvbXB0KToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZTo6c2hvdWxkSW50 ZXJydXB0SmF2YVNjcmlwdCk6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWU6OnNldFRvb2xUaXAp OgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lOjpyZXF1ZXN0R2VvbG9jYXRpb25QZXJtaXNzaW9u Rm9yRnJhbWUpOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50OjpnZW5lcmF0ZVJlcGxh Y2VtZW50RmlsZSk6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnQ6OnBhaW50Q3VzdG9t U2Nyb2xsYmFyKToKKwogMjAwOS0wNy0yMyAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBSb3dlLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9w YWdlL0Nocm9tZS5jcHAgYi9XZWJDb3JlL3BhZ2UvQ2hyb21lLmNwcAppbmRleCA2MzI5YWM3Li41 YTU2NzBlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvQ2hyb21lLmNwcAorKysgYi9XZWJDb3Jl L3BhZ2UvQ2hyb21lLmNwcApAQCAtMTE2LDEyICsxMTYsMTIgQEAgRmxvYXRSZWN0IENocm9tZTo6 cGFnZVJlY3QoKSBjb25zdAogewogICAgIHJldHVybiBtX2NsaWVudC0+cGFnZVJlY3QoKTsKIH0K LSAgICAgICAgCisKIGZsb2F0IENocm9tZTo6c2NhbGVGYWN0b3IoKQogewogICAgIHJldHVybiBt X2NsaWVudC0+c2NhbGVGYWN0b3IoKTsKIH0KLSAgICAKKwogdm9pZCBDaHJvbWU6OmZvY3VzKCkg Y29uc3QKIHsKICAgICBtX2NsaWVudC0+Zm9jdXMoKTsKQEAgLTE0MSw3ICsxNDEsNyBAQCB2b2lk IENocm9tZTo6dGFrZUZvY3VzKEZvY3VzRGlyZWN0aW9uIGRpcmVjdGlvbikgY29uc3QKIHsKICAg ICBtX2NsaWVudC0+dGFrZUZvY3VzKGRpcmVjdGlvbik7CiB9Ci0gICAgCisKIFBhZ2UqIENocm9t ZTo6Y3JlYXRlV2luZG93KEZyYW1lKiBmcmFtZSwgY29uc3QgRnJhbWVMb2FkUmVxdWVzdCYgcmVx dWVzdCwgY29uc3QgV2luZG93RmVhdHVyZXMmIGZlYXR1cmVzKSBjb25zdAogewogICAgIFBhZ2Uq IG5ld1BhZ2UgPSBtX2NsaWVudC0+Y3JlYXRlV2luZG93KGZyYW1lLCByZXF1ZXN0LCBmZWF0dXJl cyk7CkBAIC0yMzUsNyArMjM1LDcgQEAgYm9vbCBDaHJvbWU6OmNhblJ1bkJlZm9yZVVubG9hZENv bmZpcm1QYW5lbCgpCiAKIGJvb2wgQ2hyb21lOjpydW5CZWZvcmVVbmxvYWRDb25maXJtUGFuZWwo Y29uc3QgU3RyaW5nJiBtZXNzYWdlLCBGcmFtZSogZnJhbWUpCiB7Ci0gICAgLy8gRGVmZXIgbG9h ZHMgaW4gY2FzZSB0aGUgY2xpZW50IG1ldGhvZCBydW5zIGEgbmV3IGV2ZW50IGxvb3AgdGhhdCB3 b3VsZCAKKyAgICAvLyBEZWZlciBsb2FkcyBpbiBjYXNlIHRoZSBjbGllbnQgbWV0aG9kIHJ1bnMg YSBuZXcgZXZlbnQgbG9vcCB0aGF0IHdvdWxkCiAgICAgLy8gb3RoZXJ3aXNlIGNhdXNlIHRoZSBs b2FkIHRvIGNvbnRpbnVlIHdoaWxlIHdlJ3JlIGluIHRoZSBtaWRkbGUgb2YgZXhlY3V0aW5nIEph dmFTY3JpcHQuCiAgICAgUGFnZUdyb3VwTG9hZERlZmVycmVyIGRlZmVycmVyKG1fcGFnZSwgdHJ1 ZSk7CiAKQEAgLTI0OSw3ICsyNDksNyBAQCB2b2lkIENocm9tZTo6Y2xvc2VXaW5kb3dTb29uKCkK IAogdm9pZCBDaHJvbWU6OnJ1bkphdmFTY3JpcHRBbGVydChGcmFtZSogZnJhbWUsIGNvbnN0IFN0 cmluZyYgbWVzc2FnZSkKIHsKLSAgICAvLyBEZWZlciBsb2FkcyBpbiBjYXNlIHRoZSBjbGllbnQg bWV0aG9kIHJ1bnMgYSBuZXcgZXZlbnQgbG9vcCB0aGF0IHdvdWxkIAorICAgIC8vIERlZmVyIGxv YWRzIGluIGNhc2UgdGhlIGNsaWVudCBtZXRob2QgcnVucyBhIG5ldyBldmVudCBsb29wIHRoYXQg d291bGQKICAgICAvLyBvdGhlcndpc2UgY2F1c2UgdGhlIGxvYWQgdG8gY29udGludWUgd2hpbGUg d2UncmUgaW4gdGhlIG1pZGRsZSBvZiBleGVjdXRpbmcgSmF2YVNjcmlwdC4KICAgICBQYWdlR3Jv dXBMb2FkRGVmZXJyZXIgZGVmZXJyZXIobV9wYWdlLCB0cnVlKTsKIApAQCAtMjU5LDcgKzI1OSw3 IEBAIHZvaWQgQ2hyb21lOjpydW5KYXZhU2NyaXB0QWxlcnQoRnJhbWUqIGZyYW1lLCBjb25zdCBT dHJpbmcmIG1lc3NhZ2UpCiAKIGJvb2wgQ2hyb21lOjpydW5KYXZhU2NyaXB0Q29uZmlybShGcmFt ZSogZnJhbWUsIGNvbnN0IFN0cmluZyYgbWVzc2FnZSkKIHsKLSAgICAvLyBEZWZlciBsb2FkcyBp biBjYXNlIHRoZSBjbGllbnQgbWV0aG9kIHJ1bnMgYSBuZXcgZXZlbnQgbG9vcCB0aGF0IHdvdWxk IAorICAgIC8vIERlZmVyIGxvYWRzIGluIGNhc2UgdGhlIGNsaWVudCBtZXRob2QgcnVucyBhIG5l dyBldmVudCBsb29wIHRoYXQgd291bGQKICAgICAvLyBvdGhlcndpc2UgY2F1c2UgdGhlIGxvYWQg dG8gY29udGludWUgd2hpbGUgd2UncmUgaW4gdGhlIG1pZGRsZSBvZiBleGVjdXRpbmcgSmF2YVNj cmlwdC4KICAgICBQYWdlR3JvdXBMb2FkRGVmZXJyZXIgZGVmZXJyZXIobV9wYWdlLCB0cnVlKTsK IApAQCAtMjY5LDE2ICsyNjksMTYgQEAgYm9vbCBDaHJvbWU6OnJ1bkphdmFTY3JpcHRDb25maXJt KEZyYW1lKiBmcmFtZSwgY29uc3QgU3RyaW5nJiBtZXNzYWdlKQogCiBib29sIENocm9tZTo6cnVu SmF2YVNjcmlwdFByb21wdChGcmFtZSogZnJhbWUsIGNvbnN0IFN0cmluZyYgcHJvbXB0LCBjb25z dCBTdHJpbmcmIGRlZmF1bHRWYWx1ZSwgU3RyaW5nJiByZXN1bHQpCiB7Ci0gICAgLy8gRGVmZXIg bG9hZHMgaW4gY2FzZSB0aGUgY2xpZW50IG1ldGhvZCBydW5zIGEgbmV3IGV2ZW50IGxvb3AgdGhh dCB3b3VsZCAKKyAgICAvLyBEZWZlciBsb2FkcyBpbiBjYXNlIHRoZSBjbGllbnQgbWV0aG9kIHJ1 bnMgYSBuZXcgZXZlbnQgbG9vcCB0aGF0IHdvdWxkCiAgICAgLy8gb3RoZXJ3aXNlIGNhdXNlIHRo ZSBsb2FkIHRvIGNvbnRpbnVlIHdoaWxlIHdlJ3JlIGluIHRoZSBtaWRkbGUgb2YgZXhlY3V0aW5n IEphdmFTY3JpcHQuCiAgICAgUGFnZUdyb3VwTG9hZERlZmVycmVyIGRlZmVycmVyKG1fcGFnZSwg dHJ1ZSk7CiAKICAgICBBU1NFUlQoZnJhbWUpOwogICAgIGJvb2wgb2sgPSBtX2NsaWVudC0+cnVu SmF2YVNjcmlwdFByb21wdChmcmFtZSwgZnJhbWUtPmRpc3BsYXlTdHJpbmdNb2RpZmllZEJ5RW5j b2RpbmcocHJvbXB0KSwgZnJhbWUtPmRpc3BsYXlTdHJpbmdNb2RpZmllZEJ5RW5jb2RpbmcoZGVm YXVsdFZhbHVlKSwgcmVzdWx0KTsKLSAgICAKKwogICAgIGlmIChvaykKICAgICAgICAgcmVzdWx0 ID0gZnJhbWUtPmRpc3BsYXlTdHJpbmdNb2RpZmllZEJ5RW5jb2RpbmcocmVzdWx0KTsKLSAgICAK KwogICAgIHJldHVybiBvazsKIH0KIApAQCAtMjkwLDcgKzI5MCw3IEBAIHZvaWQgQ2hyb21lOjpz ZXRTdGF0dXNiYXJUZXh0KEZyYW1lKiBmcmFtZSwgY29uc3QgU3RyaW5nJiBzdGF0dXMpCiAKIGJv b2wgQ2hyb21lOjpzaG91bGRJbnRlcnJ1cHRKYXZhU2NyaXB0KCkKIHsKLSAgICAvLyBEZWZlciBs b2FkcyBpbiBjYXNlIHRoZSBjbGllbnQgbWV0aG9kIHJ1bnMgYSBuZXcgZXZlbnQgbG9vcCB0aGF0 IHdvdWxkIAorICAgIC8vIERlZmVyIGxvYWRzIGluIGNhc2UgdGhlIGNsaWVudCBtZXRob2QgcnVu cyBhIG5ldyBldmVudCBsb29wIHRoYXQgd291bGQKICAgICAvLyBvdGhlcndpc2UgY2F1c2UgdGhl IGxvYWQgdG8gY29udGludWUgd2hpbGUgd2UncmUgaW4gdGhlIG1pZGRsZSBvZiBleGVjdXRpbmcg SmF2YVNjcmlwdC4KICAgICBQYWdlR3JvdXBMb2FkRGVmZXJyZXIgZGVmZXJyZXIobV9wYWdlLCB0 cnVlKTsKIApAQCAtMzMwLDcgKzMzMCw3IEBAIHZvaWQgQ2hyb21lOjpzZXRUb29sVGlwKGNvbnN0 IEhpdFRlc3RSZXN1bHQmIHJlc3VsdCkKICAgICAgICAgICAgICAgICBpZiAoaW5wdXQtPmlucHV0 VHlwZSgpID09IEhUTUxJbnB1dEVsZW1lbnQ6OlNVQk1JVCkKICAgICAgICAgICAgICAgICAgICAg aWYgKEhUTUxGb3JtRWxlbWVudCogZm9ybSA9IGlucHV0LT5mb3JtKCkpIHsKICAgICAgICAgICAg ICAgICAgICAgICAgIHRvb2xUaXAgPSBmb3JtLT5hY3Rpb24oKTsKLSAgICAgICAgICAgICAgICAg ICAgICAgIGlmIChmb3JtLT5yZW5kZXJlcigpKSAKKyAgICAgICAgICAgICAgICAgICAgICAgIGlm IChmb3JtLT5yZW5kZXJlcigpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRvb2xUaXBE aXJlY3Rpb24gPSBmb3JtLT5yZW5kZXJlcigpLT5zdHlsZSgpLT5kaXJlY3Rpb24oKTsKICAgICAg ICAgICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0b29s VGlwRGlyZWN0aW9uID0gTFRSOwpAQCAtMzc0LDcgKzM3NCw3IEBAIHZvaWQgQ2hyb21lOjpzZXRU b29sVGlwKGNvbnN0IEhpdFRlc3RSZXN1bHQmIHJlc3VsdCkKICAgICAgICAgICAgIH0KICAgICAg ICAgfQogICAgIH0KLSAgICAKKwogICAgIG1fY2xpZW50LT5zZXRUb29sVGlwKHRvb2xUaXAsIHRv b2xUaXBEaXJlY3Rpb24pOwogfQogCkBAIC0zODUsNyArMzg1LDcgQEAgdm9pZCBDaHJvbWU6OnBy aW50KEZyYW1lKiBmcmFtZSkKIAogdm9pZCBDaHJvbWU6OnJlcXVlc3RHZW9sb2NhdGlvblBlcm1p c3Npb25Gb3JGcmFtZShGcmFtZSogZnJhbWUsIEdlb2xvY2F0aW9uKiBnZW9sb2NhdGlvbikKIHsK LSAgICAvLyBEZWZlciBsb2FkcyBpbiBjYXNlIHRoZSBjbGllbnQgbWV0aG9kIHJ1bnMgYSBuZXcg ZXZlbnQgbG9vcCB0aGF0IHdvdWxkIAorICAgIC8vIERlZmVyIGxvYWRzIGluIGNhc2UgdGhlIGNs aWVudCBtZXRob2QgcnVucyBhIG5ldyBldmVudCBsb29wIHRoYXQgd291bGQKICAgICAvLyBvdGhl cndpc2UgY2F1c2UgdGhlIGxvYWQgdG8gY29udGludWUgd2hpbGUgd2UncmUgaW4gdGhlIG1pZGRs ZSBvZiBleGVjdXRpbmcgSmF2YVNjcmlwdC4KICAgICBQYWdlR3JvdXBMb2FkRGVmZXJyZXIgZGVm ZXJyZXIobV9wYWdlLCB0cnVlKTsKIApAQCAtNDMyLDEwICs0MzIsMTAgQEAgYm9vbCBDaHJvbWVD bGllbnQ6OnNob3VsZFJlcGxhY2VXaXRoR2VuZXJhdGVkRmlsZUZvclVwbG9hZChjb25zdCBTdHJp bmcmLCBTdHJpbmcKIFN0cmluZyBDaHJvbWVDbGllbnQ6OmdlbmVyYXRlUmVwbGFjZW1lbnRGaWxl KGNvbnN0IFN0cmluZyYpCiB7CiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJu IFN0cmluZygpOyAKKyAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAKLWJvb2wgQ2hyb21lQ2xpZW50 OjpwYWludEN1c3RvbVNjcm9sbGJhcihHcmFwaGljc0NvbnRleHQqLCBjb25zdCBGbG9hdFJlY3Qm LCBTY3JvbGxiYXJDb250cm9sU2l6ZSwgCitib29sIENocm9tZUNsaWVudDo6cGFpbnRDdXN0b21T Y3JvbGxiYXIoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgRmxvYXRSZWN0JiwgU2Nyb2xsYmFyQ29u dHJvbFNpemUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU2Nyb2xs YmFyQ29udHJvbFN0YXRlLCBTY3JvbGxiYXJQYXJ0LCBib29sLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGZsb2F0LCBmbG9hdCwgU2Nyb2xsYmFyQ29udHJvbFBhcnRN YXNrKQogewo=