27604 2009-07-23 07:58:02 -0700 Enable cpplint for .c files 2009-07-23 09:14:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 jpetsovits webkit-unassigned levin manyoso oldest_to_newest 134098 0 jpetsovits 2009-07-23 07:58:02 -0700 Dave Levin gave ok to relaxing cpplint's filetype filter so that it also does .c files, with Adam Treat stating that it produces reasonable results when testing it on a some of the files. So here it comes! This patch enables cpplint for .c files, and in turn disables the check for NULL occurrences for .c files (and .m files, to be reasonable safe for the future). 134100 1 33329 jpetsovits 2009-07-23 08:03:24 -0700 Created attachment 33329 Enable cpplint for .c files 134112 2 33329 manyoso 2009-07-23 08:55:22 -0700 Comment on attachment 33329 Enable cpplint for .c files Good stuff, although I think we should remove the .cc file ending as that is not used in WebKit to my knowledge. Anyways, another patch. 134119 3 levin 2009-07-23 09:07:57 -0700 Sorry for not mentioning it before, but you may want to also fix this line in check_webkit_style 101 if file_extension in ['.cc', '.cpp', '.h']: 134122 4 manyoso 2009-07-23 09:14:12 -0700 Landed with r46269. 33329 2009-07-23 08:03:24 -0700 2009-07-23 08:55:22 -0700 Enable cpplint for .c files 0001-Enable-cpplint-for-.c-files.patch text/plain 7103 jpetsovits RnJvbSAzOGVhZGRiZmE4MDU3MTMwMjRmOGM1ODY4Y2Q0M2MxYmMyN2EyM2FkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBQZXRzb3ZpdHMgPGpha29iLnBldHNvdml0c0B0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IFRodSwgMjMgSnVsIDIwMDkgMTE6MDE6NTYgLTA0MDAKU3ViamVj dDogW1BBVENIXSBFbmFibGUgY3BwbGludCBmb3IgLmMgZmlsZXMuCgotLS0KIFdlYktpdFRvb2xz L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysKIFdlYktp dFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5ICAgICAgICAgIHwgICAxMCArKysrLS0K IFdlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5IHwgICA0NCAr KysrKysrKysrKysrKystLS0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMoKyks IDE3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dl YktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCAzNGMwNDc4Li40MTIzOTYyIDEwMDY0NAotLS0gYS9X ZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMDktMDctMjMgIEpha29iIFBldHNvdml0cyAgPGpha29iLnBldHNvdml0c0B0 b3JjaG1vYmlsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRW5hYmxlIGNwcGxpbnQgZm9yIC5jIGZpbGVzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc2MDQKKworICAgICAgICBBbHNvIG1ha2Ug c3VyZSB0aGF0IHRoZSBjaGVjayBmb3IgTlVMTCBkb2VzIG5vdCBhcHBseSB0byAuYyBmaWxlcy4K KworICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5OgorICAgICAgICAqIFNjcmlw dHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5OgorCiAyMDA5LTA3LTIyICBTdGV2ZSBGYWxr ZW5idXJnICA8c2ZhbGtlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hlY2twb2ludCBuZXcgV2lu ZG93cyBuaWdodGx5IGxhdW5jaGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9t b2R1bGVzL2NwcGxpbnQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5w eQppbmRleCAxZGY4YTlmLi5lNDRiMmFiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRz L21vZHVsZXMvY3BwbGludC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3Bw bGludC5weQpAQCAtMTk0NSw2ICsxOTQ1LDEwIEBAIGRlZiBjaGVja19mb3JfY29tcGFyaXNvbnNf dG9femVybyhmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAKIAog ZGVmIGNoZWNrX2Zvcl9udWxsKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVy cm9yKToKKyAgICAjIFRoaXMgY2hlY2sgZG9lc24ndCBhcHBseSB0byBDIG9yIE9iamVjdGl2ZS1D IGltcGxlbWVudGF0aW9uIGZpbGVzLgorICAgIGlmIGZpbGVuYW1lLmVuZHN3aXRoKCcuYycpIG9y IGZpbGVuYW1lLmVuZHN3aXRoKCcubScpOgorICAgICAgICByZXR1cm4KKwogICAgIGxpbmUgPSBj bGVhbl9saW5lcy5lbGlkZWRbbGluZV9udW1iZXJdCiAgICAgaWYgc2VhcmNoKHInXGJOVUxMXGIn LCBsaW5lKToKICAgICAgICAgZXJyb3IoZmlsZW5hbWUsIGxpbmVfbnVtYmVyLCAncmVhZGFiaWxp dHkvbnVsbCcsIDUsICdVc2UgMCBpbnN0ZWFkIG9mIE5VTEwuJykKQEAgLTI4MjUsNyArMjgyOSw3 IEBAIGRlZiBwcm9jZXNzX2ZpbGVfZGF0YShmaWxlbmFtZSwgZmlsZV9leHRlbnNpb24sIGxpbmVz LCBlcnJvcik6CiAKIAogZGVmIHByb2Nlc3NfZmlsZShmaWxlbmFtZSwgZXJyb3I9ZXJyb3IpOgot ICAgICIiIkRvZXMgZ29vZ2xlLWxpbnQgb24gYSBzaW5nbGUgZmlsZS4KKyAgICAiIiJQZXJmb3Jt cyBjcHBsaW50IG9uIGEgc2luZ2xlIGZpbGUuCiAKICAgICBBcmdzOgogICAgICAgZmlsZW5hbWU6 IFRoZSBuYW1lIG9mIHRoZSBmaWxlIHRvIHBhcnNlLgpAQCAtMjg2OCw4ICsyODcyLDggQEAgZGVm IHByb2Nlc3NfZmlsZShmaWxlbmFtZSwgZXJyb3I9ZXJyb3IpOgogICAgICMgV2hlbiByZWFkaW5n IGZyb20gc3RkaW4sIHRoZSBleHRlbnNpb24gaXMgdW5rbm93biwgc28gbm8gY3BwbGludCB0ZXN0 cwogICAgICMgc2hvdWxkIHJlbHkgb24gdGhlIGV4dGVuc2lvbi4KICAgICBpZiAoZmlsZW5hbWUg IT0gJy0nIGFuZCBmaWxlX2V4dGVuc2lvbiAhPSAnY2MnIGFuZCBmaWxlX2V4dGVuc2lvbiAhPSAn aCcKLSAgICAgICAgYW5kIGZpbGVfZXh0ZW5zaW9uICE9ICdjcHAnKToKLSAgICAgICAgc3lzLnN0 ZGVyci53cml0ZSgnSWdub3JpbmcgJXM7IG5vdCBhIC5jYyBvciAuaCBmaWxlXG4nICUgZmlsZW5h bWUpCisgICAgICAgIGFuZCBmaWxlX2V4dGVuc2lvbiAhPSAnY3BwJyBhbmQgZmlsZV9leHRlbnNp b24gIT0gJ2MnKToKKyAgICAgICAgc3lzLnN0ZGVyci53cml0ZSgnSWdub3JpbmcgJXM7IG5vdCBh IC5jYywgLmNwcCwgLmMgb3IgLmggZmlsZVxuJyAlIGZpbGVuYW1lKQogICAgIGVsc2U6CiAgICAg ICAgIHByb2Nlc3NfZmlsZV9kYXRhKGZpbGVuYW1lLCBmaWxlX2V4dGVuc2lvbiwgbGluZXMsIGVy cm9yKQogICAgICAgICBpZiBjYXJyaWFnZV9yZXR1cm5fZm91bmQgYW5kIG9zLmxpbmVzZXAgIT0g J1xyXG4nOgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRf dW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVz dC5weQppbmRleCA1ODcwNGU2Li40YmE4ZWQyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3Jp cHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRz L21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weQpAQCAtMTEwLDE1ICsxMTAsMTYgQEAgY2xhc3Mg Q3BwbGludFRlc3RCYXNlKHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAiIiJQcm92aWRlcyBzb21l IHVzZWZ1bCBoZWxwZXIgZnVuY3Rpb25zIGZvciBjcHBsaW50IHRlc3RzLiIiIgogCiAgICAgIyBQ ZXJmb3JtIGxpbnQgb24gc2luZ2xlIGxpbmUgb2YgaW5wdXQgYW5kIHJldHVybiB0aGUgZXJyb3Ig bWVzc2FnZS4KLSAgICBkZWYgcGVyZm9ybV9zaW5nbGVfbGluZV9saW50KHNlbGYsIGNvZGUpOgor ICAgIGRlZiBwZXJmb3JtX3NpbmdsZV9saW5lX2xpbnQoc2VsZiwgY29kZSwgZmlsZV9uYW1lKToK ICAgICAgICAgZXJyb3JfY29sbGVjdG9yID0gRXJyb3JDb2xsZWN0b3Ioc2VsZi5hc3NlcnRfKQog ICAgICAgICBsaW5lcyA9IGNvZGUuc3BsaXQoJ1xuJykKLSAgICAgICAgY3BwbGludC5yZW1vdmVf bXVsdGlfbGluZV9jb21tZW50cygnZm9vLmgnLCBsaW5lcywgZXJyb3JfY29sbGVjdG9yKQorICAg ICAgICBjcHBsaW50LnJlbW92ZV9tdWx0aV9saW5lX2NvbW1lbnRzKGZpbGVfbmFtZSwgbGluZXMs IGVycm9yX2NvbGxlY3RvcikKICAgICAgICAgY2xlYW5fbGluZXMgPSBjcHBsaW50LkNsZWFuc2Vk TGluZXMobGluZXMpCiAgICAgICAgIGluY2x1ZGVfc3RhdGUgPSBjcHBsaW50Ll9JbmNsdWRlU3Rh dGUoKQogICAgICAgICBmdW5jdGlvbl9zdGF0ZSA9IGNwcGxpbnQuX0Z1bmN0aW9uU3RhdGUoKQor ICAgICAgICBleHQgPSBmaWxlX25hbWVbZmlsZV9uYW1lLnJmaW5kKCcuJykgKyAxOl0KICAgICAg ICAgY2xhc3Nfc3RhdGUgPSBjcHBsaW50Ll9DbGFzc1N0YXRlKCkKLSAgICAgICAgY3BwbGludC5w cm9jZXNzX2xpbmUoJ2Zvby5jYycsICdjYycsIGNsZWFuX2xpbmVzLCAwLAorICAgICAgICBjcHBs aW50LnByb2Nlc3NfbGluZShmaWxlX25hbWUsIGV4dCwgY2xlYW5fbGluZXMsIDAsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGluY2x1ZGVfc3RhdGUsIGZ1bmN0aW9uX3N0YXRlLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBjbGFzc19zdGF0ZSwgZXJyb3JfY29sbGVjdG9yKQog ICAgICAgICAjIFNpbmdsZS1saW5lIGxpbnQgdGVzdHMgYXJlIGFsbG93ZWQgdG8gZmFpbCB0aGUg J3VubGludGFibGUgZnVuY3Rpb24nCkBAIC0yMDIsMTEgKzIwMywxMSBAQCBjbGFzcyBDcHBsaW50 VGVzdEJhc2UodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICByZXR1cm4gZXJyb3JfY29sbGVj dG9yLnJlc3VsdHMoKQogCiAgICAgIyBQZXJmb3JtIGxpbnQgYW5kIGNvbXBhcmUgdGhlIGVycm9y IG1lc3NhZ2Ugd2l0aCAiZXhwZWN0ZWRfbWVzc2FnZSIuCi0gICAgZGVmIGFzc2VydF9saW50KHNl bGYsIGNvZGUsIGV4cGVjdGVkX21lc3NhZ2UpOgotICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhl eHBlY3RlZF9tZXNzYWdlLCBzZWxmLnBlcmZvcm1fc2luZ2xlX2xpbmVfbGludChjb2RlKSkKKyAg ICBkZWYgYXNzZXJ0X2xpbnQoc2VsZiwgY29kZSwgZXhwZWN0ZWRfbWVzc2FnZSwgZmlsZV9uYW1l PSdmb28uY2MnKToKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoZXhwZWN0ZWRfbWVzc2FnZSwg c2VsZi5wZXJmb3JtX3NpbmdsZV9saW5lX2xpbnQoY29kZSwgZmlsZV9uYW1lKSkKIAotICAgIGRl ZiBhc3NlcnRfbGludF9vbmVfb2ZfbWFueV9lcnJvcnNfcmUoc2VsZiwgY29kZSwgZXhwZWN0ZWRf bWVzc2FnZV9yZSk6Ci0gICAgICAgIG1lc3NhZ2VzID0gc2VsZi5wZXJmb3JtX3NpbmdsZV9saW5l X2xpbnQoY29kZSkKKyAgICBkZWYgYXNzZXJ0X2xpbnRfb25lX29mX21hbnlfZXJyb3JzX3JlKHNl bGYsIGNvZGUsIGV4cGVjdGVkX21lc3NhZ2VfcmUsIGZpbGVfbmFtZT0nZm9vLmNjJyk6CisgICAg ICAgIG1lc3NhZ2VzID0gc2VsZi5wZXJmb3JtX3NpbmdsZV9saW5lX2xpbnQoY29kZSwgZmlsZV9u YW1lKQogICAgICAgICBmb3IgbWVzc2FnZSBpbiBtZXNzYWdlczoKICAgICAgICAgICAgIGlmIHJl LnNlYXJjaChleHBlY3RlZF9tZXNzYWdlX3JlLCBtZXNzYWdlKToKICAgICAgICAgICAgICAgICBy ZXR1cm4KQEAgLTE4NTQsNyArMTg1NSw3IEBAIGNsYXNzIENwcGxpbnRUZXN0KENwcGxpbnRUZXN0 QmFzZSk6CiAKICAgICBkZWYgYXNzZXJ0X2xpbnRMb2dDb2RlT25FcnJvcihzZWxmLCBjb2RlLCBl eHBlY3RlZF9tZXNzYWdlKToKICAgICAgICAgIyBTcGVjaWFsIGFzc2VydF9saW50IHdoaWNoIGxv Z3MgdGhlIGlucHV0IGNvZGUgb24gZXJyb3IuCi0gICAgICAgIHJlc3VsdCA9IHNlbGYucGVyZm9y bV9zaW5nbGVfbGluZV9saW50KGNvZGUpCisgICAgICAgIHJlc3VsdCA9IHNlbGYucGVyZm9ybV9z aW5nbGVfbGluZV9saW50KGNvZGUsICdmb28uY2MnKQogICAgICAgICBpZiByZXN1bHQgIT0gZXhw ZWN0ZWRfbWVzc2FnZToKICAgICAgICAgICAgIHNlbGYuZmFpbCgnRm9yIGNvZGU6ICIlcyJcbkdv dDogIiVzIlxuRXhwZWN0ZWQ6ICIlcyInCiAgICAgICAgICAgICAgICAgICAgICAgJSAoY29kZSwg cmVzdWx0LCBleHBlY3RlZF9tZXNzYWdlKSkKQEAgLTMxODksMjQgKzMxOTAsMzkgQEAgY2xhc3Mg V2ViS2l0U3R5bGVUZXN0KENwcGxpbnRUZXN0QmFzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xp bnQoCiAgICAgICAgICAgICAnZnVuY3Rpb25DYWxsKE5VTEwpJywKICAgICAgICAgICAgICdVc2Ug MCBpbnN0ZWFkIG9mIE5VTEwuJwotICAgICAgICAgICAgJyAgW3JlYWRhYmlsaXR5L251bGxdIFs1 XScpCisgICAgICAgICAgICAnICBbcmVhZGFiaWxpdHkvbnVsbF0gWzVdJywKKyAgICAgICAgICAg ICdmb28uY3BwJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKICAgICAgICAgICAgICIvLyBE b24ndCB1c2UgTlVMTCBpbiBjb21tZW50cyBzaW5jZSBpdCBpc24ndCBpbiBjb2RlLiIsCiAgICAg ICAgICAgICAnVXNlIDAgaW5zdGVhZCBvZiBOVUxMLicKLSAgICAgICAgICAgICcgIFtyZWFkYWJp bGl0eS9udWxsXSBbNF0nKQorICAgICAgICAgICAgJyAgW3JlYWRhYmlsaXR5L251bGxdIFs0XScs CisgICAgICAgICAgICAnZm9vLmNwcCcpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAg ICAgICAgICAnIkEgc3RyaW5nIHdpdGggTlVMTCIgIC8vIGFuZCBhIGNvbW1lbnQgd2l0aCBOVUxM IGlzIHRyaWNreSB0byBmbGFnIGNvcnJlY3RseSBpbiBjcHBsaW50LicsCiAgICAgICAgICAgICAn VXNlIDAgaW5zdGVhZCBvZiBOVUxMLicKLSAgICAgICAgICAgICcgIFtyZWFkYWJpbGl0eS9udWxs XSBbNF0nKQorICAgICAgICAgICAgJyAgW3JlYWRhYmlsaXR5L251bGxdIFs0XScsCisgICAgICAg ICAgICAnZm9vLmNwcCcpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAgICAgICAgICAn IkEgc3RyaW5nIGNvbnRhaW5pbmcgTlVMTCBpcyBvayInLAotICAgICAgICAgICAgJycpCisgICAg ICAgICAgICAnJywKKyAgICAgICAgICAgICdmb28uY3BwJykKICAgICAgICAgc2VsZi5hc3NlcnRf bGludCgKICAgICAgICAgICAgICdpZiAoYWJvdXROVUxMKScsCi0gICAgICAgICAgICAnJykKKyAg ICAgICAgICAgICcnLAorICAgICAgICAgICAgJ2Zvby5jcHAnKQogICAgICAgICBzZWxmLmFzc2Vy dF9saW50KAogICAgICAgICAgICAgJ215VmFyaWFibGUgPSBOVUxMaWZ5JywKLSAgICAgICAgICAg ICcnKQorICAgICAgICAgICAgJycsCisgICAgICAgICAgICAnZm9vLmNwcCcpCisgICAgICAgICMg TWFrZSBzdXJlIHRoYXQgdGhlIE5VTEwgY2hlY2sgZG9lcyBub3QgYXBwbHkgdG8gQyBhbmQgT2Jq ZWN0aXZlLUMgZmlsZXMuCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAn ZnVuY3Rpb25DYWxsKE5VTEwpJywKKyAgICAgICAgICAgICcnLAorICAgICAgICAgICAgJ2Zvby5j JykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICdmdW5jdGlvbkNhbGwo TlVMTCknLAorICAgICAgICAgICAgJycsCisgICAgICAgICAgICAnZm9vLm0nKQogCiAgICAgICAg ICMgMi4gQysrIGFuZCBDIGJvb2wgdmFsdWVzIHNob3VsZCBiZSB3cml0dGVuIGFzIHRydWUgYW5k CiAgICAgICAgICMgICAgZmFsc2UuIE9iamVjdGl2ZS1DIEJPT0wgdmFsdWVzIHNob3VsZCBiZSB3 cml0dGVuIGFzIFlFUyBhbmQgTk8uCi0tIAoxLjYuMy4zCgo=