27603 2009-07-23 03:04:41 -0700 updating Document.idl to match HTML5 spec: domain read-write and access to getSelection 2010-06-10 18:44:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 UNCONFIRMED P2 Normal --- 0 lkcl webkit-unassigned sam oldest_to_newest 134071 0 lkcl 2009-07-23 03:04:41 -0700 carrying on from discussion in https://bugs.webkit.org/show_bug.cgi?id=27434 comment https://bugs.webkit.org/show_bug.cgi?id=27434#c3 suggests that the domain property be made read-write and that access to getSelection be made universal to all bindings, to match the HTML5 specification. 134072 1 33323 lkcl 2009-07-23 03:17:43 -0700 Created attachment 33323 makes Document.domain read-write and adds Document.getSelection to all bindings, as per HTML5 spec 134133 2 33323 mrowe 2009-07-23 09:50:53 -0700 Comment on attachment 33323 makes Document.domain read-write and adds Document.getSelection to all bindings, as per HTML5 spec > #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT > attribute [ConvertNullToNullString] DOMString domain; > #else > - readonly attribute DOMString domain; > + attribute DOMString domain; > #endif It doesn't seem necessary to have this be #if'd any more. > + // now in HTML5 specification > + DOMSelection getSelection(); The comment doesn't add anything. > +2009-07-22 lkcl <lkcl@lkcl.net> > + > + Reviewed by NOBODY (OOPS!) > + > + https://bugs.webkit.org/show_bug.cgi?id=27603 > + > + https://bugs.webkit.org/show_bug.cgi?id=27434#c3 suggests that the > + domain property be made read-write and that access to getSelection be > + made universal to all bindings, to match the HTML5 specification. > + > + * dom/Document.idl: updated to match HTML spec on domain and getSelection Your ChangeLog entry again contains tabs that will make our pre-commit hook unhappy. 134274 3 lkcl 2009-07-23 15:06:36 -0700 (In reply to comment #2) > (From update of attachment 33323 [details]) > > #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT > > attribute [ConvertNullToNullString] DOMString domain; > > #else > > - readonly attribute DOMString domain; > > + attribute DOMString domain; > > #endif > > It doesn't seem necessary to have this be #if'd any more. ah... oh? oh, what, because the [ConvertNullToNullString] gets ignored by bindings generators that don't need it? oh, ok. great. less code! > > + // now in HTML5 specification > > + DOMSelection getSelection(); > > The comment doesn't add anything. oh, ok. just trying to be helpful. > > +2009-07-22 lkcl <lkcl@lkcl.net> > > + > > + Reviewed by NOBODY (OOPS!) > > + > > + https://bugs.webkit.org/show_bug.cgi?id=27603 > > + > > + https://bugs.webkit.org/show_bug.cgi?id=27434#c3 suggests that the > > + domain property be made read-write and that access to getSelection be > > + made universal to all bindings, to match the HTML5 specification. > > + > > + * dom/Document.idl: updated to match HTML spec on domain and getSelection > > Your ChangeLog entry again contains tabs that will make our pre-commit hook > unhappy. achhh, yes, that's vi messing up (ok - me messing up using vi) sorry. now i know, i've done s/^I/ /g but there may be a couple of entries still with tabs, i'll try to find them. 134279 4 lkcl 2009-07-23 15:14:02 -0700 > > + // now in HTML5 specification > > + DOMSelection getSelection(); > > The comment doesn't add anything. ahh, yes it does. look carefully at the original file, and you can see that getSelection() _used_ to be commented as a "Mozilla Extension". if you remove only the #ifdef, and don't provide a comment, it looks like getSelection() is an IE Extension (not an HTML5ism) because that's the commented-block above it. // IE extensions attribute [ConvertNullStringTo=Undefined, ConvertNullToNullString] DOMString charset; readonly attribute [ConvertNullStringTo=Undefined] DOMString defaultCharset; readonly attribute [ConvertNullStringTo=Undefined] DOMString readyState; Element elementFromPoint(in long x, in long y); // HTML 5 DOMSelection getSelection(); // Mozilla extensions readonly attribute [ConvertNullStringTo=Null] DOMString characterSet; looking _further_ down the Document.idl file, you can see that there is in fact a comment "// HTML 5" already in there: // HTML 5 NodeList getElementsByClassName(in DOMString tagname); so, anticipating that "HTML 5" is acceptable, because it's already _in_ the file, i'm resubmitting a patch which contains the exact same comment "HTML 5". the alternative is to move the function getSelection() to somewhere which would only confuse people. 134286 5 33384 lkcl 2009-07-23 15:17:55 -0700 Created attachment 33384 removes JS-specificism around Document.domain; keeps comment on getSelection to avoid it being confused with IE block of properties, above, but makes comment same as is shown further down in file 137757 6 33384 eric 2009-08-06 20:18:00 -0700 Comment on attachment 33384 removes JS-specificism around Document.domain; keeps comment on getSelection to avoid it being confused with IE block of properties, above, but makes comment same as is shown further down in file I believe getSelection is intentionally avoided for Obj-C bindings, but I"m not sure. Please have an Apple person, like Mark Rowe or Tim Hatcher comment as to if this change is correct or not. 138528 7 33384 eric 2009-08-09 08:54:49 -0700 Comment on attachment 33384 removes JS-specificism around Document.domain; keeps comment on getSelection to avoid it being confused with IE block of properties, above, but makes comment same as is shown further down in file Removing my review. 33323 2009-07-23 03:17:43 -0700 2009-07-23 15:17:55 -0700 makes Document.domain read-write and adds Document.getSelection to all bindings, as per HTML5 spec doc.html5.idl.patch text/plain 1711 lkcl SW5kZXg6IFdlYkNvcmUvZG9tL0RvY3VtZW50LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Rv bS9Eb2N1bWVudC5pZGwJKHJldmlzaW9uIDQ0NDczKQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQu aWRsCSh3b3JraW5nIGNvcHkpCkBAIC0xNTcsNyArMTU3LDcgQEAKICNpZiBkZWZpbmVkKExBTkdV QUdFX0pBVkFTQ1JJUFQpICYmIExBTkdVQUdFX0pBVkFTQ1JJUFQKICAgICAgICAgICAgICAgICAg YXR0cmlidXRlIFtDb252ZXJ0TnVsbFRvTnVsbFN0cmluZ10gRE9NU3RyaW5nIGRvbWFpbjsKICNl bHNlCi0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgZG9tYWluOworICAgICAg ICBhdHRyaWJ1dGUgRE9NU3RyaW5nIGRvbWFpbjsKICNlbmRpZgogICAgICAgICByZWFkb25seSBh dHRyaWJ1dGUgRE9NU3RyaW5nIFVSTDsKIApAQCAtMTkyLDEwICsxOTMsMTEgQEAKIAogICAgICAg ICBFbGVtZW50ICAgICAgICAgICAgZWxlbWVudEZyb21Qb2ludChpbiBsb25nIHgsIGluIGxvbmcg eSk7CiAKKyAgICAgICAgLy8gbm93IGluIEhUTUw1IHNwZWNpZmljYXRpb24KKyAgICAgICAgRE9N U2VsZWN0aW9uICAgICAgIGdldFNlbGVjdGlvbigpOworCiAgICAgICAgIC8vIE1vemlsbGEgZXh0 ZW5zaW9ucwotI2lmIGRlZmluZWQoTEFOR1VBR0VfSkFWQVNDUklQVCkgJiYgTEFOR1VBR0VfSkFW QVNDUklQVAotICAgICAgICBET01TZWxlY3Rpb24gICAgICAgZ2V0U2VsZWN0aW9uKCk7Ci0jZW5k aWYKKwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW0NvbnZlcnROdWxsU3RyaW5nVG89TnVs bF0gRE9NU3RyaW5nIGNoYXJhY3RlclNldDsKIAogICAgICAgICAvLyBXZWJLaXQgZXh0ZW5zaW9u cwpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ0NDczKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTcsNiArMTUsMTggQEAKICAgICAgICAgKiBwbGF0Zm9ybS9xdC9RV2ViUG9wdXAuY3BwOgog ICAgICAgICAqIHBsYXRmb3JtL3RleHQvcXQvVGV4dEJyZWFrSXRlcmF0b3JRdC5jcHA6CiAKKzIw MDktMDctMjIgIGxrY2wgPGxrY2xAbGtjbC5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mjc2MDMKKworCQlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mjc0MzQjYzMgc3VnZ2VzdHMgdGhhdCB0aGUKKwkJZG9tYWluIHByb3BlcnR5IGJlIG1hZGUgcmVh ZC13cml0ZSBhbmQgdGhhdCBhY2Nlc3MgdG8gZ2V0U2VsZWN0aW9uIGJlCisJCW1hZGUgdW5pdmVy c2FsIHRvIGFsbCBiaW5kaW5ncywgdG8gbWF0Y2ggdGhlIEhUTUw1IHNwZWNpZmljYXRpb24uCisK KyAgICAgICAgKiBkb20vRG9jdW1lbnQuaWRsOiB1cGRhdGVkIHRvIG1hdGNoIEhUTUwgc3BlYyBv biBkb21haW4gYW5kIGdldFNlbGVjdGlvbgorCiAyMDA5LTA2LTA1ICBGdW1pdG9zaGkgVWthaSAg PHVrYWlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3Yu Cg== 33384 2009-07-23 15:17:55 -0700 2010-06-10 18:44:34 -0700 removes JS-specificism around Document.domain; keeps comment on getSelection to avoid it being confused with IE block of properties, above, but makes comment same as is shown further down in file doc.html5.idl.patch text/plain 1881 lkcl SW5kZXg6IFdlYkNvcmUvZG9tL0RvY3VtZW50LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Rv bS9Eb2N1bWVudC5pZGwJKHJldmlzaW9uIDQ0NDczKQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQu aWRsCSh3b3JraW5nIGNvcHkpCkBAIC0xNTQsMTEgKzE1NCw3IEBACiAKICAgICAgICAgICAgICAg ICAgYXR0cmlidXRlIFtDb252ZXJ0TnVsbFRvTnVsbFN0cmluZ10gRE9NU3RyaW5nIHRpdGxlOwog ICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIHJlZmVycmVyOwotI2lmIGRlZmlu ZWQoTEFOR1VBR0VfSkFWQVNDUklQVCkgJiYgTEFOR1VBR0VfSkFWQVNDUklQVAogICAgICAgICAg ICAgICAgICBhdHRyaWJ1dGUgW0NvbnZlcnROdWxsVG9OdWxsU3RyaW5nXSBET01TdHJpbmcgZG9t YWluOwotI2Vsc2UKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyBkb21haW47 Ci0jZW5kaWYKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyBVUkw7CiAKICAg ICAgICAgLy8gRklYTUU6IHRoZSBET00gc3BlYyBzdGF0ZXMgdGhhdCB0aGlzIGF0dHJpYnV0ZSBj YW4gCkBAIC0xOTIsMTAgKzE5MywxMSBAQAogCiAgICAgICAgIEVsZW1lbnQgICAgICAgICAgICBl bGVtZW50RnJvbVBvaW50KGluIGxvbmcgeCwgaW4gbG9uZyB5KTsKIAorICAgICAgICAvLyBIVE1M IDUKKyAgICAgICAgRE9NU2VsZWN0aW9uICAgICAgIGdldFNlbGVjdGlvbigpOworCiAgICAgICAg IC8vIE1vemlsbGEgZXh0ZW5zaW9ucwotI2lmIGRlZmluZWQoTEFOR1VBR0VfSkFWQVNDUklQVCkg JiYgTEFOR1VBR0VfSkFWQVNDUklQVAotICAgICAgICBET01TZWxlY3Rpb24gICAgICAgZ2V0U2Vs ZWN0aW9uKCk7Ci0jZW5kaWYKKwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW0NvbnZlcnRO dWxsU3RyaW5nVG89TnVsbF0gRE9NU3RyaW5nIGNoYXJhY3RlclNldDsKIAogICAgICAgICAvLyBX ZWJLaXQgZXh0ZW5zaW9ucwpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ0NDczKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTcsNiArNywxOCBAQAogICAgICAgICAqIHBsYXRmb3JtL3F0L1FX ZWJQb3B1cC5jcHA6CiAgICAgICAgICogcGxhdGZvcm0vdGV4dC9xdC9UZXh0QnJlYWtJdGVyYXRv clF0LmNwcDoKIAorMjAwOS0wNy0yMyAgTHVrZSBLZW5uZXRoIENhc3NvbiBMZWlnaHRvbiA8bGtj bEBsa2NsLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKQorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzYwMworCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzQzNCNjMyBzdWdn ZXN0cyB0aGF0IHRoZQorICAgICAgICBkb21haW4gcHJvcGVydHkgYmUgbWFkZSByZWFkLXdyaXRl IGFuZCB0aGF0IGFjY2VzcyB0byBnZXRTZWxlY3Rpb24gYmUKKyAgICAgICAgbWFkZSB1bml2ZXJz YWwgdG8gYWxsIGJpbmRpbmdzLCB0byBtYXRjaCB0aGUgSFRNTDUgc3BlY2lmaWNhdGlvbi4KKwor ICAgICAgICAqIGRvbS9Eb2N1bWVudC5pZGw6IHVwZGF0ZWQgdG8gbWF0Y2ggSFRNTCBzcGVjIG9u IGRvbWFpbiBhbmQgZ2V0U2VsZWN0aW9uCisKIDIwMDktMDYtMDUgIEZ1bWl0b3NoaSBVa2FpICA8 dWthaUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4K