27602 2009-07-23 02:49:12 -0700 Build fix for x86 platforms 2009-07-24 02:50:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 ossy abarth abarth darin kevino oldest_to_newest 134066 0 ossy 2009-07-23 02:49:12 -0700 If JIT enabled, the original code works. But if JIT disabled and YARR_JIT enabled only, MacroAssembler.h not included in JIT.h because ENABLE(JIT) macro is false, and it causes build fail. 134067 1 33321 ossy 2009-07-23 02:51:45 -0700 Created attachment 33321 proposed patch 134437 2 abarth 2009-07-24 00:59:22 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/jit/JIT.cpp Committed r46334 M JavaScriptCore/jit/JIT.cpp M JavaScriptCore/ChangeLog r46334 = 6a8ef1983c1dbfaebc636ba70a046d28b12b4aab (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46334 134439 3 33321 abarth 2009-07-24 01:06:04 -0700 Comment on attachment 33321 proposed patch This breaks the build. 134441 4 abarth 2009-07-24 01:08:33 -0700 bugzilla requires a comment here. 134464 5 ossy 2009-07-24 02:02:49 -0700 (In reply to comment #3) > This breaks the build. Sorry, it was my fault, because I forgot to delete the last #endif. And during fix it, I found another fix to solve this problem in trunk: http://trac.webkit.org/changeset/46277 I think this fix is not the best solution. You shouldn't include "MacroAssemblerX86Common.h" platform dependent file on all platforms. 134466 6 33414 ossy 2009-07-24 02:10:23 -0700 Created attachment 33414 proposed patch 134471 7 33414 abarth 2009-07-24 02:21:25 -0700 Comment on attachment 33414 proposed patch This looks like a reasonable modification to the first patch. Thanks. 134474 8 abarth 2009-07-24 02:24:11 -0700 I'll try to land this again. 134481 9 abarth 2009-07-24 02:50:44 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/jit/JIT.cpp Committed r46347 M JavaScriptCore/jit/JIT.cpp M JavaScriptCore/ChangeLog r46347 = 61403abcd62556810c09bae95594d7bf1cb41deb (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46347 33321 2009-07-23 02:51:45 -0700 2009-07-24 02:10:23 -0700 proposed patch buildfix.patch text/plain 1458 ossy ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAxZjNjNjE0Li40YTNjMzdkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMDktMDctMjMgIENzYWJhIE9zenRyb2dvbmFjICA8b3N6aUBpbmYudS1zemVnZWQuaHU+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVpbGQg Zml4IGZvciB4ODYgcGxhdGZvcm1zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Mjc2MDIKKworICAgICAgICAqIGppdC9KSVQuY3BwOgorCiAyMDA5LTA3 LTIyICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvaml0 L0pJVC5jcHAgYi9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAppbmRleCAwYTg1OTAyLi45NDg4 YWVkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAorKysgYi9KYXZhU2Ny aXB0Q29yZS9qaXQvSklULmNwcApAQCAtMjYsNiArMjYsMTIgQEAKICNpbmNsdWRlICJjb25maWcu aCIKICNpbmNsdWRlICJKSVQuaCIKIAorLy8gVGhpcyBwcm9iYWJseSBkb2VzIG5vdCBiZWxvbmcg aGVyZTsgYWRkaW5nIGhlcmUgZm9yIG5vdyBhcyBhIHF1aWNrIFdpbmRvd3MgYnVpbGQgZml4Lgor I2lmIEVOQUJMRShBU1NFTUJMRVIpICYmIFBMQVRGT1JNKFg4NikgJiYgIVBMQVRGT1JNKE1BQykK KyNpbmNsdWRlICJNYWNyb0Fzc2VtYmxlci5oIgorSlNDOjpNYWNyb0Fzc2VtYmxlclg4NkNvbW1v bjo6U1NFMkNoZWNrU3RhdGUgSlNDOjpNYWNyb0Fzc2VtYmxlclg4NkNvbW1vbjo6c19zc2UyQ2hl Y2tTdGF0ZSA9IE5vdENoZWNrZWRTU0UyOworI2VuZGlmCisKICNpZiBFTkFCTEUoSklUKQogCiAj aW5jbHVkZSAiQ29kZUJsb2NrLmgiCkBAIC05MzUsMTEgKzk0MSw0IEBAIHZvaWQgSklUOjpsaW5r Q2FsbChKU0Z1bmN0aW9uKiBjYWxsZWUsIENvZGVCbG9jayogY2FsbGVyQ29kZUJsb2NrLCBDb2Rl QmxvY2sqIGNhCiAKICNlbmRpZiAvLyBFTkFCTEUoSklUKQogCi0vLyBUaGlzIHByb2JhYmx5IGRv ZXMgbm90IGJlbG9uZyBoZXJlOyBhZGRpbmcgaGVyZSBmb3Igbm93IGFzIGEgcXVpY2sgV2luZG93 cyBidWlsZCBmaXguCi0jaWYgRU5BQkxFKEFTU0VNQkxFUikKLQotI2lmIFBMQVRGT1JNKFg4Nikg JiYgIVBMQVRGT1JNKE1BQykKLUpTQzo6TWFjcm9Bc3NlbWJsZXJYODZDb21tb246OlNTRTJDaGVj a1N0YXRlIEpTQzo6TWFjcm9Bc3NlbWJsZXJYODZDb21tb246OnNfc3NlMkNoZWNrU3RhdGUgPSBO b3RDaGVja2VkU1NFMjsKLSNlbmRpZgotCiAjZW5kaWYK 33414 2009-07-24 02:10:23 -0700 2009-07-24 02:21:25 -0700 proposed patch buildfix2.patch text/plain 1504 ossy ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA4ZWQ2ZDg5Li45Yzc2Nzk5IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMDktMDctMjQgIENzYWJhIE9zenRyb2dvbmFjICA8b3N6aUBpbmYudS1zemVnZWQuaHU+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVpbGQg Zml4IGZvciB4ODYgcGxhdGZvcm1zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Mjc2MDIKKworICAgICAgICAqIGppdC9KSVQuY3BwOgorCiAyMDA5LTA3 LTIzICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAg IHd4IGJ1aWxkIGZpeCwgYWRkaW5nIG1pc3NpbmcgaGVhZGVyLgpkaWZmIC0tZ2l0IGEvSmF2YVNj cmlwdENvcmUvaml0L0pJVC5jcHAgYi9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAppbmRleCAw MGQxZDcyLi5jMDQ5ZThiIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAor KysgYi9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcApAQCAtMjYsNyArMjYsMTEgQEAKICNpbmNs dWRlICJjb25maWcuaCIKICNpbmNsdWRlICJKSVQuaCIKIAotI2luY2x1ZGUgIk1hY3JvQXNzZW1i bGVyWDg2Q29tbW9uLmgiCisvLyBUaGlzIHByb2JhYmx5IGRvZXMgbm90IGJlbG9uZyBoZXJlOyBh ZGRpbmcgaGVyZSBmb3Igbm93IGFzIGEgcXVpY2sgV2luZG93cyBidWlsZCBmaXguCisjaWYgRU5B QkxFKEFTU0VNQkxFUikgJiYgUExBVEZPUk0oWDg2KSAmJiAhUExBVEZPUk0oTUFDKQorI2luY2x1 ZGUgIk1hY3JvQXNzZW1ibGVyLmgiCitKU0M6Ok1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjpTU0Uy Q2hlY2tTdGF0ZSBKU0M6Ok1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjpzX3NzZTJDaGVja1N0YXRl ID0gTm90Q2hlY2tlZFNTRTI7CisjZW5kaWYKIAogI2lmIEVOQUJMRShKSVQpCiAKQEAgLTkzNiwx MiArOTQwLDMgQEAgdm9pZCBKSVQ6OmxpbmtDYWxsKEpTRnVuY3Rpb24qIGNhbGxlZSwgQ29kZUJs b2NrKiBjYWxsZXJDb2RlQmxvY2ssIENvZGVCbG9jayogY2EKIH0gLy8gbmFtZXNwYWNlIEpTQwog CiAjZW5kaWYgLy8gRU5BQkxFKEpJVCkKLQotLy8gVGhpcyBwcm9iYWJseSBkb2VzIG5vdCBiZWxv bmcgaGVyZTsgYWRkaW5nIGhlcmUgZm9yIG5vdyBhcyBhIHF1aWNrIFdpbmRvd3MgYnVpbGQgZml4 LgotI2lmIEVOQUJMRShBU1NFTUJMRVIpCi0KLSNpZiBQTEFURk9STShYODYpICYmICFQTEFURk9S TShNQUMpCi1KU0M6Ok1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjpTU0UyQ2hlY2tTdGF0ZSBKU0M6 Ok1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjpzX3NzZTJDaGVja1N0YXRlID0gTm90Q2hlY2tlZFNT RTI7Ci0jZW5kaWYKLQotI2VuZGlmCg==