27599 2009-07-23 00:23:17 -0700 'const unsigned' in return value 2009-07-23 01:01:44 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned oldest_to_newest 134050 0 xan.lopez 2009-07-23 00:23:17 -0700 r46179 (bug #27387) added the ErrorEvent.h file, with a method 'lineno' declared as: const unsigned lineno() const { return m_lineNumber; } The 'const unsigned' value was (probably) a copy&paste mistake, since it does not really make any sense. Patch to fix this attached. 134051 1 33319 xan.lopez 2009-07-23 00:25:15 -0700 Created attachment 33319 linenoconst.patch Remove 'const' modifier. 134058 2 33319 mrowe 2009-07-23 00:58:35 -0700 Comment on attachment 33319 linenoconst.patch r=me 134059 3 xan.lopez 2009-07-23 01:01:44 -0700 Landed as r46260, closing. 33319 2009-07-23 00:25:15 -0700 2009-07-23 00:58:34 -0700 linenoconst.patch linenoconst.patch text/plain 1642 xan.lopez RnJvbSA4OTkyYWZjZjZkM2YwM2E3ZGY5NDg5OTc1OWJmMjM2Y2JkZWMwNWZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBU aHUsIDIzIEp1bCAyMDA5IDEwOjIzOjU2ICswMzAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wNy0y MyAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mjc1OTkKICAgICAgICAnY29uc3QgdW5zaWduZWQnIGluIHJldHVybiB2YWx1ZQoKICAg ICAgICBSZW1vdmUgY29uc3QgbW9kaWZpZXIgZnJvbSB1bnNpZ25lZCByZXR1cm4gdmFsdWUsIGFz IGl0IGRvZXMgbm90CiAgICAgICAgbWFrZSBzZW5zZS4KCiAgICAgICAgKiBkb20vRXJyb3JFdmVu dC5oOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiBX ZWJDb3JlL2RvbS9FcnJvckV2ZW50LmggfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwOWIxNWE2Li5jM2ZiMmEyIDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDA5LTA3LTIzICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc1OTkKKyAgICAgICAgJ2NvbnN0IHVuc2lnbmVkJyBp biByZXR1cm4gdmFsdWUKKworICAgICAgICBSZW1vdmUgY29uc3QgbW9kaWZpZXIgZnJvbSB1bnNp Z25lZCByZXR1cm4gdmFsdWUsIGFzIGl0IGRvZXMgbm90CisgICAgICAgIG1ha2Ugc2Vuc2UuCisK KyAgICAgICAgKiBkb20vRXJyb3JFdmVudC5oOgorCiAyMDA5LTA3LTIyICBBZGFtIEJhcnRoICA8 YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9FcnJvckV2ZW50LmggYi9XZWJDb3JlL2RvbS9FcnJvckV2 ZW50LmgKaW5kZXggYmQzOGQxYS4uZjgxNTMwYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vRXJy b3JFdmVudC5oCisrKyBiL1dlYkNvcmUvZG9tL0Vycm9yRXZlbnQuaApAQCAtNTQsNyArNTQsNyBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgY29uc3QgU3RyaW5nJiBtZXNzYWdlKCkg Y29uc3QgeyByZXR1cm4gbV9tZXNzYWdlOyB9CiAgICAgICAgIGNvbnN0IFN0cmluZyYgZmlsZW5h bWUoKSBjb25zdCB7IHJldHVybiBtX2ZpbGVOYW1lOyB9Ci0gICAgICAgIGNvbnN0IHVuc2lnbmVk IGxpbmVubygpIGNvbnN0IHsgcmV0dXJuIG1fbGluZU51bWJlcjsgfQorICAgICAgICB1bnNpZ25l ZCBsaW5lbm8oKSBjb25zdCB7IHJldHVybiBtX2xpbmVOdW1iZXI7IH0KIAogICAgICAgICB2aXJ0 dWFsIGJvb2wgaXNFcnJvckV2ZW50KCkgY29uc3Q7CiAKLS0gCjEuNi4zLjMKCg==