27597 2009-07-22 23:07:52 -0700 [V8] Make Node wrappers go fast 2009-07-22 23:33:05 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned ager antonm dglazkov mbelshe oldest_to_newest 134033 0 abarth 2009-07-22 23:07:52 -0700 As requested by Anton, we should make the Node wrappers go fast (as in the opposite of slow). 134035 1 33315 abarth 2009-07-22 23:10:31 -0700 Created attachment 33315 patch 134036 2 33315 levin 2009-07-22 23:17:23 -0700 Comment on attachment 33315 patch Without the "// static" comment, please :) 134041 3 abarth 2009-07-22 23:33:05 -0700 Sending WebCore/ChangeLog Sending WebCore/bindings/v8/V8DOMMap.cpp Transmitting file data .. Committed revision 46255. http://trac.webkit.org/changeset/46255 33315 2009-07-22 23:10:31 -0700 2009-07-22 23:17:23 -0700 patch bug-27597-20090722231030.patch text/plain 2700 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjI1NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMDktMDctMjIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbVjhd IE1ha2UgTm9kZSB3cmFwcGVycyBnbyBmYXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yNzU5NworCisgICAgICAgIFByb2ZpbGVzIGluZGljYXRlIHdl J3JlIHNwZW5kaW5nIGEgbG90IG9mIHRpbWUgYXNraW5nIHdoZXRoZXIgd2UncmUgb24KKyAgICAg ICAgdGhlIG1haW4gdGhyZWFkIHdoZW4gbG9va2luZyB1cCBET00gd3JhcHBlcnMgZm9yIE5vZGVz LCBidXQgdGhlcmUgaXNuJ3QKKyAgICAgICAgbXVjaCBwb2ludCBpbiBkb2luZyB0aGF0IHdvcmsg YmVjYXVzZSBOb2RlcyBvbmx5IGV4aXN0IG9uIHRoZSBtYWluCisgICAgICAgIHRocmVhZC4gIEkn dmUgYWxzbyBhZGRlZCBhbiBhc3NlcnQgdG8ga2VlcCB1cyBob25lc3QgaW4gdGhpcyByZWdhcmQu CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTU1hcC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjopOgorICAgICAgICAoV2ViQ29yZTo6Z2V0RE9NTm9kZU1hcCk6CisgICAgICAgIChXZWJDb3Jl OjpET01EYXRhOjpnZXRDdXJyZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkRPTURhdGE6OmdldEN1 cnJlbnRNYWluVGhyZWFkKToKKwogMjAwOS0wNy0yMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4 OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NTWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NTWFwLmNwcAkocmV2aXNpb24gNDYyMzUpCisrKyBXZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4RE9NTWFwLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjk3LDYgKzI5Nyw3IEBA IHB1YmxpYzoKICAgICB9CiAKICAgICBzdGF0aWMgRE9NRGF0YSogZ2V0Q3VycmVudCgpOworICAg IHN0YXRpYyBET01EYXRhKiBnZXRDdXJyZW50TWFpblRocmVhZCgpOyAvLyBDYWxsZXIgbXVzdCBi ZSBvbiB0aGUgbWFpbiB0aHJlYWQuCiAgICAgdmlydHVhbCBET01EYXRhU3RvcmUmIGdldFN0b3Jl KCkgPSAwOwogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4KQEAgLTQwMSw3ICs0MDIsOCBAQCB2 b2lkIERPTURhdGFTdG9yZTo6SW50ZXJuYWxET01XcmFwcGVyTWFwCiAKIERPTVdyYXBwZXJNYXA8 Tm9kZT4mIGdldERPTU5vZGVNYXAoKQogewotICAgIHJldHVybiBET01EYXRhOjpnZXRDdXJyZW50 KCktPmdldFN0b3JlKCkuZG9tTm9kZU1hcCgpOworICAgIC8vIE5vZGVzIG9ubHkgZXhpc3Qgb24g dGhlIG1haW4gdGhyZWFkLgorICAgIHJldHVybiBET01EYXRhOjpnZXRDdXJyZW50TWFpblRocmVh ZCgpLT5nZXRTdG9yZSgpLmRvbU5vZGVNYXAoKTsKIH0KIAogRE9NV3JhcHBlck1hcDx2b2lkPiYg Z2V0RE9NT2JqZWN0TWFwKCkKQEAgLTQzMiwxNCArNDM0LDIxIEBAIERPTVdyYXBwZXJNYXA8dm9p ZD4mIGdldERPTVNWR09iamVjdFdpdGgKIC8vIHN0YXRpYwogRE9NRGF0YSogRE9NRGF0YTo6Z2V0 Q3VycmVudCgpCiB7Ci0gICAgaWYgKFdURjo6aXNNYWluVGhyZWFkKCkpIHsKLSAgICAgICAgREVG SU5FX1NUQVRJQ19MT0NBTChNYWluVGhyZWFkRE9NRGF0YSwgbWFpblRocmVhZERPTURhdGEsICgp KTsKLSAgICAgICAgcmV0dXJuICZtYWluVGhyZWFkRE9NRGF0YTsKLSAgICB9CisgICAgaWYgKFdU Rjo6aXNNYWluVGhyZWFkKCkpCisgICAgICAgIHJldHVybiBnZXRDdXJyZW50TWFpblRocmVhZCgp OworCiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChXVEY6OlRocmVhZFNwZWNpZmljPENoaWxkVGhy ZWFkRE9NRGF0YT4sIGNoaWxkVGhyZWFkRE9NRGF0YSwgKCkpOwogICAgIHJldHVybiBjaGlsZFRo cmVhZERPTURhdGE7CiB9CiAKKy8vIHN0YXRpYworRE9NRGF0YSogRE9NRGF0YTo6Z2V0Q3VycmVu dE1haW5UaHJlYWQoKQoreworICAgIEFTU0VSVChXVEY6OmlzTWFpblRocmVhZCgpKTsKKyAgICBE RUZJTkVfU1RBVElDX0xPQ0FMKE1haW5UaHJlYWRET01EYXRhLCBtYWluVGhyZWFkRE9NRGF0YSwg KCkpOworICAgIHJldHVybiAmbWFpblRocmVhZERPTURhdGE7Cit9CisKIC8vIENhbGxlZCB3aGVu IHRoZSBkZWFkIG9iamVjdCBpcyBub3QgaW4gR0MgdGhyZWFkJ3MgbWFwLiBHbyB0aHJvdWdoIGFs bCB0aHJlYWQgbWFwcyB0byBmaW5kIHRoZSBvbmUgY29udGFpbmluZyBpdC4KIC8vIFRoZW4gY2xl YXIgdGhlIEpTIHJlZmVyZW5jZSBhbmQgcHVzaCB0aGUgRE9NIG9iamVjdCBpbnRvIHRoZSBkZWxh eWVkIHF1ZXVlIGZvciBpdCB0byBiZSBkZXJlZi1lZCBhdCBsYXRlciB0aW1lIGZyb20gdGhlIG93 bmluZyB0aHJlYWQuCiAvLyAqIFRoaXMgaXMgY2FsbGVkIHdoZW4gdGhlIEdDIHRocmVhZCBpcyBu b3QgdGhlIG93bmluZyB0aHJlYWQu