<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>275923</bug_id>
          
          <creation_ts>2024-06-26 15:09:32 -0700</creation_ts>
          <short_desc>Remove Quirk shouldDisableWritingSuggestionsByDefault once Gmail adopts the &apos;writingsuggestions&apos; attribute.</short_desc>
          <delta_ts>2024-10-28 12:12:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>HTML Editing</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>https://mail.google.com/</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>GoodFirstBug, InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>275917</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Lily Spiniolas">lily_spiniolas</reporter>
          <assigned_to name="Lily Spiniolas">lily_spiniolas</assigned_to>
          <cc>karlcow</cc>
    
    <cc>ntim</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2043288</commentid>
    <comment_count>0</comment_count>
    <who name="Lily Spiniolas">lily_spiniolas</who>
    <bug_when>2024-06-26 15:09:32 -0700</bug_when>
    <thetext>rdar://130624461</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2044560</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-07-03 15:10:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/131079979&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2044595</commentid>
    <comment_count>2</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2024-07-03 16:34:34 -0700</bug_when>
    <thetext>rdar://130624461</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2054311</commentid>
    <comment_count>3</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2024-08-20 19:43:09 -0700</bug_when>
    <thetext>1. Open Safari
2. Develop → Developer Settings… → Compatibility: Disable Site Specific hacks
3. Go to the website mail.google.com 
4. Create a new mail
5. Write text.

Does it work?

if yes, we can remove the Quirk
it means Google is using &apos;writingsuggestions&apos; attribute.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2054329</commentid>
    <comment_count>4</comment_count>
    <who name="Lily Spiniolas">lily_spiniolas</who>
    <bug_when>2024-08-20 21:17:05 -0700</bug_when>
    <thetext>It looks like the &apos;writingsuggestions&apos; attribute has indeed been adopted. Thank you Karl!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2054330</commentid>
    <comment_count>5</comment_count>
    <who name="Lily Spiniolas">lily_spiniolas</who>
    <bug_when>2024-08-20 21:19:34 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/32507</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2054331</commentid>
    <comment_count>6</comment_count>
    <who name="Lily Spiniolas">lily_spiniolas</who>
    <bug_when>2024-08-20 21:38:15 -0700</bug_when>
    <thetext>I was incorrect- the attribute has not been adopted.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2070973</commentid>
    <comment_count>7</comment_count>
    <who name="Lily Spiniolas">lily_spiniolas</who>
    <bug_when>2024-10-28 11:16:43 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/35802</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2070999</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-10-28 12:12:32 -0700</bug_when>
    <thetext>Committed 285779@main (7729bfb61789): &lt;https://commits.webkit.org/285779@main&gt;

Reviewed commits have been landed. Closing PR #35802 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>