27586 2009-07-22 16:44:35 -0700 URL appears in back/forward button menu instead of title for items with custom representation 2009-07-23 17:11:32 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 darin darin oldest_to_newest 133985 0 darin 2009-07-22 16:44:35 -0700 To reproduce: 1. visit bookmarks 2. visit some other page 3. press and hold on the Back button in the location field The menu contains "bookmarks:". It should contain "Bookmarks". The history code expects that the DocumentLoader will store a copy of the title. This is subtly incompatible with having a title method on the representation -- we can ask what the title is, but we won't know when the title changes so we won't be able to update the title in the DocumentLoader. Here are some ways to fix this: 1) change the history item code to call via the client to get the title, so it can pass through the representation object in Mac WebKit 2) have the WebDataSource call setTitle on the DocumentLoader, passing the current title from the representation, exactly once, after the representation gets its setDataSource: call 3) same as (2), but after every method call from WebDataSource to the representation 4) change the representation API so there's a setTitle: method on WebDataSource instead of a title method on the representation I am planning to do (2) largely because we want to phase out this representation feature anyway. 133986 1 darin 2009-07-22 16:44:45 -0700 <rdar://problem/5060337> 133987 2 33307 darin 2009-07-22 16:49:02 -0700 Created attachment 33307 patch 133997 3 33307 beidson 2009-07-22 18:14:12 -0700 Comment on attachment 33307 patch Nice! 134316 4 darin 2009-07-23 17:11:32 -0700 http://trac.webkit.org/changeset/46298 http://trac.webkit.org/changeset/46300 33307 2009-07-22 16:49:02 -0700 2009-07-22 18:14:12 -0700 patch TitlePatch.txt text/plain 3999 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjI1MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDctMjIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVSTCBh cHBlYXJzIGluIGJhY2svZm9yd2FyZCBidXR0b24gbWVudSBpbnN0ZWFkIG9mIHRpdGxlIGZvciBp dGVtcyB3aXRoIGN1c3RvbSByZXByZXNlbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc1ODYKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vNTA2 MDMzNworCisgICAgICAgICogV2ViQ29yZS5iYXNlLmV4cDogRXhwb3J0ZWQgRG9jdW1lbnRMb2Fk ZXI6OnNldFRpdGxlIGZvciB1c2UgYnkgTWFjIFdlYktpdC4KKyAgICAgICAgKiBsb2FkZXIvRnJh bWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmRpZENoYW5nZVRp dGxlKTogVGlnaHRlbmVkIGNvZGUgdG8gY2hlY2sgaWYgdGhlIGRvY3VtZW50CisgICAgICAgIGxv YWRlciBpcyB0aGUgY29ycmVjdCBvbmU7IHByZXZpb3VzbHkgdGhpcyB3b3VsZCBuZXZlciBoYXBw ZW4gYmVjYXVzZSB3ZSdkCisgICAgICAgIGNvbW1pdCB0aGUgbG9hZCBiZWZvcmUgYW55IHRpdGxl IGNoYW5nZXMgY291bGQgYmUgcmVnaXN0ZXJlZCwgYnV0IG5vdyB3ZSBjYW4KKyAgICAgICAgZW5j b3VudGVyIGEgY2FzZSB3aGVyZSB3ZSBnZXQgYSB0aXRsZSBkdXJpbmcgYSBwcm92aXNpb25hbCBs b2FkLgorCiAyMDA5LTA3LTIyICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAaW50dWRhdGEuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUu YmFzZS5leHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLmJhc2UuZXhwCShyZXZpc2lv biA0NjI1MCkKKysrIFdlYkNvcmUvV2ViQ29yZS5iYXNlLmV4cAkod29ya2luZyBjb3B5KQpAQCAt Mjk4LDYgKzI5OCw3IEBAIF9fWk43V2ViQ29yZTE0RG9jdW1lbnRMb2FkZXIyNHJlbW92ZVBsdWcK IF9fWk43V2ViQ29yZTE0RG9jdW1lbnRMb2FkZXIzMnJlcGxhY2VSZXF1ZXN0VVJMRm9yQW5jaG9y U2Nyb2xsRVJLTlNfNEtVUkxFCiBfX1pON1dlYkNvcmUxNERvY3VtZW50TG9hZGVyN3JlcXVlc3RF dgogX19aTjdXZWJDb3JlMTREb2N1bWVudExvYWRlcjhzZXRGcmFtZUVQTlNfNUZyYW1lRQorX19a TjdXZWJDb3JlMTREb2N1bWVudExvYWRlcjhzZXRUaXRsZUVSS05TXzZTdHJpbmdFCiBfX1pON1dl YkNvcmUxNERvY3VtZW50TG9hZGVyQzJFUktOU18xNVJlc291cmNlUmVxdWVzdEVSS05TXzE0U3Vi c3RpdHV0ZURhdGFFCiBfX1pON1dlYkNvcmUxNERvY3VtZW50TG9hZGVyRDJFdgogX19aTjdXZWJD b3JlMTREcmFnQ29udHJvbGxlcjEwZHJhZ0V4aXRlZEVQTlNfOERyYWdEYXRhRQpJbmRleDogV2Vi Q29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVy L0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gNDYyNTApCisrKyBXZWJDb3JlL2xvYWRlci9GcmFt ZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUwOTQsOCArNTA5NCw3IEBAIHZvaWQgRnJh bWVMb2FkZXI6OmRpZENoYW5nZVRpdGxlKERvY3VtZW4KIHsKICAgICBtX2NsaWVudC0+ZGlkQ2hh bmdlVGl0bGUobG9hZGVyKTsKIAotICAgIC8vIFRoZSB0aXRsZSBkb2Vzbid0IGdldCBjb21tdW5p Y2F0ZWQgdG8gdGhlIFdlYlZpZXcgdW50aWwgd2UgYXJlIGNvbW1pdHRlZC4KLSAgICBpZiAobG9h ZGVyLT5pc0NvbW1pdHRlZCgpKSB7CisgICAgaWYgKGxvYWRlciA9PSBtX2RvY3VtZW50TG9hZGVy KSB7CiAgICAgICAgIC8vIE11c3QgdXBkYXRlIHRoZSBlbnRyaWVzIGluIHRoZSBiYWNrLWZvcndh cmQgbGlzdCB0b28uCiAgICAgICAgIGlmIChtX2N1cnJlbnRIaXN0b3J5SXRlbSkKICAgICAgICAg ICAgIG1fY3VycmVudEhpc3RvcnlJdGVtLT5zZXRUaXRsZShsb2FkZXItPnRpdGxlKCkpOwpJbmRl eDogV2ViS2l0L21hYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ2MjUwKQorKysgV2ViS2l0L21hYy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wNy0yMiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VVJMIGFwcGVhcnMgaW4gYmFjay9mb3J3YXJkIGJ1dHRvbiBtZW51IGluc3RlYWQgb2YgdGl0bGUg Zm9yIGl0ZW1zIHdpdGggY3VzdG9tIHJlcHJlc2VudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzU4NgorICAgICAgICByZGFyOi8vcHJvYmxl bS81MDYwMzM3CisKKyAgICAgICAgVGhlIHByb2JsZW0gaXMgdGhhdCBEb2N1bWVudExvYWRlciBl eHBlY3RzIHRvIHN0b3JlIGEgdGl0bGUsIGJ1dCBmb3IgY3VzdG9tIHJlcHJlc2VudGF0aW9ucwor ICAgICAgICBpdCBpcyBuZXZlciBwYXNzZWQgdG8gdGhlIGRvY3VtZW50IGxvYWRlci4KKworICAg ICAgICAqIFdlYlZpZXcvV2ViRGF0YVNvdXJjZS5tbToKKyAgICAgICAgKC1bV2ViRGF0YVNvdXJj ZSBfbWFrZVJlcHJlc2VudGF0aW9uXSk6IEFkZGVkIGEgY2FsbCB0byBEb2N1bWVudExvYWRlcjo6 c2V0VGl0bGUuCisgICAgICAgIFdvcmtzIGFzIGxvbmcgYXMgdGhlIHRpdGxlIGRvZXMgbm90IGNo YW5nZSBkdXJpbmcgdGhlIGRvY3VtZW50J3MgbGlmZXRpbWUsIHdoaWNoCisgICAgICAgIGlzIGdv b2QgZW5vdWdoIGZvciB0aGUgc2ltcGxlIGNhc2VzIGluIFNhZmFyaS4KKwogMjAwOS0wNy0yMCAg RGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFu IEJlcm5zdGVpbi4KSW5kZXg6IFdlYktpdC9tYWMvV2ViVmlldy9XZWJEYXRhU291cmNlLm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC9tYWMvV2ViVmlldy9XZWJEYXRhU291cmNlLm1tCShyZXZpc2lv biA0NjI1MCkKKysrIFdlYktpdC9tYWMvV2ViVmlldy9XZWJEYXRhU291cmNlLm1tCSh3b3JraW5n IGNvcHkpCkBAIC0zNDIsNyArMzQyLDcgQEAgc3RhdGljIGlubGluZSB2b2lkIGFkZFR5cGVzRnJv bUNsYXNzKE5TTQogICAgIHJldHVybiBbV2ViVmlldyBjYW5TaG93TUlNRVR5cGVBc0hUTUw6TUlN RVR5cGVdOwogfQogCi0tKHZvaWQpX21ha2VSZXByZXNlbnRhdGlvbgorLSAodm9pZClfbWFrZVJl cHJlc2VudGF0aW9uCiB7CiAgICAgQ2xhc3MgcmVwQ2xhc3MgPSBbW3NlbGYgY2xhc3NdIF9yZXBy ZXNlbnRhdGlvbkNsYXNzRm9yTUlNRVR5cGU6W3NlbGYgX3Jlc3BvbnNlTUlNRVR5cGVdXTsKICAg ICAKQEAgLTM1NCw2ICszNTQsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgYWRkVHlwZXNGcm9tQ2xh c3MoTlNNCiAgICAgfQogICAgIAogICAgIFtfcHJpdmF0ZS0+cmVwcmVzZW50YXRpb24gc2V0RGF0 YVNvdXJjZTpzZWxmXTsKKyAgICBfcHJpdmF0ZS0+bG9hZGVyLT5zZXRUaXRsZShbX3ByaXZhdGUt PnJlcHJlc2VudGF0aW9uIHRpdGxlXSk7CiB9CiAKIC0gKERvY3VtZW50TG9hZGVyKilfZG9jdW1l bnRMb2FkZXIK