275657 2024-06-19 01:03:46 -0700 [GStreamer] Error building with libwebrtc enabled with gstreamer 1.18 2024-06-21 05:20:37 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez philn bugs-noreply philn oldest_to_newest 2042072 0 magomez 2024-06-19 01:03:46 -0700 According to the GStreamer checks, the required GStreamer version is 1.18.4 (with 1.20 for USE_GSTREAMER_WEBRTC, ENABLE_MEDIA_RECORDER and USE_GSTREAMER_TRANSCODER). But the build enabling libwebrtc fails due to the usage of gst_buffer_new_memdup in Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.cpp, which is not available on 1.18. 2042079 1 philn 2024-06-19 01:59:53 -0700 in downstream wpe-2.38 this is fixed by commit 5f7400aee390ab9d964a0f2ede34f2008e75eaf8 2042080 2 magomez 2024-06-19 02:07:04 -0700 (In reply to Philippe Normand from comment #1) > in downstream wpe-2.38 this is fixed by commit > 5f7400aee390ab9d964a0f2ede34f2008e75eaf8 Shouldn't this upstreamed? Or are we keeping this downstream? 2042100 3 philn 2024-06-19 05:06:02 -0700 It's fine to upstream... Wasn't needed until now because the SDK ships a recent version, and I suppose you're not using it. 2042104 4 philn 2024-06-19 05:20:40 -0700 Pull request: https://github.com/WebKit/WebKit/pull/29979 2042424 5 ews-feeder 2024-06-21 05:20:34 -0700 Committed 280247@main (1b86aba5013c): <https://commits.webkit.org/280247@main> Reviewed commits have been landed. Closing PR #29979 and removing active labels.