<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27563</bug_id>
          
          <creation_ts>2009-07-22 14:27:15 -0700</creation_ts>
          <short_desc>Remove unneeded virtual destructor from ScriptSourceProvider</short_desc>
          <delta_ts>2009-07-22 19:52:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore JavaScript</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>dbates</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>133905</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-07-22 14:27:15 -0700</bug_when>
    <thetext>As requested by ap.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133906</commentid>
    <comment_count>1</comment_count>
      <attachid>33289</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-07-22 14:28:50 -0700</bug_when>
    <thetext>Created attachment 33289
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133975</commentid>
    <comment_count>2</comment_count>
      <attachid>33289</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2009-07-22 16:13:34 -0700</bug_when>
    <thetext>Comment on attachment 33289
patch

I actually liked making it non-inline more, but this class isn&apos;t used all that much for it to matter. r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>134010</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-07-22 19:52:32 -0700</bug_when>
    <thetext>Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/ScriptSourceProvider.h
Committed r46253
	M	LayoutTests/platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
	M	LayoutTests/platform/win/fast/css/getComputedStyle/computed-style-expected.txt
	M	LayoutTests/ChangeLog
r46252 = 885c66aa16b9d888b2fae5e852b8f14f3773fb26 (trunk)
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/ScriptSourceProvider.h
r46253 = 95b02cfaa936edd9f79ab13700bbc2a32819544b (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/46253</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>33289</attachid>
            <date>2009-07-22 14:28:50 -0700</date>
            <delta_ts>2009-07-22 16:13:34 -0700</delta_ts>
            <desc>patch</desc>
            <filename>bug-27563-20090722142849.patch</filename>
            <type>text/plain</type>
            <size>1020</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ODljMzNiNS4uY2I4OTk5NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0wNy0yMiAgQWRhbSBCYXJ0aCAg
PGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIFJlbW92ZSB1bm5lZWRlZCB2aXJ0dWFsIGRlc3RydWN0b3IgZnJvbSBTY3Jp
cHRTb3VyY2VQcm92aWRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9Mjc1NjMKKworICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdFNvdXJjZVByb3Zp
ZGVyLmg6CisKIDIwMDktMDctMjEgIERhbmllbCBCYXRlcyAgPGRiYXRlc0BpbnR1ZGF0YS5jb20+
CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv
YmluZGluZ3MvanMvU2NyaXB0U291cmNlUHJvdmlkZXIuaCBiL1dlYkNvcmUvYmluZGluZ3MvanMv
U2NyaXB0U291cmNlUHJvdmlkZXIuaAppbmRleCA5YWJhZGQyLi4zZmUzNTg0IDEwMDY0NAotLS0g
YS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFNvdXJjZVByb3ZpZGVyLmgKKysrIGIvV2ViQ29y
ZS9iaW5kaW5ncy9qcy9TY3JpcHRTb3VyY2VQcm92aWRlci5oCkBAIC0zOSwxMiArMzksMTAgQEAg
bmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgOiBTb3VyY2VQcm92aWRlcih1cmwsIGhh
c0JPTXMpCiAgICAgICAgIHsKICAgICAgICAgfQotICAgICAgICAKLSAgICAgICAgdmlydHVhbCB+
U2NyaXB0U291cmNlUHJvdmlkZXIoKSB7IH0KLSAgICAgICAgCisKICAgICAgICAgdmlydHVhbCBj
b25zdCBTdHJpbmcmIHNvdXJjZSgpIGNvbnN0ID0gMDsKICAgICB9OwotICAgIAorCiB9IC8vIG5h
bWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBTY3JpcHRTb3VyY2VQcm92aWRlcl9o
</data>
<flag name="review"
          id="17594"
          type_id="1"
          status="+"
          setter="ap"
    />
          </attachment>
      

    </bug>

</bugzilla>