27557 2009-07-22 12:58:56 -0700 Case-insensitive comparison of include file sorting for cpplint 2009-07-22 13:34:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED WONTFIX P2 Normal --- 0 jpetsovits webkit-unassigned darin manyoso mitz staikos oldest_to_newest 133858 0 jpetsovits 2009-07-22 12:58:56 -0700 Quoting my test case: #include "a.h" '#include "B.h" '#include "c.h" That thing currently fails. The fix is straightforward, patch goes below. 133859 1 33284 jpetsovits 2009-07-22 13:01:06 -0700 Created attachment 33284 Case-insensitive comparison of include file order for cpplint 133860 2 33284 darin 2009-07-22 13:02:42 -0700 Comment on attachment 33284 Case-insensitive comparison of include file order for cpplint The order is supposed to be case-sensitive, as if done by the command line "sort" tool. Did someone say it should be case-insensitive? 133862 3 33284 darin 2009-07-22 13:05:01 -0700 Comment on attachment 33284 Case-insensitive comparison of include file order for cpplint Setting to review- for now. I believe the sort is supposed to be case sensitive, but if there is consensus otherwise, then this is a good change to make. 133866 4 manyoso 2009-07-22 13:06:47 -0700 Oops. I committed it already. Should I back out until we find consensus? 133875 5 darin 2009-07-22 13:15:45 -0700 (In reply to comment #4) > Oops. I committed it already. Should I back out until we find consensus? Yes, I think so. I'm almost certain our standard was case-sensitive as done by the "sort" tool, and I believe it would require discussion to change that. 133876 6 jpetsovits 2009-07-22 13:19:45 -0700 Then I'm probably adding a test case to clarify that way of working, right? 133877 7 manyoso 2009-07-22 13:22:46 -0700 Reverted with r46235. Sorry guys. It just doesn't seem very intuitive to me to sort alphabetically with case-sensitivity. But if thems the rules, thems the rules. 133879 8 staikos 2009-07-22 13:31:40 -0700 sort -f? All in all the concept of sorting headers alphabetically as a rule seems like a scary and arbitrary decision, though I'm really not interested in debating it. 133882 9 darin 2009-07-22 13:34:34 -0700 Why do we sort at all? One reason is to make it less likely we will end up with duplicate includes. Another is to ensure we don't get a variety of different "logical" sorting orders invented by different well-meaning programmers in different source files. Case-sensitive vs. case-insensitive is entirely arbitrary, and we chose case-sensitive long ago. I'd be open to considering a change. 33284 2009-07-22 13:01:06 -0700 2009-07-22 13:05:01 -0700 Case-insensitive comparison of include file order for cpplint 0001-Case-insensitive-comparison-of-include-file-order-fo.patch text/plain 2980 jpetsovits RnJvbSBlOTBiYmY3NDVhYzFmZDhiOGIyMmJkNGIxYWZmNGJkNjRiNWY2NDQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBQZXRzb3ZpdHMgPGpha29iLnBldHNvdml0c0B0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IFdlZCwgMjIgSnVsIDIwMDkgMTY6MDA6MzIgLTA0MDAKU3ViamVj dDogW1BBVENIXSBDYXNlLWluc2Vuc2l0aXZlIGNvbXBhcmlzb24gb2YgaW5jbHVkZSBmaWxlIG9y ZGVyIGZvciBjcHBsaW50LgoKLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTAgKysrKysrKysrKwogV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1 bGVzL2NwcGxpbnQucHkgICAgICAgICAgfCAgICAyICstCiBXZWJLaXRUb29scy9TY3JpcHRzL21v ZHVsZXMvY3BwbGludF91bml0dGVzdC5weSB8ICAgIDYgKysrKysrCiAzIGZpbGVzIGNoYW5nZWQs IDE3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDMxYWNlOWEuLmJiNDY2 ZjIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9D aGFuZ2VMb2cKQEAgLTEsNSArMSwxNSBAQAogMjAwOS0wNy0yMiAgSmFrb2IgUGV0c292aXRzICA8 amFrb2IucGV0c292aXRzQHRvcmNobW9iaWxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYXNlLWluc2Vuc2l0aXZlIGNvbXBhcmlzb24gb2Yg aW5jbHVkZSBmaWxlIG9yZGVyIGZvciBjcHBsaW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc1NTcKKworICAgICAgICAqIFNjcmlwdHMvbW9kdWxl cy9jcHBsaW50LnB5OgorICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0 LnB5OgorCisyMDA5LTA3LTIyICBKYWtvYiBQZXRzb3ZpdHMgIDxqYWtvYi5wZXRzb3ZpdHNAdG9y Y2htb2JpbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gVHJlYXQuCiAKICAgICAg ICAgY3BwbGludCBnZW5lcmF0ZXMgZmFsc2UgcG9zaXRpdmVzIGZvciBwcmltYXJ5IGluY2x1ZGVz CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5weSBiL1dl YktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5CmluZGV4IDYwNGUxMjguLjgyMzk5 MjUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5Cisr KyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5CkBAIC0yMjIwLDcgKzIy MjAsNyBAQCBkZWYgY2hlY2tfaW5jbHVkZV9saW5lKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGlu ZV9udW1iZXIsIGluY2x1ZGVfc3RhdGUsIGVycm9yKQogICAgICAgICAgICAgICAgICAgICBwcmV2 aW91c19tYXRjaCA9IF9SRV9QQVRURVJOX0lOQ0xVREUuc2VhcmNoKHByZXZpb3VzX2xpbmUpCiAg ICAgICAgICAgICAgICAgIGlmIHByZXZpb3VzX21hdGNoOgogICAgICAgICAgICAgICAgICAgICBw cmV2aW91c19oZWFkZXJfdHlwZSA9IGluY2x1ZGVfc3RhdGUuaGVhZGVyX3R5cGVzW3ByZXZpb3Vz X2xpbmVfbnVtYmVyXQotICAgICAgICAgICAgICAgICAgICBpZiBwcmV2aW91c19oZWFkZXJfdHlw ZSA9PSBfT1RIRVJfSEVBREVSIGFuZCBwcmV2aW91c19saW5lLnN0cmlwKCkgPiBsaW5lLnN0cmlw KCk6CisgICAgICAgICAgICAgICAgICAgIGlmIHByZXZpb3VzX2hlYWRlcl90eXBlID09IF9PVEhF Ul9IRUFERVIgYW5kIHByZXZpb3VzX2xpbmUuc3RyaXAoKS5sb3dlcigpID4gbGluZS5zdHJpcCgp Lmxvd2VyKCk6CiAgICAgICAgICAgICAgICAgICAgICAgICBlcnJvcihmaWxlbmFtZSwgbGluZV9u dW1iZXIsICdidWlsZC9pbmNsdWRlX29yZGVyJywgNCwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICdBbHBoYWJldGljYWwgc29ydGluZyBwcm9ibGVtLicpCiAKZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRfdW5pdHRlc3QucHkKaW5kZXggYzk0ZDdhMS4uNDY4 MDNiYSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRfdW5p dHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRfdW5pdHRl c3QucHkKQEAgLTIwODYsNiArMjA4NiwxMiBAQCBjbGFzcyBPcmRlck9mSW5jbHVkZXNUZXN0KENw cGxpbnRUZXN0QmFzZSk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICcnKQogCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdlX3J1bGVzX2NoZWNrKCdmb28uaCcs CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcjaW5jbHVkZSAiYS5o IlxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUg IkIuaCJcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNs dWRlICJjLmgiXG4nLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAn JykKKworICAgICAgICBzZWxmLmFzc2VydF9sYW5ndWFnZV9ydWxlc19jaGVjaygnZm9vLmgnLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgPGFzc2Vy dC5oPlxuJwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1 ZGUgImJhci5oIlxuJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg J0FscGhhYmV0aWNhbCBzb3J0aW5nIHByb2JsZW0uICBbYnVpbGQvaW5jbHVkZV9vcmRlcl0gWzRd JykKLS0gCjEuNi4zLjMKCg==