27556 2009-07-22 12:57:52 -0700 pushDownTextDecorationStyleAroundNode needs clean up 2009-07-22 13:47:36 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC All RESOLVED FIXED P2 Enhancement --- 1 rniwa rniwa oldest_to_newest 133857 0 rniwa 2009-07-22 12:57:52 -0700 pushDownTextDecorationStyleAroundNode has nested loop whose structure is not clear. It has to be cleaned up. 133865 1 33285 rniwa 2009-07-22 13:06:23 -0700 Created attachment 33285 cleans up pushDownTextDecorationStyleAroundNode 133884 2 33285 eric 2009-07-22 13:37:24 -0700 Comment on attachment 33285 cleans up pushDownTextDecorationStyleAroundNode Looks fine. 133887 3 rniwa 2009-07-22 13:47:36 -0700 Landed in http://trac.webkit.org/changeset/46238 33285 2009-07-22 13:06:23 -0700 2009-07-22 13:37:24 -0700 cleans up pushDownTextDecorationStyleAroundNode fix27556 text/plain 4583 rniwa SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjIzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDctMjIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcHVz aERvd25UZXh0RGVjb3JhdGlvblN0eWxlQXJvdW5kTm9kZSBuZWVkcyBjbGVhbiB1cAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc1NTYKKworICAgICAg ICBDbGVhbmVkIHVwLiBwdXNoRG93blRleHREZWNvcmF0aW9uU3R5bGVBcm91bmROb2RlIHRyYXZl cnNlcyB0cmVlIHZlcnRpY2FsbHkgZnJvbSBoaWdoZXN0QW5jZXN0b3IgdG8gdGFyZ2V0Tm9kZQor ICAgICAgICBXaGlsZSB0cmF2ZXJzaW5nLCBpdCB3aWxsIGFwcGx5IHRoZSBzcGVjaWZpZWQgc3R5 bGUgdG8gYWxsIG5vZGVzIGJ1dCB0YXJnZXROb2RlLgorICAgICAgICBpLmUuIHRoZSBzdHlsZSBp cyBhcHBsaWVzIHRvIGFsbCBhbmNlc3RvciBub2RlcyBhbmQgdGhlaXIgc2libGluZ3Mgb2YgdGFy Z2V0Tm9kZS4KKworICAgICAgICAqIGVkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6QXBwbHlTdHlsZUNvbW1hbmQ6OnB1c2hEb3duVGV4dERlY29yYXRpb25T dHlsZUFyb3VuZE5vZGUpOiBDbGVhbmVkIHVwIGFuZCBhZGRlZCBjb21tZW50cworICAgICAgICAq IGVkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuaDogVXBkYXRlZCBwcm90b3R5cGUKKwogMjAwOS0w Ny0yMiAgUGF1bCBHb2RhdmFyaSAgPHBhdWxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEZpc2hlci4KSW5kZXg6IFdlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29t bWFuZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5k LmNwcAkocmV2aXNpb24gNDYyMjcpCisrKyBXZWJDb3JlL2VkaXRpbmcvQXBwbHlTdHlsZUNvbW1h bmQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYyLDMyICsxMTYyLDM1IEBAIHZvaWQgQXBwbHlT dHlsZUNvbW1hbmQ6OmFwcGx5VGV4dERlY29yYXQKICAgICB9CiB9CiAKLXZvaWQgQXBwbHlTdHls ZUNvbW1hbmQ6OnB1c2hEb3duVGV4dERlY29yYXRpb25TdHlsZUFyb3VuZE5vZGUoTm9kZSogbm9k ZSwgYm9vbCBmb3JjZSkKK3ZvaWQgQXBwbHlTdHlsZUNvbW1hbmQ6OnB1c2hEb3duVGV4dERlY29y YXRpb25TdHlsZUFyb3VuZE5vZGUoTm9kZSogdGFyZ2V0Tm9kZSwgYm9vbCBmb3JjZU5lZ2F0ZSkK IHsKLSAgICBOb2RlICpoaWdoZXN0QW5jZXN0b3IgPSBoaWdoZXN0QW5jZXN0b3JXaXRoVGV4dERl Y29yYXRpb24obm9kZSk7Ci0gICAgCi0gICAgaWYgKGhpZ2hlc3RBbmNlc3RvcikgewotICAgICAg ICBOb2RlICpuZXh0Q3VycmVudDsKLSAgICAgICAgTm9kZSAqbmV4dENoaWxkOwotICAgICAgICBm b3IgKE5vZGUgKmN1cnJlbnQgPSBoaWdoZXN0QW5jZXN0b3I7IGN1cnJlbnQgIT0gbm9kZTsgY3Vy cmVudCA9IG5leHRDdXJyZW50KSB7Ci0gICAgICAgICAgICBBU1NFUlQoY3VycmVudCk7Ci0gICAg ICAgICAgICAKLSAgICAgICAgICAgIG5leHRDdXJyZW50ID0gTlVMTDsKLSAgICAgICAgICAgIAot ICAgICAgICAgICAgUmVmUHRyPENTU011dGFibGVTdHlsZURlY2xhcmF0aW9uPiBkZWNvcmF0aW9u ID0gZm9yY2UgPyBleHRyYWN0QW5kTmVnYXRlVGV4dERlY29yYXRpb25TdHlsZShjdXJyZW50KSA6 IGV4dHJhY3RUZXh0RGVjb3JhdGlvblN0eWxlKGN1cnJlbnQpOworICAgIEFTU0VSVCh0YXJnZXRO b2RlKTsKKyAgICBOb2RlKiBoaWdoZXN0QW5jZXN0b3IgPSBoaWdoZXN0QW5jZXN0b3JXaXRoVGV4 dERlY29yYXRpb24odGFyZ2V0Tm9kZSk7CisgICAgaWYgKCFoaWdoZXN0QW5jZXN0b3IpCisgICAg ICAgIHJldHVybjsKIAotICAgICAgICAgICAgZm9yIChOb2RlICpjaGlsZCA9IGN1cnJlbnQtPmZp cnN0Q2hpbGQoKTsgY2hpbGQ7IGNoaWxkID0gbmV4dENoaWxkKSB7Ci0gICAgICAgICAgICAgICAg bmV4dENoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5nKCk7CisgICAgLy8gVGhlIG91dGVyIGxvb3Ag aXMgdHJhdmVyc2luZyB0aGUgdHJlZSB2ZXJ0aWNhbGx5IGZyb20gaGlnaGVzdEFuY2VzdG9yIHRv IHRhcmdldE5vZGUKKyAgICBOb2RlKiBjdXJyZW50ID0gaGlnaGVzdEFuY2VzdG9yOworICAgIHdo aWxlIChjdXJyZW50ICE9IHRhcmdldE5vZGUpIHsKKyAgICAgICAgQVNTRVJUKGN1cnJlbnQpOwor ICAgICAgICBBU1NFUlQoY3VycmVudC0+Y29udGFpbnModGFyZ2V0Tm9kZSkpOworICAgICAgICBS ZWZQdHI8Q1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24+IGRlY29yYXRpb24gPSBmb3JjZU5lZ2F0 ZSA/IGV4dHJhY3RBbmROZWdhdGVUZXh0RGVjb3JhdGlvblN0eWxlKGN1cnJlbnQpIDogZXh0cmFj dFRleHREZWNvcmF0aW9uU3R5bGUoY3VycmVudCk7CisKKyAgICAgICAgLy8gVGhlIGlubmVyIGxv b3Agd2lsbCBnbyB0aHJvdWdoIGNoaWxkcmVuIG9uIGVhY2ggbGV2ZWwKKyAgICAgICAgTm9kZSog Y2hpbGQgPSBjdXJyZW50LT5maXJzdENoaWxkKCk7CisgICAgICAgIHdoaWxlIChjaGlsZCkgewor ICAgICAgICAgICAgTm9kZSogbmV4dENoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5nKCk7CisKKyAg ICAgICAgICAgIC8vIEFwcGx5IHRleHQgZGVjb3JhdGlvbiB0byBhbGwgbm9kZXMgY29udGFpbmlu ZyB0YXJnZXROb2RlIGFuZCB0aGVpciBzaWJsaW5ncyBidXQgTk9UIHRvIHRhcmdldE5vZGUKKyAg ICAgICAgICAgIGlmIChjaGlsZCAhPSB0YXJnZXROb2RlKQorICAgICAgICAgICAgICAgIGFwcGx5 VGV4dERlY29yYXRpb25TdHlsZShjaGlsZCwgZGVjb3JhdGlvbi5nZXQoKSk7CisgICAgICAgICAg ICAKKyAgICAgICAgICAgIC8vIFdlIGZvdW5kIHRoZSBuZXh0IG5vZGUgZm9yIHRoZSBvdXRlciBs b29wIChjb250YWlucyB0YXJnZXROb2RlKQorICAgICAgICAgICAgLy8gV2hlbiByZWFjaGVkIHRh cmdldE5vZGUsIHN0b3AgdGhlIG91dGVyIGxvb3AgdXBvbiB0aGUgY29tcGxldGlvbiBvZiB0aGUg Y3VycmVudCBpbm5lciBsb29wCisgICAgICAgICAgICBpZiAoY2hpbGQgPT0gdGFyZ2V0Tm9kZSB8 fCBjaGlsZC0+Y29udGFpbnModGFyZ2V0Tm9kZSkpCisgICAgICAgICAgICAgICAgY3VycmVudCA9 IGNoaWxkOwogCi0gICAgICAgICAgICAgICAgaWYgKG5vZGUgPT0gY2hpbGQpIHsKLSAgICAgICAg ICAgICAgICAgICAgbmV4dEN1cnJlbnQgPSBjaGlsZDsKLSAgICAgICAgICAgICAgICB9IGVsc2Ug aWYgKG5vZGUtPmlzRGVzY2VuZGFudE9mKGNoaWxkKSkgewotICAgICAgICAgICAgICAgICAgICBh cHBseVRleHREZWNvcmF0aW9uU3R5bGUoY2hpbGQsIGRlY29yYXRpb24uZ2V0KCkpOwotICAgICAg ICAgICAgICAgICAgICBuZXh0Q3VycmVudCA9IGNoaWxkOwotICAgICAgICAgICAgICAgIH0gZWxz ZSB7Ci0gICAgICAgICAgICAgICAgICAgIGFwcGx5VGV4dERlY29yYXRpb25TdHlsZShjaGlsZCwg ZGVjb3JhdGlvbi5nZXQoKSk7Ci0gICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgfQorICAg ICAgICAgICAgY2hpbGQgPSBuZXh0Q2hpbGQ7CiAgICAgICAgIH0KICAgICB9CiB9CkluZGV4OiBX ZWJDb3JlL2VkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2VkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuaAkocmV2aXNpb24gNDYyMjcpCisrKyBXZWJDb3Jl L2VkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuaAkod29ya2luZyBjb3B5KQpAQCAtNzMsNyArNzMs NyBAQCBwcml2YXRlOgogICAgIFBhc3NSZWZQdHI8Q1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24+ IGV4dHJhY3RUZXh0RGVjb3JhdGlvblN0eWxlKE5vZGUqKTsKICAgICBQYXNzUmVmUHRyPENTU011 dGFibGVTdHlsZURlY2xhcmF0aW9uPiBleHRyYWN0QW5kTmVnYXRlVGV4dERlY29yYXRpb25TdHls ZShOb2RlKik7CiAgICAgdm9pZCBhcHBseVRleHREZWNvcmF0aW9uU3R5bGUoTm9kZSosIENTU011 dGFibGVTdHlsZURlY2xhcmF0aW9uICpzdHlsZSk7Ci0gICAgdm9pZCBwdXNoRG93blRleHREZWNv cmF0aW9uU3R5bGVBcm91bmROb2RlKE5vZGUqLCBib29sIGZvcmNlKTsKKyAgICB2b2lkIHB1c2hE b3duVGV4dERlY29yYXRpb25TdHlsZUFyb3VuZE5vZGUoTm9kZSosIGJvb2wgZm9yY2VOZWdhdGUp OwogICAgIHZvaWQgcHVzaERvd25UZXh0RGVjb3JhdGlvblN0eWxlQXRCb3VuZGFyaWVzKGNvbnN0 IFBvc2l0aW9uJiBzdGFydCwgY29uc3QgUG9zaXRpb24mIGVuZCk7CiAgICAgCiAgICAgLy8gc3R5 bGUtYXBwbGljYXRpb24gaGVscGVycwo=