27553 2009-07-22 12:32:26 -0700 Fix cpplint generating false positives for "primary" includes in headers 2009-07-22 12:51:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jpetsovits webkit-unassigned manyoso oldest_to_newest 133843 0 jpetsovits 2009-07-22 12:32:26 -0700 The following piece of code placed in a header file will incorrectly throw an error: (in "FooBar.h":) #include "Foo.h" Which is because Foo.h is classified as primary include, and thus considered the same by the don't-include-yourself check for header files. That's a false positive, and should be fixed. Patch follows below! 133851 1 33283 jpetsovits 2009-07-22 12:44:41 -0700 Created attachment 33283 Fix cpplint generating false positives for "primary" includes in headers 133854 2 manyoso 2009-07-22 12:51:58 -0700 Landed with r46231. 33283 2009-07-22 12:44:41 -0700 2009-07-22 12:49:01 -0700 Fix cpplint generating false positives for "primary" includes in headers 0001-Fix-cpplint-generating-false-positives-for-primary-i.patch text/plain 3369 jpetsovits RnJvbSBhZjU0N2E0YjczODE0ZDQ2ZWVjODE4Zjg5NTdmZmJjMWVjOGJiYTRlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBQZXRzb3ZpdHMgPGpha29iLnBldHNvdml0c0B0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IFdlZCwgMjIgSnVsIDIwMDkgMTU6NDM6MDggLTA0MDAKU3ViamVj dDogW1BBVENIXSBGaXggY3BwbGludCBnZW5lcmF0aW5nIGZhbHNlIHBvc2l0aXZlcyBmb3IgInBy aW1hcnkiIGluY2x1ZGVzIGluIGhlYWRlcnMuCgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIFdlYktpdFRv b2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5ICAgICAgICAgIHwgICAgNiArKysrKysKIFdl YktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5IHwgICAgOCArKysr KysrKwogMyBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkZjhjMjlhLi40Y2Q0OTk3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDct MjIgIEpha29iIFBldHNvdml0cyAgPGpha29iLnBldHNvdml0c0B0b3JjaG1vYmlsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGNwcGxp bnQgZ2VuZXJhdGluZyBmYWxzZSBwb3NpdGl2ZXMgZm9yCisgICAgICAgICJwcmltYXJ5IiBpbmNs dWRlcyBpbiBoZWFkZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mjc1NTMKKworICAgICAgICBEb2luZyBzbyBieSBvbmx5IGZsYWdnaW5nIGluY2x1 ZGVzIGluIGhlYWRlciBmaWxlcworICAgICAgICBhcyBwcmltYXJ5IHdoZW4gdGhlIGluY2x1ZGUg ZmlsZW5hbWUgZXhhY3RseSBtYXRjaGVzCisgICAgICAgIHRoZSBoZWFkZXIgZmlsZW5hbWUuCisK KyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY3BwbGludC5weToKKyAgICAgICAgKiBTY3JpcHRz L21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weToKKwogMjAwOS0wNy0yMSAgSmFrb2IgUGV0c292 aXRzICA8amFrb2IucGV0c292aXRzQHRvcmNobW9iaWxlLmNvbT4KIAogICAgICAgICAgUmV2aWV3 ZWQgYnkgQWRhbSBUcmVhdC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxl cy9jcHBsaW50LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnQucHkKaW5k ZXggYzZmOTNiNy4uNmQyN2YwOCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1 bGVzL2NwcGxpbnQucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnQu cHkKQEAgLTIxMzIsNiArMjEzMiwxMiBAQCBkZWYgX2NsYXNzaWZ5X2luY2x1ZGUoZmlsZW5hbWUs IGluY2x1ZGUsIGlzX3N5c3RlbSk6CiAgICAgaWYgaW5jbHVkZSA9PSAiY29uZmlnLmgiOgogICAg ICAgICByZXR1cm4gX0NPTkZJR19IRUFERVIKIAorICAgICMgVGhlcmUgY2Fubm90IGJlIHByaW1h cnkgaW5jbHVkZXMgaW4gaGVhZGVyIGZpbGVzIHRoZW1zZWx2ZXMuIE9ubHkgYW4KKyAgICAjIGlu Y2x1ZGUgZXhhY3RseSBtYXRjaGVzIHRoZSBoZWFkZXIgZmlsZW5hbWUgd2lsbCBiZSBpcyBmbGFn Z2VkIGFzCisgICAgIyBwcmltYXJ5LCBzbyB0aGF0IGl0IHRyaWdnZXJzIHRoZSAiZG9uJ3QgaW5j bHVkZSB5b3Vyc2VsZiIgY2hlY2suCisgICAgaWYgZmlsZW5hbWUuZW5kc3dpdGgoJy5oJykgYW5k IGZpbGVuYW1lICE9IGluY2x1ZGU6CisgICAgICAgIHJldHVybiBfT1RIRVJfSEVBREVSOworCiAg ICAgIyBJZiB0aGUgdGFyZ2V0IGZpbGUgYmFzZW5hbWUgc3RhcnRzIHdpdGggdGhlIGluY2x1ZGUg d2UncmUgY2hlY2tpbmcKICAgICAjIHRoZW4gd2UgY29uc2lkZXIgaXQgdGhlIHByaW1hcnkgaGVh ZGVyLgogICAgIHRhcmdldF9iYXNlID0gRmlsZUluZm8oZmlsZW5hbWUpLmJhc2VfbmFtZSgpCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5w eSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5CmluZGV4 IDE4ZWMwMGEuLjYzZWRkN2EgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxl cy9jcHBsaW50X3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9j cHBsaW50X3VuaXR0ZXN0LnB5CkBAIC0yMDUyLDYgKzIwNTIsMTQgQEAgY2xhc3MgT3JkZXJPZklu Y2x1ZGVzVGVzdChDcHBsaW50VGVzdEJhc2UpOgogICAgIGRlZiB0ZXN0X2NoZWNrX25leHRfaW5j bHVkZV9vcmRlcl9fbm9fc2VsZihzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbCgnSGVh ZGVyIGZpbGUgc2hvdWxkIG5vdCBjb250YWluIGl0c2VsZi4nLAogICAgICAgICAgICAgICAgICAg ICAgICAgIHNlbGYuaW5jbHVkZV9zdGF0ZS5jaGVja19uZXh0X2luY2x1ZGVfb3JkZXIoY3BwbGlu dC5fUFJJTUFSWV9IRUFERVIsIFRydWUpKQorICAgICAgICAjIFRlc3QgYWN0dWFsIGNvZGUgdG8g bWFrZSBzdXJlIHRoYXQgaGVhZGVyIHR5cGVzIGFyZSBjb3JyZWN0bHkgYXNzaWduZWQuCisgICAg ICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdlX3J1bGVzX2NoZWNrKCdGb28uaCcsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcjaW5jbHVkZSAiRm9vLmgiXG4nLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnSGVhZGVyIGZpbGUgc2hvdWxk IG5vdCBjb250YWluIGl0c2VsZi4gU2hvdWxkIGJlOiBhbHBoYWJldGljYWxseSBzb3J0ZWQuJwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnICBbYnVpbGQvaW5jbHVk ZV9vcmRlcl0gWzRdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGFuZ3VhZ2VfcnVsZXNfY2hlY2so J0Zvb0Jhci5oJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNp bmNsdWRlICJGb28uaCJcbicsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICcnKQogCiAgICAgZGVmIHRlc3RfY2hlY2tfbmV4dF9pbmNsdWRlX29yZGVyX19saWtlbHlf dGhlbl9jb25maWcoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoJ0ZvdW5kIGhlYWRl ciB0aGlzIGZpbGUgaW1wbGVtZW50cyBiZWZvcmUgV2ViQ29yZSBjb25maWcuaC4nLAotLSAKMS42 LjMuMwoK