27549 2009-07-22 11:19:09 -0700 Make run-webkit-lint supports files as arguments 2009-07-29 08:14:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Minor --- 1 kenneth kenneth levin manyoso oldest_to_newest 133814 0 kenneth 2009-07-22 11:19:09 -0700 Make run-webkit-lint supports files as arguments so that we dont need to call python WebKitTools/Scripts/modules/cpplint.py on individual files. Patch coming up. 133815 1 33274 kenneth 2009-07-22 11:22:13 -0700 Created attachment 33274 Make run-webkit-lint supports files as arguments 134115 2 33274 levin 2009-07-23 09:03:37 -0700 Comment on attachment 33274 Make run-webkit-lint supports files as arguments Thanks for the patch. This is a nice addition. Just a few things to address at the moment. Well, first off, sorry, I changed the name of the tool on you. So if you would switch the patch over to check-webkit-style, that would be excellent. fwiw, you don't need to request me as the reviewer - Adam has been also reviewing these and doing a great job (The funny thing is that it delayed your review because I typically scan the general queue -- not used to being asked for by name). cc'ing me did get my attention though :) > diff --git a/WebKitTools/Scripts/run-webkit-lint b/WebKitTools/Scripts/run-webkit-lint Please fix up "cpplint._USAGE" to reflect the fact that you may optionally pass in files. What should happen if the user passes in --git-commit and files? (Personally I recommend something simple like an error message that you need to choose one or the other.) > + if not filenames: > + cwd = os.path.abspath('.') > + scm = detect_scm_system(cwd) > + > + process_patch(scm.create_patch()) > + else: > + # Change stderr to write with replacement characters so we don't die > + # if we try to print something containing non-ASCII characters. > + sys.stderr = codecs.StreamReaderWriter(sys.stderr, > + codecs.getreader('utf8'), > + codecs.getwriter('utf8'), > + 'replace') If this is useful (and I think it is), it seems like it would be needed for both code paths, so I'd move this outside of the "if". > + > + for filename in filenames: > + cpplint.process_file(filename) 135569 3 33712 kenneth 2009-07-29 06:03:30 -0700 Created attachment 33712 Updates and improved patch 135586 4 33712 levin 2009-07-29 08:04:14 -0700 Comment on attachment 33712 Updates and improved patch I'm willing to do these changes, but I'd like to know how you feel about the "consider" comments. > diff --git a/WebKitTools/Scripts/check-webkit-style b/WebKitTools/Scripts/check-webkit-style > + The file parameter is optional and multiple file scan be passed in. Leaving Consider: The file parameter is optional and multiple files to scan may be passed in > + out the file parameter will apply the check to the files currently not Consider: out the file parameter will apply the check to the files changed according to the scm system. > + if files and "--git-commit" in flags: > + sys.stderr.write("ERROR: It is not possible to check files " > + "and a specific commit at the same time.\n" + cpp_style._USAGE) > sys.exit(1) > + elif files: Make this an "if" since the pre if "exits". 135587 5 kenneth 2009-07-29 08:08:15 -0700 I feel fine about these changes. 135593 6 33712 kenneth 2009-07-29 08:13:58 -0700 Comment on attachment 33712 Updates and improved patch Landed (with the above changes) in 46542. 33274 2009-07-22 11:22:13 -0700 2009-07-29 06:03:30 -0700 Make run-webkit-lint supports files as arguments bug-27549.patch text/plain 2688 kenneth RnJvbSA2YzEzNmFmMzVhZmVjMjgyMjExY2E3YjAzMzFlZTQyYWE5ODRjYTAxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3 ZWJraXQub3JnPgpEYXRlOiBXZWQsIDIyIEp1bCAyMDA5IDE1OjA3OjIzIC0wMzAwClN1YmplY3Q6 IFtQQVRDSF0gMjAwOS0wNy0yMiAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRo QHdlYmtpdC5vcmc+CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAg ICBNYWtlIHJ1bi13ZWJraXQtbGludCBzdXBwb3J0cyBmaWxlcyBhcyBhcmd1bWVudHMuCiAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NTQ5CgogICAgICAg ICogU2NyaXB0cy9ydW4td2Via2l0LWxpbnQ6Ci0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgfCAgICA5ICsrKysrKysrKwogV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Vi a2l0LWxpbnQgfCAgIDI2ICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5n ZWQsIDI2IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDI2ZWFlNzQuLmRk ZWZmNWIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0wNy0yMiAgS2VubmV0aCBSb2hkZSBD aHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBydW4td2Via2l0LWxpbnQgc3VwcG9ydHMg ZmlsZXMgYXMgYXJndW1lbnRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mjc1NDkKKworICAgICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC1saW50Ogor CiAyMDA5LTA3LTIxICBBZGFtIFRyZWF0ICA8YWRhbS50cmVhdEB0b3JjaG1vYmlsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL3J1bi13ZWJraXQtbGludCBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtp dC1saW50CmluZGV4IGJlYjI0OTcuLjc0NTM4OGIgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvcnVuLXdlYmtpdC1saW50CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtp dC1saW50CkBAIC0zMCw2ICszMCw3IEBACiAKICIiIlNjcmlwdCB0byBydW4gdGhlIGxpbnRlciBm b3Igc291cmNlIGNvZGUgb2YgV2ViS2l0LiIiIgogCitpbXBvcnQgY29kZWNzCiBpbXBvcnQgb3MK IGltcG9ydCBvcy5wYXRoCiBpbXBvcnQgc3lzCkBAIC0xMTIsMTUgKzExMywyMiBAQCBkZWYgcHJv Y2Vzc19wYXRjaChwYXRjaF9zdHJpbmcpOgogCiBkZWYgbWFpbigpOgogICAgIGNwcGxpbnQudXNl X3dlYmtpdF9zdHlsZXMoKQotICAgIGFyZ3MgPSBjcHBsaW50LnBhcnNlX2FyZ3VtZW50cyhzeXMu YXJndlsxOl0pCi0gICAgaWYgYXJnczoKLSAgICAgICAgc3lzLnN0ZGVyci53cml0ZSgiRVJST1I6 IFdlIGRvbid0IHN1cHBvcnQgZmlsZXMgYXMgYXJndW1lbnRzIGZvciBub3cuXG4iICsgY3BwbGlu dC5fVVNBR0UpCi0gICAgICAgIHN5cy5leGl0KDEpCi0KLSAgICBjd2QgPSBvcy5wYXRoLmFic3Bh dGgoJy4nKQotICAgIHNjbSA9IGRldGVjdF9zY21fc3lzdGVtKGN3ZCkKLQotICAgIHByb2Nlc3Nf cGF0Y2goc2NtLmNyZWF0ZV9wYXRjaCgpKQorICAgIGZpbGVuYW1lcyA9IGNwcGxpbnQucGFyc2Vf YXJndW1lbnRzKHN5cy5hcmd2WzE6XSkKKyAgICBpZiBub3QgZmlsZW5hbWVzOgorICAgICAgICBj d2QgPSBvcy5wYXRoLmFic3BhdGgoJy4nKQorICAgICAgICBzY20gPSBkZXRlY3Rfc2NtX3N5c3Rl bShjd2QpCisKKyAgICAgICAgcHJvY2Vzc19wYXRjaChzY20uY3JlYXRlX3BhdGNoKCkpCisgICAg ZWxzZToKKyAgICAgICAgIyBDaGFuZ2Ugc3RkZXJyIHRvIHdyaXRlIHdpdGggcmVwbGFjZW1lbnQg Y2hhcmFjdGVycyBzbyB3ZSBkb24ndCBkaWUKKyAgICAgICAgIyBpZiB3ZSB0cnkgdG8gcHJpbnQg c29tZXRoaW5nIGNvbnRhaW5pbmcgbm9uLUFTQ0lJIGNoYXJhY3RlcnMuCisgICAgICAgIHN5cy5z dGRlcnIgPSBjb2RlY3MuU3RyZWFtUmVhZGVyV3JpdGVyKHN5cy5zdGRlcnIsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvZGVjcy5nZXRyZWFkZXIoJ3V0 ZjgnKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29k ZWNzLmdldHdyaXRlcigndXRmOCcpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAncmVwbGFjZScpCisKKyAgICAgICAgZm9yIGZpbGVuYW1lIGluIGZpbGVu YW1lczoKKyAgICAgICAgICAgIGNwcGxpbnQucHJvY2Vzc19maWxlKGZpbGVuYW1lKQogCiAgICAg c3lzLnN0ZGVyci53cml0ZSgnVG90YWwgZXJyb3JzIGZvdW5kOiAlZFxuJyAlIGNwcGxpbnQuZXJy b3JfY291bnQoKSkKICAgICBzeXMuZXhpdChjcHBsaW50LmVycm9yX2NvdW50KCkgPiAwKQotLSAK MS42LjAuNAoK 33712 2009-07-29 06:03:30 -0700 2009-07-29 08:13:58 -0700 Updates and improved patch 0001-2009-07-29-Kenneth-Rohde-Christiansen-check-webkit-style.patch text/plain 4868 kenneth RnJvbSAwYjkzZTBmYzg0OWYwMGZmZWFhOTY0NDZlMjM5MTRhNzFkOGIwYjhhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3 ZWJraXQub3JnPgpEYXRlOiBXZWQsIDI5IEp1bCAyMDA5IDEwOjAyOjE4IC0wMzAwClN1YmplY3Q6 IFtQQVRDSF0gMjAwOS0wNy0yOSAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRo QHdlYmtpdC5vcmc+CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAg ICBNYWtlIGNoZWNrLXdlYmtpdC1zdHlsZSBzdXBwb3J0IGZpbGVzIGFzIGFyZ3VtZW50cy4KICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc1NDkKCiAgICAg ICAgKiBTY3JpcHRzL2NoZWNrLXdlYmtpdC1zdHlsZToKICAgICAgICBTdXBwb3J0IGZpbGVzIGFz IGFyZ3VtZW50LiBDaGFuZ2UgZG9jdW1lbnRhdGlvbiBhbmQgdXNlIGJhc2VuYW1lCiAgICAgICAg b24gdGhlIGJpbmFyeSBuYW1lIHdoZW4gdXNlZCBpbiB0aGUgZG9jdW1lbnRhdGlvbi4gQWxzbyBk byBub3QKICAgICAgICBkaWUgd2hlbiBwcmludGluZyBzb21ldGhpbmcgY29udGFpbmluZyBub24t QVNDSUkgY2hhcmFjdGVycy4KLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICB8ICAgMTIgKysrKysrKysrCiBXZWJLaXRUb29scy9TY3JpcHRzL2NoZWNrLXdlYmtpdC1z dHlsZSB8ICAgNDAgKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KIDIgZmlsZXMgY2hh bmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGIxNTE2ZDgu LmQ1MjY2YzQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRU b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNy0yOSAgS2VubmV0aCBSb2hk ZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBjaGVjay13ZWJraXQtc3R5bGUgc3Vw cG9ydCBmaWxlcyBhcyBhcmd1bWVudHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNzU0OQorCisgICAgICAgICogU2NyaXB0cy9jaGVjay13ZWJraXQt c3R5bGU6CisgICAgICAgIFN1cHBvcnQgZmlsZXMgYXMgYXJndW1lbnQuIENoYW5nZSBkb2N1bWVu dGF0aW9uIGFuZCB1c2UgYmFzZW5hbWUKKyAgICAgICAgb24gdGhlIGJpbmFyeSBuYW1lIHdoZW4g dXNlZCBpbiB0aGUgZG9jdW1lbnRhdGlvbi4gQWxzbyBkbyBub3QKKyAgICAgICAgZGllIHdoZW4g cHJpbnRpbmcgc29tZXRoaW5nIGNvbnRhaW5pbmcgbm9uLUFTQ0lJIGNoYXJhY3RlcnMuCisKIDIw MDktMDctMjkgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICA8 aHR0cDovL3dlYmtpdC5vcmcvYi8yNzExOT4gYnVnemlsbGEtdG9vbDogQWRkIGNyZWF0ZS1idWcg Y29tbWFuZApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9jaGVjay13ZWJraXQtc3R5 bGUgYi9XZWJLaXRUb29scy9TY3JpcHRzL2NoZWNrLXdlYmtpdC1zdHlsZQppbmRleCA3ZWU5MDk4 Li4xMzZjMjdlIDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2NoZWNrLXdlYmtpdC1z dHlsZQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL2NoZWNrLXdlYmtpdC1zdHlsZQpAQCAtMzAs NiArMzAsNyBAQAogCiAiIiJTY3JpcHQgdG8gcnVuIHRoZSBsaW50ZXIgZm9yIHNvdXJjZSBjb2Rl IG9mIFdlYktpdC4iIiIKIAoraW1wb3J0IGNvZGVjcwogaW1wb3J0IG9zCiBpbXBvcnQgb3MucGF0 aAogaW1wb3J0IHN5cwpAQCAtNDEsNyArNDIsOCBAQCBmcm9tIG1vZHVsZXMuc2NtIGltcG9ydCBk ZXRlY3Rfc2NtX3N5c3RlbQogCiAjIE92ZXJyaWRlIHRoZSB1c2FnZSBvZiB0aGUgbGludCB0b29s LgogY3BwX3N0eWxlLl9VU0FHRSA9ICIiIgotU3ludGF4OiAlKHByb2dyYW1fbmFtZSlzIFstLXZl cmJvc2U9I10gWy0tZ2l0LWNvbW1pdD08Q09NTUlUSVNIPl0gWy0tb3V0cHV0PXZzN10gWy0tZmls dGVyPS14LCt5LC4uLl0KK1N5bnRheDogJShwcm9ncmFtX25hbWUpcyBbLS12ZXJib3NlPSNdIFst LWdpdC1jb21taXQ9PENPTU1JVElTSD5dIFstLW91dHB1dD12czddCisgICAgICAgIFstLWZpbHRl cj0teCwreSwuLi5dIFtmaWxlXSAuLi4KIAogICBUaGUgc3R5bGUgZ3VpZGVsaW5lcyB0aGlzIHRy aWVzIHRvIGZvbGxvdyBhcmUgdGhvc2UgaW4KICAgICBodHRwOi8vd2Via2l0Lm9yZy9jb2Rpbmcv Y29kaW5nLXN0eWxlLmh0bWwKQEAgLTU1LDYgKzU3LDEwIEBAIFN5bnRheDogJShwcm9ncmFtX25h bWUpcyBbLS12ZXJib3NlPSNdIFstLWdpdC1jb21taXQ9PENPTU1JVElTSD5dIFstLW91dHB1dD12 czddCiAKICAgTGludGVkIGV4dGVuc2lvbnMgYXJlIC5jcHAsIC5jIGFuZCAuaC4gIE90aGVyIGZp bGUgdHlwZXMgd2lsbCBiZSBpZ25vcmVkLgogCisgIFRoZSBmaWxlIHBhcmFtZXRlciBpcyBvcHRp b25hbCBhbmQgbXVsdGlwbGUgZmlsZSBzY2FuIGJlIHBhc3NlZCBpbi4gTGVhdmluZworICBvdXQg dGhlIGZpbGUgcGFyYW1ldGVyIHdpbGwgYXBwbHkgdGhlIGNoZWNrIHRvIHRoZSBmaWxlcyBjdXJy ZW50bHkgbm90CisgIGNoZWNrZWQgaW4gdGhlIHNjbSBzeXN0ZW0uCisKICAgRmxhZ3M6CiAKICAg ICB2ZXJib3NlPSMKQEAgLTg1LDcgKzkxLDcgQEAgU3ludGF4OiAlKHByb2dyYW1fbmFtZSlzIFst LXZlcmJvc2U9I10gWy0tZ2l0LWNvbW1pdD08Q09NTUlUSVNIPl0gWy0tb3V0cHV0PXZzN10KIAog ICAgICAgVG8gc2VlIGEgbGlzdCBvZiBhbGwgdGhlIGNhdGVnb3JpZXMgdXNlZCBpbiAlKHByb2dy YW1fbmFtZSlzLCBwYXNzIG5vIGFyZzoKICAgICAgICAgIC0tZmlsdGVyPQotIiIiICUgeydwcm9n cmFtX25hbWUnOiBzeXMuYXJndlswXX0KKyIiIiAlIHsncHJvZ3JhbV9uYW1lJzogb3MucGF0aC5i YXNlbmFtZShzeXMuYXJndlswXSl9CiAKIAogZGVmIHByb2Nlc3NfcGF0Y2gocGF0Y2hfc3RyaW5n KToKQEAgLTEyMywxOCArMTI5LDMyIEBAIGRlZiBwcm9jZXNzX3BhdGNoKHBhdGNoX3N0cmluZyk6 CiBkZWYgbWFpbigpOgogICAgIGNwcF9zdHlsZS51c2Vfd2Via2l0X3N0eWxlcygpCiAKLSAgICAo YXJncywgZmxhZ3MpID0gY3BwX3N0eWxlLnBhcnNlX2FyZ3VtZW50cyhzeXMuYXJndlsxOl0sIFsi Z2l0LWNvbW1pdD0iXSkKLSAgICBpZiBhcmdzOgotICAgICAgICBzeXMuc3RkZXJyLndyaXRlKCJF UlJPUjogV2UgZG9uJ3Qgc3VwcG9ydCBmaWxlcyBhcyBhcmd1bWVudHMgZm9yIG5vdy5cbiIgKyBj cHBfc3R5bGUuX1VTQUdFKQorICAgIChmaWxlcywgZmxhZ3MpID0gY3BwX3N0eWxlLnBhcnNlX2Fy Z3VtZW50cyhzeXMuYXJndlsxOl0sIFsiZ2l0LWNvbW1pdD0iXSkKKworICAgICMgQ2hhbmdlIHN0 ZGVyciB0byB3cml0ZSB3aXRoIHJlcGxhY2VtZW50IGNoYXJhY3RlcnMgc28gd2UgZG9uJ3QgZGll CisgICAgIyBpZiB3ZSB0cnkgdG8gcHJpbnQgc29tZXRoaW5nIGNvbnRhaW5pbmcgbm9uLUFTQ0lJ IGNoYXJhY3RlcnMuCisgICAgc3lzLnN0ZGVyciA9IGNvZGVjcy5TdHJlYW1SZWFkZXJXcml0ZXIo c3lzLnN0ZGVyciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj b2RlY3MuZ2V0cmVhZGVyKCd1dGY4JyksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY29kZWNzLmdldHdyaXRlcigndXRmOCcpLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICdyZXBsYWNlJykKKworICAgIGlmIGZpbGVzIGFuZCAi LS1naXQtY29tbWl0IiBpbiBmbGFnczoKKyAgICAgICAgc3lzLnN0ZGVyci53cml0ZSgiRVJST1I6 IEl0IGlzIG5vdCBwb3NzaWJsZSB0byBjaGVjayBmaWxlcyAiCisgICAgICAgICAgICAgICAgICAg ICAgICAgICJhbmQgYSBzcGVjaWZpYyBjb21taXQgYXQgdGhlIHNhbWUgdGltZS5cbiIgKyBjcHBf c3R5bGUuX1VTQUdFKQogICAgICAgICBzeXMuZXhpdCgxKQogCi0gICAgY3dkID0gb3MucGF0aC5h YnNwYXRoKCcuJykKLSAgICBzY20gPSBkZXRlY3Rfc2NtX3N5c3RlbShjd2QpCisgICAgZWxpZiBm aWxlczoKKyAgICAgICAgZm9yIGZpbGVuYW1lIGluIGZpbGVzOgorICAgICAgICAgICAgY3BwX3N0 eWxlLnByb2Nlc3NfZmlsZShmaWxlbmFtZSkKIAotICAgIGlmICItLWdpdC1jb21taXQiIGluIGZs YWdzOgotICAgICAgICBwcm9jZXNzX3BhdGNoKHNjbS5jcmVhdGVfcGF0Y2hfZnJvbV9sb2NhbF9j b21taXQoZmxhZ3NbIi0tZ2l0LWNvbW1pdCJdKSkKICAgICBlbHNlOgotICAgICAgICBwcm9jZXNz X3BhdGNoKHNjbS5jcmVhdGVfcGF0Y2goKSkKKyAgICAgICAgY3dkID0gb3MucGF0aC5hYnNwYXRo KCcuJykKKyAgICAgICAgc2NtID0gZGV0ZWN0X3NjbV9zeXN0ZW0oY3dkKQorCisgICAgICAgIGlm ICItLWdpdC1jb21taXQiIGluIGZsYWdzOgorICAgICAgICAgICAgcHJvY2Vzc19wYXRjaChzY20u Y3JlYXRlX3BhdGNoX2Zyb21fbG9jYWxfY29tbWl0KGZsYWdzWyItLWdpdC1jb21taXQiXSkpCisg ICAgICAgIGVsc2U6CisgICAgICAgICAgICBwcm9jZXNzX3BhdGNoKHNjbS5jcmVhdGVfcGF0Y2go KSkKIAogICAgIHN5cy5zdGRlcnIud3JpdGUoJ1RvdGFsIGVycm9ycyBmb3VuZDogJWRcbicgJSBj cHBfc3R5bGUuZXJyb3JfY291bnQoKSkKICAgICBzeXMuZXhpdChjcHBfc3R5bGUuZXJyb3JfY291 bnQoKSA+IDApCi0tIAoxLjYuMC40Cgo=