<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>275489</bug_id>
          
          <creation_ts>2024-06-14 08:42:44 -0700</creation_ts>
          <short_desc>[JSC] Fix `Intl.DurationFormat` for `numeric` and `2-digit`</short_desc>
          <delta_ts>2024-06-28 10:43:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sosuke Suzuki">sosuke</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2041361</commentid>
    <comment_count>0</comment_count>
    <who name="Sosuke Suzuki">sosuke</who>
    <bug_when>2024-06-14 08:42:44 -0700</bug_when>
    <thetext>In the current JSC `Intl.DurationFormat` implementation, only units with a value that is not 0 or a
    display setting that is not `auto` are formatted. However, this behavior is incorrect according to
    the current spec[1]. When a unit&apos;s style is `numeric` or `2-digit` (i.e., the unit is `hours`,
    `minutes`, or `seconds`), it needs to be formatted even if its value is 0 and its display is set to
    auto. For example, consider the following code:
    
    ```
    const df = new Intl.DurationFormat(&quot;en&quot;, { hours: &quot;numeric&quot;, minutesDisplay: &quot;auto&quot;, secondsDisplay: &quot;auto&quot; });
    print(df.format({ hours: 0, minutes: 0, seconds: 1 }));
    ```
    
    This code is expected to output `0:00:01`, but the current JSC outputs `0, 01`. Only the hours and
    seconds are displayed, while the minutes are not. Additionally, the separator `:` is not used; instead,
    `,` is outputted.
        
    [1]: https://tc39.es/proposal-intl-duration-format/#sec-partitiondurationformatpattern</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2041362</commentid>
    <comment_count>1</comment_count>
    <who name="Sosuke Suzuki">sosuke</who>
    <bug_when>2024-06-14 08:43:51 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/29823</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2042449</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-06-21 08:46:31 -0700</bug_when>
    <thetext>&lt;rdar://problem/130279541&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2043610</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-06-28 10:42:58 -0700</bug_when>
    <thetext>Committed 280460@main (471838036efe): &lt;https://commits.webkit.org/280460@main&gt;

Reviewed commits have been landed. Closing PR #29823 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>