<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27537</bug_id>
          
          <creation_ts>2009-07-22 03:12:39 -0700</creation_ts>
          <short_desc>[V8] Inform V8 of the amount of WebCore string memory it is keeping alive.</short_desc>
          <delta_ts>2009-07-22 15:11:34 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore JavaScript</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mads Ager">ager</reporter>
          <assigned_to name="David Levin">levin</assigned_to>
          <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>133732</commentid>
    <comment_count>0</comment_count>
    <who name="Mads Ager">ager</who>
    <bug_when>2009-07-22 03:12:39 -0700</bug_when>
    <thetext>In the V8 bindings, we should inform V8 of the amount of WebCore data we are keeping alive in the form of external strings.  This will give V8 a chance to release some of those resources.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133734</commentid>
    <comment_count>1</comment_count>
      <attachid>33251</attachid>
    <who name="Mads Ager">ager</who>
    <bug_when>2009-07-22 03:25:30 -0700</bug_when>
    <thetext>Created attachment 33251
Inform V8 of the amount of external memory kept alive by external strings.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133780</commentid>
    <comment_count>2</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-07-22 09:16:46 -0700</bug_when>
    <thetext>Of course, this is only an approximation and if the same String gets added to v8 more than once, then the external memory will be artificially high.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133897</commentid>
    <comment_count>3</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-07-22 14:22:39 -0700</bug_when>
    <thetext>Assign to levin for landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133936</commentid>
    <comment_count>4</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-07-22 15:11:34 -0700</bug_when>
    <thetext>Committed as http://trac.webkit.org/changeset/46241</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>33251</attachid>
            <date>2009-07-22 03:25:30 -0700</date>
            <delta_ts>2009-07-22 09:14:35 -0700</delta_ts>
            <desc>Inform V8 of the amount of external memory kept alive by external strings.</desc>
            <filename>external-strings.txt</filename>
            <type>text/plain</type>
            <size>1634</size>
            <attacher name="Mads Ager">ager</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA0NjIxOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMjAgQEAKKzIwMDktMDctMjIgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0ub3Jn
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluZm9y
bSBWOCBvZiB0aGUgYW1vdW50IG9mIFdlYkNvcmUgc3RyaW5nIG1lbW9yeSBpdCBpcyBrZWVwaW5n
IGFsaXZlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
Mjc1MzcKKworICAgICAgICBWOCB1c2VzIGV4dGVybmFsIHN0cmluZ3MgdGhhdCBhcmUgYmFja2Vk
IGJ5IFdlYkNvcmUgc3RyaW5ncy4gU2luY2UKKyAgICAgICAgdGhlIGV4dGVybmFsIHN0cmluZ3Mg
dGhlbXNlbHZlcyBhcmUgc21hbGwsIFY4IGhhcyBubyB3YXkgb2YKKyAgICAgICAga25vd2luZyBo
b3cgbXVjaCBtZW1vcnkgaXQgaXMgYWN0dWFsbHkgaG9sZGluZyBvbiB0by4gV2l0aCB0aGlzCisg
ICAgICAgIGNoYW5nZSwgd2UgaW5mb3JtIFY4IG9mIHRoZSBhbW91bnQgb2YgV2ViQ29yZSBzdHJp
bmcgZGF0YSBpdCBpcworICAgICAgICBob2xkaW5nIG9uIHRvIHdpdGggZXh0ZXJuYWwgc3RyaW5n
cy4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHA6CisgICAgICAgIChXZWJD
b3JlOjpXZWJDb3JlU3RyaW5nUmVzb3VyY2U6OldlYkNvcmVTdHJpbmdSZXNvdXJjZSk6CisgICAg
ICAgIChXZWJDb3JlOjpXZWJDb3JlU3RyaW5nUmVzb3VyY2U6On5XZWJDb3JlU3RyaW5nUmVzb3Vy
Y2UpOgorCiAyMDA5LTA3LTIyICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAg
ICAgICBBdHRlbXB0IHRvIGZpeCB0aGUgR1RLKyBidWlsZC4KSW5kZXg6IFdlYkNvcmUvYmluZGlu
Z3MvdjgvVjhCaW5kaW5nLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4
QmluZGluZy5jcHAJKHJldmlzaW9uIDQ2MTU2KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJp
bmRpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OCw5ICs0OCwxMyBAQCBwdWJsaWM6CiAgICAg
ZXhwbGljaXQgV2ViQ29yZVN0cmluZ1Jlc291cmNlKGNvbnN0IFN0cmluZyYgc3RyaW5nKQogICAg
ICAgICA6IG1faW1wbChzdHJpbmcuaW1wbCgpKQogICAgIHsKKyAgICAgICAgdjg6OlY4OjpBZGp1
c3RBbW91bnRPZkV4dGVybmFsQWxsb2NhdGVkTWVtb3J5KDIgKiBsZW5ndGgoKSk7CiAgICAgfQog
Ci0gICAgdmlydHVhbCB+V2ViQ29yZVN0cmluZ1Jlc291cmNlKCkgeyB9CisgICAgdmlydHVhbCB+
V2ViQ29yZVN0cmluZ1Jlc291cmNlKCkKKyAgICB7CisgICAgICAgIHY4OjpWODo6QWRqdXN0QW1v
dW50T2ZFeHRlcm5hbEFsbG9jYXRlZE1lbW9yeSgtMiAqIGxlbmd0aCgpKTsKKyAgICB9CiAKICAg
ICBjb25zdCB1aW50MTZfdCogZGF0YSgpIGNvbnN0CiAgICAgewo=
</data>
<flag name="review"
          id="17563"
          type_id="1"
          status="+"
          setter="levin"
    />
          </attachment>
      

    </bug>

</bugzilla>