<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>275352</bug_id>
          
          <creation_ts>2024-06-11 04:39:42 -0700</creation_ts>
          <short_desc>Remove Trusted Types enforcement from toggleAttribute</short_desc>
          <delta_ts>2024-06-12 09:58:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>Safari 17</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://github.com/web-platform-tests/wpt/pull/46691</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>266630</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Luke Warlow">lwarlow</reporter>
          <assigned_to name="Luke Warlow">lwarlow</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2040772</commentid>
    <comment_count>0</comment_count>
    <who name="Luke Warlow">lwarlow</who>
    <bug_when>2024-06-11 04:39:42 -0700</bug_when>
    <thetext>Based on discussions with the chromium folks it turns out the enforcement inside of toggleAttribute was an accidental implementation bug rather than intentional (the integration with DOM was underspecified so the spec originally worked off of the chrome implementation). Based on this and the fact that toggling an attribute isn&apos;t an XSS vulnerability, the spec PR https://github.com/whatwg/dom/pull/1268 has been updated to not include this enforcement.

This bug tracks removing it from WebKit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2040790</commentid>
    <comment_count>1</comment_count>
    <who name="Luke Warlow">lwarlow</who>
    <bug_when>2024-06-11 05:59:09 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/29712</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2040998</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-06-12 09:56:22 -0700</bug_when>
    <thetext>Committed 279950@main (1ae029b5a34e): &lt;https://commits.webkit.org/279950@main&gt;

Reviewed commits have been landed. Closing PR #29712 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2040999</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-06-12 09:58:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/129689673&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>