<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>275321</bug_id>
          
          <creation_ts>2024-06-10 10:56:25 -0700</creation_ts>
          <short_desc>[CMake] Allow using a system-provided libsysprof-capture package</short_desc>
          <delta_ts>2024-08-19 13:39:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>275203</dependson>
          <blocked>277626</blocked>
    
    <blocked>277627</blocked>
    
    <blocked>278341</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrian Perez">aperez</reporter>
          <assigned_to name="Adrian Perez">aperez</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2040631</commentid>
    <comment_count>0</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2024-06-10 10:56:25 -0700</bug_when>
    <thetext>The patch for bug #275203 imported a copy of the libsysprof-capture
library, but some (although not all) Linux distributions provide a
package for it. It would be friendlier towards packagers to allow
opting out of using the bundled copy. This will need adding a new
CMake find-module for the “sysprof-capture-4” pkg-config module and
using that instead depending on the value of a CMake option. As long
as the find-module defines a SysProfCapture::SysProfCapture target
(as does the bundled copy) then this should imply almost no changes
to the existing CMake files.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2040758</commentid>
    <comment_count>1</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2024-06-11 02:13:07 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/29707</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2053255</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-08-16 01:45:41 -0700</bug_when>
    <thetext>Committed 282340@main (9cdef20e38c0): &lt;https://commits.webkit.org/282340@main&gt;

Reviewed commits have been landed. Closing PR #29707 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2053256</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-08-16 01:46:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/134030042&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>