275293 2024-06-08 12:22:37 -0700 [SVG] Handle `repeatEvent` for svg animations 2025-09-17 15:22:20 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=299047 BrowserCompat, InRadar, WPTImpact P2 Normal --- 1 ahmad.saleem792 ahmad.saleem792 sabouhallawa webkit-bug-importer zimmermann oldest_to_newest 2040492 0 ahmad.saleem792 2024-06-08 12:22:37 -0700 Hi Team, While going through SVG Animations failure, I noticed that we fail 'repeat' event. Blink Commit: https://chromium.googlesource.com/chromium/blink/+/f7d3a4aaa8598d79b137dde63e9b401ea351e1e9 WebKit Source: https://github.com/WebKit/WebKit/blob/502bfe649c550c59266753403cb4b2ab86854333/Source/WebCore/svg/animation/SVGSMILElement.cpp Following compiles: > Source/WebCore/dom/EventNames.json: Add -> "repeatEvent": { }, > Source/WebCore/svg/animation/SVGSMILElement.cpp: In 'SVGSMILElement::progress': After: if (oldActiveState == Inactive) startedActiveInterval(); Add following: if (repeat && repeat != m_lastRepeat) smilEventSender().dispatchEventSoon(*this, eventNames().repeatEventEvent); In same, after 'if (seekToTime)' (within same loop) add following: if (repeat) { for (unsigned repeatEventCount = 1; repeatEventCount < repeat; repeatEventCount++) { smilEventSender().dispatchEventSoon(*this, eventNames().repeatEventEvent); } if (m_activeState == Inactive) smilEventSender().dispatchEventSoon(*this, eventNames().repeatEventEvent); } ___ It progress following: https://wpt.fyi/results/svg/animations/repeat-event.svg?label=experimental&label=master&aligned= ___ Just raising so we can fix it. Thanks! 2041534 1 webkit-bug-importer 2024-06-15 12:23:14 -0700 <rdar://problem/129919749> 2135463 2 ahmad.saleem792 2025-08-09 14:34:55 -0700 Pull request: https://github.com/WebKit/WebKit/pull/29658 2136644 3 ews-feeder 2025-08-14 16:14:53 -0700 Committed 298715@main (d7366f00065a): <https://commits.webkit.org/298715@main> Reviewed commits have been landed. Closing PR #29658 and removing active labels.