27529 2009-07-21 22:50:22 -0700 run-webkit-lint checks code which are not changed 2009-07-22 15:10:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hamaji levin levin oldest_to_newest 133702 0 hamaji 2009-07-21 22:50:22 -0700 The run-webkit-lint checks lines around the modified line. 133703 1 33242 hamaji 2009-07-21 22:51:16 -0700 Created attachment 33242 Patch v1 --- 2 files changed, 15 insertions(+), 1 deletions(-) 133711 2 33242 levin 2009-07-21 23:24:30 -0700 Comment on attachment 33242 Patch v1 > if not line_numbers: > for line in diff.lines: > - line_numbers.add(line[1]) > + # When deleted line is not set, it means that > + # the line is newly added. There is no need to wrap this comment. > + if not line[0]: > + line_numbers.add(line[1]) Of course...nice fix. 133903 3 levin 2009-07-22 14:24:25 -0700 Assign to levin for landing. 133934 4 levin 2009-07-22 15:10:46 -0700 Committed as http://trac.webkit.org/changeset/46243 33242 2009-07-21 22:51:16 -0700 2009-07-21 23:24:30 -0700 Patch v1 bug-27529-20090722145115.patch text/plain 1318 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyNmVhZTc0Li4xZGZjNzk4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDct MjEgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBydW4td2Via2l0LWxpbnQgY2hl Y2tzIGNvZGUgd2hpY2ggYXJlIG5vdCBjaGFuZ2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzUyOQorCisgICAgICAgIEFkZCBjaGVjayBpZiB0aGUg bGluZSBpcyBuZXdseSBhZGRlZC4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC1saW50 OgorCiAyMDA5LTA3LTIxICBBZGFtIFRyZWF0ICA8YWRhbS50cmVhdEB0b3JjaG1vYmlsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9TY3JpcHRzL3J1bi13ZWJraXQtbGludCBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdl YmtpdC1saW50CmluZGV4IGJlYjI0OTcuLmRiMDg2NmIgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xz L1NjcmlwdHMvcnVuLXdlYmtpdC1saW50CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdl YmtpdC1saW50CkBAIC0xMDIsNyArMTAyLDEwIEBAIGRlZiBwcm9jZXNzX3BhdGNoKHBhdGNoX3N0 cmluZyk6CiAgICAgICAgICAgICAgICAgIiIiCiAgICAgICAgICAgICAgICAgaWYgbm90IGxpbmVf bnVtYmVyczoKICAgICAgICAgICAgICAgICAgICAgZm9yIGxpbmUgaW4gZGlmZi5saW5lczoKLSAg ICAgICAgICAgICAgICAgICAgICAgIGxpbmVfbnVtYmVycy5hZGQobGluZVsxXSkKKyAgICAgICAg ICAgICAgICAgICAgICAgICMgV2hlbiBkZWxldGVkIGxpbmUgaXMgbm90IHNldCwgaXQgbWVhbnMg dGhhdAorICAgICAgICAgICAgICAgICAgICAgICAgIyB0aGUgbGluZSBpcyBuZXdseSBhZGRlZC4K KyAgICAgICAgICAgICAgICAgICAgICAgIGlmIG5vdCBsaW5lWzBdOgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGxpbmVfbnVtYmVycy5hZGQobGluZVsxXSkKIAogICAgICAgICAgICAgICAg IGlmIGxpbmVfbnVtYmVyIGluIGxpbmVfbnVtYmVyczoKICAgICAgICAgICAgICAgICAgICAgY3Bw bGludC5lcnJvcihmaWxlbmFtZSwgbGluZV9udW1iZXIsIGNhdGVnb3J5LCBjb25maWRlbmNlLCBt ZXNzYWdlKQ==