27526 2009-07-21 16:55:24 -0700 Inspector: Removing an Attribute via Edit should Delete the Attribute, Not Ignore Your Changes 2009-07-24 23:51:40 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All OS X 10.5 RESOLVED DUPLICATE 27673 P2 Normal --- 0 joepeck webkit-unassigned oldest_to_newest 133657 0 joepeck 2009-07-21 16:55:24 -0700 This decision must have been made in the past. When editing an element's attribute in the Element Panel's Tree, if you remove all of the text and commit the change, your changes are ignored. I would have expected this to remove the attribute. Was there a good reason for this? Was it to prevent accidental errors? Otherwise there is no way to remove an attribute via the tree (you can always use the console). 133667 1 33231 joepeck 2009-07-21 17:37:59 -0700 Created attachment 33231 Removing an Attribute Deletes the Attribute - And Fix Possible Exception NOTES: 1. This will delete an attribute _if_ that attribute previously existed. The only time an attribute would not previously exist would be if it is a "new" attribute. This means this is compatible with the (uncommitted) patch on the following bug to create new attributes: https://bugs.webkit.org/show_bug.cgi?id=21108 2. This fixes an error that has been around for a while where an invalid attribute from user input (such as "-") can cause an error. An example test case will be attached in a minute. 133668 2 33232 joepeck 2009-07-21 17:39:07 -0700 Created attachment 33232 Example Page Showing the Caught Error This shows why the try/catch fixes an error. If the user edits an attribute and changes all the text to "-" the innerHTML works fine but the setAttribute() would throw an Error. 134435 3 33231 abarth 2009-07-24 00:55:43 -0700 Comment on attachment 33231 Removing an Attribute Deletes the Attribute - And Fix Possible Exception This patch does not apply cleanly to TOT. I haven't looked whether the merge is trivial. 134539 4 33439 joepeck 2009-07-24 07:12:55 -0700 Created attachment 33439 Applies to ToT - Fixed a Style Issue as well 134713 5 33439 joepeck 2009-07-24 23:29:33 -0700 Comment on attachment 33439 Applies to ToT I added this functionality into bug 27673, which does more and includes this feature. 134715 6 joepeck 2009-07-24 23:51:40 -0700 *** This bug has been marked as a duplicate of bug 27673 *** 33231 2009-07-21 17:37:59 -0700 2009-07-24 07:12:55 -0700 Removing an Attribute Deletes the Attribute - And Fix Possible Exception patch.patch text/plain 2465 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDAwZmZiYS4uYmMzMWIzZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxNiBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIEluc3BlY3RvcjogUmVtb3ZpbmcgYW4gQXR0cmlidXRl IHZpYSBFZGl0IHNob3VsZCBEZWxldGUgdGhlIEF0dHJpYnV0ZSwgTm90IElnbm9yZSBZb3VyIENo YW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3 NTI2CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVudC5wcm90b3R5cGUu X2F0dHJpYnV0ZUVkaXRpbmdDb21taXR0ZWQpOgorCisyMDA5LTA3LTIxICBKb3NlcGggUGVjb3Jh cm8gIDxqb2VwZWNrMDJAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCiAgICAgICAgIEluc3BlY3RvcjogSW1wb3NzaWJsZSB0byBhZGQgYW4gYXR0cmli dXRlIHRvIGEgbm9kZSB3aXRob3V0IGF0dHJpYnV0ZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTA4CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzIGIvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKaW5kZXggZjUwNDZiZi4uOWJkYTFh MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91 dGxpbmUuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91 dGxpbmUuanMKQEAgLTYyNSwxNiArNjI1LDI1IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVF bGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIHBhcnNlQ29udGFpbmVyRWxlbWVudCA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNwYW4iKTsKICAgICAgICAgcGFyc2VDb250YWluZXJF bGVtZW50LmlubmVySFRNTCA9ICI8c3BhbiAiICsgbmV3VGV4dCArICI+PC9zcGFuPiI7CiAgICAg ICAgIHZhciBwYXJzZUVsZW1lbnQgPSBwYXJzZUNvbnRhaW5lckVsZW1lbnQuZmlyc3RDaGlsZDsK LSAgICAgICAgaWYgKCFwYXJzZUVsZW1lbnQgfHwgIXBhcnNlRWxlbWVudC5oYXNBdHRyaWJ1dGVz KCkpIHsKKyAgICAgICAgaWYgKCFwYXJzZUVsZW1lbnQpIHsKICAgICAgICAgICAgIHRoaXMuX2Vk aXRpbmdDYW5jZWxsZWQoZWxlbWVudCwgYXR0cmlidXRlTmFtZSk7CiAgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgIH0KIAorICAgICAgICBpZiAoIXBhcnNlRWxlbWVudC5oYXNBdHRyaWJ1dGVz KCkpIHsKKyAgICAgICAgICAgIGlmICggdGhpcy5yZXByZXNlbnRlZE9iamVjdC5nZXRBdHRyaWJ1 dGUoYXR0cmlidXRlTmFtZSkgKQorICAgICAgICAgICAgICAgIEluc3BlY3RvckNvbnRyb2xsZXIu aW5zcGVjdGVkV2luZG93KCkuRWxlbWVudC5wcm90b3R5cGUucmVtb3ZlQXR0cmlidXRlLmNhbGwo dGhpcy5yZXByZXNlbnRlZE9iamVjdCwgYXR0cmlidXRlTmFtZSk7CisgICAgICAgICAgICB0aGlz Ll91cGRhdGVUaXRsZSgpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKICAgICAg ICAgdmFyIGZvdW5kT3JpZ2luYWxBdHRyaWJ1dGUgPSBmYWxzZTsKICAgICAgICAgZm9yICh2YXIg aSA9IDA7IGkgPCBwYXJzZUVsZW1lbnQuYXR0cmlidXRlcy5sZW5ndGg7ICsraSkgewogICAgICAg ICAgICAgdmFyIGF0dHIgPSBwYXJzZUVsZW1lbnQuYXR0cmlidXRlc1tpXTsKICAgICAgICAgICAg IGZvdW5kT3JpZ2luYWxBdHRyaWJ1dGUgPSBmb3VuZE9yaWdpbmFsQXR0cmlidXRlIHx8IGF0dHIu bmFtZSA9PT0gYXR0cmlidXRlTmFtZTsKLSAgICAgICAgICAgIEluc3BlY3RvckNvbnRyb2xsZXIu aW5zcGVjdGVkV2luZG93KCkuRWxlbWVudC5wcm90b3R5cGUuc2V0QXR0cmlidXRlLmNhbGwodGhp cy5yZXByZXNlbnRlZE9iamVjdCwgYXR0ci5uYW1lLCBhdHRyLnZhbHVlKTsKKyAgICAgICAgICAg IHRyeSB7CisgICAgICAgICAgICAgICAgSW5zcGVjdG9yQ29udHJvbGxlci5pbnNwZWN0ZWRXaW5k b3coKS5FbGVtZW50LnByb3RvdHlwZS5zZXRBdHRyaWJ1dGUuY2FsbCh0aGlzLnJlcHJlc2VudGVk T2JqZWN0LCBhdHRyLm5hbWUsIGF0dHIudmFsdWUpOworICAgICAgICAgICAgfSBjYXRjaChlKSB7 fSAvLyBpZ25vcmUgaW52YWxpZCBhdHRyaWJ1dGUgKGlubmVySFRNTCBkb2Vzbid0IHRocm93IGVy cm9ycywgYnV0IHRoaXMgY2FuKQogICAgICAgICB9CiAKICAgICAgICAgaWYgKCFmb3VuZE9yaWdp bmFsQXR0cmlidXRlKQo= 33232 2009-07-21 17:39:07 -0700 2009-07-21 17:39:07 -0700 Example Page Showing the Caught Error example_error.html text/html 819 joepeck PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9FTiIK CSJodHRwOi8vd3d3LnczLm9yZy9UUi94aHRtbDEvRFREL3hodG1sMS1zdHJpY3QuZHRkIj4KPGh0 bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJlbiIgbGFu Zz0iZW4iPgo8aGVhZD4KCTxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ii8+Cgk8dGl0bGU+RE9NIEVycm9yPC90aXRsZT4KPC9o ZWFkPgo8Ym9keT4KICA8aDEgaWQ9IngiPkNoZWNrIENvbnNvbGU8L2gxPgogIDxzY3JpcHQgdHlw ZT0idGV4dC9qYXZhc2NyaXB0Ij4KCiAgICB2YXIgYSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo J3NwYW4nKTsKICAgIGEuaW5uZXJIVE1MID0gJzxzcGFuIC0gPjwvc3Bhbj4nOwogICAgdmFyIHgg PSBhLmZpcnN0Q2hpbGQ7CiAgICB2YXIgYiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3NwYW4n KTsKCiAgICBmb3IgKHZhciBpPTAsIGxlbj14LmF0dHJpYnV0ZXMubGVuZ3RoOyBpPGxlbjsgKytp KSB7CiAgICAgIHZhciBhdHRyID0geC5hdHRyaWJ1dGVzW2ldOwogICAgICBjb25zb2xlLmxvZyhh dHRyKTsKICAgICAgdHJ5IHsKICAgICAgICBiLnNldEF0dHJpYnV0ZShhdHRyLm5hbWUsIGF0dHIu dmFsdWUpOwogICAgICB9IGNhdGNoKGUpIHsKICAgICAgICBjb25zb2xlLmxvZygnQ2F1Z2h0IGV4 Y2VwdGlvbicpOwogICAgICAgIGNvbnNvbGUubG9nKGUpOwogICAgICB9CiAgICB9CgogIDwvc2Ny aXB0Pgo8L2JvZHk+CjwvaHRtbD4K 33439 2009-07-24 07:12:55 -0700 2009-07-24 23:29:33 -0700 Applies to ToT better.patch text/plain 2375 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmE3MzY5YS4uMzZmNjhkMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNy0yNCAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVjazAyQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbnNwZWN0b3I6IFJlbW92aW5nIGFuIEF0dHJpYnV0ZSB2aWEg RWRpdCBzaG91bGQgRGVsZXRlIHRoZSBBdHRyaWJ1dGUsIE5vdCBJZ25vcmUgWW91ciBDaGFuZ2Vz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzUyNgor CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlLl9hdHRy aWJ1dGVFZGl0aW5nQ29tbWl0dGVkKToKKwogPDw8PDw8PCBVcGRhdGVkIHVwc3RyZWFtOldlYkNv cmUvQ2hhbmdlTG9nCiAyMDA5LTA3LTI0ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4K IApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91 dGxpbmUuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGlu ZS5qcwppbmRleCAwYzkyZDUyLi43OTdjZGE1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwpAQCAtNjQyLDE2ICs2NDIsMjUgQEAg V2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgICAgICB2 YXIgcGFyc2VDb250YWluZXJFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic3BhbiIp OwogICAgICAgICBwYXJzZUNvbnRhaW5lckVsZW1lbnQuaW5uZXJIVE1MID0gIjxzcGFuICIgKyBu ZXdUZXh0ICsgIj48L3NwYW4+IjsKICAgICAgICAgdmFyIHBhcnNlRWxlbWVudCA9IHBhcnNlQ29u dGFpbmVyRWxlbWVudC5maXJzdENoaWxkOwotICAgICAgICBpZiAoIXBhcnNlRWxlbWVudCB8fCAh cGFyc2VFbGVtZW50Lmhhc0F0dHJpYnV0ZXMoKSkgeworICAgICAgICBpZiAoIXBhcnNlRWxlbWVu dCkgewogICAgICAgICAgICAgdGhpcy5fZWRpdGluZ0NhbmNlbGxlZChlbGVtZW50LCBhdHRyaWJ1 dGVOYW1lKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCisgICAgICAgIGlmICgh cGFyc2VFbGVtZW50Lmhhc0F0dHJpYnV0ZXMoKSkgeworICAgICAgICAgICAgaWYgKHRoaXMucmVw cmVzZW50ZWRPYmplY3QuZ2V0QXR0cmlidXRlKGF0dHJpYnV0ZU5hbWUpKQorICAgICAgICAgICAg ICAgIEluc3BlY3RvckNvbnRyb2xsZXIuaW5zcGVjdGVkV2luZG93KCkuRWxlbWVudC5wcm90b3R5 cGUucmVtb3ZlQXR0cmlidXRlLmNhbGwodGhpcy5yZXByZXNlbnRlZE9iamVjdCwgYXR0cmlidXRl TmFtZSk7CisgICAgICAgICAgICB0aGlzLl91cGRhdGVUaXRsZSgpOworICAgICAgICAgICAgcmV0 dXJuOworICAgICAgICB9CisKICAgICAgICAgdmFyIGZvdW5kT3JpZ2luYWxBdHRyaWJ1dGUgPSBm YWxzZTsKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBwYXJzZUVsZW1lbnQuYXR0cmlidXRl cy5sZW5ndGg7ICsraSkgewogICAgICAgICAgICAgdmFyIGF0dHIgPSBwYXJzZUVsZW1lbnQuYXR0 cmlidXRlc1tpXTsKICAgICAgICAgICAgIGZvdW5kT3JpZ2luYWxBdHRyaWJ1dGUgPSBmb3VuZE9y aWdpbmFsQXR0cmlidXRlIHx8IGF0dHIubmFtZSA9PT0gYXR0cmlidXRlTmFtZTsKLSAgICAgICAg ICAgIEluc3BlY3RvckNvbnRyb2xsZXIuaW5zcGVjdGVkV2luZG93KCkuRWxlbWVudC5wcm90b3R5 cGUuc2V0QXR0cmlidXRlLmNhbGwodGhpcy5yZXByZXNlbnRlZE9iamVjdCwgYXR0ci5uYW1lLCBh dHRyLnZhbHVlKTsKKyAgICAgICAgICAgIHRyeSB7CisgICAgICAgICAgICAgICAgSW5zcGVjdG9y Q29udHJvbGxlci5pbnNwZWN0ZWRXaW5kb3coKS5FbGVtZW50LnByb3RvdHlwZS5zZXRBdHRyaWJ1 dGUuY2FsbCh0aGlzLnJlcHJlc2VudGVkT2JqZWN0LCBhdHRyLm5hbWUsIGF0dHIudmFsdWUpOwor ICAgICAgICAgICAgfSBjYXRjaChlKSB7fSAvLyBpZ25vcmUgaW52YWxpZCBhdHRyaWJ1dGUgKGlu bmVySFRNTCBkb2Vzbid0IHRocm93IGVycm9ycywgYnV0IHRoaXMgY2FuKQogICAgICAgICB9CiAK ICAgICAgICAgaWYgKCFmb3VuZE9yaWdpbmFsQXR0cmlidXRlKQo=