27524 2009-07-21 16:00:18 -0700 Add check for correct wtf includes to cpplint 2009-07-22 12:28:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jpetsovits webkit-unassigned darin manyoso oldest_to_newest 133640 0 jpetsovits 2009-07-21 16:00:18 -0700 Adam Treat told me that wtf includes in WebCore should be included using <wtf/file.h> instead of "wtf/file.h". Here's a check for that, hopefully it's how it should approximately be done. 133646 1 33225 jpetsovits 2009-07-21 16:14:03 -0700 Created attachment 33225 Add check for correct wtf includes in WebCore to cpplint The patch implementing this check. 133653 2 33225 levin 2009-07-21 16:47:31 -0700 Comment on attachment 33225 Add check for correct wtf includes in WebCore to cpplint > diff --git a/WebKitTools/Scripts/modules/cpplint.py b/WebKitTools/Scripts/modules/cpplint.py > + # Check specific include file rules. > + if filename != "-": When is the filename "-" ? > + filepath = os.path.abspath(filename) > + filepath_parts = filepath.split(os.sep) > + if 'WebCore' in filepath_parts: Why only WebCore? I think this is true in all directories. (And if it should only be WebCore, please add a test for this.) > 133666 3 manyoso 2009-07-21 17:37:11 -0700 After talking with Mark Rowe and Dave Levin on IRC it would seem we don't need to detect whether the file is in WebCore or not. All references to a wtf header of the form wtf/foo.h should always be <> style, not "" style. No matter what file is doing the including. 133764 4 33261 jpetsovits 2009-07-22 07:33:58 -0700 Created attachment 33261 Add check for correct wtf includes to cpplint re #3: Cool, that simplifies stuff a lot. Also looks less out of place this way. Please re-review... thanks! 133768 5 33261 manyoso 2009-07-22 07:49:49 -0700 Comment on attachment 33261 Add check for correct wtf includes to cpplint 'wtf includes inside WebCore should be <wtf/file.h> instead of "wtf/file.h".') This should no longer mention 'WebCore'. Just say, "wtf includes should be..." And make sure to change the tests to reflect :) I'd tell you to make the change on landing, but you can't land yet so please post another patch with that change and then I'll land. 133769 6 33263 jpetsovits 2009-07-22 07:54:28 -0700 Created attachment 33263 Add check for correct wtf includes to cpplint Ouch. I adapted the ChangeLog, the commit message and the test function, but that occurrence I forgot... fixed in this version, no other changes. 133773 7 manyoso 2009-07-22 08:20:58 -0700 Landed with r46225. 133820 8 darin 2009-07-22 11:33:09 -0700 An exception would be includes of wtf from files inside wtf itself. These should use the "HashMap.h" style in both headers and implementation files. 133821 9 manyoso 2009-07-22 11:38:50 -0700 (In reply to comment #8) > An exception would be includes of wtf from files inside wtf itself. These > should use the "HashMap.h" style in both headers and implementation files. Talked about this extensively with Mark Rowe and David Levin on IRC. Currently, JavaScriptCore/wtf/Foo.h uses <wtf/Bar.h> all over the place. In fact, one of the things that informed us was a commit by you changing one of the files from "" to <>. 133841 10 darin 2009-07-22 12:28:27 -0700 (In reply to comment #9) > Talked about this extensively with Mark Rowe and David Levin on IRC. > Currently, JavaScriptCore/wtf/Foo.h uses <wtf/Bar.h> all over the place. In > fact, one of the things that informed us was a commit by you changing one of > the files from "" to <>. OK, my bad, but that won’t work on the Mac if we ever decide to make some of the wtf headers be public headers in the JavaScriptCore framework. It would force us to name the framework "wtf". Mark Rowe is definitely an expert in this area, though. 33225 2009-07-21 16:14:03 -0700 2009-07-22 07:33:58 -0700 Add check for correct wtf includes in WebCore to cpplint 0001-Add-check-for-correct-wtf-includes-in-WebCore-to-cpp.patch text/plain 4390 jpetsovits RnJvbSBiYTQyOTAxNTBkOWYzMWNkYzAyNjEwNmExYzI5MzhhMjFjNWNlYWVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBQZXRzb3ZpdHMgPGpha29iLnBldHNvdml0c0B0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IFR1ZSwgMjEgSnVsIDIwMDkgMTk6MTM6MDggLTA0MDAKU3ViamVj dDogW1BBVENIXSBBZGQgY2hlY2sgZm9yIGNvcnJlY3Qgd3RmIGluY2x1ZGVzIGluIFdlYkNvcmUg dG8gY3BwbGludC4KCi0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgfCAgIDEwICsrKysrKysrKysKIFdlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9j cHBsaW50LnB5ICAgICAgICAgIHwgICAxNSArKysrKysrKysrKy0tLS0KIFdlYktpdFRvb2xzL1Nj cmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5IHwgICAxNSArKysrKysrKysrKysrKysK IDMgZmlsZXMgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5k ZXggMjZlYWU3NC4uNjhkY2U4NCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisr KyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDA5LTA3LTIxICBK YWtvYiBQZXRzb3ZpdHMgIDxqYWtvYi5wZXRzb3ZpdHNAdG9yY2htb2JpbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBjaGVjayBmb3Ig Y29ycmVjdCB3dGYgaW5jbHVkZXMgaW4gV2ViQ29yZSB0byBjcHBsaW50LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc1MjQKKworICAgICAgICAqIFNj cmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5OgorICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jcHBs aW50X3VuaXR0ZXN0LnB5OgorCiAyMDA5LTA3LTIxICBBZGFtIFRyZWF0ICA8YWRhbS50cmVhdEB0 b3JjaG1vYmlsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5weSBiL1dlYktpdFRv b2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5CmluZGV4IDQ2N2YwYzMuLjU1NjkxOTkgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5CisrKyBiL1dl YktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5CkBAIC0yMjE2LDE2ICsyMjE2LDIz IEBAIGRlZiBjaGVja19pbmNsdWRlX2xpbmUoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251 bWJlciwgaW5jbHVkZV9zdGF0ZSwgZXJyb3IpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICcl cyBTaG91bGQgYmU6IGNvbmZpZy5oLCBwcmltYXJ5IGhlYWRlciwgYmxhbmsgbGluZSwgYW5kIHRo ZW4gYWxwaGFiZXRpY2FsbHkgc29ydGVkLicgJQogICAgICAgICAgICAgICAgICAgICAgICAgICBl cnJvcl9tZXNzYWdlKQogCi0gICAgIyBMb29rIGZvciBhbnkgb2YgdGhlIHN0cmVhbSBjbGFzc2Vz IHRoYXQgYXJlIHBhcnQgb2Ygc3RhbmRhcmQgQysrLgotICAgIG1hdGNoZWQgPSBfUkVfUEFUVEVS Tl9JTkNMVURFLm1hdGNoKGxpbmUpCi0gICAgaWYgbWF0Y2hlZDoKLSAgICAgICAgaW5jbHVkZSA9 IG1hdGNoZWQuZ3JvdXAoMikKKyAgICAgICAgIyBMb29rIGZvciBhbnkgb2YgdGhlIHN0cmVhbSBj bGFzc2VzIHRoYXQgYXJlIHBhcnQgb2Ygc3RhbmRhcmQgQysrLgogICAgICAgICBpZiBtYXRjaChy JyhmfGluZHxpb3xpfG98cGFyc2V8cGZ8c3RkaW98c3RyfCk/c3RyZWFtJCcsIGluY2x1ZGUpOgog ICAgICAgICAgICAgIyBNYW55IHVuaXQgdGVzdHMgdXNlIGNvdXQsIHNvIHdlIGV4ZW1wdCB0aGVt LgogICAgICAgICAgICAgaWYgbm90IF9pc190ZXN0X2ZpbGVuYW1lKGZpbGVuYW1lKToKICAgICAg ICAgICAgICAgICBlcnJvcihmaWxlbmFtZSwgbGluZV9udW1iZXIsICdyZWFkYWJpbGl0eS9zdHJl YW1zJywgMywKICAgICAgICAgICAgICAgICAgICAgICAnU3RyZWFtcyBhcmUgaGlnaGx5IGRpc2Nv dXJhZ2VkLicpCiAKKyAgICAgICAgIyBDaGVjayBzcGVjaWZpYyBpbmNsdWRlIGZpbGUgcnVsZXMu CisgICAgICAgIGlmIGZpbGVuYW1lICE9ICItIjoKKyAgICAgICAgICAgIGZpbGVwYXRoID0gb3Mu cGF0aC5hYnNwYXRoKGZpbGVuYW1lKQorICAgICAgICAgICAgZmlsZXBhdGhfcGFydHMgPSBmaWxl cGF0aC5zcGxpdChvcy5zZXApCisgICAgICAgICAgICBpZiAnV2ViQ29yZScgaW4gZmlsZXBhdGhf cGFydHM6CisgICAgICAgICAgICAgICAgaWYgaW5jbHVkZS5zdGFydHN3aXRoKCd3dGYvJykgYW5k IG5vdCBpc19zeXN0ZW06CisgICAgICAgICAgICAgICAgICAgIGVycm9yKGZpbGVuYW1lLCBsaW5l X251bWJlciwgJ2J1aWxkL2luY2x1ZGUnLCA0LAorICAgICAgICAgICAgICAgICAgICAgICAgICAn d3RmIGluY2x1ZGVzIGluc2lkZSBXZWJDb3JlIHNob3VsZCBiZSA8d3RmL2ZpbGUuaD4gaW5zdGVh ZCBvZiAid3RmL2ZpbGUuaCIuJykKKworCiBkZWYgY2hlY2tfbGFuZ3VhZ2UoZmlsZW5hbWUsIGNs ZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9leHRlbnNpb24sIGluY2x1ZGVfc3RhdGUsCiAg ICAgICAgICAgICAgICAgICAgZXJyb3IpOgogICAgICIiIkNoZWNrcyBydWxlcyBmcm9tIHRoZSAn QysrIGxhbmd1YWdlIHJ1bGVzJyBzZWN0aW9uIG9mIGNwcGd1aWRlLmh0bWwuCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weSBiL1dlYktp dFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5CmluZGV4IDZmZDY4ZTYu LjY5OTVmNTEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50 X3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3Vu aXR0ZXN0LnB5CkBAIC0yMTU2LDYgKzIxNTYsMjEgQEAgY2xhc3MgT3JkZXJPZkluY2x1ZGVzVGVz dChDcHBsaW50VGVzdEJhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAnI2luY2x1ZGUgImEuaCJcbicsICMgU2hvdWxkIHN0aWxsIGZsYWcgdGhpcy4KICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ0FscGhhYmV0aWNhbCBzb3J0aW5n IHByb2JsZW0uICBbYnVpbGQvaW5jbHVkZV9vcmRlcl0gWzRdJykKIAorICAgIGRlZiB0ZXN0X2No ZWNrX3dlYmNvcmVfaW5jbHVkZXMoc2VsZik6CisgICAgICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdl X3J1bGVzX2NoZWNrKCcvaG9tZS9iYXIvd2Via2l0L1dlYkNvcmUvZG9tL2Zvby5jcHAnLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgImNvbmZpZy5o IlxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUg ImZvby5oIlxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnXG4n CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcjaW5jbHVkZSA8d3Rm L0Fzc2VydGlvbnMuaD5cbicsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICcnKQorICAgICAgICBzZWxmLmFzc2VydF9sYW5ndWFnZV9ydWxlc19jaGVjaygnL2hvbWUv YmFyL3dlYmtpdC9XZWJDb3JlL2RvbS9mb28uY3BwJywKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJjb25maWcuaCJcbicKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJmb28uaCJcbicKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ1xuJworICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgInd0Zi9Bc3NlcnRpb25zLmgiXG4nLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnd3RmIGluY2x1ZGVzIGlu c2lkZSBXZWJDb3JlIHNob3VsZCBiZSA8d3RmL2ZpbGUuaD4gaW5zdGVhZCBvZiAid3RmL2ZpbGUu aCIuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnICBbYnVpbGQv aW5jbHVkZV0gWzRdJykKKwogICAgIGRlZiB0ZXN0X2NsYXNzaWZ5X2luY2x1ZGUoc2VsZik6CiAg ICAgICAgIGNsYXNzaWZ5X2luY2x1ZGUgPSBjcHBsaW50Ll9jbGFzc2lmeV9pbmNsdWRlCiAgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWwoY3BwbGludC5fQ09ORklHX0hFQURFUiwKLS0gCjEuNi4zLjMK Cg== 33261 2009-07-22 07:33:58 -0700 2009-07-22 07:54:28 -0700 Add check for correct wtf includes to cpplint 0001-Add-check-for-correct-wtf-includes-to-cpplint.patch text/plain 4101 jpetsovits RnJvbSBiYTc5ZDdkOGVmMjQwMzE3N2M4ZTEzMDYyYzU3MDQzNjRhNjYwNjQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBQZXRzb3ZpdHMgPGpha29iLnBldHNvdml0c0B0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IFdlZCwgMjIgSnVsIDIwMDkgMTA6MzE6NDMgLTA0MDAKU3ViamVj dDogW1BBVENIXSBBZGQgY2hlY2sgZm9yIGNvcnJlY3Qgd3RmIGluY2x1ZGVzIHRvIGNwcGxpbnQu CgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAxMCArKysrKysrKysrCiBXZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5weSAg ICAgICAgICB8ICAgMTEgKysrKysrKy0tLS0KIFdlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9j cHBsaW50X3VuaXR0ZXN0LnB5IHwgICAxNSArKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdl ZCwgMzIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggMjZlYWU3NC4uY2Fl NWFhNiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDA5LTA3LTIxICBKYWtvYiBQZXRzb3ZpdHMg IDxqYWtvYi5wZXRzb3ZpdHNAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBjaGVjayBmb3IgY29ycmVjdCB3dGYgaW5j bHVkZXMgdG8gY3BwbGludC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI3NTI0CisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY3BwbGludC5weToK KyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weToKKwogMjAwOS0w Ny0yMSAgQWRhbSBUcmVhdCAgPGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy9tb2R1bGVzL2NwcGxpbnQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGlu dC5weQppbmRleCA0NjdmMGMzLi44ZWM2OGUyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3Jp cHRzL21vZHVsZXMvY3BwbGludC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMv Y3BwbGludC5weQpAQCAtMjIxNiwxNiArMjIxNiwxOSBAQCBkZWYgY2hlY2tfaW5jbHVkZV9saW5l KGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGluY2x1ZGVfc3RhdGUsIGVycm9y KQogICAgICAgICAgICAgICAgICAgICAgICAgICAnJXMgU2hvdWxkIGJlOiBjb25maWcuaCwgcHJp bWFyeSBoZWFkZXIsIGJsYW5rIGxpbmUsIGFuZCB0aGVuIGFscGhhYmV0aWNhbGx5IHNvcnRlZC4n ICUKICAgICAgICAgICAgICAgICAgICAgICAgICAgZXJyb3JfbWVzc2FnZSkKIAotICAgICMgTG9v ayBmb3IgYW55IG9mIHRoZSBzdHJlYW0gY2xhc3NlcyB0aGF0IGFyZSBwYXJ0IG9mIHN0YW5kYXJk IEMrKy4KLSAgICBtYXRjaGVkID0gX1JFX1BBVFRFUk5fSU5DTFVERS5tYXRjaChsaW5lKQotICAg IGlmIG1hdGNoZWQ6Ci0gICAgICAgIGluY2x1ZGUgPSBtYXRjaGVkLmdyb3VwKDIpCisgICAgICAg ICMgTG9vayBmb3IgYW55IG9mIHRoZSBzdHJlYW0gY2xhc3NlcyB0aGF0IGFyZSBwYXJ0IG9mIHN0 YW5kYXJkIEMrKy4KICAgICAgICAgaWYgbWF0Y2gocicoZnxpbmR8aW98aXxvfHBhcnNlfHBmfHN0 ZGlvfHN0cnwpP3N0cmVhbSQnLCBpbmNsdWRlKToKICAgICAgICAgICAgICMgTWFueSB1bml0IHRl c3RzIHVzZSBjb3V0LCBzbyB3ZSBleGVtcHQgdGhlbS4KICAgICAgICAgICAgIGlmIG5vdCBfaXNf dGVzdF9maWxlbmFtZShmaWxlbmFtZSk6CiAgICAgICAgICAgICAgICAgZXJyb3IoZmlsZW5hbWUs IGxpbmVfbnVtYmVyLCAncmVhZGFiaWxpdHkvc3RyZWFtcycsIDMsCiAgICAgICAgICAgICAgICAg ICAgICAgJ1N0cmVhbXMgYXJlIGhpZ2hseSBkaXNjb3VyYWdlZC4nKQogCisgICAgICAgICMgTG9v ayBmb3Igc3BlY2lmaWMgaW5jbHVkZXMgdG8gZml4LgorICAgICAgICBpZiBpbmNsdWRlLnN0YXJ0 c3dpdGgoJ3d0Zi8nKSBhbmQgbm90IGlzX3N5c3RlbToKKyAgICAgICAgICAgIGVycm9yKGZpbGVu YW1lLCBsaW5lX251bWJlciwgJ2J1aWxkL2luY2x1ZGUnLCA0LAorICAgICAgICAgICAgICAgICAg J3d0ZiBpbmNsdWRlcyBpbnNpZGUgV2ViQ29yZSBzaG91bGQgYmUgPHd0Zi9maWxlLmg+IGluc3Rl YWQgb2YgInd0Zi9maWxlLmgiLicpCisKKwogZGVmIGNoZWNrX2xhbmd1YWdlKGZpbGVuYW1lLCBj bGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfZXh0ZW5zaW9uLCBpbmNsdWRlX3N0YXRlLAog ICAgICAgICAgICAgICAgICAgIGVycm9yKToKICAgICAiIiJDaGVja3MgcnVsZXMgZnJvbSB0aGUg J0MrKyBsYW5ndWFnZSBydWxlcycgc2VjdGlvbiBvZiBjcHBndWlkZS5odG1sLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRfdW5pdHRlc3QucHkgYi9XZWJL aXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weQppbmRleCA2ZmQ2OGU2 Li5kYjczOGQxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGlu dF91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91 bml0dGVzdC5weQpAQCAtMjE1Niw2ICsyMTU2LDIxIEBAIGNsYXNzIE9yZGVyT2ZJbmNsdWRlc1Rl c3QoQ3BwbGludFRlc3RCYXNlKToKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJyNpbmNsdWRlICJhLmgiXG4nLCAjIFNob3VsZCBzdGlsbCBmbGFnIHRoaXMuCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdBbHBoYWJldGljYWwgc29ydGlu ZyBwcm9ibGVtLiAgW2J1aWxkL2luY2x1ZGVfb3JkZXJdIFs0XScpCiAKKyAgICBkZWYgdGVzdF9j aGVja193dGZfaW5jbHVkZXMoc2VsZik6CisgICAgICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdlX3J1 bGVzX2NoZWNrKCdmb28uY3BwJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJyNpbmNsdWRlICJjb25maWcuaCJcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJyNpbmNsdWRlICJmb28uaCJcbicKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJ1xuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAnI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+XG4nLAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGFu Z3VhZ2VfcnVsZXNfY2hlY2soJ2Zvby5jcHAnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAnI2luY2x1ZGUgImNvbmZpZy5oIlxuJworICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgImZvby5oIlxuJworICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnXG4nCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICcjaW5jbHVkZSAid3RmL0Fzc2VydGlvbnMuaCJcbicsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICd3dGYgaW5jbHVkZXMgaW5zaWRl IFdlYkNvcmUgc2hvdWxkIGJlIDx3dGYvZmlsZS5oPiBpbnN0ZWFkIG9mICJ3dGYvZmlsZS5oIi4n CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcgIFtidWlsZC9pbmNs dWRlXSBbNF0nKQorCiAgICAgZGVmIHRlc3RfY2xhc3NpZnlfaW5jbHVkZShzZWxmKToKICAgICAg ICAgY2xhc3NpZnlfaW5jbHVkZSA9IGNwcGxpbnQuX2NsYXNzaWZ5X2luY2x1ZGUKICAgICAgICAg c2VsZi5hc3NlcnRFcXVhbChjcHBsaW50Ll9DT05GSUdfSEVBREVSLAotLSAKMS42LjMuMwoK 33263 2009-07-22 07:54:28 -0700 2009-07-22 07:56:39 -0700 Add check for correct wtf includes to cpplint 0001-Add-check-for-correct-wtf-includes-to-cpplint.patch text/plain 4071 jpetsovits RnJvbSBhZjMyZGQyMmExNzQ5YjY2MGM0OTFjOWMzOTk3MDQxOWFmNWRmMzg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBQZXRzb3ZpdHMgPGpha29iLnBldHNvdml0c0B0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IFdlZCwgMjIgSnVsIDIwMDkgMTA6NTI6MjAgLTA0MDAKU3ViamVj dDogW1BBVENIXSBBZGQgY2hlY2sgZm9yIGNvcnJlY3Qgd3RmIGluY2x1ZGVzIHRvIGNwcGxpbnQu CgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAxMCArKysrKysrKysrCiBXZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5weSAg ICAgICAgICB8ICAgMTEgKysrKysrKy0tLS0KIFdlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9j cHBsaW50X3VuaXR0ZXN0LnB5IHwgICAxNSArKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdl ZCwgMzIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggMjZlYWU3NC4uY2Fl NWFhNiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDA5LTA3LTIxICBKYWtvYiBQZXRzb3ZpdHMg IDxqYWtvYi5wZXRzb3ZpdHNAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBjaGVjayBmb3IgY29ycmVjdCB3dGYgaW5j bHVkZXMgdG8gY3BwbGludC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI3NTI0CisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY3BwbGludC5weToK KyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weToKKwogMjAwOS0w Ny0yMSAgQWRhbSBUcmVhdCAgPGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy9tb2R1bGVzL2NwcGxpbnQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGlu dC5weQppbmRleCA0NjdmMGMzLi41Y2I3NTI2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3Jp cHRzL21vZHVsZXMvY3BwbGludC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMv Y3BwbGludC5weQpAQCAtMjIxNiwxNiArMjIxNiwxOSBAQCBkZWYgY2hlY2tfaW5jbHVkZV9saW5l KGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGluY2x1ZGVfc3RhdGUsIGVycm9y KQogICAgICAgICAgICAgICAgICAgICAgICAgICAnJXMgU2hvdWxkIGJlOiBjb25maWcuaCwgcHJp bWFyeSBoZWFkZXIsIGJsYW5rIGxpbmUsIGFuZCB0aGVuIGFscGhhYmV0aWNhbGx5IHNvcnRlZC4n ICUKICAgICAgICAgICAgICAgICAgICAgICAgICAgZXJyb3JfbWVzc2FnZSkKIAotICAgICMgTG9v ayBmb3IgYW55IG9mIHRoZSBzdHJlYW0gY2xhc3NlcyB0aGF0IGFyZSBwYXJ0IG9mIHN0YW5kYXJk IEMrKy4KLSAgICBtYXRjaGVkID0gX1JFX1BBVFRFUk5fSU5DTFVERS5tYXRjaChsaW5lKQotICAg IGlmIG1hdGNoZWQ6Ci0gICAgICAgIGluY2x1ZGUgPSBtYXRjaGVkLmdyb3VwKDIpCisgICAgICAg ICMgTG9vayBmb3IgYW55IG9mIHRoZSBzdHJlYW0gY2xhc3NlcyB0aGF0IGFyZSBwYXJ0IG9mIHN0 YW5kYXJkIEMrKy4KICAgICAgICAgaWYgbWF0Y2gocicoZnxpbmR8aW98aXxvfHBhcnNlfHBmfHN0 ZGlvfHN0cnwpP3N0cmVhbSQnLCBpbmNsdWRlKToKICAgICAgICAgICAgICMgTWFueSB1bml0IHRl c3RzIHVzZSBjb3V0LCBzbyB3ZSBleGVtcHQgdGhlbS4KICAgICAgICAgICAgIGlmIG5vdCBfaXNf dGVzdF9maWxlbmFtZShmaWxlbmFtZSk6CiAgICAgICAgICAgICAgICAgZXJyb3IoZmlsZW5hbWUs IGxpbmVfbnVtYmVyLCAncmVhZGFiaWxpdHkvc3RyZWFtcycsIDMsCiAgICAgICAgICAgICAgICAg ICAgICAgJ1N0cmVhbXMgYXJlIGhpZ2hseSBkaXNjb3VyYWdlZC4nKQogCisgICAgICAgICMgTG9v ayBmb3Igc3BlY2lmaWMgaW5jbHVkZXMgdG8gZml4LgorICAgICAgICBpZiBpbmNsdWRlLnN0YXJ0 c3dpdGgoJ3d0Zi8nKSBhbmQgbm90IGlzX3N5c3RlbToKKyAgICAgICAgICAgIGVycm9yKGZpbGVu YW1lLCBsaW5lX251bWJlciwgJ2J1aWxkL2luY2x1ZGUnLCA0LAorICAgICAgICAgICAgICAgICAg J3d0ZiBpbmNsdWRlcyBzaG91bGQgYmUgPHd0Zi9maWxlLmg+IGluc3RlYWQgb2YgInd0Zi9maWxl LmgiLicpCisKKwogZGVmIGNoZWNrX2xhbmd1YWdlKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGlu ZV9udW1iZXIsIGZpbGVfZXh0ZW5zaW9uLCBpbmNsdWRlX3N0YXRlLAogICAgICAgICAgICAgICAg ICAgIGVycm9yKToKICAgICAiIiJDaGVja3MgcnVsZXMgZnJvbSB0aGUgJ0MrKyBsYW5ndWFnZSBy dWxlcycgc2VjdGlvbiBvZiBjcHBndWlkZS5odG1sLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv U2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRz L21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weQppbmRleCA2ZmQ2OGU2Li5hNTExZjA5IDEwMDY0 NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weQor KysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weQpAQCAt MjE1Niw2ICsyMTU2LDIxIEBAIGNsYXNzIE9yZGVyT2ZJbmNsdWRlc1Rlc3QoQ3BwbGludFRlc3RC YXNlKToKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRl ICJhLmgiXG4nLCAjIFNob3VsZCBzdGlsbCBmbGFnIHRoaXMuCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICdBbHBoYWJldGljYWwgc29ydGluZyBwcm9ibGVtLiAgW2J1 aWxkL2luY2x1ZGVfb3JkZXJdIFs0XScpCiAKKyAgICBkZWYgdGVzdF9jaGVja193dGZfaW5jbHVk ZXMoc2VsZik6CisgICAgICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdlX3J1bGVzX2NoZWNrKCdmb28u Y3BwJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRl ICJjb25maWcuaCJcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg JyNpbmNsdWRlICJmb28uaCJcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJ1xuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2lu Y2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+XG4nLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGFuZ3VhZ2VfcnVsZXNfY2hl Y2soJ2Zvby5jcHAnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAn I2luY2x1ZGUgImNvbmZpZy5oIlxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAnI2luY2x1ZGUgImZvby5oIlxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAnXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICcjaW5jbHVkZSAid3RmL0Fzc2VydGlvbnMuaCJcbicsCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICd3dGYgaW5jbHVkZXMgc2hvdWxkIGJlIDx3dGYvZmlsZS5o PiBpbnN0ZWFkIG9mICJ3dGYvZmlsZS5oIi4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICcgIFtidWlsZC9pbmNsdWRlXSBbNF0nKQorCiAgICAgZGVmIHRlc3RfY2xh c3NpZnlfaW5jbHVkZShzZWxmKToKICAgICAgICAgY2xhc3NpZnlfaW5jbHVkZSA9IGNwcGxpbnQu X2NsYXNzaWZ5X2luY2x1ZGUKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChjcHBsaW50Ll9DT05G SUdfSEVBREVSLAotLSAKMS42LjMuMwoK