<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>275207</bug_id>
          
          <creation_ts>2024-06-06 05:33:01 -0700</creation_ts>
          <short_desc>run-webkit-app command not able to set DYLD_FRAMEWORK_PATH under SIP enabled environment.</short_desc>
          <delta_ts>2024-06-07 11:23:48 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jinyu Meng">megabitsenmzq</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>a_protyasha</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2040082</commentid>
    <comment_count>0</comment_count>
      <attachid>471609</attachid>
    <who name="Jinyu Meng">megabitsenmzq</who>
    <bug_when>2024-06-06 05:33:01 -0700</bug_when>
    <thetext>Created attachment 471609
Patch to fix this bug

I&apos;m trying to use the run-webkit-app command to run a demo app with self-built WebKit on macOS. But the app is still using the system one. The WebKit I built is not showing under &quot;Open Files and Ports&quot; in the  &quot;Activity Monitor&quot;. You can check this thread for more information: https://bugs.webkit.org/show_bug.cgi?id=274818

After some hints from Alexey Proskuryakov, I managed to fix this bug by passing $ENV to the &quot;open&quot; command with some &quot;--env&quot; arguments. The reason is &quot;open&quot; command couldn&apos;t keep environment variables while SIP is enabled.

I will post a PR on GitHub later to fix this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2040088</commentid>
    <comment_count>1</comment_count>
    <who name="Jinyu Meng">megabitsenmzq</who>
    <bug_when>2024-06-06 07:18:29 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/29578</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2040348</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-06-07 11:22:19 -0700</bug_when>
    <thetext>Committed 279822@main (34e6542dbf34): &lt;https://commits.webkit.org/279822@main&gt;

Reviewed commits have been landed. Closing PR #29578 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2040349</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-06-07 11:23:48 -0700</bug_when>
    <thetext>&lt;rdar://problem/129408609&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>471609</attachid>
            <date>2024-06-06 05:33:01 -0700</date>
            <delta_ts>2024-06-06 05:33:01 -0700</delta_ts>
            <desc>Patch to fix this bug</desc>
            <filename>WebKit-21-29-51.patch</filename>
            <type>text/plain</type>
            <size>1664</size>
            <attacher name="Jinyu Meng">megabitsenmzq</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBmb3JrU3JjUHJlZml4L1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBmb3Jr
RHN0UHJlZml4L1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCA4ZmIxN2RlNzM0MTZi
ODQ3NWEzM2RlN2YwYTQ5ZTJlMjA3Mzk5MjVhLi5mMjNjMzE0OGYyZWU1MjZlODU5YTkyNDEwMmZk
ZGZkNGZhODVhZWFlIDEwMDc1NQotLS0gZm9ya1NyY1ByZWZpeC9Ub29scy9TY3JpcHRzL3dlYmtp
dGRpcnMucG0KKysrIGZvcmtEc3RQcmVmaXgvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBA
IC0zMzUyLDEyICszMzUyLDEzIEBAIHN1YiBydW5JT1NXZWJLaXRBcHAoJCkKICAgICBkaWUgIk5v
dCB1c2luZyBhbiBpT1MgU0RLLiIKIH0KIAotc3ViIGFyY2hDb21tYW5kTGluZUFyZ3VtZW50c0Zv
clJlc3RyaWN0ZWRFbnZpcm9ubWVudFZhcmlhYmxlcygpCitzdWIgY29tbWFuZExpbmVBcmd1bWVu
dHNGb3JSZXN0cmljdGVkRW52aXJvbm1lbnRWYXJpYWJsZXMoJCkKIHsKKyAgICBteSAoJHByZWZp
eCkgPSBAXzsKICAgICBteSBAYXJndW1lbnRzID0gKCk7CiAgICAgZm9yZWFjaCBteSAka2V5IChr
ZXlzKCVFTlYpKSB7CiAgICAgICAgIGlmICgka2V5ID1+IC9eRFlMRF8vKSB7Ci0gICAgICAgICAg
ICBwdXNoIEBhcmd1bWVudHMsICItZSIsICIka2V5PSRFTlZ7JGtleX0iOworICAgICAgICAgICAg
cHVzaCBAYXJndW1lbnRzLCAkcHJlZml4LCAiJGtleT0kRU5WeyRrZXl9IjsKICAgICAgICAgfQog
ICAgIH0KICAgICByZXR1cm4gQGFyZ3VtZW50czsKQEAgLTMzNzMsMTAgKzMzNzQsMTAgQEAgc3Vi
IHJ1bk1hY1dlYktpdEFwcCgkOyQpCiAgICAgc2V0dXBNYWNXZWJLaXRFbnZpcm9ubWVudCgkcHJv
ZHVjdERpcik7CiAKICAgICBpZiAoZGVmaW5lZCgkdXNlT3BlbkNvbW1hbmQpICYmICR1c2VPcGVu
Q29tbWFuZCA9PSBVU0VfT1BFTl9DT01NQU5EKSB7Ci0gICAgICAgIHJldHVybiBzeXN0ZW0oIm9w
ZW4iLCAiLVciLCAiLWEiLCAkYXBwUGF0aCwgIi0tYXJncyIsIGFyZ3VtZW50c0ZvclJ1bkFuZERl
YnVnTWFjV2ViS2l0QXBwKCkpOworICAgICAgICByZXR1cm4gc3lzdGVtKCJvcGVuIiwgIi1XIiwg
Ii1hIiwgJGFwcFBhdGgsIGNvbW1hbmRMaW5lQXJndW1lbnRzRm9yUmVzdHJpY3RlZEVudmlyb25t
ZW50VmFyaWFibGVzKCItLWVudiIpLCAiLS1hcmdzIiwgYXJndW1lbnRzRm9yUnVuQW5kRGVidWdN
YWNXZWJLaXRBcHAoKSk7CiAgICAgfQogICAgIGlmIChhcmNoaXRlY3R1cmUoKSkgewotICAgICAg
ICByZXR1cm4gc3lzdGVtICJhcmNoIiwgIi0iIC4gYXJjaGl0ZWN0dXJlKCksIGFyY2hDb21tYW5k
TGluZUFyZ3VtZW50c0ZvclJlc3RyaWN0ZWRFbnZpcm9ubWVudFZhcmlhYmxlcygpLCAkYXBwUGF0
aCwgYXJndW1lbnRzRm9yUnVuQW5kRGVidWdNYWNXZWJLaXRBcHAoKTsKKyAgICAgICAgcmV0dXJu
IHN5c3RlbSAiYXJjaCIsICItIiAuIGFyY2hpdGVjdHVyZSgpLCBjb21tYW5kTGluZUFyZ3VtZW50
c0ZvclJlc3RyaWN0ZWRFbnZpcm9ubWVudFZhcmlhYmxlcygiLWUiKSwgJGFwcFBhdGgsIGFyZ3Vt
ZW50c0ZvclJ1bkFuZERlYnVnTWFjV2ViS2l0QXBwKCk7CiAgICAgfQogICAgIHJldHVybiBzeXN0
ZW0geyAkYXBwUGF0aCB9ICRhcHBQYXRoLCBhcmd1bWVudHNGb3JSdW5BbmREZWJ1Z01hY1dlYktp
dEFwcCgpOwogfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>