275174 2024-06-05 11:35:43 -0700 The URL for Chromium bugs has changed, stopping them from being added to See Also in Bugzilla 2024-06-09 09:47:14 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari 17 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 danielhunterjacobs webkit-unassigned ap jond karlcow lingho webkit-bug-importer oldest_to_newest 2039910 0 danielhunterjacobs 2024-06-05 11:35:43 -0700 https://bugs.chromium.org/p/chromium/issues/list is now https://issues.chromium.org/issues, but that is not an accepted URL for adding bugs to See Also. 2039943 1 danielhunterjacobs 2024-06-05 13:43:48 -0700 This change was documented in https://developer.chrome.com/blog/chromium-issue-tracker-migration-complete 2039947 2 ap 2024-06-05 14:07:12 -0700 Thank you for the report! The fix would be in Websites/bugs.webkit.org/Bugzilla/BugUrl/Chromium.pm 2040002 3 danielhunterjacobs 2024-06-05 20:08:36 -0700 Maybe the subroutines in https://github.com/WebKit/WebKit/blob/main/Websites/bugs.webkit.org/Bugzilla/BugUrl/Chromium.pm should just be these, adapted from the simpler code in https://github.com/WebKit/WebKit/blob/main/Websites/bugs.webkit.org/Bugzilla/BugUrl/Google.pm. Though if there's still a desire to support the old Chromium URL syntax the code would either need to be more complex or these subroutines could be added to a new Perl module. I just don't understand the point of the current code for Chromium that gets $project_name and $bug_id in _check_value. sub should_handle { my ($class, $uri) = @_; # Chromium URLs have this form: # http(s)://issues.chromium.org/issues/1234 return (lc($uri->authority) eq 'issues.chromium.org' and $uri->path =~ m|^/issues/\d+$| ? 1 : 0; } sub _check_value { my ($class, $uri) = @_; $uri = $class->SUPER::_check_value($uri); return $uri; } 2040239 4 karlcow 2024-06-06 22:17:58 -0700 is there a chance that old URI will go 500 in the future or 410 Gone? Asking because I wonder if the bugs should be updated. 2040333 5 danielhunterjacobs 2024-06-07 10:28:28 -0700 Opened https://github.com/WebKit/WebKit/pull/29624 2040533 6 ews-feeder 2024-06-09 09:46:44 -0700 Committed 279863@main (15c7ae209695): <https://commits.webkit.org/279863@main> Reviewed commits have been landed. Closing PR #29624 and removing active labels. 2040534 7 webkit-bug-importer 2024-06-09 09:47:14 -0700 <rdar://problem/129473435>