27516 2009-07-21 13:54:01 -0700 Add onerror to WorkerContext. 2009-07-21 16:01:35 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 27518 1 jianli jianli levin oldest_to_newest 133587 0 jianli 2009-07-21 13:54:01 -0700 Add onerror to WorkerContext. 133595 1 33214 jianli 2009-07-21 14:11:40 -0700 Created attachment 33214 Proposed Patch 133608 2 jianli 2009-07-21 14:45:32 -0700 This is to adhere to the latest Web Worker spec (http://www.whatwg.org/specs/web-workers/current-work/#workerglobalscope): interface WorkerGlobalScope { ... attribute Function onerror; }; I will have other patches that will trigger onerror. 133614 3 33214 levin 2009-07-21 15:12:11 -0700 Comment on attachment 33214 Proposed Patch Just a few things to clean up. > diff --git a/WebCore/workers/WorkerContext.h b/WebCore/workers/WorkerContext.h > + RefPtr<EventListener> m_onErrorListener; Should be "m_onerrorListener" because onerror seems to consistently treated as one word. > diff --git a/WebCore/workers/WorkerContext.idl b/WebCore/workers/WorkerContext.idl > #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT > - attribute [Replaceable] WorkerContext self; > + attribute [Replaceable] WorkerContext self; Don't unindent these. The idl formatting leaves room for "readonly " when it isn't present which is why these are indented to this level. > #endif > - attribute [Replaceable] WorkerLocation location; > + attribute [Replaceable] WorkerLocation location; Same unindenting comment. > void close(); > - // attribute EventListener onerror; > + attribute EventListener onerror; Just uncomment but indent correctly. 133617 4 33218 jianli 2009-07-21 15:27:22 -0700 Created attachment 33218 Proposed Patch 133641 5 jianli 2009-07-21 16:01:35 -0700 Committed as http://trac.webkit.org/changeset/46197 and http://trac.webkit.org/changeset/46198. 33214 2009-07-21 14:11:40 -0700 2009-07-21 15:27:22 -0700 Proposed Patch 27516 text/plain 2954 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmQ4MWQ0NC4uYjg1MjgxOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNy0yMSAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIG9uZXJyb3IgdG8gV29ya2VyQ29udGV4dC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NTE2CisKKyAgICAgICAgKiBiaW5k aW5ncy9qcy9KU1dvcmtlckNvbnRleHRDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNX b3JrZXJDb250ZXh0OjptYXJrKToKKyAgICAgICAgKiB3b3JrZXJzL1dvcmtlckNvbnRleHQuaDoK KyAgICAgICAgKFdlYkNvcmU6OldvcmtlckNvbnRleHQ6OnNldE9uZXJyb3IpOgorICAgICAgICAo V2ViQ29yZTo6V29ya2VyQ29udGV4dDo6b25lcnJvcik6CisgICAgICAgICogd29ya2Vycy9Xb3Jr ZXJDb250ZXh0LmlkbDoKKwogMjAwOS0wNy0yMSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvYmluZGluZ3MvanMvSlNXb3JrZXJDb250ZXh0Q3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNXb3JrZXJDb250ZXh0Q3VzdG9tLmNwcAppbmRleCAwNjQ3NWY5Li40NDBiYjdhIDEw MDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTV29ya2VyQ29udGV4dEN1c3RvbS5jcHAK KysrIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1dvcmtlckNvbnRleHRDdXN0b20uY3BwCkBAIC01 OCw2ICs1OCw3IEBAIHZvaWQgSlNXb3JrZXJDb250ZXh0OjptYXJrKCkKICAgICBtYXJrRE9NT2Jq ZWN0V3JhcHBlcihnbG9iYWxEYXRhLCBpbXBsKCktPm9wdGlvbmFsTG9jYXRpb24oKSk7CiAgICAg bWFya0RPTU9iamVjdFdyYXBwZXIoZ2xvYmFsRGF0YSwgaW1wbCgpLT5vcHRpb25hbE5hdmlnYXRv cigpKTsKIAorICAgIG1hcmtJZk5vdE51bGwoaW1wbCgpLT5vbmVycm9yKCkpOwogICAgIG1hcmtJ Zk5vdE51bGwoaW1wbCgpLT5vbm1lc3NhZ2UoKSk7CiAKICAgICB0eXBlZGVmIFdvcmtlckNvbnRl eHQ6OkV2ZW50TGlzdGVuZXJzTWFwIEV2ZW50TGlzdGVuZXJzTWFwOwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuaCBiL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250 ZXh0LmgKaW5kZXggMTZmNDNmZC4uMmVlMDE2ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS93b3JrZXJz L1dvcmtlckNvbnRleHQuaAorKysgYi9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5oCkBA IC04NCw2ICs4NCw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgV29ya2VyQ29udGV4 dCogc2VsZigpIHsgcmV0dXJuIHRoaXM7IH0KICAgICAgICAgV29ya2VyTG9jYXRpb24qIGxvY2F0 aW9uKCkgY29uc3Q7CiAgICAgICAgIHZvaWQgY2xvc2UoKTsKKyAgICAgICAgdm9pZCBzZXRPbmVy cm9yKFBhc3NSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gZXZlbnRMaXN0ZW5lcikgeyBtX29uRXJyb3JM aXN0ZW5lciA9IGV2ZW50TGlzdGVuZXI7IH0KKyAgICAgICAgRXZlbnRMaXN0ZW5lciogb25lcnJv cigpIGNvbnN0IHsgcmV0dXJuIG1fb25FcnJvckxpc3RlbmVyLmdldCgpOyB9CiAKICAgICAgICAg Ly8gV29ya2VyVXRpbHMKICAgICAgICAgdm9pZCBpbXBvcnRTY3JpcHRzKGNvbnN0IFZlY3RvcjxT dHJpbmc+JiB1cmxzLCBjb25zdCBTdHJpbmcmIGNhbGxlclVSTCwgaW50IGNhbGxlckxpbmUsIEV4 Y2VwdGlvbkNvZGUmKTsKQEAgLTE0MCw2ICsxNDIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAg ICAgICAgIE93blB0cjxXb3JrZXJTY3JpcHRDb250cm9sbGVyPiBtX3NjcmlwdDsKICAgICAgICAg V29ya2VyVGhyZWFkKiBtX3RocmVhZDsKIAorICAgICAgICBSZWZQdHI8RXZlbnRMaXN0ZW5lcj4g bV9vbkVycm9yTGlzdGVuZXI7CiAgICAgICAgIFJlZlB0cjxFdmVudExpc3RlbmVyPiBtX29ubWVz c2FnZUxpc3RlbmVyOwogICAgICAgICBFdmVudExpc3RlbmVyc01hcCBtX2V2ZW50TGlzdGVuZXJz OwogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5pZGwgYi9XZWJD b3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5pZGwKaW5kZXggNzA5NDEwYS4uYWI0YTc2NiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuaWRsCisrKyBiL1dlYkNvcmUv d29ya2Vycy9Xb3JrZXJDb250ZXh0LmlkbApAQCAtMzcsMTEgKzM3LDExIEBAIG1vZHVsZSB0aHJl YWRzIHsKIAogICAgICAgICAvLyBXb3JrZXJHbG9iYWxTY29wZQogI2lmIGRlZmluZWQoTEFOR1VB R0VfSkFWQVNDUklQVCkgJiYgTEFOR1VBR0VfSkFWQVNDUklQVAotICAgICAgICAgICAgICAgICBh dHRyaWJ1dGUgW1JlcGxhY2VhYmxlXSBXb3JrZXJDb250ZXh0IHNlbGY7CisgICAgICAgIGF0dHJp YnV0ZSBbUmVwbGFjZWFibGVdIFdvcmtlckNvbnRleHQgc2VsZjsKICNlbmRpZgotICAgICAgICAg ICAgICAgICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxlXSBXb3JrZXJMb2NhdGlvbiBsb2NhdGlvbjsK KyAgICAgICAgYXR0cmlidXRlIFtSZXBsYWNlYWJsZV0gV29ya2VyTG9jYXRpb24gbG9jYXRpb247 CiAgICAgICAgIHZvaWQgY2xvc2UoKTsKLSAgICAgICAgLy8gICAgICAgICBhdHRyaWJ1dGUgRXZl bnRMaXN0ZW5lciBvbmVycm9yOworICAgICAgICBhdHRyaWJ1dGUgRXZlbnRMaXN0ZW5lciBvbmVy cm9yOwogCiAgICAgICAgIC8vIFdvcmtlclV0aWxzCiAgICAgICAgIFtDdXN0b21dIHZvaWQgaW1w b3J0U2NyaXB0cygvKltWYXJpYWRpY10gaW4gRE9NU3RyaW5nIHVybHMgKi8pOwo= 33218 2009-07-21 15:27:22 -0700 2009-07-21 15:31:10 -0700 Proposed Patch 27516_2 text/plain 2699 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmQ4MWQ0NC4uYjg1MjgxOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNy0yMSAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIG9uZXJyb3IgdG8gV29ya2VyQ29udGV4dC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NTE2CisKKyAgICAgICAgKiBiaW5k aW5ncy9qcy9KU1dvcmtlckNvbnRleHRDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNX b3JrZXJDb250ZXh0OjptYXJrKToKKyAgICAgICAgKiB3b3JrZXJzL1dvcmtlckNvbnRleHQuaDoK KyAgICAgICAgKFdlYkNvcmU6OldvcmtlckNvbnRleHQ6OnNldE9uZXJyb3IpOgorICAgICAgICAo V2ViQ29yZTo6V29ya2VyQ29udGV4dDo6b25lcnJvcik6CisgICAgICAgICogd29ya2Vycy9Xb3Jr ZXJDb250ZXh0LmlkbDoKKwogMjAwOS0wNy0yMSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvYmluZGluZ3MvanMvSlNXb3JrZXJDb250ZXh0Q3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNXb3JrZXJDb250ZXh0Q3VzdG9tLmNwcAppbmRleCAwNjQ3NWY5Li40NDBiYjdhIDEw MDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTV29ya2VyQ29udGV4dEN1c3RvbS5jcHAK KysrIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1dvcmtlckNvbnRleHRDdXN0b20uY3BwCkBAIC01 OCw2ICs1OCw3IEBAIHZvaWQgSlNXb3JrZXJDb250ZXh0OjptYXJrKCkKICAgICBtYXJrRE9NT2Jq ZWN0V3JhcHBlcihnbG9iYWxEYXRhLCBpbXBsKCktPm9wdGlvbmFsTG9jYXRpb24oKSk7CiAgICAg bWFya0RPTU9iamVjdFdyYXBwZXIoZ2xvYmFsRGF0YSwgaW1wbCgpLT5vcHRpb25hbE5hdmlnYXRv cigpKTsKIAorICAgIG1hcmtJZk5vdE51bGwoaW1wbCgpLT5vbmVycm9yKCkpOwogICAgIG1hcmtJ Zk5vdE51bGwoaW1wbCgpLT5vbm1lc3NhZ2UoKSk7CiAKICAgICB0eXBlZGVmIFdvcmtlckNvbnRl eHQ6OkV2ZW50TGlzdGVuZXJzTWFwIEV2ZW50TGlzdGVuZXJzTWFwOwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuaCBiL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250 ZXh0LmgKaW5kZXggMTZmNDNmZC4uYmE0NzQ1NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS93b3JrZXJz L1dvcmtlckNvbnRleHQuaAorKysgYi9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5oCkBA IC04NCw2ICs4NCw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgV29ya2VyQ29udGV4 dCogc2VsZigpIHsgcmV0dXJuIHRoaXM7IH0KICAgICAgICAgV29ya2VyTG9jYXRpb24qIGxvY2F0 aW9uKCkgY29uc3Q7CiAgICAgICAgIHZvaWQgY2xvc2UoKTsKKyAgICAgICAgdm9pZCBzZXRPbmVy cm9yKFBhc3NSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gZXZlbnRMaXN0ZW5lcikgeyBtX29uZXJyb3JM aXN0ZW5lciA9IGV2ZW50TGlzdGVuZXI7IH0KKyAgICAgICAgRXZlbnRMaXN0ZW5lciogb25lcnJv cigpIGNvbnN0IHsgcmV0dXJuIG1fb25lcnJvckxpc3RlbmVyLmdldCgpOyB9CiAKICAgICAgICAg Ly8gV29ya2VyVXRpbHMKICAgICAgICAgdm9pZCBpbXBvcnRTY3JpcHRzKGNvbnN0IFZlY3RvcjxT dHJpbmc+JiB1cmxzLCBjb25zdCBTdHJpbmcmIGNhbGxlclVSTCwgaW50IGNhbGxlckxpbmUsIEV4 Y2VwdGlvbkNvZGUmKTsKQEAgLTE0MCw2ICsxNDIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAg ICAgICAgIE93blB0cjxXb3JrZXJTY3JpcHRDb250cm9sbGVyPiBtX3NjcmlwdDsKICAgICAgICAg V29ya2VyVGhyZWFkKiBtX3RocmVhZDsKIAorICAgICAgICBSZWZQdHI8RXZlbnRMaXN0ZW5lcj4g bV9vbmVycm9yTGlzdGVuZXI7CiAgICAgICAgIFJlZlB0cjxFdmVudExpc3RlbmVyPiBtX29ubWVz c2FnZUxpc3RlbmVyOwogICAgICAgICBFdmVudExpc3RlbmVyc01hcCBtX2V2ZW50TGlzdGVuZXJz OwogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5pZGwgYi9XZWJD b3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5pZGwKaW5kZXggNzA5NDEwYS4uYzdiOGNiOSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuaWRsCisrKyBiL1dlYkNvcmUv d29ya2Vycy9Xb3JrZXJDb250ZXh0LmlkbApAQCAtNDEsNyArNDEsNyBAQCBtb2R1bGUgdGhyZWFk cyB7CiAjZW5kaWYKICAgICAgICAgICAgICAgICAgYXR0cmlidXRlIFtSZXBsYWNlYWJsZV0gV29y a2VyTG9jYXRpb24gbG9jYXRpb247CiAgICAgICAgIHZvaWQgY2xvc2UoKTsKLSAgICAgICAgLy8g ICAgICAgICBhdHRyaWJ1dGUgRXZlbnRMaXN0ZW5lciBvbmVycm9yOworICAgICAgICAgICAgICAg ICBhdHRyaWJ1dGUgRXZlbnRMaXN0ZW5lciBvbmVycm9yOwogCiAgICAgICAgIC8vIFdvcmtlclV0 aWxzCiAgICAgICAgIFtDdXN0b21dIHZvaWQgaW1wb3J0U2NyaXB0cygvKltWYXJpYWRpY10gaW4g RE9NU3RyaW5nIHVybHMgKi8pOwo=