27515 2009-07-21 13:49:53 -0700 Implement AbstractWorker::dispatchScriptErrorEvent by generating an ErrorEvent. 2009-07-21 20:22:32 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 27525 1 jianli jianli levin sam oldest_to_newest 133584 0 jianli 2009-07-21 13:49:53 -0700 Implement AbstractWorker::dispatchScriptErrorEvent by generating an ErrorEvent. 133591 1 33211 jianli 2009-07-21 14:00:04 -0700 Created attachment 33211 Proposed Patch 133609 2 jianli 2009-07-21 14:48:13 -0700 This is to adhere to the latest Web Worker spec (http://www.whatwg.org/specs/web-workers/current-work/#runtime-script-errors): When the user agent is to fire a worker error event at a Worker object, it must dispatch an event that uses the ErrorEvent interface, with the name error, that doesn't bubble and is cancelable, with its message, filename, and lineno attributes set appropriately. I will have other patch that will fix the error handling flow in WorkerContext and Worker. 133651 3 levin 2009-07-21 16:42:24 -0700 > I will have other patch that will fix the error handling flow in WorkerContext and Worker. Please file a bug for this. 133664 4 33211 levin 2009-07-21 17:25:04 -0700 Comment on attachment 33211 Proposed Patch Please do a variable name change below before landing. > +void AbstractWorker::dispatchScriptErrorEvent(const String& message, const String& sourceURL, int lineNumber) > { > + RefPtr<ErrorEvent> evt = ErrorEvent::create(message, sourceURL, static_cast<unsigned>(lineNumber)); Use full words, except in the rare case where an abbreviation would be more canonical and easier to understand. s/evt/event/ > + if (m_onErrorListener) { > + evt->setTarget(this); > + evt->setCurrentTarget(this); > + m_onErrorListener->handleEvent(evt.get(), true); > + } > + > + ExceptionCode ec = 0; > + dispatchEvent(evt.release(), ec); > + ASSERT(!ec); > } > > } // namespace WebCore 133670 5 jianli 2009-07-21 17:44:19 -0700 Committed as http://trac.webkit.org/changeset/46203 133679 6 sam 2009-07-21 18:59:18 -0700 This should really have a test case. Is there a reason this cannot be tested? 133684 7 jianli 2009-07-21 20:22:32 -0700 (In reply to comment #6) > This should really have a test case. Is there a reason this cannot be tested? This is the first patch towards fixing error handling in workers. It can not be tested before completing the changes for 27525. I will add test cases in dealing with 27525. 33211 2009-07-21 14:00:04 -0700 2009-07-21 17:25:04 -0700 Proposed Patch 27515 text/plain 1671 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmQ4MWQ0NC4uMGQyODM2ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNy0yMSAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW1wbGVtZW50IEFic3RyYWN0V29ya2VyOjpkaXNwYXRjaFNjcmlwdEVycm9y RXZlbnQgYnkgZ2VuZXJhdGluZyBhbiBFcnJvckV2ZW50LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc1MTUKKworICAgICAgICAqIHdvcmtlcnMvQWJz dHJhY3RXb3JrZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWJzdHJhY3RXb3JrZXI6OmRpc3Bh dGNoU2NyaXB0RXJyb3JFdmVudCk6CisKIDIwMDktMDctMjEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQg YS9XZWJDb3JlL3dvcmtlcnMvQWJzdHJhY3RXb3JrZXIuY3BwIGIvV2ViQ29yZS93b3JrZXJzL0Fi c3RyYWN0V29ya2VyLmNwcAppbmRleCBhNjgwOGZiLi5iMmRlNmUyIDEwMDY0NAotLS0gYS9XZWJD b3JlL3dvcmtlcnMvQWJzdHJhY3RXb3JrZXIuY3BwCisrKyBiL1dlYkNvcmUvd29ya2Vycy9BYnN0 cmFjdFdvcmtlci5jcHAKQEAgLTM0LDYgKzM0LDcgQEAKIAogI2luY2x1ZGUgIkFic3RyYWN0V29y a2VyLmgiCiAKKyNpbmNsdWRlICJFcnJvckV2ZW50LmgiCiAjaW5jbHVkZSAiRXZlbnQuaCIKICNp bmNsdWRlICJFdmVudEV4Y2VwdGlvbi5oIgogI2luY2x1ZGUgIkV2ZW50TmFtZXMuaCIKQEAgLTEx NCwxMCArMTE1LDE4IEBAIHZvaWQgQWJzdHJhY3RXb3JrZXI6OmRpc3BhdGNoTG9hZEVycm9yRXZl bnQoKQogICAgIEFTU0VSVCghZWMpOwogfQogCi12b2lkIEFic3RyYWN0V29ya2VyOjpkaXNwYXRj aFNjcmlwdEVycm9yRXZlbnQoY29uc3QgU3RyaW5nJiwgY29uc3QgU3RyaW5nJiwgaW50KQordm9p ZCBBYnN0cmFjdFdvcmtlcjo6ZGlzcGF0Y2hTY3JpcHRFcnJvckV2ZW50KGNvbnN0IFN0cmluZyYg bWVzc2FnZSwgY29uc3QgU3RyaW5nJiBzb3VyY2VVUkwsIGludCBsaW5lTnVtYmVyKQogewotICAg IC8vRklYTUU6IEdlbmVyYXRlIGFuIEVycm9yRXZlbnQgaW5zdGVhZCBvZiBhIHNpbXBsZSBldmVu dAotICAgIGRpc3BhdGNoTG9hZEVycm9yRXZlbnQoKTsKKyAgICBSZWZQdHI8RXJyb3JFdmVudD4g ZXZ0ID0gRXJyb3JFdmVudDo6Y3JlYXRlKG1lc3NhZ2UsIHNvdXJjZVVSTCwgc3RhdGljX2Nhc3Q8 dW5zaWduZWQ+KGxpbmVOdW1iZXIpKTsKKyAgICBpZiAobV9vbkVycm9yTGlzdGVuZXIpIHsKKyAg ICAgICAgZXZ0LT5zZXRUYXJnZXQodGhpcyk7CisgICAgICAgIGV2dC0+c2V0Q3VycmVudFRhcmdl dCh0aGlzKTsKKyAgICAgICAgbV9vbkVycm9yTGlzdGVuZXItPmhhbmRsZUV2ZW50KGV2dC5nZXQo KSwgdHJ1ZSk7CisgICAgfQorCisgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CisgICAgZGlzcGF0 Y2hFdmVudChldnQucmVsZWFzZSgpLCBlYyk7CisgICAgQVNTRVJUKCFlYyk7CiB9CiAKIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUK