275134 2024-06-04 16:26:24 -0700 Enable GraphicsContext filters for Canvas filter 2024-06-20 02:37:40 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa bfulgham sabouhallawa simon.fraser webkit-bug-importer zalan oldest_to_newest 2039770 0 sabouhallawa 2024-06-04 16:26:24 -0700 GraphicsContext filters were disabled for the canvas filter in 278000@main. The canvas drop-shadow filter was drawn upside down. So software filters were used instead to make the layout test pass. It turned out all we need is to flip the sign of the vertical offset of the drop-shadow. This is what CanvasRenderingContext2DBase::applyShadow() does when it sets GraphicsContext drop-shadow by calling: c->setDropShadow({ { width, -height }, state().shadowBlur, state().shadowColor, ShadowRadiusMode::Legacy }); 2039771 1 webkit-bug-importer 2024-06-04 16:26:51 -0700 <rdar://problem/129249264> 2039773 2 sabouhallawa 2024-06-04 16:32:59 -0700 Pull request: https://github.com/WebKit/WebKit/pull/29522 2042184 3 ews-feeder 2024-06-20 02:37:38 -0700 Committed 280195@main (8e66e149a07d): <https://commits.webkit.org/280195@main> Reviewed commits have been landed. Closing PR #29522 and removing active labels.