<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27508</bug_id>
          
          <creation_ts>2009-07-21 11:54:22 -0700</creation_ts>
          <short_desc>Add checks for switch statement indentation to cpplint</short_desc>
          <delta_ts>2009-07-21 13:06:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jakob Petsovits">jpetsovits</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>133543</commentid>
    <comment_count>0</comment_count>
      <attachid>33196</attachid>
    <who name="Jakob Petsovits">jpetsovits</who>
    <bug_when>2009-07-21 11:54:22 -0700</bug_when>
    <thetext>Created attachment 33196
Add checks for switch statement indentation to cpplint

Switch statements have strong similarities to namespaces when it comes to indentation, so I stole from my previous patch (https://bugs.webkit.org/show_bug.cgi?id=27461) and adapted some parts to implement style guideline #5 from http://webkit.org/coding/coding-style.html to cpplint. Looking for a motivated reviewer, hope you like it!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133544</commentid>
    <comment_count>1</comment_count>
      <attachid>33197</attachid>
    <who name="Jakob Petsovits">jpetsovits</who>
    <bug_when>2009-07-21 11:59:31 -0700</bug_when>
    <thetext>Created attachment 33197
Add checks for switch statement indentation to cpplint

Note to self: Don&apos;t post patch files unless bug report is created and URL is inserted into the ChangeLog.
Apart from that, same patch as the previous one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133546</commentid>
    <comment_count>2</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-07-21 12:12:57 -0700</bug_when>
    <thetext>Re changelog: Just use prepare-ChangeLog --bug YourBugNumber</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133547</commentid>
    <comment_count>3</comment_count>
      <attachid>33197</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2009-07-21 12:16:10 -0700</bug_when>
    <thetext>Comment on attachment 33197
Add checks for switch statement indentation to cpplint

In general it looks good but I think it will have problems on nested switch statements. What can be done about that?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133558</commentid>
    <comment_count>4</comment_count>
      <attachid>33200</attachid>
    <who name="Jakob Petsovits">jpetsovits</who>
    <bug_when>2009-07-21 12:39:21 -0700</bug_when>
    <thetext>Created attachment 33200
Add checks for switch statement indentation to cpplint (try 3)

Good point, I had not thought of that case. Here&apos;s a relatively simple solution that&apos;ll work in pretty much all common cases, approach explained in the code comments. Plus more test cases. Is that good enough, or does it need to be perfect?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133565</commentid>
    <comment_count>5</comment_count>
      <attachid>33200</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2009-07-21 13:01:36 -0700</bug_when>
    <thetext>Comment on attachment 33200
Add checks for switch statement indentation to cpplint (try 3)

This is an improvement over what we have now and seems to minimize the possibility of false alarms (with respect to nested switch statements), so it seems like a positive step forward.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>133570</commentid>
    <comment_count>6</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-07-21 13:06:45 -0700</bug_when>
    <thetext>Committed as http://trac.webkit.org/changeset/46189</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>33196</attachid>
            <date>2009-07-21 11:54:22 -0700</date>
            <delta_ts>2009-07-21 11:59:31 -0700</delta_ts>
            <desc>Add checks for switch statement indentation to cpplint</desc>
            <filename>0001-Add-checks-for-switch-statement-indentation-to-cppli.patch</filename>
            <type>text/plain</type>
            <size>6657</size>
            <attacher name="Jakob Petsovits">jpetsovits</attacher>
            
              <data encoding="base64">RnJvbSA4MjFlNWIxNzVlYzZlY2M4NTQyYzVlOGM1YzkwMzg3YWFhYmFlNmY4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBQZXRzb3ZpdHMgPGpha29iLnBldHNvdml0c0B0b3Jj
aG1vYmlsZS5jb20+CkRhdGU6IFR1ZSwgMjEgSnVsIDIwMDkgMTQ6NDI6NDggLTA0MDAKU3ViamVj
dDogW1BBVENIXSBBZGQgY2hlY2tzIGZvciBzd2l0Y2ggc3RhdGVtZW50IGluZGVudGF0aW9uIHRv
IGNwcGxpbnQuCgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHwgICAgOSArKysrCiBXZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5w
eSAgICAgICAgICB8ICAgNTIgKysrKysrKysrKysrKysrKysrKysrKysKIFdlYktpdFRvb2xzL1Nj
cmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5IHwgICA0MiArKysrKysrKysrKysrKy0t
LS0KIDMgZmlsZXMgY2hhbmdlZCwgOTMgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpk
aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9n
CmluZGV4IDBiYzBlODQuLjZmNDMwOWEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0wNy0y
MSAgSmFrb2IgUGV0c292aXRzICA8amFrb2IucGV0c292aXRzQHRvcmNobW9iaWxlLmNvbT4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgY2hlY2tz
IGZvciBzd2l0Y2ggc3RhdGVtZW50IGluZGVudGF0aW9uIHRvIGNwcGxpbnQuCisKKyAgICAgICAg
KiBTY3JpcHRzL21vZHVsZXMvY3BwbGludC5weToKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMv
Y3BwbGludF91bml0dGVzdC5weToKKwogMjAwOS0wNy0yMCAgSmFrb2IgUGV0c292aXRzICA8amFr
b2IucGV0c292aXRzQHRvcmNobW9iaWxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZp
ZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50
LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnQucHkKaW5kZXggOTEwOWU4
NC4uOTVjOTRlOSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxp
bnQucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnQucHkKQEAgLTE3
MTcsNiArMTcxNyw1NyBAQCBkZWYgY2hlY2tfbmFtZXNwYWNlX2luZGVudGF0aW9uKGZpbGVuYW1l
LCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfZXh0ZW5zaQogICAgICAgICAgICAgYnJl
YWsKIAogCitkZWYgY2hlY2tfc3dpdGNoX2luZGVudGF0aW9uKGZpbGVuYW1lLCBjbGVhbl9saW5l
cywgbGluZV9udW1iZXIsIGVycm9yKToKKyAgICAiIiJMb29rcyBmb3IgaW5kZW50YXRpb24gZXJy
b3JzIGluc2lkZSBvZiBzd2l0Y2ggc3RhdGVtZW50cy4KKworICAgIEFyZ3M6CisgICAgICBmaWxl
bmFtZTogVGhlIG5hbWUgb2YgdGhlIGN1cnJlbnQgZmlsZS4KKyAgICAgIGNsZWFuX2xpbmVzOiBB
IENsZWFuc2VkTGluZXMgaW5zdGFuY2UgY29udGFpbmluZyB0aGUgZmlsZS4KKyAgICAgIGxpbmVf
bnVtYmVyOiBUaGUgbnVtYmVyIG9mIHRoZSBsaW5lIHRvIGNoZWNrLgorICAgICAgZXJyb3I6IFRo
ZSBmdW5jdGlvbiB0byBjYWxsIHdpdGggYW55IGVycm9ycyBmb3VuZC4KKyAgICAiIiIKKworICAg
IGxpbmUgPSBjbGVhbl9saW5lcy5lbGlkZWRbbGluZV9udW1iZXJdICMgR2V0IHJpZCBvZiBjb21t
ZW50cyBhbmQgc3RyaW5ncy4KKworICAgIHN3aXRjaF9tYXRjaCA9IG1hdGNoKHInKD9QPHN3aXRj
aF9pbmRlbnRhdGlvbj5ccyopc3dpdGNoXHMqXCguK1wpXHMqe1xzKiQnLCBsaW5lKQorICAgIGlm
IG5vdCBzd2l0Y2hfbWF0Y2g6CisgICAgICAgIHJldHVybgorCisgICAgc3dpdGNoX2luZGVudGF0
aW9uID0gc3dpdGNoX21hdGNoLmdyb3VwKCdzd2l0Y2hfaW5kZW50YXRpb24nKQorICAgIGlubmVy
X2luZGVudGF0aW9uID0gc3dpdGNoX2luZGVudGF0aW9uICsgJyAnICogNAorICAgIGxpbmVfb2Zm
c2V0ID0gMAorCisgICAgZm9yIGN1cnJlbnRfbGluZSBpbiBjbGVhbl9saW5lcy5lbGlkZWRbbGlu
ZV9udW1iZXIgKyAxOl06CisgICAgICAgIGxpbmVfb2Zmc2V0ICs9IDEKKworICAgICAgICAjIFNr
aXAgbm90IG9ubHkgZW1wdHkgbGluZXMgYnV0IGFsc28gdGhvc2Ugd2l0aCBwcmVwcm9jZXNzb3Ig
ZGlyZWN0aXZlcy4KKyAgICAgICAgaWYgY3VycmVudF9saW5lLnN0cmlwKCkgPT0gJycgb3IgY3Vy
cmVudF9saW5lLnN0YXJ0c3dpdGgoJyMnKToKKyAgICAgICAgICAgIGNvbnRpbnVlCisKKyAgICAg
ICAgY3VycmVudF9pbmRlbnRhdGlvbl9tYXRjaCA9IG1hdGNoKHInKD9QPGluZGVudGF0aW9uPlxz
KikoP1A8cmVtYWluaW5nX2xpbmU+LiopJCcsIGN1cnJlbnRfbGluZSk7CisgICAgICAgIGN1cnJl
bnRfaW5kZW50YXRpb24gPSBjdXJyZW50X2luZGVudGF0aW9uX21hdGNoLmdyb3VwKCdpbmRlbnRh
dGlvbicpCisgICAgICAgIHJlbWFpbmluZ19saW5lID0gY3VycmVudF9pbmRlbnRhdGlvbl9tYXRj
aC5ncm91cCgncmVtYWluaW5nX2xpbmUnKQorCisgICAgICAgIGlmIHJlbWFpbmluZ19saW5lLnN0
YXJ0c3dpdGgoJ30nKToKKyAgICAgICAgICAgIGJyZWFrICMgVGhlIGVuZCBvZiB0aGUgc3dpdGNo
IHN0YXRlbWVudC4KKyAgICAgICAgZWxpZiBtYXRjaChyJyhkZWZhdWx0fGNhc2VccysuKilccyo6
XHMqJCcsIHJlbWFpbmluZ19saW5lKToKKyAgICAgICAgICAgIGlmIGN1cnJlbnRfaW5kZW50YXRp
b24gIT0gc3dpdGNoX2luZGVudGF0aW9uOgorICAgICAgICAgICAgICAgIGVycm9yKGZpbGVuYW1l
LCBsaW5lX251bWJlciArIGxpbmVfb2Zmc2V0LCAnd2hpdGVzcGFjZS9pbmRlbnQnLCA0LAorICAg
ICAgICAgICAgICAgICAgICAgICdBIGNhc2UgbGFiZWwgc2hvdWxkIG5vdCBiZSBpbmRlbnRlZCwg
YnV0IGxpbmUgdXAgd2l0aCBpdHMgc3dpdGNoIHN0YXRlbWVudC4nKQorICAgICAgICAgICAgICAg
ICMgRG9uJ3QgdGhyb3cgYW4gZXJyb3IgZm9yIG11bHRpcGxlIGJhZGx5IGluZGVudGVkIGxhYmVs
cywKKyAgICAgICAgICAgICAgICAjIG9uZSBzaG91bGQgYmUgZW5vdWdoIHRvIGZpZ3VyZSBvdXQg
dGhlIHByb2JsZW0uCisgICAgICAgICAgICAgICAgYnJlYWsKKyAgICAgICAgZWxpZiBub3QgbWF0
Y2gocidcdytccyo6XHMqJCcsIHJlbWFpbmluZ19saW5lKToKKyAgICAgICAgICAgICMgSXQncyBu
b3QgYSBnb3RvIGxhYmVsICh3aGljaCB3ZSBkb24ndCBjYXJlIGFib3V0KSwgc28gY2hlY2sgaWYK
KyAgICAgICAgICAgICMgaXQncyBpbmRlbnRlZCBhdCBsZWFzdCBhcyBmYXIgYXMgdGhlIHN3aXRj
aCBwbHVzIDQgc3BhY2VzLgorICAgICAgICAgICAgaWYgbm90IGN1cnJlbnRfaW5kZW50YXRpb24u
c3RhcnRzd2l0aChpbm5lcl9pbmRlbnRhdGlvbik6CisgICAgICAgICAgICAgICAgZXJyb3IoZmls
ZW5hbWUsIGxpbmVfbnVtYmVyICsgbGluZV9vZmZzZXQsICd3aGl0ZXNwYWNlL2luZGVudCcsIDQs
CisgICAgICAgICAgICAgICAgICAgICAgJ05vbi1sYWJlbCBjb2RlIGluc2lkZSBzd2l0Y2ggc3Rh
dGVtZW50cyBzaG91bGQgYmUgaW5kZW50ZWQuJykKKyAgICAgICAgICAgICAgICAjIERvbid0IHRo
cm93IGFuIGVycm9yIGZvciBtdWx0aXBsZSBiYWRseSBpbmRlbnRlZCBzdGF0ZW1lbnRzLAorICAg
ICAgICAgICAgICAgICMgb25lIHNob3VsZCBiZSBlbm91Z2ggdG8gZmlndXJlIG91dCB0aGUgcHJv
YmxlbS4KKyAgICAgICAgICAgICAgICBicmVhaworCisKIGRlZiBjaGVja19icmFjZXMoZmlsZW5h
bWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICIiIkxvb2tzIGZvciBt
aXNwbGFjZWQgYnJhY2VzIChlLmcuIGF0IHRoZSBlbmQgb2YgbGluZSkuCiAKQEAgLTE5NzMsNiAr
MjAyNCw3IEBAIGRlZiBjaGVja19zdHlsZShmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVt
YmVyLCBmaWxlX2V4dGVuc2lvbiwgZXJyb3IpOgogCiAgICAgIyBTb21lIG1vcmUgc3R5bGUgY2hl
Y2tzCiAgICAgY2hlY2tfbmFtZXNwYWNlX2luZGVudGF0aW9uKGZpbGVuYW1lLCBjbGVhbl9saW5l
cywgbGluZV9udW1iZXIsIGZpbGVfZXh0ZW5zaW9uLCBlcnJvcikKKyAgICBjaGVja19zd2l0Y2hf
aW5kZW50YXRpb24oZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpCiAg
ICAgY2hlY2tfYnJhY2VzKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9y
KQogICAgIGNoZWNrX3NwYWNpbmcoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwg
ZXJyb3IpCiAgICAgY2hlY2tfY2hlY2soZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJl
ciwgZXJyb3IpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGlu
dF91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0
ZXN0LnB5CmluZGV4IGM2OTQyZDcuLjU4ZDZmMjUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Nj
cmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1Njcmlw
dHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5CkBAIC0yNzQ2LDE2ICsyNzQ2LDM4IEBAIGNs
YXNzIFdlYktpdFN0eWxlVGVzdChDcHBsaW50VGVzdEJhc2UpOgogCiAgICAgICAgICMgNS4gQSBj
YXNlIGxhYmVsIHNob3VsZCBsaW5lIHVwIHdpdGggaXRzIHN3aXRjaCBzdGF0ZW1lbnQuIFRoZQog
ICAgICAgICAjICAgIGNhc2Ugc3RhdGVtZW50IGlzIGluZGVudGVkLgotICAgICAgICAjIEZJWE1F
OiBObyB0ZXN0cyBmb3IgdGhpcyBydWxlLiBUaGUgZm9sbG93aW5nIHNob3VsZCBmYWlsLgotICAg
ICAgICAjIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKLSAgICAgICAgIyAgICAgJyAgICBz
d2l0Y2ggKGNvbmRpdGlvbikge1xuJwotICAgICAgICAjICAgICAnICAgICAgICBjYXNlIGZvb0Nv
bmRpdGlvbjpcbicKLSAgICAgICAgIyAgICAgJyAgICAgICAgY2FzZSBiYXJDb25kaXRpb246XG4n
Ci0gICAgICAgICMgICAgICcgICAgICAgICAgICBpKys7XG4nCi0gICAgICAgICMgICAgICcgICAg
ICAgICAgICBicmVhaztcbicKLSAgICAgICAgIyAgICAgJyAgICAgICAgZGVmYXVsdDpcbicKLSAg
ICAgICAgIyAgICAgJyAgICAgICAgICAgIGktLTtcbicsCi0gICAgICAgICMgICAgICcnKQorICAg
ICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCisgICAgICAgICAgICAnICAgIHN3aXRj
aCAoY29uZGl0aW9uKSB7XG4nCisgICAgICAgICAgICAnICAgIGNhc2UgZm9vQ29uZGl0aW9uOlxu
JworICAgICAgICAgICAgJyAgICBjYXNlIGJhckNvbmRpdGlvbjpcbicKKyAgICAgICAgICAgICcg
ICAgICAgIGkrKztcbicKKyAgICAgICAgICAgICcgICAgICAgIGJyZWFrO1xuJworICAgICAgICAg
ICAgJyAgICBkZWZhdWx0OlxuJworICAgICAgICAgICAgJyAgICAgICAgaS0tO1xuJworICAgICAg
ICAgICAgJyAgICB9XG4nLAorICAgICAgICAgICAgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X211
bHRpX2xpbmVfbGludCgKKyAgICAgICAgICAgICcgICAgc3dpdGNoIChjb25kaXRpb24pIHtcbicK
KyAgICAgICAgICAgICcgICAgICAgIGNhc2UgZm9vQ29uZGl0aW9uOlxuJworICAgICAgICAgICAg
JyAgICAgICAgY2FzZSBiYXJDb25kaXRpb246XG4nCisgICAgICAgICAgICAnICAgICAgICAgICAg
aSsrO1xuJworICAgICAgICAgICAgJyAgICAgICAgICAgIGJyZWFrO1xuJworICAgICAgICAgICAg
JyAgICAgICAgZGVmYXVsdDpcbicKKyAgICAgICAgICAgICcgICAgICAgICAgICBpLS07XG4nCisg
ICAgICAgICAgICAnICAgIH1cbicsCisgICAgICAgICAgICAnQSBjYXNlIGxhYmVsIHNob3VsZCBu
b3QgYmUgaW5kZW50ZWQsIGJ1dCBsaW5lIHVwIHdpdGggaXRzIHN3aXRjaCBzdGF0ZW1lbnQuJwor
ICAgICAgICAgICAgJyAgW3doaXRlc3BhY2UvaW5kZW50XSBbNF0nKQorICAgICAgICBzZWxmLmFz
c2VydF9tdWx0aV9saW5lX2xpbnQoCisgICAgICAgICAgICAnICAgIHN3aXRjaCAoY29uZGl0aW9u
KSB7XG4nCisgICAgICAgICAgICAnICAgIGNhc2UgZm9vQ29uZGl0aW9uOlxuJworICAgICAgICAg
ICAgJyAgICBjYXNlIGJhckNvbmRpdGlvbjpcbicKKyAgICAgICAgICAgICcgICAgaSsrO1xuJwor
ICAgICAgICAgICAgJyAgICBicmVhaztcblxuJworICAgICAgICAgICAgJyAgICBkZWZhdWx0Olxu
JworICAgICAgICAgICAgJyAgICBpLS07XG4nCisgICAgICAgICAgICAnICAgIH1cbicsCisgICAg
ICAgICAgICAnTm9uLWxhYmVsIGNvZGUgaW5zaWRlIHN3aXRjaCBzdGF0ZW1lbnRzIHNob3VsZCBi
ZSBpbmRlbnRlZC4nCisgICAgICAgICAgICAnICBbd2hpdGVzcGFjZS9pbmRlbnRdIFs0XScpCiAK
ICAgICAgICAgIyA2LiBCb29sZWFuIGV4cHJlc3Npb25zIGF0IHRoZSBzYW1lIG5lc3RpbmcgbGV2
ZWwgdGhhdCBzcGFuCiAgICAgICAgICMgICBtdWx0aXBsZSBsaW5lcyBzaG91bGQgaGF2ZSB0aGVp
ciBvcGVyYXRvcnMgb24gdGhlIGxlZnQgc2lkZSBvZgotLSAKMS42LjMuMwoK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>33197</attachid>
            <date>2009-07-21 11:59:31 -0700</date>
            <delta_ts>2009-07-21 12:39:21 -0700</delta_ts>
            <desc>Add checks for switch statement indentation to cpplint</desc>
            <filename>0001-Add-checks-for-switch-statement-indentation-to-cppli.patch</filename>
            <type>text/plain</type>
            <size>6712</size>
            <attacher name="Jakob Petsovits">jpetsovits</attacher>
            
              <data encoding="base64">RnJvbSA3YTlkYWU4NzBlYTYwMDhhZGUwYTMwYzU0MDNlZDhmYThmYmRmODRjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBQZXRzb3ZpdHMgPGpha29iLnBldHNvdml0c0B0b3Jj
aG1vYmlsZS5jb20+CkRhdGU6IFR1ZSwgMjEgSnVsIDIwMDkgMTQ6NTc6MjIgLTA0MDAKU3ViamVj
dDogW1BBVENIXSBBZGQgY2hlY2tzIGZvciBzd2l0Y2ggc3RhdGVtZW50IGluZGVudGF0aW9uIHRv
IGNwcGxpbnQuCgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHwgICAxMCArKysrCiBXZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5w
eSAgICAgICAgICB8ICAgNTIgKysrKysrKysrKysrKysrKysrKysrKysKIFdlYktpdFRvb2xzL1Nj
cmlwdHMvbW9kdWxlcy9jcHBsaW50X3VuaXR0ZXN0LnB5IHwgICA0MiArKysrKysrKysrKysrKy0t
LS0KIDMgZmlsZXMgY2hhbmdlZCwgOTQgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpk
aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9n
CmluZGV4IDBiYzBlODQuLmZjYWU0YzQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNy0y
MSAgSmFrb2IgUGV0c292aXRzICA8amFrb2IucGV0c292aXRzQHRvcmNobW9iaWxlLmNvbT4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgY2hlY2tz
IGZvciBzd2l0Y2ggc3RhdGVtZW50IGluZGVudGF0aW9uIHRvIGNwcGxpbnQuCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzUwOAorCisgICAgICAgICog
U2NyaXB0cy9tb2R1bGVzL2NwcGxpbnQucHk6CisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2Nw
cGxpbnRfdW5pdHRlc3QucHk6CisKIDIwMDktMDctMjAgIEpha29iIFBldHNvdml0cyAgPGpha29i
LnBldHNvdml0c0B0b3JjaG1vYmlsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQg
TGV2aW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5w
eSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5CmluZGV4IDkxMDllODQu
Ljk1Yzk0ZTkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50
LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5CkBAIC0xNzE3
LDYgKzE3MTcsNTcgQEAgZGVmIGNoZWNrX25hbWVzcGFjZV9pbmRlbnRhdGlvbihmaWxlbmFtZSwg
Y2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX2V4dGVuc2kKICAgICAgICAgICAgIGJyZWFr
CiAKIAorZGVmIGNoZWNrX3N3aXRjaF9pbmRlbnRhdGlvbihmaWxlbmFtZSwgY2xlYW5fbGluZXMs
IGxpbmVfbnVtYmVyLCBlcnJvcik6CisgICAgIiIiTG9va3MgZm9yIGluZGVudGF0aW9uIGVycm9y
cyBpbnNpZGUgb2Ygc3dpdGNoIHN0YXRlbWVudHMuCisKKyAgICBBcmdzOgorICAgICAgZmlsZW5h
bWU6IFRoZSBuYW1lIG9mIHRoZSBjdXJyZW50IGZpbGUuCisgICAgICBjbGVhbl9saW5lczogQSBD
bGVhbnNlZExpbmVzIGluc3RhbmNlIGNvbnRhaW5pbmcgdGhlIGZpbGUuCisgICAgICBsaW5lX251
bWJlcjogVGhlIG51bWJlciBvZiB0aGUgbGluZSB0byBjaGVjay4KKyAgICAgIGVycm9yOiBUaGUg
ZnVuY3Rpb24gdG8gY2FsbCB3aXRoIGFueSBlcnJvcnMgZm91bmQuCisgICAgIiIiCisKKyAgICBs
aW5lID0gY2xlYW5fbGluZXMuZWxpZGVkW2xpbmVfbnVtYmVyXSAjIEdldCByaWQgb2YgY29tbWVu
dHMgYW5kIHN0cmluZ3MuCisKKyAgICBzd2l0Y2hfbWF0Y2ggPSBtYXRjaChyJyg/UDxzd2l0Y2hf
aW5kZW50YXRpb24+XHMqKXN3aXRjaFxzKlwoLitcKVxzKntccyokJywgbGluZSkKKyAgICBpZiBu
b3Qgc3dpdGNoX21hdGNoOgorICAgICAgICByZXR1cm4KKworICAgIHN3aXRjaF9pbmRlbnRhdGlv
biA9IHN3aXRjaF9tYXRjaC5ncm91cCgnc3dpdGNoX2luZGVudGF0aW9uJykKKyAgICBpbm5lcl9p
bmRlbnRhdGlvbiA9IHN3aXRjaF9pbmRlbnRhdGlvbiArICcgJyAqIDQKKyAgICBsaW5lX29mZnNl
dCA9IDAKKworICAgIGZvciBjdXJyZW50X2xpbmUgaW4gY2xlYW5fbGluZXMuZWxpZGVkW2xpbmVf
bnVtYmVyICsgMTpdOgorICAgICAgICBsaW5lX29mZnNldCArPSAxCisKKyAgICAgICAgIyBTa2lw
IG5vdCBvbmx5IGVtcHR5IGxpbmVzIGJ1dCBhbHNvIHRob3NlIHdpdGggcHJlcHJvY2Vzc29yIGRp
cmVjdGl2ZXMuCisgICAgICAgIGlmIGN1cnJlbnRfbGluZS5zdHJpcCgpID09ICcnIG9yIGN1cnJl
bnRfbGluZS5zdGFydHN3aXRoKCcjJyk6CisgICAgICAgICAgICBjb250aW51ZQorCisgICAgICAg
IGN1cnJlbnRfaW5kZW50YXRpb25fbWF0Y2ggPSBtYXRjaChyJyg/UDxpbmRlbnRhdGlvbj5ccyop
KD9QPHJlbWFpbmluZ19saW5lPi4qKSQnLCBjdXJyZW50X2xpbmUpOworICAgICAgICBjdXJyZW50
X2luZGVudGF0aW9uID0gY3VycmVudF9pbmRlbnRhdGlvbl9tYXRjaC5ncm91cCgnaW5kZW50YXRp
b24nKQorICAgICAgICByZW1haW5pbmdfbGluZSA9IGN1cnJlbnRfaW5kZW50YXRpb25fbWF0Y2gu
Z3JvdXAoJ3JlbWFpbmluZ19saW5lJykKKworICAgICAgICBpZiByZW1haW5pbmdfbGluZS5zdGFy
dHN3aXRoKCd9Jyk6CisgICAgICAgICAgICBicmVhayAjIFRoZSBlbmQgb2YgdGhlIHN3aXRjaCBz
dGF0ZW1lbnQuCisgICAgICAgIGVsaWYgbWF0Y2gocicoZGVmYXVsdHxjYXNlXHMrLiopXHMqOlxz
KiQnLCByZW1haW5pbmdfbGluZSk6CisgICAgICAgICAgICBpZiBjdXJyZW50X2luZGVudGF0aW9u
ICE9IHN3aXRjaF9pbmRlbnRhdGlvbjoKKyAgICAgICAgICAgICAgICBlcnJvcihmaWxlbmFtZSwg
bGluZV9udW1iZXIgKyBsaW5lX29mZnNldCwgJ3doaXRlc3BhY2UvaW5kZW50JywgNCwKKyAgICAg
ICAgICAgICAgICAgICAgICAnQSBjYXNlIGxhYmVsIHNob3VsZCBub3QgYmUgaW5kZW50ZWQsIGJ1
dCBsaW5lIHVwIHdpdGggaXRzIHN3aXRjaCBzdGF0ZW1lbnQuJykKKyAgICAgICAgICAgICAgICAj
IERvbid0IHRocm93IGFuIGVycm9yIGZvciBtdWx0aXBsZSBiYWRseSBpbmRlbnRlZCBsYWJlbHMs
CisgICAgICAgICAgICAgICAgIyBvbmUgc2hvdWxkIGJlIGVub3VnaCB0byBmaWd1cmUgb3V0IHRo
ZSBwcm9ibGVtLgorICAgICAgICAgICAgICAgIGJyZWFrCisgICAgICAgIGVsaWYgbm90IG1hdGNo
KHInXHcrXHMqOlxzKiQnLCByZW1haW5pbmdfbGluZSk6CisgICAgICAgICAgICAjIEl0J3Mgbm90
IGEgZ290byBsYWJlbCAod2hpY2ggd2UgZG9uJ3QgY2FyZSBhYm91dCksIHNvIGNoZWNrIGlmCisg
ICAgICAgICAgICAjIGl0J3MgaW5kZW50ZWQgYXQgbGVhc3QgYXMgZmFyIGFzIHRoZSBzd2l0Y2gg
cGx1cyA0IHNwYWNlcy4KKyAgICAgICAgICAgIGlmIG5vdCBjdXJyZW50X2luZGVudGF0aW9uLnN0
YXJ0c3dpdGgoaW5uZXJfaW5kZW50YXRpb24pOgorICAgICAgICAgICAgICAgIGVycm9yKGZpbGVu
YW1lLCBsaW5lX251bWJlciArIGxpbmVfb2Zmc2V0LCAnd2hpdGVzcGFjZS9pbmRlbnQnLCA0LAor
ICAgICAgICAgICAgICAgICAgICAgICdOb24tbGFiZWwgY29kZSBpbnNpZGUgc3dpdGNoIHN0YXRl
bWVudHMgc2hvdWxkIGJlIGluZGVudGVkLicpCisgICAgICAgICAgICAgICAgIyBEb24ndCB0aHJv
dyBhbiBlcnJvciBmb3IgbXVsdGlwbGUgYmFkbHkgaW5kZW50ZWQgc3RhdGVtZW50cywKKyAgICAg
ICAgICAgICAgICAjIG9uZSBzaG91bGQgYmUgZW5vdWdoIHRvIGZpZ3VyZSBvdXQgdGhlIHByb2Js
ZW0uCisgICAgICAgICAgICAgICAgYnJlYWsKKworCiBkZWYgY2hlY2tfYnJhY2VzKGZpbGVuYW1l
LCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKToKICAgICAiIiJMb29rcyBmb3IgbWlz
cGxhY2VkIGJyYWNlcyAoZS5nLiBhdCB0aGUgZW5kIG9mIGxpbmUpLgogCkBAIC0xOTczLDYgKzIw
MjQsNyBAQCBkZWYgY2hlY2tfc3R5bGUoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJl
ciwgZmlsZV9leHRlbnNpb24sIGVycm9yKToKIAogICAgICMgU29tZSBtb3JlIHN0eWxlIGNoZWNr
cwogICAgIGNoZWNrX25hbWVzcGFjZV9pbmRlbnRhdGlvbihmaWxlbmFtZSwgY2xlYW5fbGluZXMs
IGxpbmVfbnVtYmVyLCBmaWxlX2V4dGVuc2lvbiwgZXJyb3IpCisgICAgY2hlY2tfc3dpdGNoX2lu
ZGVudGF0aW9uKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKQogICAg
IGNoZWNrX2JyYWNlcyhmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcikK
ICAgICBjaGVja19zcGFjaW5nKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVy
cm9yKQogICAgIGNoZWNrX2NoZWNrKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIs
IGVycm9yKQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRf
dW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludF91bml0dGVz
dC5weQppbmRleCBjNjk0MmQ3Li41OGQ2ZjI1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3Jp
cHRzL21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRz
L21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weQpAQCAtMjc0NiwxNiArMjc0NiwzOCBAQCBjbGFz
cyBXZWJLaXRTdHlsZVRlc3QoQ3BwbGludFRlc3RCYXNlKToKIAogICAgICAgICAjIDUuIEEgY2Fz
ZSBsYWJlbCBzaG91bGQgbGluZSB1cCB3aXRoIGl0cyBzd2l0Y2ggc3RhdGVtZW50LiBUaGUKICAg
ICAgICAgIyAgICBjYXNlIHN0YXRlbWVudCBpcyBpbmRlbnRlZC4KLSAgICAgICAgIyBGSVhNRTog
Tm8gdGVzdHMgZm9yIHRoaXMgcnVsZS4gVGhlIGZvbGxvd2luZyBzaG91bGQgZmFpbC4KLSAgICAg
ICAgIyBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCi0gICAgICAgICMgICAgICcgICAgc3dp
dGNoIChjb25kaXRpb24pIHtcbicKLSAgICAgICAgIyAgICAgJyAgICAgICAgY2FzZSBmb29Db25k
aXRpb246XG4nCi0gICAgICAgICMgICAgICcgICAgICAgIGNhc2UgYmFyQ29uZGl0aW9uOlxuJwot
ICAgICAgICAjICAgICAnICAgICAgICAgICAgaSsrO1xuJwotICAgICAgICAjICAgICAnICAgICAg
ICAgICAgYnJlYWs7XG4nCi0gICAgICAgICMgICAgICcgICAgICAgIGRlZmF1bHQ6XG4nCi0gICAg
ICAgICMgICAgICcgICAgICAgICAgICBpLS07XG4nLAotICAgICAgICAjICAgICAnJykKKyAgICAg
ICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAorICAgICAgICAgICAgJyAgICBzd2l0Y2gg
KGNvbmRpdGlvbikge1xuJworICAgICAgICAgICAgJyAgICBjYXNlIGZvb0NvbmRpdGlvbjpcbicK
KyAgICAgICAgICAgICcgICAgY2FzZSBiYXJDb25kaXRpb246XG4nCisgICAgICAgICAgICAnICAg
ICAgICBpKys7XG4nCisgICAgICAgICAgICAnICAgICAgICBicmVhaztcbicKKyAgICAgICAgICAg
ICcgICAgZGVmYXVsdDpcbicKKyAgICAgICAgICAgICcgICAgICAgIGktLTtcbicKKyAgICAgICAg
ICAgICcgICAgfVxuJywKKyAgICAgICAgICAgICcnKQorICAgICAgICBzZWxmLmFzc2VydF9tdWx0
aV9saW5lX2xpbnQoCisgICAgICAgICAgICAnICAgIHN3aXRjaCAoY29uZGl0aW9uKSB7XG4nCisg
ICAgICAgICAgICAnICAgICAgICBjYXNlIGZvb0NvbmRpdGlvbjpcbicKKyAgICAgICAgICAgICcg
ICAgICAgIGNhc2UgYmFyQ29uZGl0aW9uOlxuJworICAgICAgICAgICAgJyAgICAgICAgICAgIGkr
KztcbicKKyAgICAgICAgICAgICcgICAgICAgICAgICBicmVhaztcbicKKyAgICAgICAgICAgICcg
ICAgICAgIGRlZmF1bHQ6XG4nCisgICAgICAgICAgICAnICAgICAgICAgICAgaS0tO1xuJworICAg
ICAgICAgICAgJyAgICB9XG4nLAorICAgICAgICAgICAgJ0EgY2FzZSBsYWJlbCBzaG91bGQgbm90
IGJlIGluZGVudGVkLCBidXQgbGluZSB1cCB3aXRoIGl0cyBzd2l0Y2ggc3RhdGVtZW50LicKKyAg
ICAgICAgICAgICcgIFt3aGl0ZXNwYWNlL2luZGVudF0gWzRdJykKKyAgICAgICAgc2VsZi5hc3Nl
cnRfbXVsdGlfbGluZV9saW50KAorICAgICAgICAgICAgJyAgICBzd2l0Y2ggKGNvbmRpdGlvbikg
e1xuJworICAgICAgICAgICAgJyAgICBjYXNlIGZvb0NvbmRpdGlvbjpcbicKKyAgICAgICAgICAg
ICcgICAgY2FzZSBiYXJDb25kaXRpb246XG4nCisgICAgICAgICAgICAnICAgIGkrKztcbicKKyAg
ICAgICAgICAgICcgICAgYnJlYWs7XG5cbicKKyAgICAgICAgICAgICcgICAgZGVmYXVsdDpcbicK
KyAgICAgICAgICAgICcgICAgaS0tO1xuJworICAgICAgICAgICAgJyAgICB9XG4nLAorICAgICAg
ICAgICAgJ05vbi1sYWJlbCBjb2RlIGluc2lkZSBzd2l0Y2ggc3RhdGVtZW50cyBzaG91bGQgYmUg
aW5kZW50ZWQuJworICAgICAgICAgICAgJyAgW3doaXRlc3BhY2UvaW5kZW50XSBbNF0nKQogCiAg
ICAgICAgICMgNi4gQm9vbGVhbiBleHByZXNzaW9ucyBhdCB0aGUgc2FtZSBuZXN0aW5nIGxldmVs
IHRoYXQgc3BhbgogICAgICAgICAjICAgbXVsdGlwbGUgbGluZXMgc2hvdWxkIGhhdmUgdGhlaXIg
b3BlcmF0b3JzIG9uIHRoZSBsZWZ0IHNpZGUgb2YKLS0gCjEuNi4zLjMKCg==
</data>
<flag name="review"
          id="17512"
          type_id="1"
          status="-"
          setter="levin"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>33200</attachid>
            <date>2009-07-21 12:39:21 -0700</date>
            <delta_ts>2009-07-21 13:01:36 -0700</delta_ts>
            <desc>Add checks for switch statement indentation to cpplint (try 3)</desc>
            <filename>0001-Add-checks-for-switch-statement-indentation-to-cppli.patch</filename>
            <type>text/plain</type>
            <size>8866</size>
            <attacher name="Jakob Petsovits">jpetsovits</attacher>
            
              <data encoding="base64">RnJvbSA2ZjczMTgwN2U5NmE3Y2MxMDhlYmVhZDI2ODI0ZTVmZTYyNzFhMjg4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBQZXRzb3ZpdHMgPGpha29iLnBldHNvdml0c0B0b3Jj
aG1vYmlsZS5jb20+CkRhdGU6IFR1ZSwgMjEgSnVsIDIwMDkgMTU6MzU6MTcgLTA0MDAKU3ViamVj
dDogW1BBVENIXSBBZGQgY2hlY2tzIGZvciBzd2l0Y2ggc3RhdGVtZW50IGluZGVudGF0aW9uIHRv
IGNwcGxpbnQuCgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHwgICAxMCArKysKIFdlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5
ICAgICAgICAgIHwgICA2NiArKysrKysrKysrKysrKysrKysrCiBXZWJLaXRUb29scy9TY3JpcHRz
L21vZHVsZXMvY3BwbGludF91bml0dGVzdC5weSB8ICAgNzkgKysrKysrKysrKysrKysrKysrKyst
LS0KIDMgZmlsZXMgY2hhbmdlZCwgMTQ1IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQoK
ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCAwYmMwZTg0Li5mY2FlNGM0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDct
MjEgIEpha29iIFBldHNvdml0cyAgPGpha29iLnBldHNvdml0c0B0b3JjaG1vYmlsZS5jb20+CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGNoZWNr
cyBmb3Igc3dpdGNoIHN0YXRlbWVudCBpbmRlbnRhdGlvbiB0byBjcHBsaW50LgorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc1MDgKKworICAgICAgICAq
IFNjcmlwdHMvbW9kdWxlcy9jcHBsaW50LnB5OgorICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9j
cHBsaW50X3VuaXR0ZXN0LnB5OgorCiAyMDA5LTA3LTIwICBKYWtvYiBQZXRzb3ZpdHMgIDxqYWtv
Yi5wZXRzb3ZpdHNAdG9yY2htb2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlk
IExldmluLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnQu
cHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5weQppbmRleCA5MTA5ZTg0
Li4wNjBkNjMwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGlu
dC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwbGludC5weQpAQCAtMTcx
Nyw2ICsxNzE3LDcxIEBAIGRlZiBjaGVja19uYW1lc3BhY2VfaW5kZW50YXRpb24oZmlsZW5hbWUs
IGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9leHRlbnNpCiAgICAgICAgICAgICBicmVh
awogCiAKK2RlZiBjaGVja19zd2l0Y2hfaW5kZW50YXRpb24oZmlsZW5hbWUsIGNsZWFuX2xpbmVz
LCBsaW5lX251bWJlciwgZXJyb3IpOgorICAgICIiIkxvb2tzIGZvciBpbmRlbnRhdGlvbiBlcnJv
cnMgaW5zaWRlIG9mIHN3aXRjaCBzdGF0ZW1lbnRzLgorCisgICAgQXJnczoKKyAgICAgIGZpbGVu
YW1lOiBUaGUgbmFtZSBvZiB0aGUgY3VycmVudCBmaWxlLgorICAgICAgY2xlYW5fbGluZXM6IEEg
Q2xlYW5zZWRMaW5lcyBpbnN0YW5jZSBjb250YWluaW5nIHRoZSBmaWxlLgorICAgICAgbGluZV9u
dW1iZXI6IFRoZSBudW1iZXIgb2YgdGhlIGxpbmUgdG8gY2hlY2suCisgICAgICBlcnJvcjogVGhl
IGZ1bmN0aW9uIHRvIGNhbGwgd2l0aCBhbnkgZXJyb3JzIGZvdW5kLgorICAgICIiIgorCisgICAg
bGluZSA9IGNsZWFuX2xpbmVzLmVsaWRlZFtsaW5lX251bWJlcl0gIyBHZXQgcmlkIG9mIGNvbW1l
bnRzIGFuZCBzdHJpbmdzLgorCisgICAgc3dpdGNoX21hdGNoID0gbWF0Y2gocicoP1A8c3dpdGNo
X2luZGVudGF0aW9uPlxzKilzd2l0Y2hccypcKC4rXClccyp7XHMqJCcsIGxpbmUpCisgICAgaWYg
bm90IHN3aXRjaF9tYXRjaDoKKyAgICAgICAgcmV0dXJuCisKKyAgICBzd2l0Y2hfaW5kZW50YXRp
b24gPSBzd2l0Y2hfbWF0Y2guZ3JvdXAoJ3N3aXRjaF9pbmRlbnRhdGlvbicpCisgICAgaW5uZXJf
aW5kZW50YXRpb24gPSBzd2l0Y2hfaW5kZW50YXRpb24gKyAnICcgKiA0CisgICAgbGluZV9vZmZz
ZXQgPSAwCisgICAgZW5jb3VudGVyZWRfbmVzdGVkX3N3aXRjaCA9IEZhbHNlCisKKyAgICBmb3Ig
Y3VycmVudF9saW5lIGluIGNsZWFuX2xpbmVzLmVsaWRlZFtsaW5lX251bWJlciArIDE6XToKKyAg
ICAgICAgbGluZV9vZmZzZXQgKz0gMQorCisgICAgICAgICMgU2tpcCBub3Qgb25seSBlbXB0eSBs
aW5lcyBidXQgYWxzbyB0aG9zZSB3aXRoIHByZXByb2Nlc3NvciBkaXJlY3RpdmVzLgorICAgICAg
ICBpZiBjdXJyZW50X2xpbmUuc3RyaXAoKSA9PSAnJyBvciBjdXJyZW50X2xpbmUuc3RhcnRzd2l0
aCgnIycpOgorICAgICAgICAgICAgY29udGludWUKKworICAgICAgICBpZiBtYXRjaChyJ1xzKnN3
aXRjaFxzKlwoLitcKVxzKntccyokJywgY3VycmVudF9saW5lKToKKyAgICAgICAgICAgICMgQ29t
cGxleGl0eSBhbGFybSAtIGFub3RoZXIgc3dpdGNoIHN0YXRlbWVudCBuZXN0ZWQgaW5zaWRlIHRo
ZSBvbmUKKyAgICAgICAgICAgICMgdGhhdCB3ZSdyZSBjdXJyZW50bHkgdGVzdGluZy4gV2UnbGwg
bmVlZCB0byB0cmFjayB0aGUgZXh0ZW50IG9mCisgICAgICAgICAgICAjIHRoYXQgaW5uZXIgc3dp
dGNoIGlmIHRoZSB1cGNvbWluZyBsYWJlbCB0ZXN0cyBhcmUgc3RpbGwgc3VwcG9zZWQKKyAgICAg
ICAgICAgICMgdG8gd29yayBjb3JyZWN0bHkuIExldCdzIG5vdCBkbyB0aGF0OyBpbnN0ZWFkLCB3
ZSdsbCBmaW5pc2gKKyAgICAgICAgICAgICMgY2hlY2tpbmcgdGhpcyBsaW5lLCBhbmQgdGhlbiBs
ZWF2ZSBpdCBsaWtlIHRoYXQuIEFzc3VtaW5nIHRoZQorICAgICAgICAgICAgIyBpbmRlbnRhdGlv
biBpcyBkb25lIGNvbnNpc3RlbnRseSAoZXZlbiBpZiBpbmNvcnJlY3RseSksIHRoaXMgd2lsbAor
ICAgICAgICAgICAgIyBzdGlsbCBjYXRjaCBhbGwgaW5kZW50YXRpb24gaXNzdWVzIGluIHByYWN0
aWNlLgorICAgICAgICAgICAgZW5jb3VudGVyZWRfbmVzdGVkX3N3aXRjaCA9IFRydWUKKworICAg
ICAgICBjdXJyZW50X2luZGVudGF0aW9uX21hdGNoID0gbWF0Y2gocicoP1A8aW5kZW50YXRpb24+
XHMqKSg/UDxyZW1haW5pbmdfbGluZT4uKikkJywgY3VycmVudF9saW5lKTsKKyAgICAgICAgY3Vy
cmVudF9pbmRlbnRhdGlvbiA9IGN1cnJlbnRfaW5kZW50YXRpb25fbWF0Y2guZ3JvdXAoJ2luZGVu
dGF0aW9uJykKKyAgICAgICAgcmVtYWluaW5nX2xpbmUgPSBjdXJyZW50X2luZGVudGF0aW9uX21h
dGNoLmdyb3VwKCdyZW1haW5pbmdfbGluZScpCisKKyAgICAgICAgaWYgcmVtYWluaW5nX2xpbmUu
c3RhcnRzd2l0aCgnfScpOgorICAgICAgICAgICAgYnJlYWsgIyBUaGUgZW5kIG9mIHRoZSBzd2l0
Y2ggc3RhdGVtZW50LgorICAgICAgICBlbGlmIG1hdGNoKHInKGRlZmF1bHR8Y2FzZVxzKy4qKVxz
KjpccyokJywgcmVtYWluaW5nX2xpbmUpOgorICAgICAgICAgICAgaWYgY3VycmVudF9pbmRlbnRh
dGlvbiAhPSBzd2l0Y2hfaW5kZW50YXRpb246CisgICAgICAgICAgICAgICAgZXJyb3IoZmlsZW5h
bWUsIGxpbmVfbnVtYmVyICsgbGluZV9vZmZzZXQsICd3aGl0ZXNwYWNlL2luZGVudCcsIDQsCisg
ICAgICAgICAgICAgICAgICAgICAgJ0EgY2FzZSBsYWJlbCBzaG91bGQgbm90IGJlIGluZGVudGVk
LCBidXQgbGluZSB1cCB3aXRoIGl0cyBzd2l0Y2ggc3RhdGVtZW50LicpCisgICAgICAgICAgICAg
ICAgIyBEb24ndCB0aHJvdyBhbiBlcnJvciBmb3IgbXVsdGlwbGUgYmFkbHkgaW5kZW50ZWQgbGFi
ZWxzLAorICAgICAgICAgICAgICAgICMgb25lIHNob3VsZCBiZSBlbm91Z2ggdG8gZmlndXJlIG91
dCB0aGUgcHJvYmxlbS4KKyAgICAgICAgICAgICAgICBicmVhaworICAgICAgICBlbGlmIG5vdCBt
YXRjaChyJ1x3K1xzKjpccyokJywgcmVtYWluaW5nX2xpbmUpOgorICAgICAgICAgICAgIyBJdCdz
IG5vdCBhIGdvdG8gbGFiZWwgKHdoaWNoIHdlIGRvbid0IGNhcmUgYWJvdXQpLCBzbyBjaGVjayBp
ZgorICAgICAgICAgICAgIyBpdCdzIGluZGVudGVkIGF0IGxlYXN0IGFzIGZhciBhcyB0aGUgc3dp
dGNoIHBsdXMgNCBzcGFjZXMuCisgICAgICAgICAgICBpZiBub3QgY3VycmVudF9pbmRlbnRhdGlv
bi5zdGFydHN3aXRoKGlubmVyX2luZGVudGF0aW9uKToKKyAgICAgICAgICAgICAgICBlcnJvcihm
aWxlbmFtZSwgbGluZV9udW1iZXIgKyBsaW5lX29mZnNldCwgJ3doaXRlc3BhY2UvaW5kZW50Jywg
NCwKKyAgICAgICAgICAgICAgICAgICAgICAnTm9uLWxhYmVsIGNvZGUgaW5zaWRlIHN3aXRjaCBz
dGF0ZW1lbnRzIHNob3VsZCBiZSBpbmRlbnRlZC4nKQorICAgICAgICAgICAgICAgICMgRG9uJ3Qg
dGhyb3cgYW4gZXJyb3IgZm9yIG11bHRpcGxlIGJhZGx5IGluZGVudGVkIHN0YXRlbWVudHMsCisg
ICAgICAgICAgICAgICAgIyBvbmUgc2hvdWxkIGJlIGVub3VnaCB0byBmaWd1cmUgb3V0IHRoZSBw
cm9ibGVtLgorICAgICAgICAgICAgICAgIGJyZWFrCisKKyAgICAgICAgaWYgZW5jb3VudGVyZWRf
bmVzdGVkX3N3aXRjaDoKKyAgICAgICAgICAgIGJyZWFrCisKKwogZGVmIGNoZWNrX2JyYWNlcyhm
aWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgIiIiTG9va3Mg
Zm9yIG1pc3BsYWNlZCBicmFjZXMgKGUuZy4gYXQgdGhlIGVuZCBvZiBsaW5lKS4KIApAQCAtMTk3
Myw2ICsyMDM4LDcgQEAgZGVmIGNoZWNrX3N0eWxlKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGlu
ZV9udW1iZXIsIGZpbGVfZXh0ZW5zaW9uLCBlcnJvcik6CiAKICAgICAjIFNvbWUgbW9yZSBzdHls
ZSBjaGVja3MKICAgICBjaGVja19uYW1lc3BhY2VfaW5kZW50YXRpb24oZmlsZW5hbWUsIGNsZWFu
X2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9leHRlbnNpb24sIGVycm9yKQorICAgIGNoZWNrX3N3
aXRjaF9pbmRlbnRhdGlvbihmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJv
cikKICAgICBjaGVja19icmFjZXMoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwg
ZXJyb3IpCiAgICAgY2hlY2tfc3BhY2luZyhmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVt
YmVyLCBlcnJvcikKICAgICBjaGVja19jaGVjayhmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVf
bnVtYmVyLCBlcnJvcikKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9j
cHBsaW50X3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRf
dW5pdHRlc3QucHkKaW5kZXggYzY5NDJkNy4uMmNkNTg0YSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v
bHMvU2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMv
U2NyaXB0cy9tb2R1bGVzL2NwcGxpbnRfdW5pdHRlc3QucHkKQEAgLTI3NDYsMTYgKzI3NDYsNzUg
QEAgY2xhc3MgV2ViS2l0U3R5bGVUZXN0KENwcGxpbnRUZXN0QmFzZSk6CiAKICAgICAgICAgIyA1
LiBBIGNhc2UgbGFiZWwgc2hvdWxkIGxpbmUgdXAgd2l0aCBpdHMgc3dpdGNoIHN0YXRlbWVudC4g
VGhlCiAgICAgICAgICMgICAgY2FzZSBzdGF0ZW1lbnQgaXMgaW5kZW50ZWQuCi0gICAgICAgICMg
RklYTUU6IE5vIHRlc3RzIGZvciB0aGlzIHJ1bGUuIFRoZSBmb2xsb3dpbmcgc2hvdWxkIGZhaWwu
Ci0gICAgICAgICMgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAotICAgICAgICAjICAgICAn
ICAgIHN3aXRjaCAoY29uZGl0aW9uKSB7XG4nCi0gICAgICAgICMgICAgICcgICAgICAgIGNhc2Ug
Zm9vQ29uZGl0aW9uOlxuJwotICAgICAgICAjICAgICAnICAgICAgICBjYXNlIGJhckNvbmRpdGlv
bjpcbicKLSAgICAgICAgIyAgICAgJyAgICAgICAgICAgIGkrKztcbicKLSAgICAgICAgIyAgICAg
JyAgICAgICAgICAgIGJyZWFrO1xuJwotICAgICAgICAjICAgICAnICAgICAgICBkZWZhdWx0Olxu
JwotICAgICAgICAjICAgICAnICAgICAgICAgICAgaS0tO1xuJywKLSAgICAgICAgIyAgICAgJycp
CisgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKKyAgICAgICAgICAgICcgICAg
c3dpdGNoIChjb25kaXRpb24pIHtcbicKKyAgICAgICAgICAgICcgICAgY2FzZSBmb29Db25kaXRp
b246XG4nCisgICAgICAgICAgICAnICAgIGNhc2UgYmFyQ29uZGl0aW9uOlxuJworICAgICAgICAg
ICAgJyAgICAgICAgaSsrO1xuJworICAgICAgICAgICAgJyAgICAgICAgYnJlYWs7XG4nCisgICAg
ICAgICAgICAnICAgIGRlZmF1bHQ6XG4nCisgICAgICAgICAgICAnICAgICAgICBpLS07XG4nCisg
ICAgICAgICAgICAnICAgIH1cbicsCisgICAgICAgICAgICAnJykKKyAgICAgICAgc2VsZi5hc3Nl
cnRfbXVsdGlfbGluZV9saW50KAorICAgICAgICAgICAgJyAgICBzd2l0Y2ggKGNvbmRpdGlvbikg
e1xuJworICAgICAgICAgICAgJyAgICBjYXNlIGZvb0NvbmRpdGlvbjpcbicKKyAgICAgICAgICAg
ICcgICAgICAgIHN3aXRjaCAob3RoZXJDb25kaXRpb24pIHtcbicKKyAgICAgICAgICAgICcgICAg
ICAgIGRlZmF1bHQ6XG4nCisgICAgICAgICAgICAnICAgICAgICAgICAgcmV0dXJuO1xuJworICAg
ICAgICAgICAgJyAgICAgICAgfVxuJworICAgICAgICAgICAgJyAgICBkZWZhdWx0OlxuJworICAg
ICAgICAgICAgJyAgICAgICAgaS0tO1xuJworICAgICAgICAgICAgJyAgICB9XG4nLAorICAgICAg
ICAgICAgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKKyAgICAgICAg
ICAgICcgICAgc3dpdGNoIChjb25kaXRpb24pIHtcbicKKyAgICAgICAgICAgICcgICAgICAgIGNh
c2UgZm9vQ29uZGl0aW9uOlxuJworICAgICAgICAgICAgJyAgICAgICAgY2FzZSBiYXJDb25kaXRp
b246XG4nCisgICAgICAgICAgICAnICAgICAgICAgICAgaSsrO1xuJworICAgICAgICAgICAgJyAg
ICAgICAgICAgIGJyZWFrO1xuJworICAgICAgICAgICAgJyAgICAgICAgZGVmYXVsdDpcbicKKyAg
ICAgICAgICAgICcgICAgICAgICAgICBpLS07XG4nCisgICAgICAgICAgICAnICAgIH1cbicsCisg
ICAgICAgICAgICAnQSBjYXNlIGxhYmVsIHNob3VsZCBub3QgYmUgaW5kZW50ZWQsIGJ1dCBsaW5l
IHVwIHdpdGggaXRzIHN3aXRjaCBzdGF0ZW1lbnQuJworICAgICAgICAgICAgJyAgW3doaXRlc3Bh
Y2UvaW5kZW50XSBbNF0nKQorICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCisg
ICAgICAgICAgICAnICAgIHN3aXRjaCAoY29uZGl0aW9uKSB7XG4nCisgICAgICAgICAgICAnICAg
IGNhc2UgZm9vQ29uZGl0aW9uOlxuJworICAgICAgICAgICAgJyAgICBjYXNlIGJhckNvbmRpdGlv
bjpcbicKKyAgICAgICAgICAgICcgICAgICAgIHN3aXRjaCAob3RoZXJDb25kaXRpb24pIHtcbicK
KyAgICAgICAgICAgICcgICAgICAgICAgICBkZWZhdWx0OlxuJworICAgICAgICAgICAgJyAgICAg
ICAgICAgIHJldHVybjtcbicKKyAgICAgICAgICAgICcgICAgICAgIH1cbicKKyAgICAgICAgICAg
ICcgICAgZGVmYXVsdDpcbicKKyAgICAgICAgICAgICcgICAgICAgIGktLTtcbicKKyAgICAgICAg
ICAgICcgICAgfVxuJywKKyAgICAgICAgICAgICdBIGNhc2UgbGFiZWwgc2hvdWxkIG5vdCBiZSBp
bmRlbnRlZCwgYnV0IGxpbmUgdXAgd2l0aCBpdHMgc3dpdGNoIHN0YXRlbWVudC4nCisgICAgICAg
ICAgICAnICBbd2hpdGVzcGFjZS9pbmRlbnRdIFs0XScpCisgICAgICAgIHNlbGYuYXNzZXJ0X211
bHRpX2xpbmVfbGludCgKKyAgICAgICAgICAgICcgICAgc3dpdGNoIChjb25kaXRpb24pIHtcbicK
KyAgICAgICAgICAgICcgICAgY2FzZSBmb29Db25kaXRpb246XG4nCisgICAgICAgICAgICAnICAg
IGNhc2UgYmFyQ29uZGl0aW9uOlxuJworICAgICAgICAgICAgJyAgICBpKys7XG4nCisgICAgICAg
ICAgICAnICAgIGJyZWFrO1xuXG4nCisgICAgICAgICAgICAnICAgIGRlZmF1bHQ6XG4nCisgICAg
ICAgICAgICAnICAgIGktLTtcbicKKyAgICAgICAgICAgICcgICAgfVxuJywKKyAgICAgICAgICAg
ICdOb24tbGFiZWwgY29kZSBpbnNpZGUgc3dpdGNoIHN0YXRlbWVudHMgc2hvdWxkIGJlIGluZGVu
dGVkLicKKyAgICAgICAgICAgICcgIFt3aGl0ZXNwYWNlL2luZGVudF0gWzRdJykKKyAgICAgICAg
c2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAorICAgICAgICAgICAgJyAgICBzd2l0Y2ggKGNv
bmRpdGlvbikge1xuJworICAgICAgICAgICAgJyAgICBjYXNlIGZvb0NvbmRpdGlvbjpcbicKKyAg
ICAgICAgICAgICcgICAgY2FzZSBiYXJDb25kaXRpb246XG4nCisgICAgICAgICAgICAnICAgICAg
ICBzd2l0Y2ggKG90aGVyQ29uZGl0aW9uKSB7XG4nCisgICAgICAgICAgICAnICAgICAgICBkZWZh
dWx0OlxuJworICAgICAgICAgICAgJyAgICAgICAgcmV0dXJuO1xuJworICAgICAgICAgICAgJyAg
ICAgICAgfVxuJworICAgICAgICAgICAgJyAgICBkZWZhdWx0OlxuJworICAgICAgICAgICAgJyAg
ICAgICAgaS0tO1xuJworICAgICAgICAgICAgJyAgICB9XG4nLAorICAgICAgICAgICAgJ05vbi1s
YWJlbCBjb2RlIGluc2lkZSBzd2l0Y2ggc3RhdGVtZW50cyBzaG91bGQgYmUgaW5kZW50ZWQuJwor
ICAgICAgICAgICAgJyAgW3doaXRlc3BhY2UvaW5kZW50XSBbNF0nKQogCiAgICAgICAgICMgNi4g
Qm9vbGVhbiBleHByZXNzaW9ucyBhdCB0aGUgc2FtZSBuZXN0aW5nIGxldmVsIHRoYXQgc3Bhbgog
ICAgICAgICAjICAgbXVsdGlwbGUgbGluZXMgc2hvdWxkIGhhdmUgdGhlaXIgb3BlcmF0b3JzIG9u
IHRoZSBsZWZ0IHNpZGUgb2YKLS0gCjEuNi4zLjMKCg==
</data>
<flag name="review"
          id="17515"
          type_id="1"
          status="+"
          setter="levin"
    />
          </attachment>
      

    </bug>

</bugzilla>